Activity

From 11/25/2025 to 12/24/2025

12/24/2025

02:02 PM Feature #6256: improved profile support: Greg Shah wrote:
> Roger Borrello wrote:
> > Dănuț, did you test any configuration where you had 2 profiles, each o... Roger Borrello
09:38 AM Feature #6256: improved profile support: Roger Borrello wrote:
> Dănuț, did you test any configuration where you had 2 profiles, each one specifying a differ... Greg Shah

12/23/2025

04:42 PM Feature #6256: improved profile support: Dănuț, did you test any configuration where you had 2 profiles, each one specifying a different fileset? If you could... Roger Borrello

12/19/2025

09:49 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Committed the ProgressLexer.g4 as rev @16007@. Paula Păstrăguș
07:10 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: I think it is time to get the lexer reworked as a one-for-one replacement of the @progress.g@ lexer, including the ja... Greg Shah
05:20 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Around 30 tests are invalid ones, and the rest of them are caused by #10804-78, #10804-80. Paula Păstrăguș
04:49 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: The number of files with differences has dropped to *86* after fixing another issue. Paula Păstrăguș
04:31 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: I managed to fix another issue, which reduced the number of files with differences to *90*!! The fix was embedding th... Paula Păstrăguș
04:11 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Actually, that was my mistake, I forgot to reinitialize a value. Thankfully, this isn't an ANTLR4 issue after all.
... Paula Păstrăguș
03:58 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: I want to correct what I said yesterday about ANTLR4 being fully deterministic. I ran into an odd case where @12@ is ... Paula Păstrăguș
03:37 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: The extra @DOT@ appears when the Progress lexer is instantiated with @kludge = true@. I set this flag to @false@, whi... Paula Păstrăguș
09:29 AM Bug #10569 (Review): Semicolon is skipped while preprocessing: I've committed new changes into *6859b/16327*. These include the following:
* Fixed concatenation operator @+@. Befo... Octavian Adrian Gavril
02:31 AM Feature #10190: Prototype the changes to the build to add ANTLR v4: Thanks, that did the trick! Committed as rev *16006*. Paula Păstrăguș

12/18/2025

01:04 PM Feature #10190: Prototype the changes to the build to add ANTLR v4: Paula, @ant-antlr4All@ should be protected with @run-gradle-run@. Try to add @unless="run-gradle-run"@ to it. Hynek Cihlar
09:36 AM Feature #10190: Prototype the changes to the build to add ANTLR v4: Hynek / Tomasz, could you share your thoughts on the logs being printed twice? Is this expected behavior, or somethin... Paula Păstrăguș
09:33 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Attached it. Paula Păstrăguș
09:29 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Please attach the entire lexer, I need to see more context. Greg Shah
09:23 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Greg, here's the caller code for NUM_action..... Paula Păstrăguș
05:05 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Consider this example rule:... Paula Păstrăguș

12/17/2025

11:27 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Please post the generated Java code (in both ANTLR2 and ANTLR4) for an example rule that shows this. Evaluating all ... Greg Shah
10:34 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Greg Shah wrote:
> Paula Păstrăguș wrote:
> > I also identified another significant issue related to the k = 4 sett... Paula Păstrăguș
09:39 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Paula Păstrăguș wrote:
> Paula Păstrăguș wrote:
> > I didn’t actually apply the settings from there directly.
>
... Greg Shah
09:25 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Paula Păstrăguș wrote:
> I also identified another significant issue related to the k = 4 setting. For example, give... Greg Shah
09:18 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Paula Păstrăguș wrote:
> I didn’t actually apply the settings from there directly.
In @generate_preproc_output.p@... Paula Păstrăguș
09:09 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: I also identified another significant issue related to the k = 4 setting. For example, given the input:... Paula Păstrăguș
09:02 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Greg Shah wrote:
> Our ANTLR2 tests are run with a full toolset (preprocessor etc...). I think we may be adding an ... Paula Păstrăguș
09:00 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Greg Shah wrote:
> Where are the @.lexer@ baselines in the testcases project? I don't see them.
Same here. Anywa... Paula Păstrăguș
08:55 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: > Should invalid test cases also be expected to produce matching results...?
Generally, yes. Where the lexer shou... Greg Shah
08:53 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Where are the @.lexer@ baselines in the testcases project? I don't see them.
> Why does the ANTLR2 version emit a... Greg Shah
07:53 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Should invalid test cases also be expected to produce matching results...? For example, consider the invalid input @*... Paula Păstrăguș
06:57 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: The first difference appears in the @symbol_backslash.p@ test case, whose content is:... Paula Păstrăguș
06:39 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: I used the test suite located in @testcases/tests/conversion/lexer/4gl_testcases@ to evaluate areas where the current... Paula Păstrăguș
09:44 AM Bug #10569: Semicolon is skipped while preprocessing: This seems reasonable. Greg Shah
09:27 AM Bug #10569: Semicolon is skipped while preprocessing: Look at this testcase:... Octavian Adrian Gavril
07:10 AM Feature #10190: Prototype the changes to the build to add ANTLR v4: Here are the logs for @ant jar --verbose@:
{{collapse... Paula Păstrăguș
07:00 AM Feature #10190: Prototype the changes to the build to add ANTLR v4: Paula Păstrăguș wrote:
> I completed a full conversion of a large GUI application, and it passed successfully. I als... Hynek Cihlar
04:03 AM Feature #10190: Prototype the changes to the build to add ANTLR v4: I completed a full conversion of a large GUI application, and it passed successfully. I also performed smoke testing,... Paula Păstrăguș
07:18 PM Bug #10919 (WIP): the source/AST view is broken in the Analytics web UI: Greg Shah
07:18 PM Bug #10919: the source/AST view is broken in the Analytics web UI: I've tested the fix, although it works, it is VERY SLOW. Even use in a small customer project (500KLOC) takes 10+ se... Greg Shah

12/16/2025

08:57 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...: Greg Shah wrote:
> Code Review Task Branch 7180a Revisions 16356 and 16357
>
> @getConfigNameMapParameter()@ shou... Dănuț Filimon
07:05 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...: Code Review Task Branch 7180a Revisions 16356 and 16357
@getConfigNameMapParameter()@ should be in @NameMappingWor... Greg Shah
08:00 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: The core idea is reasonable.
Please keep as much of the original grammar as possible. For example, the code shown... Greg Shah
07:43 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: I think I’ve found a workaround for the DSTRING lexer rule, although it requires changing the original structure a bi... Paula Păstrăguș
06:09 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Just a quick update on this issue. At the moment, I’m investigating a memory leak in the lexer. Using the following t... Paula Păstrăguș
06:50 AM Bug #10626 (Test): DMO names can collide on case-insensitive file-system: Branch 10626a was merged into trunk as rev. 16321 and archived. Dănuț Filimon
06:43 AM Bug #10626 (Merge Pending): DMO names can collide on case-insensitive file-system: You can merge to trunk now. Greg Shah
06:11 AM Bug #10626: DMO names can collide on case-insensitive file-system: All testing passed! 10626a can be merged! Dănuț Filimon

12/15/2025

10:13 AM Bug #10569: Semicolon is skipped while preprocessing: > It looks like we can open a string only if the quote/apostrophe is preceded by white space. So, I really think that... Greg Shah
10:09 AM Bug #10569: Semicolon is skipped while preprocessing: > Greg, do you recall why is it OK to match @"@ or @'@ as the 2nd or later char in @CODE@?
I don't recall exactly... Greg Shah
04:19 AM Bug #10569: Semicolon is skipped while preprocessing: Here is another testcase:... Octavian Adrian Gavril
03:07 AM Bug #10569: Semicolon is skipped while preprocessing: Could this be a reason why using @'@ or @"@ as @CODE@ is allowed on *trunk*? Octavian Adrian Gavril
02:45 AM Bug #10569: Semicolon is skipped while preprocessing: I used changes above and ChUI regression app converted and there were no differences. But a preprocessor test failed ... Octavian Adrian Gavril
07:36 AM Bug #6889 (Test): rollback the files as 'unconverted' if (incremental) conversion fails.: Branch 6889a was merged into trunk as rev. 16318 and archived. Dănuț Filimon
07:17 AM Bug #6889 (Merge Pending): rollback the files as 'unconverted' if (incremental) conversion fails.: Please merge 6889a to trunk after 7851a. Alexandru Lungu
07:26 AM Feature #7851 (Test): automatically add to conversion list all classes referenced via unit test s...: Branch 7851a was merged into trunk as rev. 16317 and archived. Dănuț Filimon
07:15 AM Feature #7851 (Merge Pending): automatically add to conversion list all classes referenced via un...: > Alex: Please schedule this in the merge queue when trunk thaws.
Please merge 7851a to trunk now. Alexandru Lungu
04:16 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...: Committed *7180a/16346*. clean() used a file instead of the artifact, this was a rebase issue. Dănuț Filimon

12/12/2025

01:14 PM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...: > the ant commands that use profile must be modified to exclude additional parameter. The purpose would be that a pro... Greg Shah
01:14 PM Feature #7180 (Internal Test): create a centralized manager for the conversion list and per-file/...: Code Review Task Branch 7180a Revisions 16343 through 16345
No objections. Greg Shah
08:39 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Greg Shah wrote:
> FYI, the testcase should have @.@ instead of @;@ at the end of the first line.
Good catch! Paula Păstrăguș
08:37 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: I'm pleased to see the continued headway. Greg Shah
08:37 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: FYI, the testcase should have @.@ instead of @;@ at the end of the first line. Greg Shah
08:35 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: With a little bit of fine tuning, the test output in this moment looks like this:... Paula Păstrăguș
08:14 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: I think I am making some progress with the lexer. I managed to set up a small test project, and I am actually quite h... Paula Păstrăguș
07:20 AM Feature #8525: eliminate the runtime dependency on registry.xml: Coming up with an idea of solving the conflicts is the first step. If removing the registry.xml is limited to convers... Dănuț Filimon
06:45 AM Bug #10626: DMO names can collide on case-insensitive file-system: The bare-metal machine for the application that failed was updated recently and I've been running conversions on it w... Dănuț Filimon
04:53 AM Bug #6889: rollback the files as 'unconverted' if (incremental) conversion fails.: Trunk is currently frozen for a delivery.
Alex: Please schedule this in the merge queue when trunk thaws. Greg Shah
02:51 AM Bug #6889: rollback the files as 'unconverted' if (incremental) conversion fails.: Rebased 6889a to latest trunk/16312, the branch is now at revision 16316.
6889a can be merged. Dănuț Filimon
02:23 AM Bug #6889: rollback the files as 'unconverted' if (incremental) conversion fails.: Regression tests passed, I am rebasing to check for conflicts. Dănuț Filimon
04:48 AM Feature #7851: automatically add to conversion list all classes referenced via unit test suite an...: Trunk is currently frozen for a delivery.
Alex: Please schedule this in the merge queue when trunk thaws. Greg Shah
02:39 AM Feature #7851: automatically add to conversion list all classes referenced via unit test suite an...: Rebased *7851a* to latest *trunk/16312*, the branch is now at revision *16315*.
*7851a* can be merged. Dănuț Filimon
02:23 AM Feature #7851: automatically add to conversion list all classes referenced via unit test suite an...: Regression tests passed, I am rebasing to check for conflicts. Dănuț Filimon

12/11/2025

07:47 AM Bug #10569: Semicolon is skipped while preprocessing: Greg, do you recall why is it OK to match @"@ or @'@ as the 2nd or later char in @CODE@? I used these changes and the... Octavian Adrian Gavril
06:44 AM Bug #10569: Semicolon is skipped while preprocessing: The tricky zone is here: @+"|" + "~n".@.
* @+"|@ is @CODE@
* @" + "@ is a @QSTRING@. This way, the new line will be... Octavian Adrian Gavril
06:14 AM Bug #10569 (WIP): Semicolon is skipped while preprocessing: Actually, only the last revision of *6859b* is triggering this issue with concatenation operator. I think this should... Octavian Adrian Gavril
04:28 AM Bug #10569: Semicolon is skipped while preprocessing: I noticed some suspect differences for ChUI regression testing app:... Octavian Adrian Gavril
04:32 AM Feature #7180 (Review): create a centralized manager for the conversion list and per-file/project...: Rebased *7180a* to latest *trunk/16310*, the branch is now at revision *16345*.
A few remarks:
* the ant commands... Dănuț Filimon
04:12 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...: Updated status:
* #6083 - working as expected
* #6738 - deleting artifacts didn't work (name_map.xml was not update... Dănuț Filimon
08:04 PM Feature #10804: create replacement AST implementation for use with ANTLR 4: > I looked more closely at the @YEAR_TRASH_MODE@ fragment and I still don’t fully understand why the lookahead is nee... Greg Shah

12/10/2025

02:46 PM Bug #10912: Cannot invoke "java.lang.Class.isAssignableFrom(java.lang.Class)" because "calleeType...: Alexandru, I think the first condition needs also to be:... Constantin Asofiei
09:32 AM Bug #10912 (Internal Test): Cannot invoke "java.lang.Class.isAssignableFrom(java.lang.Class)" bec...: Created 10912a. Committed patch as rev. 16310.
This fixed the OG issue. Planning to run some tests. Alexandru Lungu
09:54 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...: Current status:
* #10816- duplicate getOriginalArtifact() call - fixed
* #10613 - testing passed, no issues
* #77... Dănuț Filimon
08:31 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Paula Păstrăguș wrote:
> Things are getting more complicated: ANTLR4 does not allow action blocks inside fragment ru... Paula Păstrăguș
04:35 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: I’ll rename @SchemaLexer@ to @ProgressLexer@ (+ I'll keep the same structure of the progress.g grammar lexer into the... Paula Păstrăguș
04:30 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Paula Păstrăguș wrote:
> Paula Păstrăguș wrote:
> > * Fragment rules were introduced in ANTLR4. I haven’t yet creat... Paula Păstrăguș
04:17 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Another aspect we need to clarify is the equivalent for ANTLR2’s @LA() lookahead@ function. At the moment, I used @_i... Paula Păstrăguș
04:08 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: We will need a mechanism to replicate the old ANTLR2 @append()@ behavior and the @!@ operator when migrating to ANTLR... Paula Păstrăguș
04:00 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Paula Păstrăguș wrote:
> * Fragment rules were introduced in ANTLR4. I haven’t yet created any, but they can be used... Paula Păstrăguș
01:42 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: You're right, this options block did the trick:... Paula Păstrăguș
06:05 AM Bug #10919: the source/AST view is broken in the Analytics web UI: Branch 10919a was merged into trunk as rev. 16308 and archived.
Only a customer and ChUI scripts are left to be up... Dănuț Filimon
05:50 AM Bug #10919: the source/AST view is broken in the Analytics web UI: I am merging 10919a now so that the trunk revision can be referenced. Dănuț Filimon

12/09/2025

09:57 AM Feature #9638: resolve OO dependencies during parsing using annotations in already converted classes: I think the overall idea of how to build up the class data is correct. My concerns with extending the @UsingType@ ar... Greg Shah
09:26 AM Feature #9638: resolve OO dependencies during parsing using annotations in already converted classes: I think the best place where we can introduce this idea is in @SymbolResolver.loadClass(String name, boolean topLevel... Octavian Adrian Gavril
06:39 AM Feature #9638 (WIP): resolve OO dependencies during parsing using annotations in already converte...: Octavian Adrian Gavril
09:46 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: > Kind of, we need that token for both, the parser and the lexer.
You should not define the tokens in the parser,... Greg Shah
09:42 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: A couple of housekeeping items:
* I would prefer if you are working on the @ProgressLexer@ and just use that direc... Greg Shah
09:18 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Hm, into the @SchemaLexer.tokens@, the value of @HEX_LITERAL@ is @1@, and into the @SchemaParser.tokens@, the value o... Paula Păstrăguș
09:01 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Kind of, we need that token for both, the parser and the lexer. But the int values will be different, depending on ho... Paula Păstrăguș
08:53 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: > in the lexer we reference @HEX_LITERAL@ and other 'artificial' tokens, tokens that do not correspond to any actual ... Greg Shah
08:33 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: As a side note, I feel that rewriting the grammar was actually the easy part, what comes next is where the real compl... Paula Păstrăguș
08:21 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Greg, I'm a bit confused... I initially thought that splitting the grammar would solve this issue. Let me explain the... Paula Păstrăguș
07:31 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: * The next step is to split the grammar into @SchemaParser.g4@ and @SchemaLexer.g4@. I realize the schema grammar nor... Paula Păstrăguș
04:21 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Committed the grammar as rev @16006@. Paula Păstrăguș
02:40 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Greg Shah wrote:
> For the Progress lexer, I'd like to see the standalone @.g4@ file for it. It is hard for me to g... Paula Păstrăguș
09:18 AM Feature #7180 (WIP): create a centralized manager for the conversion list and per-file/project st...: Dănuț Filimon
09:18 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...: I plan to make the @getSiblingPath()@ patch after I am clearing up the testing, I already found 3 issues:
* Found a ... Dănuț Filimon
08:47 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...: > I'll make it general and call it getSiblingPath() since the purpose of the method is to change a path to another (s... Greg Shah
08:38 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...: Greg Shah wrote:
> Dănuț Filimon wrote:
> > Greg Shah wrote:
> > > Code Review Task Branch 7180a Revision 16336
>... Dănuț Filimon
08:26 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...: Dănuț Filimon wrote:
> Greg Shah wrote:
> > Code Review Task Branch 7180a Revision 16336
> >
> > Let's rename @A... Greg Shah
07:30 AM Feature #7180 (Review): create a centralized manager for the conversion list and per-file/project...: Committed *7180a/16337-16338*, once for #4867 and once for FileExtensions usage/method renaming.
I plan to test th... Dănuț Filimon
04:42 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...: Greg Shah wrote:
> Code Review Task Branch 7180a Revision 16336
>
> Let's rename @AM.getPathToProjectFolderPojoFr... Dănuț Filimon
08:49 AM Bug #10569: Semicolon is skipped while preprocessing: I described the testing for all of 6859b. You can document that in #6859 itself. I don't see a reason to do separat... Greg Shah
08:44 AM Bug #10569: Semicolon is skipped while preprocessing: This approach should test only the changes related to this task or it should include all the changes from *6859b*? If... Octavian Adrian Gavril
08:29 AM Bug #10569: Semicolon is skipped while preprocessing: Greg Shah wrote:
> We can take this approach:
>
> # Run the front end on an application. Confirm there are no err... Octavian Adrian Gavril
08:24 AM Bug #10569: Semicolon is skipped while preprocessing: We can take this approach:
# Run the front end on an application. Confirm there are no errors.
# Compare the @.ca... Greg Shah
03:33 AM Bug #10569: Semicolon is skipped while preprocessing: What extra testing is needed for this issue? Should we run conversion of some apps? Octavian Adrian Gavril
08:35 AM Feature #10190: Prototype the changes to the build to add ANTLR v4: Updated the antlr4 version to @4.13.2@ in rev @16005@. Paula Păstrăguș
08:27 AM Feature #10190: Prototype the changes to the build to add ANTLR v4: > Currently we are using ANTLR @4.9.3@. Since #9687 is now merged into trunk, should I also update the ANTLR runtime ... Greg Shah
06:50 AM Feature #10190: Prototype the changes to the build to add ANTLR v4: I tested the build changes and everything appears to be in order. The only missing piece is the @src/com/goldencode/p... Paula Păstrăguș
03:30 AM Bug #10988: Extra quote is not generated during preprocessing when alternative for two quotes/apo...: Another example of what the current preprocessing work does is mentioned in #10569-25. Octavian Adrian Gavril
03:27 AM Bug #10988: Extra quote is not generated during preprocessing when alternative for two quotes/apo...: Take a look at this OE example:... Octavian Adrian Gavril
03:15 AM Bug #10988 (New): Extra quote is not generated during preprocessing when alternative for two quot...: Octavian Adrian Gavril
02:29 AM Feature #7851: automatically add to conversion list all classes referenced via unit test suite an...: Greg Shah wrote:
> + Marian/Vladimir
Greg, all I can share about this is that we were only running `ABLUnit` in F... Marian Edu

12/08/2025

06:19 PM Feature #7851: automatically add to conversion list all classes referenced via unit test suite an...: Code Review Task Branch 7851a REvisions 16299 and 16300
The changes are good. Greg Shah
03:53 AM Feature #7851 (Internal Test): automatically add to conversion list all classes referenced via un...: Thank you Vladimir! I committed *7851a/16300* to address your review. Dănuț Filimon
05:26 PM Bug #10569 (Internal Test): Semicolon is skipped while preprocessing: Code Review Task Branch 6859b Revision 16145
The changes are good.
> Since the preprocessor tests are stable, i... Greg Shah
07:31 AM Bug #10569: Semicolon is skipped while preprocessing: I did some experiments that add an extra @'@ as OE does, but this changed how the lexer process next input. For examp... Octavian Adrian Gavril
03:46 PM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...: Code Review Task Branch 7180a Revision 16336
Let's rename @AM.getPathToProjectFolderPojoFromDmo()@ to something mo... Greg Shah
09:27 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...: Rebased *7180a* to latest *trunk/16304*, the branch is now at revision *16336*.
The good news is that the only co... Dănuț Filimon
08:48 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...: Greg Shah wrote:
> Really good. Minor feedback:
> 2. References to DMOs (e.g. JavaDoc for @pkgRootPath@) and Pojos... Dănuț Filimon
04:31 AM Feature #7180 (WIP): create a centralized manager for the conversion list and per-file/project st...: I am currently addressing the review. Dănuț Filimon
02:36 PM Feature #10804: create replacement AST implementation for use with ANTLR 4: For the Progress lexer, I'd like to see the standalone @.g4@ file for it. It is hard for me to give feedback without... Greg Shah
09:54 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Today I worked on the lexer rules and tokens, which are the final missing piece of the schema migration puzzle.
Here... Paula Păstrăguș
09:36 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Paula Păstrăguș wrote:
> Greg Shah wrote:
> > What do you mean by "lookahead hooks"? In both ANTLR2 and ANTLR4 we ... Greg Shah
09:29 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Greg Shah wrote:
> What do you mean by "lookahead hooks"? In both ANTLR2 and ANTLR4 we can use @LT()@ to lookahead ... Paula Păstrăguș
02:31 PM Feature #10190: Prototype the changes to the build to add ANTLR v4: Paula: Please make sure to get the testing going from #10190-23. I'd like to close this out. Greg Shah

12/05/2025

06:13 PM Feature #7851: automatically add to conversion list all classes referenced via unit test suite an...: I noticed I was not listed as a reviewer, though I have already completed the review.
7851a rev 16299 code review:... Vladimir Tsichevski
08:27 AM Feature #7851 (Review): automatically add to conversion list all classes referenced via unit test...: I committed *7851a/16299*. Addressed the #7851-12 review, removed the changes from SymbolResolver and added a loadPro... Dănuț Filimon
08:13 AM Feature #7851: automatically add to conversion list all classes referenced via unit test suite an...: + Marian/Vladimir Greg Shah
03:19 AM Feature #7851: automatically add to conversion list all classes referenced via unit test suite an...: ... Dănuț Filimon
12:18 PM Feature #10804: create replacement AST implementation for use with ANTLR 4: > I have some good news: I’m very close to finishing the rewrite of the schema file. The remaining work is mainly to ... Greg Shah
10:42 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: I have some good news: I’m very close to finishing the rewrite of the schema file. The remaining work is mainly to re... Paula Păstrăguș
09:49 AM Bug #6889 (Internal Test): rollback the files as 'unconverted' if (incremental) conversion fails.: Greg Shah wrote:
> Code Review Task Branch 6889a Revision 16269
>
> Literals like @".ast"@, @".p2o"@, @".jast"@, ... Dănuț Filimon
09:10 AM Bug #10569 (Review): Semicolon is skipped while preprocessing: I changed the @% Done@ by mistake. The issue of this task is fixed. And the preprocessor tests have the same status a... Octavian Adrian Gavril
09:04 AM Bug #10569 (WIP): Semicolon is skipped while preprocessing: Greg Shah
09:02 AM Bug #10569: Semicolon is skipped while preprocessing: I started to add new tests in [[p2j:Preprocessor Testcases]] but I found that we already have these cases in @tests/c... Octavian Adrian Gavril
07:57 AM Bug #10569 (Review): Semicolon is skipped while preprocessing: I've committed new changes that completes the initial fix:
* I added an extra check for @LA(3)@ to avoid any excepti... Octavian Adrian Gavril

12/04/2025

08:29 AM Bug #6889: rollback the files as 'unconverted' if (incremental) conversion fails.: Code Review Task Branch 6889a Revision 16269
Literals like @".ast"@, @".p2o"@, @".jast"@, @".dict"@ should be @Ast... Greg Shah
08:23 AM Feature #7851 (WIP): automatically add to conversion list all classes referenced via unit test su...: Greg Shah
07:43 AM Feature #7851: automatically add to conversion list all classes referenced via unit test suite an...: The TestSuite can specify both the @classes@ and @procedures@, so it's better to handle all of them rather than half.... Dănuț Filimon
08:10 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...: Code Review Task Branch 7180a Revisions 16267 through 16273
Really good. Minor feedback:
1. The @gen_fname@ fu... Greg Shah
08:06 AM Bug #10569: Semicolon is skipped while preprocessing: The cause of failing is this scenario: ... Octavian Adrian Gavril
07:28 AM Bug #10569 (WIP): Semicolon is skipped while preprocessing: Unfortunately, there are 10 extra tests from @alternative_coding_test_set@ which failed with *6859b/16144*. I need to... Octavian Adrian Gavril
06:03 AM Bug #10569: Semicolon is skipped while preprocessing: Radu Apetrii wrote:
> Octavian Adrian Gavril wrote:
> > Radu, can you check if that's happening for your specific f... Radu Apetrii
05:56 AM Bug #10569: Semicolon is skipped while preprocessing: Please make sure that these cases have been added to the [[p2j:Preprocessor Testcases]] (unit tests).
All of the... Greg Shah
03:41 AM Bug #10569: Semicolon is skipped while preprocessing: Octavian Adrian Gavril wrote:
> Radu, can you check if that's happening for your specific file as well?
Yes, I'll w... Radu Apetrii
01:26 AM Bug #10569: Semicolon is skipped while preprocessing: The changes fix the testcase mentioned in #10569-1.
Radu, can you check if that's happening for your specific file... Octavian Adrian Gavril
07:20 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Greg Shah wrote:
> 3. We need to discuss the tree building. I think the idea of returning the created subtree from... Paula Păstrăguș

12/03/2025

06:50 PM Bug #10569 (Internal Test): Semicolon is skipped while preprocessing: Code Review Task Branch 6859b Revision 16144
This is really good. Greg Shah
10:09 AM Bug #10569: Semicolon is skipped while preprocessing: Greg, please review the changes. Octavian Adrian Gavril
09:45 AM Bug #10569 (Review): Semicolon is skipped while preprocessing: Apparently, in 4GL you can write two single/double quotes and the compiler will keep only one. 4GL seems to generate ... Octavian Adrian Gavril
06:42 PM Feature #10804: create replacement AST implementation for use with ANTLR 4: Code Review Schema.g4
It is a good start and there is a lot to like about it. Some thoughts:
1. For an early P... Greg Shah
10:02 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Greg, I’ve attached the current @Schema.g4@ grammar. There are only a few rules implemented so far, but if you have s... Paula Păstrăguș
05:59 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Good plan. Greg Shah
03:34 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Just a quick note regarding my next steps: I’ll begin modifying the @schema.g@ file to migrate it to ANTLR4. Working ... Paula Păstrăguș
12:44 PM Feature #7851: automatically add to conversion list all classes referenced via unit test suite an...: Code Review Task branch 7851a Revision 16298
1. The string comparisons in @handleReferenceFiles()@ probably need t... Greg Shah
08:41 AM Feature #7851 (Review): automatically add to conversion list all classes referenced via unit test...: Committed *7851a/16298*. Added support for automatically adding procedures/classes referenced using the TestSuite ann... Dănuț Filimon
06:36 AM Feature #7851: automatically add to conversion list all classes referenced via unit test suite an...: Greg Shah wrote:
> Dănuț Filimon wrote:
> > Greg, I think we'll need something similar to pre_scan_class in progres... Dănuț Filimon
06:14 AM Feature #7851: automatically add to conversion list all classes referenced via unit test suite an...: Dănuț Filimon wrote:
> Greg, I think we'll need something similar to pre_scan_class in progress.g, but for procedure... Greg Shah
06:09 AM Feature #7851: automatically add to conversion list all classes referenced via unit test suite an...: Greg, I think we'll need something similar to pre_scan_class in progress.g, but for procedures. What do you think? Dănuț Filimon
06:04 AM Feature #7851: automatically add to conversion list all classes referenced via unit test suite an...: I managed to implement the fix for TestSuite that specifies classes:... Dănuț Filimon

12/02/2025

09:27 AM Feature #7851: automatically add to conversion list all classes referenced via unit test suite an...: In the following code: ... Dănuț Filimon
06:59 AM Feature #7851: automatically add to conversion list all classes referenced via unit test suite an...: Greg Shah wrote:
> > [...]. It is possible to extract the text from the STRING and turn it into a filename which can... Dănuț Filimon
07:46 AM Bug #10919: the source/AST view is broken in the Analytics web UI: Committed xfer testcases/1817. Dănuț Filimon
07:39 AM Bug #10919: the source/AST view is broken in the Analytics web UI: Committed *hotel_gui/419*, *hotel/186*. Fixed reports using the wrong location for AST resource.
ETF does not have... Dănuț Filimon
07:12 AM Bug #10919 (Merge Pending): the source/AST view is broken in the Analytics web UI: Go ahead and commit this to our Hotel projects.
Assuming all other customer projects are using an unmodified versi... Greg Shah
04:07 AM Bug #10919: the source/AST view is broken in the Analytics web UI: I tested @ant report_server@, checked call graphs and reports. I found a single issue where the report log was in the... Dănuț Filimon
07:45 AM Bug #10569: Semicolon is skipped while preprocessing: Yes, that would probably be for the best. Greg Shah
07:34 AM Bug #10569: Semicolon is skipped while preprocessing: I think the work should be done in *6859b*, is that right? Octavian Adrian Gavril

12/01/2025

11:11 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: In regard to artificial nodes, it is true that some TRPL code will create them but the majority are created during th... Greg Shah
11:06 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: The shadow nodes should not be directly attached to the root. Here is an example:... Greg Shah
10:53 AM Feature #7851: automatically add to conversion list all classes referenced via unit test suite an...: > [...]. It is possible to extract the text from the STRING and turn it into a filename which can be searched. Then m... Greg Shah
10:29 AM Bug #10919: the source/AST view is broken in the Analytics web UI: Dănuț Filimon wrote:
> Thanks Roger, is there any testing I can do aside from running the report server for Hotel?
... Greg Shah

11/28/2025

12:53 PM Bug #10919: the source/AST view is broken in the Analytics web UI: Dănuț Filimon wrote:
> Thanks Roger, is there any testing I can do aside from running the report server for Hotel?
... Roger Borrello
08:15 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Thank you, Ovidiu. I asked this because we need to create @helper methods@ that allow us to build the AST directly fr... Paula Păstrăguș
05:47 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: During the transpiling from 4GL to Java, FWD parser and TRPL rules will add these additional nodes. The semantic of t... Ovidiu Maxiniuc
04:15 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: I have a question regarding artificial nodes. These are the nodes that the grammar creates manually, for example usin... Paula Păstrăguș
03:21 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Regarding the shadow nodes: the @left@ and @right@ IDs are used to locate the nearest AST node for each shadow node, ... Paula Păstrăguș
03:16 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Ovidiu Maxiniuc wrote:
> I do not think we should use @left@ and @right@. The resulting tree is not always binary.
... Paula Păstrăguș

11/27/2025

08:39 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: I do not think we should use @left@ and @right@. The resulting tree is not always binary. One node may have multiple ... Ovidiu Maxiniuc
04:51 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Another thing I noticed: I added the shadows nodes to the list after the @left@ and @right@ IDs were populated, which... Paula Păstrăguș
04:24 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: During testing, I realized I forgot to assign the @parent AST@ to the shadow nodes. Right now, they’re orphans:), so ... Paula Păstrăguș
08:25 AM Feature #7851: automatically add to conversion list all classes referenced via unit test suite an...: This @root@ is built in @ProgressParser.oea_annotation(), line 10017@:... Dănuț Filimon
06:36 AM Feature #7851 (WIP): automatically add to conversion list all classes referenced via unit test su...: Dănuț Filimon
05:28 AM Feature #7318: prevent abend during conversion in case of failures when processing TRPL rules: #6889 only has the changes for incremental conversion, making this available for all conversions is easy as it only r... Dănuț Filimon
02:58 AM Bug #10919 (Internal Test): the source/AST view is broken in the Analytics web UI: Thanks Roger, is there any testing I can do aside from running the report server for Hotel? Dănuț Filimon

11/26/2025

10:08 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Thanks, Greg, I had misunderstood that part. I’ve been working on adapting the @TreeLocal@, the @ShadowNode@, and the... Paula Păstrăguș
08:53 AM Bug #10919: the source/AST view is broken in the Analytics web UI: Dănuț Filimon wrote:
> Roger Borrello wrote:
> > So you start the web server as: @./deploy/server/report.sh@?
>
... Roger Borrello
08:46 AM Bug #10919: the source/AST view is broken in the Analytics web UI: Roger Borrello wrote:
> So you start the web server as: @./deploy/server/report.sh@?
No, like this: @~/gcd/branch... Dănuț Filimon
08:44 AM Bug #10919: the source/AST view is broken in the Analytics web UI: So you start the web server as: @./deploy/server/report.sh@? Roger Borrello
07:35 AM Bug #10919: the source/AST view is broken in the Analytics web UI: Roger, this is the final patch:... Dănuț Filimon
07:05 AM Bug #10919: the source/AST view is broken in the Analytics web UI: I'm OK with the idea. Please add comments to make it clear that the @ReportWebServer@ MUST be executed with the proj... Greg Shah
03:49 AM Bug #10919: the source/AST view is broken in the Analytics web UI: I fixed this in the @report.sh@ script:... Dănuț Filimon
03:20 AM Bug #6889 (Review): rollback the files as 'unconverted' if (incremental) conversion fails.: I addressed the review from #6889-11 in *6889a/16269*.
Greg, please review. Dănuț Filimon

11/25/2025

10:11 AM Bug #10919: the source/AST view is broken in the Analytics web UI: Above, I was saying @ReportDriver@ but that was a mistake. I meant @ReportWebServer@.
If the files are being read... Greg Shah
09:09 AM Bug #10919: the source/AST view is broken in the Analytics web UI: Greg Shah wrote:
> > No, it will just remove home from the path. We already have home which is the relative path tha... Dănuț Filimon
08:53 AM Bug #10919: the source/AST view is broken in the Analytics web UI: > No, it will just remove home from the path. We already have home which is the relative path that we need, so I don'... Greg Shah
08:40 AM Bug #10919: the source/AST view is broken in the Analytics web UI: Greg Shah wrote:
> Won't this be a problem when we reach the @if (absolute.startsWith(home))@ code later in that met... Dănuț Filimon
07:41 AM Bug #10919: the source/AST view is broken in the Analytics web UI: Also, assuming @home@ is always the same value, can't @home = new File(home).getCanonicalPath();@ be calculated at st... Greg Shah
07:40 AM Bug #10919: the source/AST view is broken in the Analytics web UI: Won't this be a problem when we reach the @if (absolute.startsWith(home))@ code later in that method? Why not have t... Greg Shah
04:03 AM Bug #10919: the source/AST view is broken in the Analytics web UI: I've got @./abl/fwd-embedded-driver.p@ which is normalized to @./deploy/server/abl/fwd-embedded-driver.p@. My initial... Dănuț Filimon
07:55 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: I think you are conflating parse-time processing with TRPL-processing. During TRPL, the AST *must have* the shadow n... Greg Shah
05:54 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Greg, I reviewed the @hidden@ field, the @ShadowNode@ structure, and the entire @TreeLocal@ mechanism. The conclusion... Paula Păstrăguș
06:00 AM Bug #6889 (WIP): rollback the files as 'unconverted' if (incremental) conversion fails.: Dănuț Filimon
06:00 AM Bug #6889: rollback the files as 'unconverted' if (incremental) conversion fails.: Greg Shah wrote:
> Code Review Task Branch 6889a Revisions 16267 and 16268
>
> 1. Shouldn't @cleanSources()@ be c... Dănuț Filimon

« Previous

Also available in: Atom

Project

General

Profile

FWD » Core Development » Conversion Tools

Activity

Activity

12/24/2025

12/23/2025

12/19/2025

12/18/2025

12/17/2025

12/16/2025

12/15/2025

12/12/2025

12/11/2025

12/10/2025

12/09/2025

12/08/2025

12/05/2025

12/04/2025

12/03/2025

12/02/2025

12/01/2025

11/28/2025

11/27/2025

11/26/2025

11/25/2025