Project

General

Profile

Activity

From 02/27/2026 to 03/28/2026

03/20/2026

07:52 AM Feature #11317 (New): Implementing multi-threaded parsing
Octavian Adrian Gavril
05:42 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
OK, that would be a good result. The final exam will be if @ProgressTransformDriver@ works properly. Greg Shah
05:04 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
@setChannel(Token.HIDDEN_CHANNEL)@ likely does everything needed: the tokens aren't discarded, they're simply routed ... Paula Păstrăguș
05:00 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Used this grammar to see what happens when we hide a token in antlr4 using @setChannel(Token.HIDDEN_CHANNEL)@:
<pr...
Paula Păstrăguș
04:57 AM Feature #7178: move the buffer scoping calculations to parse time
There are buffer scoping tests available in the testcases project, /tests/persistence/buffer_scoping/. A quick scan o... Dănuț Filimon

03/19/2026

11:51 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
> Will be enough to set the channel to @HIDDEN_CHANNEL@ for the old @hide()@ method?
I doubt it.
Here is the co...
Greg Shah
10:22 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Will be enough to set the channel to @HIDDEN_CHANNEL@ for the old @hide()@ method?
Note to myself: investigate whe...
Paula Păstrăguș

03/18/2026

07:29 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
> Hm.., so are we aiming to eliminate all of the parser-side token stream surgery?
At least the forms I describe i...
Greg Shah
07:15 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Hm.., so are we aiming to eliminate all of the parser-side token stream surgery? Paula Păstrăguș
07:03 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
> I started working on the Progress parser, and I'm seeing that hidden tokens are used quite a bit in methods such as... Greg Shah
05:00 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
I started working on the Progress parser, and I'm seeing that hidden tokens are used quite a bit in methods such as @... Paula Păstrăguș
03:29 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Committed the migrated lexer and parser for @expression.g@ as rev *16468*. Paula Păstrăguș

03/17/2026

03:26 PM Support #10231 (WIP): Document the code style guidelines for ANTLR grammars, based on progress.g
Please enhance the documentation to address changes for ANTLR4.
Also, fix missing or incorrect content in general ...
Greg Shah
11:09 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Fearless and confident! Let's go! Greg Shah
10:52 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Should be done before coffee ☕ gets cold next morning 😄 Paula Păstrăguș
10:48 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
It is now time for the Progress Parser. 😱 Greg Shah
10:32 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Fixed it:-D
I'll continue testing, and if no issues arise, I'll commit the expression parser and lexer tomorrow mo...
Paula Păstrăguș
09:52 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Finished migration of @expression.g@. I did some testing and found some differences that I believe are caused by the ... Paula Păstrăguș

03/16/2026

10:54 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Committed the FQL lexer and parser as rev *16467*.
I compared the AST produced and later manipulated in FqlToSqlCo...
Paula Păstrăguș
08:32 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
@com/goldencode/expr/expression.g@ Greg Shah
08:17 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Finished migrating the FQL parser. I also ran some tests using the existing @FqlToSqlConverter@. I'll continue testin... Paula Păstrăguș

03/13/2026

10:53 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Committed as rev *16466*. (the hql parser and grammar)
I could not find any cases where the HQL grammar produces d...
Paula Păstrăguș
09:18 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
@fql.g@ Greg Shah
08:58 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
I have completed the migration of the HQL parser and lexer. I also did some initial testing of the grammar by compari... Paula Păstrăguș
03:16 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Next step: hql.g migration - wip Paula Păstrăguș
03:15 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Committed as rev *16465*. Decoupled antlr2 logic from the antlr4 logic. (Also refined schema parser and the progress ... Paula Păstrăguș

03/12/2026

10:50 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Greg, I'm not able to commit the changes. I keep getting @Could not request local forwarding.@ @Connection reset by p... Paula Păstrăguș
05:10 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Managed to fix this. It turned out not to be very difficult, since the ANTLR4 lexer provides a @Vocabulary@ along wit... Paula Păstrăguș
03:35 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Paula Păstrăguș wrote:
> The only *issue* I noticed is that the type is not resolved properly. It seems that the new...
Paula Păstrăguș

03/11/2026

11:26 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
There were also some build issues: classes were duplicated because ANTLR4 creates a @.antlr@ folder (hidden folder) w... Paula Păstrăguș
11:23 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Paula Păstrăguș wrote:
> I'll share more details about how I approached it and which path I chose.
I managed to ...
Paula Păstrăguș
11:13 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
also solved the id issue, now they are exactly the same as the ones generated by antlr2. Paula Păstrăguș
11:11 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
I compared the ASTs and they appear to be correct.. The only *issue* I noticed is that the type is not resolved prope... Paula Păstrăguș
10:03 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
🚨 I managed to obtain the schema root AST using our new schema parser and Progress lexer, with a few local changes co... Paula Păstrăguș
08:01 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
I think I've managed to decouple the ANTLR4 logic from the existing ANTLR2 logic, and I finally got fwd to compile. I... Paula Păstrăguș

03/09/2026

04:21 PM Feature #10804: create replacement AST implementation for use with ANTLR 4
For early testing you could focus on getting just enough of the things compiled to run @SchemaLoader@. I wouldn't wo... Greg Shah
08:31 AM Feature #7169: drive conversion order using user-specified dependencies
Right now the implementation contains:
* The profile dependency config (depends can be used on a profile definition)...
Dănuț Filimon

03/06/2026

10:08 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Greg, I’m not entirely sure what the best approach is for migrating all the related classes to rely on ANTLR4 instead... Paula Păstrăguș

03/05/2026

10:54 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Agreed. Please add some comments to both of those methods to explain this non-intuitive behavior AND to highlight th... Greg Shah
09:38 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Yes, I kept the same behavior, even though it feels a bit awkward.. Currently, @setFirstChild@ removes all existing c... Paula Păstrăguș
09:25 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
The output seems consistent. I haven't checked the behavior of the specific methods versus their original meaning in... Greg Shah
08:32 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
I attached the test program I used to validate the approach. The first 10 tests are easy to inspect visually to confi... Paula Păstrăguș
07:48 AM Feature #7169: drive conversion order using user-specified dependencies
Greg Shah wrote:
> I'm not exactly sure what you are trying to do with this process. It does worry me that you are ...
Dănuț Filimon
07:44 AM Feature #7169: drive conversion order using user-specified dependencies
I'm not exactly sure what you are trying to do with this process. It does worry me that you are going to lose all hi... Greg Shah
06:36 AM Feature #7169: drive conversion order using user-specified dependencies
This is how I managed to rebase the branch:... Dănuț Filimon

03/04/2026

01:24 PM Feature #10804: create replacement AST implementation for use with ANTLR 4
Paula Păstrăguș wrote:
> I need a bit of guidance regarding the inline shadow nodes. Are we planning to keep/support...
Greg Shah
01:03 PM Feature #10804: create replacement AST implementation for use with ANTLR 4
Good so far. I'm OK with the reported trade offs.
> While implementing the pointer-based approach I already ran i...
Greg Shah
09:22 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
I committed the first version of migration as rev *16464* (branch was also rebased). (I didn't delete v4 classes yet,... Paula Păstrăguș
05:14 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
I need a bit of guidance regarding the inline shadow nodes. Are we planning to keep/support them?
From what I can ...
Paula Păstrăguș
12:47 PM Bug #3711: improve/fix comments conversion problems
This task is about improving/fixing comments in general. There will generally be 2 causes:
# orphaned comments whe...
Greg Shah
09:51 AM Feature #7169: drive conversion order using user-specified dependencies
I'll create 7169b instead of trying to recover this branch, I can't revert specific files that are just removed and a... Dănuț Filimon
09:47 AM Feature #7169: drive conversion order using user-specified dependencies
Rebasing has a tiny issue because trunk and 7169a both added src/com/goldencode/artifacts. I got the branch into this... Dănuț Filimon
04:22 AM Bug #6629: incremental conversion for OpenClient proxy programs
Rebased *6629a* to *trunk/16453*, the branch is now at revision *16457*.
Committed *6629a/16457*. Removed initiali...
Dănuț Filimon

03/02/2026

07:49 AM Bug #6629: incremental conversion for OpenClient proxy programs
Found the following error while testing a customer:... Dănuț Filimon
05:31 AM Bug #6629 (Internal Test): incremental conversion for OpenClient proxy programs
I'm OK with the changes. Please go ahead with testing. Constantin Asofiei

02/27/2026

10:47 AM Bug #11266: Filename of extension too long in Windows during import
For @ScriptRunner@ I think the classpath only need to contain @fwd@, @fwdspi@ (H2 only) and the db-specific driver ja... Ovidiu Maxiniuc
09:30 AM Bug #11266: Filename of extension too long in Windows during import
I did try to use the 4th option after also discovering that the classpath is the issue, the ScriptRUnner class could ... Dănuț Filimon
09:27 AM Bug #11266: Filename of extension too long in Windows during import
I know we recently dropped @ant@ as a tool for building FWD. But in this case, @ant@ is used to do in database import... Ovidiu Maxiniuc
09:12 AM Bug #11266: Filename of extension too long in Windows during import
Item 3 is the most important. We need to fix our scripting to not be stupid.
> But the first two should also used...
Greg Shah
08:54 AM Bug #11266: Filename of extension too long in Windows during import
I think the problem here is the classpath, not the size of filename / extension. Moving the project directly into roo... Ovidiu Maxiniuc
08:08 AM Bug #11266: Filename of extension too long in Windows during import
I got the following error while running @and import.db@ in hotel_gui, Windows, java 17:... Dănuț Filimon
08:06 AM Bug #11266 (New): Filename of extension too long in Windows during import
Dănuț Filimon
06:52 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Now it's fine, thanks! Paula Păstrăguș
06:52 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Paula Păstrăguș wrote:
> Greg Shah wrote:
> > See [[p2j:ANTLR Migration Guide]].
>
> I'm not authorized to see t...
Greg Shah
06:42 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Greg Shah wrote:
> See [[p2j:ANTLR Migration Guide]].
I'm not authorized to see that page (403 err)
Paula Păstrăguș
06:39 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Thanks! And yes, some of the changes were introduced specifically for the prototype model.
You're absolutely right...
Paula Păstrăguș
06:33 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Paula Păstrăguș wrote:
> Can you also create a wiki page for the lexer guide, or would you prefer that I post it dir...
Greg Shah
06:27 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Paula Păstrăguș wrote:
> Aha, more exactly you're referring to only store 3 references instead of using a collection...
Greg Shah
06:23 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Can you also create a wiki page for the lexer guide, or would you prefer that I post it directly in this task? Paula Păstrăguș
06:21 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Aha, more exactly you're referring to only store 3 references instead of using a collection?
* first child
* next ...
Paula Păstrăguș
06:15 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
When I am talking about a doubly linked list, I mean one that we create ourselves using "next" and "previous" AST ref... Greg Shah
05:03 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
I ran some analysis on the current AST implementation in order to evaluate the concern regarding the use of @List@ f... Paula Păstrăguș
 

Also available in: Atom