Project

General

Profile

Activity

From 04/10/2016 to 05/09/2016

04/29/2016

12:25 PM Feature #3092: improve the RemoteLaunchOptionResource to validate against complex expressions
Branch 1774b adds a new "remotelaunchoption" resource which secures the options which can be specified via the remote... Constantin Asofiei
12:23 PM Feature #3092 (New): improve the RemoteLaunchOptionResource to validate against complex expressions
Constantin Asofiei

04/21/2016

07:53 AM Feature #1842: implement the multi-source directory approach
It should really minimize per-site/per-system configuration and allow most things to be configured at the most approp... Greg Shah
07:42 AM Feature #1842: implement the multi-source directory approach
I've not come across this issue before - I like it and have been having similar (less well-structured) thoughts. Paul E

04/19/2016

05:42 AM Feature #1916: improve the runtime statistics gathered by P2J
Paul, I think the stats are enabled by setting a @block-execution-statistics@ attribute in the directory (which repre... Constantin Asofiei

04/18/2016

08:26 AM Feature #1916: improve the runtime statistics gathered by P2J
This sounds interesting. How do I enable gathering of these statistics? Paul E

04/12/2016

12:55 PM Feature #2973 (Closed): improve ContextLocal performance
Code Review Task Branch 3035a Revision 11006
The changes are fine.
I'm closing this task. If there are problem...
Greg Shah
11:06 AM Feature #2973: improve ContextLocal performance
Greg Shah wrote:
> Code Review Task Branch 3035a Revision 11005
>
> 1. @keysInUse@ is missing javadoc.
>
> 2. ...
Igor Skornyakov
10:44 AM Feature #2973: improve ContextLocal performance
Code Review Task Branch 3035a Revision 11005
1. @keysInUse@ is missing javadoc.
2. @ContextKey.toString()@ open...
Greg Shah
09:39 AM Feature #2973: improve ContextLocal performance
Added @ContextKey@ re-use protection.
Committed to the task branch *3035a* revision 11005.
Igor Skornyakov
07:03 AM Feature #2973: improve ContextLocal performance
Greg Shah wrote:
> > how many instances of the ContextKey are expected to be in use at the same time? Just up to an ...
Igor Skornyakov
07:02 AM Feature #2973: improve ContextLocal performance
> how many instances of the ContextKey are expected to be in use at the same time? Just up to an order of magnitude.
...
Greg Shah
07:00 AM Feature #2973: improve ContextLocal performance
Greg Shah wrote:
> We aren't checking that code is not in use. At construction of the @ContextKey@ we can simply as...
Igor Skornyakov
06:56 AM Feature #2973: improve ContextLocal performance
We aren't checking that code is not in use. At construction of the @ContextKey@ we can simply ask the @SecurityConte... Greg Shah
05:47 AM Feature #2973: improve ContextLocal performance
Greg Shah wrote:
> The idea is simply to never set a @ContextKey.id@ that is already in use. No one wants the id to...
Igor Skornyakov
05:33 AM Feature #2973: improve ContextLocal performance
The idea is simply to never set a @ContextKey.id@ that is already in use. No one wants the id to be mutable. Greg Shah
03:53 AM Feature #2973: improve ContextLocal performance
Igor Skornyakov wrote:
> Of course this can be done very easily. However I do not think that it is a good idea. Firs...
Igor Skornyakov
03:41 AM Feature #2973: improve ContextLocal performance
Greg Shah wrote:
> The problem is that one can create a @ContextKey@ instance which fails the @addToken()@ and then ...
Igor Skornyakov

04/11/2016

07:15 PM Feature #2973: improve ContextLocal performance
The problem is that one can create a @ContextKey@ instance which fails the @addToken()@ and then later can call @getT... Greg Shah
06:32 PM Feature #2973: improve ContextLocal performance
Igor Skornyakov wrote:
> Sorry Greg. I do not understand what you and Constantin mean exactly. The @SecurityContext...
Igor Skornyakov
06:27 PM Feature #2973: improve ContextLocal performance
Greg Shah wrote:
> I'm referring to the wrapping case where an id gets reused because the long overflows and some lo...
Igor Skornyakov
06:20 PM Feature #2973: improve ContextLocal performance
> May be it makes sense to add it to the 3035a branch as the change is very small (one line) and non critical?
Yes...
Greg Shah
06:20 PM Feature #2973: improve ContextLocal performance
I'm referring to the wrapping case where an id gets reused because the long overflows and some long-running existing ... Greg Shah
06:16 PM Feature #2973: improve ContextLocal performance
Greg Shah wrote:
> Considering that the check for this is low cost and should not be in the most common use case (th...
Igor Skornyakov
05:59 PM Feature #2973: improve ContextLocal performance
> but I think that 138 years is still a long time which as far beyond any reasonable estimation of a non-stop run dur... Greg Shah
04:07 PM Feature #2973: improve ContextLocal performance
Task branch 2973a was merged to the trunk revision 11001 and archived. Igor Skornyakov
04:02 PM Feature #2973: improve ContextLocal performance
Please merge to trunk. Thank you. Eric Faulhaber
03:40 PM Feature #2973: improve ContextLocal performance
Eric Faulhaber wrote:
> Please address the remaining code review issues.
All issues are fixed now.
> Constantin,...
Constantin Asofiei
03:07 PM Feature #2973: improve ContextLocal performance
Please address the remaining code review issues.
Constantin, I don't think the changes made from this review warra...
Eric Faulhaber
01:38 PM Feature #2973: improve ContextLocal performance
The @ContextKey.id@ is @long@ in revision 11012. Igor Skornyakov
01:29 PM Feature #2973: improve ContextLocal performance
Igor Skornyakov wrote:
> I do not understand the argument regarding the @hashCode@ value - the additional (CPU) over...
Constantin Asofiei
11:38 AM Feature #2973: improve ContextLocal performance
Constantin Asofiei wrote:
> Regardless if we switch to long, the hash key will still be an integer value (this is wh...
Igor Skornyakov
11:24 AM Feature #2973: improve ContextLocal performance
Igor Skornyakov wrote:
> I understand the concern. However it is easy to calculate that if a new instance of the @Co...
Constantin Asofiei
10:54 AM Feature #2973: improve ContextLocal performance
Constantin Asofiei wrote:
> Review for 2973a rev 11008:
> # @ContextKey@
> - we are using @AtomicInteger@ as a gen...
Igor Skornyakov
09:54 AM Feature #2973: improve ContextLocal performance
Another issue in @SecurityContext.transferAllTokens@ - removing an element from the map while the map is processed (v... Constantin Asofiei
09:39 AM Feature #2973: improve ContextLocal performance
Review for 2973a rev 11008:
# @ContextKey@
- we are using @AtomicInteger@ as a generator. My worries are about ver...
Constantin Asofiei
08:29 AM Feature #2973: improve ContextLocal performance
Constantin, would you please review the latest version? Eric Faulhaber
04:08 AM Feature #2973: improve ContextLocal performance
Task branch 2973a was rebased from the trunk revision 11000. Pushed up to revision 11008. Igor Skornyakov

04/10/2016

06:22 PM Feature #2973: improve ContextLocal performance
I've restores the post-cleanup check.
Committed to the task branch 2973a revision 11006.
Automated regression t...
Igor Skornyakov
 

Also available in: Atom