Project

General

Profile

Activity

From 08/15/2017 to 09/13/2017

09/12/2017

04:17 AM Feature #3222: rewrite admin console for native web (html5/css/javascript)
Committed revision 11445 fixed java doc issues from the 570 note except the issue 6. Sergey Ivanovskiy
01:15 AM Feature #3222: rewrite admin console for native web (html5/css/javascript)
> 6. AdminServiceImpl - methods starting from line 2055 to line 2330
These methods are not implemented by @AdminServ... Sergey Ivanovskiy
12:12 AM Feature #3222: rewrite admin console for native web (html5/css/javascript)
Fixing the import statements is not very valuable because we use the Bootstrap GWT UI library, GWT and Guava that hav... Sergey Ivanovskiy

09/11/2017

08:36 AM Feature #3222: rewrite admin console for native web (html5/css/javascript)
Working to fix the issues listed in 570. Sergey Ivanovskiy

09/07/2017

02:56 PM Feature #3222: rewrite admin console for native web (html5/css/javascript)
I'm adding the coding standard issues here, all are in FWD code.
Sergey: I think most of them are yours, can you p... Constantin Asofiei

09/06/2017

12:09 PM Feature #3222: rewrite admin console for native web (html5/css/javascript)
> will build the "core" without Admin. But if you think the core target would still be needed I will add it.
Yes, ... Greg Shah
11:46 AM Feature #3222: rewrite admin console for native web (html5/css/javascript)
Greg Shah wrote:
> On average, how much is the increase?
On my i5-6440HQ the Admin build target takes 84 seconds.... Hynek Cihlar
09:17 AM Feature #3222: rewrite admin console for native web (html5/css/javascript)
Sorry, that should have been @gradle@, not @ant@. Not sure where my mind is... Greg Shah
09:17 AM Feature #3222: rewrite admin console for native web (html5/css/javascript)
> This results in significant build time increase even when there is no change to the sources.
On average, how mu... Greg Shah

09/05/2017

06:08 PM Feature #3222: rewrite admin console for native web (html5/css/javascript)
The Admin part of the FWD build takes considerable amount od time relatively to the rest while the GWT compiler doesn... Hynek Cihlar

08/25/2017

06:56 PM Feature #3222: rewrite admin console for native web (html5/css/javascript)
Committed rev 11441 was rebased over the trunc rev 11164 and fixed javadoc warnings. Sergey Ivanovskiy
04:14 PM Feature #3222: rewrite admin console for native web (html5/css/javascript)
Rebased up to rev 11436 over the current trunc 11162. Sergey Ivanovskiy
03:26 PM Feature #3222: rewrite admin console for native web (html5/css/javascript)
Committed revision 11434 fixed some of missed headers and java docs. Rebasing now. Sergey Ivanovskiy

08/24/2017

01:44 PM Feature #3222: rewrite admin console for native web (html5/css/javascript)
3222a is rebased rev 11433 over the current trunk 11160. Sergey Ivanovskiy
06:21 AM Feature #3222: rewrite admin console for native web (html5/css/javascript)
3222a is rebased rev. 11431 over the current trunk 11159. Sergey Ivanovskiy
05:59 AM Feature #3222: rewrite admin console for native web (html5/css/javascript)
Committed revision 11430 fixed missed java doc for server report package. Rebasing the branch now. Sergey Ivanovskiy

08/23/2017

07:25 AM Feature #3222: rewrite admin console for native web (html5/css/javascript)
It seems that this Eclipse tool https://sourceforge.net/projects/jautodoc/ is helpful to add java docs automatically.... Sergey Ivanovskiy
06:20 AM Feature #3222: rewrite admin console for native web (html5/css/javascript)
Committed revision 11429 fixed java docs for @com.goldencode.p2j.admin.client.application.home.print@ and @com.golden... Sergey Ivanovskiy

08/22/2017

02:58 AM Feature #3222: rewrite admin console for native web (html5/css/javascript)
Committed revision 11428 fixed java docs for @com.goldencode.p2j.admin.client.application.home.console@ package. Look... Sergey Ivanovskiy

08/21/2017

09:02 AM Feature #3222: rewrite admin console for native web (html5/css/javascript)
Sergey Ivanovskiy wrote:
> I suppose that you didn't update 3222a after my rebases.
I did, but I keep history in ... Hynek Cihlar
09:00 AM Feature #3222: rewrite admin console for native web (html5/css/javascript)
Ok, thank you. It seems that they were not added at all. I suppose that you didn't update 3222a after my rebases. Sergey Ivanovskiy
08:58 AM Feature #3222: rewrite admin console for native web (html5/css/javascript)
Sergey Ivanovskiy wrote:
> I am suspecting that some java docs at least were lost.
I checked AcquiredLocks* and R... Hynek Cihlar
08:34 AM Feature #3222: rewrite admin console for native web (html5/css/javascript)
I am suspecting that some java docs at least were lost. Sergey Ivanovskiy
08:33 AM Feature #3222: rewrite admin console for native web (html5/css/javascript)
No, I think, because the rebase has been done with @push overwrite@ if you haven't updated it yet after the branch ha... Sergey Ivanovskiy
08:32 AM Feature #3222: rewrite admin console for native web (html5/css/javascript)
Sergey Ivanovskiy wrote:
> Hynek, could you please send me your local 3222a branch diff against the current 3222a br... Hynek Cihlar
08:25 AM Feature #3222: rewrite admin console for native web (html5/css/javascript)
Hynek, could you please send me your local 3222a branch diff against the current 3222a branch diff if you haven't upd... Sergey Ivanovskiy
07:58 AM Feature #3222: rewrite admin console for native web (html5/css/javascript)
Found that AcquiredLocks* classes have no java docs but it seems that I added them before. Also RecordLocks* classes... Sergey Ivanovskiy
02:05 AM Feature #3222: rewrite admin console for native web (html5/css/javascript)
The all code is large enough and some java docs can be missed now. The accounts package has been filled with missed j... Sergey Ivanovskiy
01:23 AM Feature #3222: rewrite admin console for native web (html5/css/javascript)
Correct, java docs for these units were added by committed revision 11425. Sergey Ivanovskiy

08/20/2017

12:58 PM Feature #3222: rewrite admin console for native web (html5/css/javascript)
Sergey Ivanovskiy wrote:
> Hynek, do you agree if I will add java docs and headers to @ProcessActionDefinition@ and ... Eric Faulhaber
08:09 AM Feature #3222: rewrite admin console for native web (html5/css/javascript)
3222a was rebased, the current revision is 11422.
Hynek, do you agree if I will add java docs and headers to @Proc... Sergey Ivanovskiy

08/17/2017

03:35 PM Feature #3222: rewrite admin console for native web (html5/css/javascript)
Planning to rebase 3222a now. Sergey Ivanovskiy
02:59 AM Feature #3222: rewrite admin console for native web (html5/css/javascript)
Eric Faulhaber wrote:
> Eric Faulhaber wrote:
> > Were these classes machine-generated?
> Just curious -- were the... Hynek Cihlar
08:37 PM Feature #3222: rewrite admin console for native web (html5/css/javascript)
Committed revision 11417 fixed java docs for the certificates package. Sergey Ivanovskiy
08:35 PM Feature #3222: rewrite admin console for native web (html5/css/javascript)
Don't know. Hynek, please could you help? Sergey Ivanovskiy

08/16/2017

04:17 PM Feature #3222: rewrite admin console for native web (html5/css/javascript)
Eric Faulhaber wrote:
> Were these classes machine-generated?
Just curious -- were these made by an IDE plug-in or ... Eric Faulhaber
02:39 PM Feature #3222: rewrite admin console for native web (html5/css/javascript)
Sergey Ivanovskiy wrote:
> Please point to the usage of AGPL in the trunc to fix these issues correctly.
See, for e... Eric Faulhaber
02:32 PM Feature #3222: rewrite admin console for native web (html5/css/javascript)
Sergey Ivanovskiy wrote:
> I guess you mean undocumented UI annotated fields like these ones
Yes, but also many met... Eric Faulhaber
02:31 PM Feature #3222: rewrite admin console for native web (html5/css/javascript)
Eric Faulhaber wrote:
> Missing AGPL license text and/or wrong copyright notice; should be the one which goes with A... Sergey Ivanovskiy
02:27 PM Feature #3222: rewrite admin console for native web (html5/css/javascript)
Eric Faulhaber wrote:
> More coding standard issues I'm seeing across multiple files:
> * @extends@ and @implements... Sergey Ivanovskiy
02:16 PM Feature #3222: rewrite admin console for native web (html5/css/javascript)
More coding standard issues I'm seeing across multiple files:
* @extends@ and @implements@ keywords should be on nex... Eric Faulhaber
01:28 PM Feature #3222: rewrite admin console for native web (html5/css/javascript)
Missing javadoc:... Eric Faulhaber
11:19 AM Feature #3222: rewrite admin console for native web (html5/css/javascript)
Eric Faulhaber wrote:
> Hynek, I have a rudimentary understanding of the GWT module concept, but please add some doc... Hynek Cihlar
11:07 AM Feature #3222: rewrite admin console for native web (html5/css/javascript)
Ok, thanks for pointing this coding rule (handbook/coding_stds/format.html, Java import statements). I was sure that ... Sergey Ivanovskiy
10:49 AM Feature #3222: rewrite admin console for native web (html5/css/javascript)
Sergey, I've noticed in a number of files you have edited in this branch that you are using individual import stateme... Eric Faulhaber
10:32 AM Feature #3222: rewrite admin console for native web (html5/css/javascript)
Hynek, I have a rudimentary understanding of the GWT module concept, but please add some documentation to each of the... Eric Faulhaber
 

Also available in: Atom