FWD » Core Development » Runtime Infrastructure

05/21/2018

07:18 PM Feature #3565: provide better support for file system access across platforms

Committed revision 11270 added @src/com/goldencode/p2j/util/PathResolverContainer.java@. Sergey Ivanovskiy

06:53 PM Feature #3565: provide better support for file system access across platforms

Committed revision 11269 fixed java docs. Sergey Ivanovskiy

06:14 PM Feature #3565: provide better support for file system access across platforms

Greg, please review 11268. I encountered text conflict in @Utils.java@ that it is possible that your changes can be l... Sergey Ivanovskiy

02:24 PM Feature #3565: provide better support for file system access across platforms

> @ThinClient.getInstance().getFileSystemDaemon()@
Surely we should not need to call @ThinClient@ from @FileSystem... Greg Shah

02:14 PM Feature #3565: provide better support for file system access across platforms

I did a mistake
>And in this instance method com.goldencode.p2j.util.FileSystemDaemon.getFileName(boolean, boolean, ... Sergey Ivanovskiy

02:12 PM Feature #3565: provide better support for file system access across platforms

Sergey Ivanovskiy wrote:
> I searched usages of @FileSystemDaemon@ constructor
> [...]
> Is the second usage corre... Constantin Asofiei

02:01 PM Feature #3565: provide better support for file system access across platforms

> @searchAll@ is used only
> @search@ is used only
OK, good analysis. Please add comments to both of these to ex... Greg Shah

01:37 PM Feature #3565: provide better support for file system access across platforms

Greg Shah wrote:
> Code Review Task Branch 3565a Revision 11266
>
> 1. Why is this code duplicated in multiple @F... Sergey Ivanovskiy

01:17 PM Feature #3565: provide better support for file system access across platforms

I searched usages of @FileSystemDaemon@ constructor... Sergey Ivanovskiy

12:40 PM Feature #3565: provide better support for file system access across platforms

Greg Shah wrote:
> Code Review Task Branch 3565a Revision 11266
>
> 3. Don't the following @FileSystemDaemon@ met... Sergey Ivanovskiy

10:40 AM Feature #3565: provide better support for file system access across platforms

Code Review Task Branch 3565a Revision 11266
1. Why is this code duplicated in multiple @FileSystemDaemon@ locatio... Greg Shah

09:16 AM Feature #3565: provide better support for file system access across platforms

> It seems that OPEN-MIME-RESOURCE and OPEN-URL should resolve the file path if they open the local file. Correct?
... Greg Shah

07:55 AM Feature #3565: provide better support for file system access across platforms

Eric Faulhaber wrote:
> Sergey, will your changes handle image loading from the file system as well? I am not that f... Sergey Ivanovskiy

07:10 AM Feature #3565: provide better support for file system access across platforms

It seems that this implementation of the search @FileSystemDaemon.searchAll@ searches file system roots first and if ... Sergey Ivanovskiy

06:58 AM Feature #3565: provide better support for file system access across platforms

Constantin Asofiei wrote:
> Test @FILE-INFO:FILENAME@ and associated attributes like @PATHNAME@ and @FULL-PATHNAME@,... Sergey Ivanovskiy

02:57 AM Feature #3565: provide better support for file system access across platforms

Eric Faulhaber wrote:
> Sergey Ivanovskiy wrote:
> > Eric, could you point on the case where the image loading prob... Constantin Asofiei

02:41 AM Feature #3565: provide better support for file system access across platforms

Sergey Ivanovskiy wrote:
> Eric, could you point on the case where the image loading problem appeared?
The probl... Eric Faulhaber

01:20 AM Feature #3565: provide better support for file system access across platforms

In this function the target resource is looking through the value of @searchpath@ defined by the directory. This is t... Sergey Ivanovskiy

12:45 AM Feature #3565: provide better support for file system access across platforms

If we investigate the @PROPATH@ of the converted application, then we can find that all these paths are relative to t... Sergey Ivanovskiy

12:41 AM Feature #3565: provide better support for file system access across platforms

Don't mind it is due to java doc doesn't describe that if the target resource is not found in its application jar, th... Sergey Ivanovskiy

12:24 AM Feature #3565: provide better support for file system access across platforms

Eric, could you point on the case where the image loading problem appeared? There is @LogicalTerminal.getImageStreamF... Sergey Ivanovskiy

12:11 AM Feature #3565: provide better support for file system access across platforms

Sergey, will your changes handle image loading from the file system as well? I am not that familiar with the UI side ... Eric Faulhaber

05/20/2018

03:29 PM Feature #3565: provide better support for file system access across platforms

Test @FILE-INFO:FILENAME@ and associated attributes like @PATHNAME@ and @FULL-PATHNAME@, with FWD configured for lega... Constantin Asofiei

02:16 PM Feature #3565: provide better support for file system access across platforms

Constantin Asofiei wrote:
> Sergey, please test folder names with FILE-INFO handle, like @FILE-INFO:FILENAME = "."@ ... Sergey Ivanovskiy

05/18/2018

06:24 PM Feature #3565: provide better support for file system access across platforms

At least this patch I think is required:... Constantin Asofiei

06:00 PM Feature #3565: provide better support for file system access across platforms

Sergey, please test folder names with FILE-INFO handle, like @FILE-INFO:FILENAME = "."@ (and other folder names), for... Constantin Asofiei

05:14 PM Feature #3565: provide better support for file system access across platforms

It seems that OPEN-MIME-RESOURCE and OPEN-URL should resolve the file path if they open the local file. Correct?
<p... Sergey Ivanovskiy

01:08 PM Feature #3565: provide better support for file system access across platforms

Please review the committed revision 11264. It should cover all file path usages. Sergey Ivanovskiy

05/16/2018

04:18 PM Feature #3565: provide better support for file system access across platforms

Greg Shah wrote:
> 3. In any usage of @FileSystemDaemon.search*()@ on the *client side*, we use it for lookup in the... Constantin Asofiei

04:02 PM Feature #3565: provide better support for file system access across platforms

I added this setting @<parameter name="opsys" value="win32" />@... Sergey Ivanovskiy

03:45 PM Feature #3565: provide better support for file system access across platforms

Sergey Ivanovskiy wrote:
> I don't understand why this converted code works with "\\", but doesn't work with "\"
> ... Greg Shah

03:41 PM Feature #3565: provide better support for file system access across platforms

Sergey Ivanovskiy wrote:
> I need advices how to convert this program correctly
> [...]
There is no file system ... Greg Shah

03:41 PM Feature #3565: provide better support for file system access across platforms

Sergey Ivanovskiy wrote:
> Greg, please help to explain the @propath@ values. Is it correct that if @propath@ lists ... Greg Shah

03:40 PM Feature #3565: provide better support for file system access across platforms

I don't understand why this converted code works with "\\", but doesn't work with "\"... Sergey Ivanovskiy

03:28 PM Feature #3565: provide better support for file system access across platforms

Testing this committed revision 11258. Please look at this revision. The directory changes are... Sergey Ivanovskiy

03:05 PM Feature #3565: provide better support for file system access across platforms

I need advices how to convert this program correctly... Sergey Ivanovskiy

02:51 PM Feature #3565: provide better support for file system access across platforms

It seems that my changes in file-separator has an impact on the conversion of windows path strings... Sergey Ivanovskiy

01:29 PM Feature #3565: provide better support for file system access across platforms

> It seems that this "legacyPlatform" has similar meaning as new proposed legacy-system/opsys.
You are right.
P... Greg Shah

12:22 PM Feature #3565: provide better support for file system access across platforms

Greg, please help to explain the @propath@ values. Is it correct that if @propath@ lists legacy paths, then it must b... Sergey Ivanovskiy

11:29 AM Feature #3565: provide better support for file system access across platforms

There is @"legacyPlatform"@ ... Sergey Ivanovskiy

11:08 AM Feature #3565: provide better support for file system access across platforms

Thank you, see the idea now. Sergey Ivanovskiy

10:51 AM Feature #3565: provide better support for file system access across platforms

> then what is the responsibility file-system node?
It won't exist.
> Do these changes just extend/rename file... Greg Shah

10:49 AM Feature #3565: provide better support for file system access across platforms

Greg, if we add @legacy-system@ node, then what is the responsibility @file-system@ node? There are @file-system/pkgr... Sergey Ivanovskiy

08:28 PM Feature #3565: provide better support for file system access across platforms

Planning to use redundant data for the same mapping... Sergey Ivanovskiy

08:21 PM Feature #3565: provide better support for file system access across platforms

That is true for the name attribute since it is part of the "path" to the node.
You will need to implement somethi... Greg Shah

08:05 PM Feature #3565: provide better support for file system access across platforms

We can't use @:@ colon character, @/@ slash and @\@ back slash in node names. It seems that these nodes are invalid
... Sergey Ivanovskiy

05/15/2018

07:38 PM Feature #3565: provide better support for file system access across platforms

Please don't mind. If the scope of search is defined to be accounts search, then similar paths to @/server/standard/r... Sergey Ivanovskiy

07:14 PM Feature #3565: provide better support for file system access across platforms

My code failed to read @file-system@ node due to it has no read access writes to the target nodes. It seems that the ... Sergey Ivanovskiy

05:50 PM Feature #3565 (WIP): provide better support for file system access across platforms

1. I think we need to track the original system @OPSYS@ value.
Today we have the capability to override the @OPS... Greg Shah

05:20 PM Feature #3565: provide better support for file system access across platforms

OK. It is unclear how to support @absolute-path-prefix-map@ if there are Windows and Linux clients simultaneously acc... Sergey Ivanovskiy

09:33 AM Feature #3565: provide better support for file system access across platforms

Consider sending @absolute-path-prefix-map@ down to the client in @FileSystemOps.ContextContainer.initialValue()@. Greg Shah

09:29 AM Feature #3565: provide better support for file system access across platforms

It seems that the client gets directory settings via @BootstrapConfig@. And there are no usages of @DirectoryService@... Sergey Ivanovskiy

05/14/2018

05:45 PM Feature #3565: provide better support for file system access across platforms

Committed revision 11254 (3565a) added @PathResolver@ defined in @Utils@ module. Sergey Ivanovskiy

03:33 PM Feature #3565: provide better support for file system access across platforms

Please don't mind. These values define the native file separator and the native case sensitive mode. Sergey Ivanovskiy

03:17 PM Feature #3565: provide better support for file system access across platforms

It seems that with @file-separator@ and @case-sensitive@ under @file-system@ node this task needs @native-file-separa... Sergey Ivanovskiy

12:45 PM Feature #3565: provide better support for file system access across platforms

Yes.
The idea is to accept the longest exact match (case-insensitive) to a prefix of a path. That match must only... Greg Shah

12:25 PM Feature #3565: provide better support for file system access across platforms

Let us consider these hypothetical settings... Sergey Ivanovskiy

05/11/2018

10:51 AM Feature #3565: provide better support for file system access across platforms

Sergey Ivanovskiy wrote:
> OK. It seems I considered another tasks. Thanks for explanations. Thus in this task we sh... Eric Faulhaber

10:27 AM Feature #3565: provide better support for file system access across platforms

OK. It seems I considered another tasks. Thanks for explanations. Thus in this task we should add a windows path supp... Sergey Ivanovskiy

09:34 AM Feature #3565: provide better support for file system access across platforms

Sergey Ivanovskiy wrote:
> Constantin, in this revision 11269 (branch 3556a) you added similar mapping as described ... Constantin Asofiei

09:29 AM Feature #3565: provide better support for file system access across platforms

Constantin, in this revision 11269 (branch 3556a) you added similar mapping as described in this task Absolute Task P... Sergey Ivanovskiy

07:33 AM Feature #3565: provide better support for file system access across platforms

OK. The task branch 3565a rev 11253 - created. Sergey Ivanovskiy

07:14 AM Feature #3565: provide better support for file system access across platforms

Sergey Ivanovskiy wrote:
> Don't know it is reasonable to use 3556a. Although 3556a contains timer changes, r-file s... Eric Faulhaber

03:53 AM Feature #3565: provide better support for file system access across platforms

Don't know it is reasonable to use 3556a. Although 3556a contains timer changes, r-file search improvements and selec... Sergey Ivanovskiy

05/10/2018

03:53 PM Feature #3565: provide better support for file system access across platforms

There is an impedance mismatch when a converted application accesses file system resources, if the original system ra... Eric Faulhaber

02:22 PM Feature #3565 (WIP): provide better support for file system access across platforms

Eric Faulhaber