FWD » Core Development » Runtime Infrastructure

05/29/2018

04:03 PM Feature #3565: provide better support for file system access across platforms

Eric Faulhaber wrote:
> So, the two things to fix in 3565b are:
>
> * make the FWD SEARCH implementation work the... Sergey Ivanovskiy

09:40 AM Feature #3565: provide better support for file system access across platforms

I can confirm that INPUT FROM does not use the search path, as Sergey found through separate testing.
So, the two ... Eric Faulhaber

02:03 AM Feature #3565: provide better support for file system access across platforms

Created 3565b task branch. Sergey Ivanovskiy

05/28/2018

05:45 PM Feature #3565: provide better support for file system access across platforms

Sergey Ivanovskiy wrote:
> Eric, please test this one
> [...]
Based on Greg's response, that doesn't look right. Eric Faulhaber

05:42 PM Feature #3565: provide better support for file system access across platforms

@StreamDaemon.openFileStream@ comes from two language statements:
1. @INPUT FROM@ which opens a file for reading.... Greg Shah

05:32 PM Feature #3565: provide better support for file system access across platforms

Eric Faulhaber wrote:
> How much effort to add this? It is pretty urgent.
Eric, please test this one... Sergey Ivanovskiy

05:05 PM Feature #3565: provide better support for file system access across platforms

Sergey Ivanovskiy wrote:
> Please specify how it should work precisely. Should this relative path name be searched i... Eric Faulhaber

05:03 PM Feature #3565: provide better support for file system access across platforms

Please specify how it should work precisely. Should this relative path name be searched in PROPATH or SEARCHPATH that... Sergey Ivanovskiy

04:47 PM Feature #3565: provide better support for file system access across platforms

Sergey Ivanovskiy wrote:
> OK. @StreamDaemon.openFileStream@ doesn't implement case insensitive search. It is only m... Eric Faulhaber

04:42 PM Feature #3565: provide better support for file system access across platforms

OK. @StreamDaemon.openFileStream@ doesn't implement case insensitive search. It only maps absolute legacy paths to ho... Sergey Ivanovskiy

04:25 PM Feature #3565: provide better support for file system access across platforms

Sergey, I'm getting errors loading files using relative paths. The use case:... Eric Faulhaber

05/26/2018

08:15 PM Feature #3565: provide better support for file system access across platforms

3565a has been merged into the trunc as bzr revision 11261 and archived. Sergey Ivanovskiy

08:04 PM Feature #3565: provide better support for file system access across platforms

3565a passed regression testing, planning to merge it into the trunk now. Sergey Ivanovskiy

05/25/2018

04:43 AM Feature #3565: provide better support for file system access across platforms

remote 3565a branch for regression testing was created with corresponding directory changes: file-system to legacy-sy... Sergey Ivanovskiy

01:55 AM Feature #3565: provide better support for file system access across platforms

I started regression testing for rev 11280, but forgot to setup manually the directory that has changes. Sergey Ivanovskiy

05/23/2018

04:48 PM Feature #3565: provide better support for file system access across platforms

OK. 3565a has been updated over the trunc rev. 11259 up to the rev. 11277. Sergey Ivanovskiy

04:17 PM Feature #3565: provide better support for file system access across platforms

Sergey, please rebase 3565a. I have a converted project that depends upon changes in trunk revision 11259. Thanks. Eric Faulhaber

05/22/2018

12:29 PM Feature #3565: provide better support for file system access across platforms

Committed revision 11275 reduced the log level to FINER. My environment is not ready now. I am building the customer ... Sergey Ivanovskiy

12:21 PM Feature #3565: provide better support for file system access across platforms

Code Review Task Branch 3565a Revision 11274
I'm good with the changes.
Please use @Level.FINER@ instead of @L... Greg Shah

12:18 PM Feature #3565: provide better support for file system access across platforms

OK. It has been fixed in committed revision 11274. Sergey Ivanovskiy

12:05 PM Feature #3565: provide better support for file system access across platforms

This is not a code review, but I have a minor request: please rename @UnResolvedPathException@ to @UnresolvedPathExce... Eric Faulhaber

11:51 AM Feature #3565: provide better support for file system access across platforms

Please review the committed revision 11273. Sergey Ivanovskiy

09:35 AM Feature #3565: provide better support for file system access across platforms

@legacy-system/opsys@ is the definition of the original OPSYS value from the legacy system (the system on which the 4... Greg Shah

09:31 AM Feature #3565: provide better support for file system access across platforms

Sergey Ivanovskiy wrote:
> Testing this committed revision 11258. Please look at this revision. The directory change... Eric Faulhaber

09:24 AM Feature #3565: provide better support for file system access across platforms

It seems that I missed this issue because I got this case too without proper settings. Thank you, planning to fix it ... Sergey Ivanovskiy

09:14 AM Feature #3565: provide better support for file system access across platforms

I just tried using this branch with a project that does not have any directory changes. I got:... Eric Faulhaber

09:02 AM Feature #3565: provide better support for file system access across platforms

Code Review Task Branch 3565a Revision 11272
I am OK with the changes.
> this.paths field is set from void setS... Greg Shah

08:56 AM Feature #3565: provide better support for file system access across platforms

Can I start regression testing for 3565a? Sergey Ivanovskiy

05:36 AM Feature #3565: provide better support for file system access across platforms

3565a rev 11272 has been updated over trunc rev 11257. Sergey Ivanovskiy

05/21/2018

07:18 PM Feature #3565: provide better support for file system access across platforms

Committed revision 11270 added @src/com/goldencode/p2j/util/PathResolverContainer.java@. Sergey Ivanovskiy

06:53 PM Feature #3565: provide better support for file system access across platforms

Committed revision 11269 fixed java docs. Sergey Ivanovskiy

06:14 PM Feature #3565: provide better support for file system access across platforms

Greg, please review 11268. I encountered text conflict in @Utils.java@ that it is possible that your changes can be l... Sergey Ivanovskiy

02:24 PM Feature #3565: provide better support for file system access across platforms

> @ThinClient.getInstance().getFileSystemDaemon()@
Surely we should not need to call @ThinClient@ from @FileSystem... Greg Shah

02:14 PM Feature #3565: provide better support for file system access across platforms

I did a mistake
>And in this instance method com.goldencode.p2j.util.FileSystemDaemon.getFileName(boolean, boolean, ... Sergey Ivanovskiy

02:12 PM Feature #3565: provide better support for file system access across platforms

Sergey Ivanovskiy wrote:
> I searched usages of @FileSystemDaemon@ constructor
> [...]
> Is the second usage corre... Constantin Asofiei

02:01 PM Feature #3565: provide better support for file system access across platforms

> @searchAll@ is used only
> @search@ is used only
OK, good analysis. Please add comments to both of these to ex... Greg Shah

01:37 PM Feature #3565: provide better support for file system access across platforms

Greg Shah wrote:
> Code Review Task Branch 3565a Revision 11266
>
> 1. Why is this code duplicated in multiple @F... Sergey Ivanovskiy

01:17 PM Feature #3565: provide better support for file system access across platforms

I searched usages of @FileSystemDaemon@ constructor... Sergey Ivanovskiy

12:40 PM Feature #3565: provide better support for file system access across platforms

Greg Shah wrote:
> Code Review Task Branch 3565a Revision 11266
>
> 3. Don't the following @FileSystemDaemon@ met... Sergey Ivanovskiy

10:40 AM Feature #3565: provide better support for file system access across platforms

Code Review Task Branch 3565a Revision 11266
1. Why is this code duplicated in multiple @FileSystemDaemon@ locatio... Greg Shah

09:16 AM Feature #3565: provide better support for file system access across platforms

> It seems that OPEN-MIME-RESOURCE and OPEN-URL should resolve the file path if they open the local file. Correct?
... Greg Shah

07:55 AM Feature #3565: provide better support for file system access across platforms

Eric Faulhaber wrote:
> Sergey, will your changes handle image loading from the file system as well? I am not that f... Sergey Ivanovskiy

07:10 AM Feature #3565: provide better support for file system access across platforms

It seems that this implementation of the search @FileSystemDaemon.searchAll@ searches file system roots first and if ... Sergey Ivanovskiy

06:58 AM Feature #3565: provide better support for file system access across platforms

Constantin Asofiei wrote:
> Test @FILE-INFO:FILENAME@ and associated attributes like @PATHNAME@ and @FULL-PATHNAME@,... Sergey Ivanovskiy

02:57 AM Feature #3565: provide better support for file system access across platforms

Eric Faulhaber wrote:
> Sergey Ivanovskiy wrote:
> > Eric, could you point on the case where the image loading prob... Constantin Asofiei

02:41 AM Feature #3565: provide better support for file system access across platforms

Sergey Ivanovskiy wrote:
> Eric, could you point on the case where the image loading problem appeared?
The probl... Eric Faulhaber

01:20 AM Feature #3565: provide better support for file system access across platforms

In this function the target resource is looking through the value of @searchpath@ defined by the directory. This is t... Sergey Ivanovskiy

12:45 AM Feature #3565: provide better support for file system access across platforms

If we investigate the @PROPATH@ of the converted application, then we can find that all these paths are relative to t... Sergey Ivanovskiy

12:41 AM Feature #3565: provide better support for file system access across platforms

Don't mind it is due to java doc doesn't describe that if the target resource is not found in its application jar, th... Sergey Ivanovskiy

12:24 AM Feature #3565: provide better support for file system access across platforms

Eric, could you point on the case where the image loading problem appeared? There is @LogicalTerminal.getImageStreamF... Sergey Ivanovskiy

12:11 AM Feature #3565: provide better support for file system access across platforms

Sergey, will your changes handle image loading from the file system as well? I am not that familiar with the UI side ... Eric Faulhaber

05/20/2018

03:29 PM Feature #3565: provide better support for file system access across platforms

Test @FILE-INFO:FILENAME@ and associated attributes like @PATHNAME@ and @FULL-PATHNAME@, with FWD configured for lega... Constantin Asofiei

02:16 PM Feature #3565: provide better support for file system access across platforms

Constantin Asofiei wrote:
> Sergey, please test folder names with FILE-INFO handle, like @FILE-INFO:FILENAME = "."@ ... Sergey Ivanovskiy

05/18/2018

06:24 PM Feature #3565: provide better support for file system access across platforms

At least this patch I think is required:... Constantin Asofiei

06:00 PM Feature #3565: provide better support for file system access across platforms

Sergey, please test folder names with FILE-INFO handle, like @FILE-INFO:FILENAME = "."@ (and other folder names), for... Constantin Asofiei

05:14 PM Feature #3565: provide better support for file system access across platforms

It seems that OPEN-MIME-RESOURCE and OPEN-URL should resolve the file path if they open the local file. Correct?
<p... Sergey Ivanovskiy

01:08 PM Feature #3565: provide better support for file system access across platforms

Please review the committed revision 11264. It should cover all file path usages. Sergey Ivanovskiy