Project

General

Profile

Activity

From 11/20/2022 to 12/19/2022

12/19/2022

05:09 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> > Right now, I don't foresee any changes to conversion needed. If that changes, I would agree with this idea.
>
...
Greg Shah
06:51 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> Galya Bogdanova wrote:
>
> > *Conversion* code should be reworked to not be broken by upcoming ...
Galya B

12/16/2022

09:50 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> We need both server side and client side logging. I think most of the time the server side appro...
Galya B
09:33 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> > We are at a point where we are still heavily modifying our implementation and that includes our external API.
> ...
Greg Shah
09:33 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Yes, @LogHelper@ can be changed. Greg Shah
09:32 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> We are at a point where we are still heavily modifying our implementation and that includes our e...
Galya B
09:31 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> At this time, I don't see how our 4GL-compatibility needs to change for this task, but I may be m...
Galya B
09:29 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> If some FWD users want to develop their new Java code extending their app functionality, do they import / integrate... Greg Shah
09:25 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> * Each system process should have a separate log file.
Yes
> * Screen / client drivers output on the screen e...
Greg Shah
06:49 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
A question: If some FWD users want to develop their new Java code extending their app functionality, do they import /... Galya B
07:24 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
Please focus on #5703 first and pause work on this task. Greg Shah
05:48 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
Galya Bogdanova wrote:
> The Windows spawner creates the new process with all the needed attributes as it is now, bu...
Galya B
03:01 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
Galya Bogdanova wrote:
> That's where we set a @stdout@ handler to the properly renamed filename and execute the @cm...
Galya B
02:52 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
I have another idea of how to solve the pid issue on Windows.
The Windows spawner creates the new process with all...
Galya B
02:30 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
Greg Shah wrote:
> I think you can try any 4GL code which uses @DISPLAY@, @PUT@ or similar output statement without ...
Galya B

12/15/2022

02:56 PM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
> I need an ABL procedure that outputs to outputToFile to test it out.
I think you can try any 4GL code which uses...
Greg Shah
01:17 PM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
I'm attaching a diff for a demo implementation of how @%pid%@ replace and @stdout@ redirect can work in Java for back... Galya B
09:00 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
> Run the cmd in the spawner process itself. This looks like a more dangerous exercise, since I don't fully understan... Greg Shah
07:26 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
My proposal cannot actually work for Windows where @CreateProcess@ creates an independent new process without any ref... Galya B
11:02 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
I'll use this comment to summarize the types of log files we ultimately need (it'll be updated additionally).
---...
Galya B
09:01 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
A related issue to be addressed by the change, as described in #4331:
> Standalone clients (confirmed for gui_swin...
Galya B

12/12/2022

04:34 PM Bug #5699 (Closed): broken logfile name on Windows appserver clients (and probably other cases on...
Greg Shah
01:28 PM Bug #5699: broken logfile name on Windows appserver clients (and probably other cases on Windows)
I ran the server on Windows with a batch process and was able to confirm the new behavior of the spawner of properly ... Galya B
01:29 PM Feature #6939: improve proxy performance by hard-coding method invocation
Some additional notes:
* having both consumer and function lambdas doesn't really have a functional benefit, only fu...
Constantin Asofiei
10:32 AM Feature #6939: improve proxy performance by hard-coding method invocation
Eric, please review attached patch - it adds a invocation handler like this:... Constantin Asofiei

12/09/2022

05:41 AM Bug #5699: broken logfile name on Windows appserver clients (and probably other cases on Windows)
Greg Shah wrote:
> In your current setup, you are just using a local copy *bound to* the central repo. Any local co...
Galya B
05:38 AM Bug #5699 (Test): broken logfile name on Windows appserver clients (and probably other cases on W...
When you believe that all functional requirements of the task are complete, please set the % Done to 100%. Greg Shah
05:37 AM Bug #5699: broken logfile name on Windows appserver clients (and probably other cases on Windows)
> I messed up the branch creation / co and pushed from the local branch directly to 3821c. I'll be more careful next ... Greg Shah
05:32 AM Bug #5699: broken logfile name on Windows appserver clients (and probably other cases on Windows)
Greg Shah wrote:
> Code Review Task Branch 3821c Revision 14429
>
> The change is good, however you are missing t...
Galya B
05:30 AM Bug #5699: broken logfile name on Windows appserver clients (and probably other cases on Windows)
Code Review Task Branch 3821c Revision 14429
The change is good, however you are missing the history entry.
Greg Shah
05:20 AM Bug #5699 (Review): broken logfile name on Windows appserver clients (and probably other cases on...
Greg Shah wrote:
> Is @string@ not a pointer to @WCHAR@? If the contents of @string@ are not wide characters, then ...
Galya B

12/08/2022

04:23 PM Bug #5699: broken logfile name on Windows appserver clients (and probably other cases on Windows)
Is @string@ not a pointer to @WCHAR@? If the contents of @string@ are not wide characters, then that explains the re... Greg Shah
11:42 AM Bug #5699 (WIP): broken logfile name on Windows appserver clients (and probably other cases on Wi...
I was able to reproduce it. The problem is in @replace_str@ function. I've added to the code a few comments to show v... Galya B
01:55 PM Feature #6939: improve proxy performance by hard-coding method invocation
In the lambda approach, the target instance is already captured, so changing the array also changes the target. Greg Shah
01:43 PM Feature #6939: improve proxy performance by hard-coding method invocation
Greg Shah wrote:
> If we need the ability to temporarily replace the target methods for an implementation,
I don't ...
Constantin Asofiei
01:29 PM Feature #6939: improve proxy performance by hard-coding method invocation
If we need the ability to temporarily replace the target methods for an implementation, we should consider a kind of ... Greg Shah
01:10 PM Feature #6939: improve proxy performance by hard-coding method invocation
Constantin Asofiei wrote:
> ... directly from the bytecode of the i.e. DMO Implementation class setter/getter.
wh...
Constantin Asofiei
01:07 PM Feature #6939: improve proxy performance by hard-coding method invocation
Eric, the main issue of the interceptor flavor of the @InvocationHandler@ is that in some cases the target instance o... Constantin Asofiei

12/07/2022

07:07 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
From Galya, via email:
> I haven't looked at the Java classes instantiated by the spawner, so let me ask if there ...
Greg Shah

12/05/2022

09:29 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
Greg Shah wrote:
> The approach seems reasonable.
>
> Eugenie: Do you have any thoughts, questions or concerns?
...
Eugenie Lyzenko
09:11 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
The approach seems reasonable.
Eugenie: Do you have any thoughts, questions or concerns?
Greg Shah
06:18 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
The Windows spawner is a lot more simple than the UNIX one in the process creation part (more complicated in the secu... Galya B
04:41 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
Greg Shah wrote:
> The test code doesn't help me understand the process tree/pid list/redirected output log name for...
Galya B

12/02/2022

11:17 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
The test code doesn't help me understand the process tree/pid list/redirected output log name for the FWD client. Ca... Greg Shah

12/01/2022

10:49 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
I created a simple test to verify @execvp@ behaviour and uploaded it as zip. The test function in @C@ prints the pid ... Galya B
09:12 AM Bug #5701 (WIP): logfile names for -O outputToFile use the spawner pid instead of the Java (FWD c...
Constantin Asofiei wrote:
> The spawner will use @NativeSecureConnection.command@ to determine the launch command fo...
Galya B
07:08 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
Galya Bogdanova wrote:
> ... running in background where no client driver seems to be instantiated in the Java code,...
Constantin Asofiei
06:51 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
This is how I read the logic for the spawner (I'll be going with the Unix example):
@ClientBuilder#localStart()@ b...
Galya B
 

Also available in: Atom