FWD » Core Development » Runtime Infrastructure

03/06/2023

06:27 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

The new logger is very simplified and has no external dependencies. I even removed the dependency on @java.util.loggi... Galya B

06:21 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Greg Shah wrote:
> > We are deprecating this - Greg, if we introduce other jar dependencies to p2jpl.jar, then this ... Constantin Asofiei

06:16 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

> Otherwise, the standalone tool list (and build scripts) still work with the full p2j.jar, and any other jar depende... Greg Shah

06:12 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

> We are deprecating this - Greg, if we introduce other jar dependencies to p2jpl.jar, then this will break fast. I'm... Greg Shah

06:11 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Galya Bogdanova wrote:
> Constantin, sorry for the time taken.
No problem. Please remove the @NIOSslSocket-no-more... Constantin Asofiei

05:59 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

-Oops, there is one @return@ to be removed in @finish@ that prevents the flag @IS_LOGGER_WORK_FINISHED@ to be set to ... Galya B

05:58 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

The deadlock for NIO sockets is on the @NativeSecureConnection@ side:
* this part blocks for a response from the ser... Constantin Asofiei

05:45 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

There are two bugs here:
* NIO sockets are dead-locking, as you mentioned before.
* without NIO sockets, the Native... Constantin Asofiei

05:33 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Actually there are several threads related to logging, but the loggers themselves are not on separate threads. The th... Galya B

05:23 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Some other notes:
* the logger service runs in its own thread(s), as I see; please name these threads so they can be... Constantin Asofiei

05:20 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Fix for the NPE in r14508. The breakpoint in the NPE class helped. By the way the default location for the log file i... Galya B

04:45 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Constantin Asofiei wrote:
> Hard to spot unless you have breakpoints in @java.lang.NullPointerException@ constructor... Galya B

04:42 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

There is a NPE when 'nothing is configured':... Constantin Asofiei

04:40 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Constantin Asofiei wrote:
> Galya, how do I configure the loggers to log to STDOUT, for the FWD server? This should... Galya B

04:36 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Galya, how do I configure the loggers to log to STDOUT, for the FWD server? This should be the default way. Constantin Asofiei

02:25 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Galya, I've looked at your table and split the 'main' classes into this:
* used for standalone testing, not FWD runt... Constantin Asofiei

03/03/2023

04:00 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Server writes @authModeReq@ to socket:
!server-writes-authmodereq.png!
Client doesn't receive packets and hangs:
... Galya B

03/02/2023

09:33 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

I'm introducing a change to @NIOSslSocket#readFully()@ to fix an indefinite loop. Please check the attached file.
... Galya B

02/28/2023

10:46 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

And about the rest of the classes with main methods: Can I try to move all tools to a separate package, so that we kn... Galya B

10:23 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

It seems that some of the main methods are used by Harness for tests.
1. Can we get them out to the test directory... Galya B

07:06 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Also @System.err@ can be found in ignored classes:... Galya B

06:10 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

⚠ Which entry points are NOT used with p2j classpath?
List of all entry points in [[internal-documentation... Galya B

02/27/2023

01:25 PM Feature #7147: Make FWD log outputs consistent

Galya Bogdanova wrote:
> Hynek, there are many issues with the current logging, formatting and init points are just ... Hynek Cihlar

10:40 AM Feature #7147: Make FWD log outputs consistent

Hynek, there are many issues with the current logging, formatting and init points are just some of them. Most of it i... Galya B

08:39 AM Feature #7147: Make FWD log outputs consistent

Galya has been working on a complete rewrite of our logging support. I suspect there is some duplication of effort h... Greg Shah

07:36 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

@TransformDriver@ (ProgressTransformDriver / ConversionDriver) are used as standalone apps and if I'm not wrong they ... Galya B

02/26/2023

09:31 AM Feature #7147: Make FWD log outputs consistent

The attached diff improves the @CleanFormatter@ to shorten the qualified names to only include first letters for the ... Hynek Cihlar

09:11 AM Feature #7147: Make FWD log outputs consistent

The above points are resolved with the attached diff. Please review. Hynek Cihlar

09:10 AM Feature #7147: Make FWD log outputs consistent

There are multiple issues with FWD log outputs for both server and client processes.
* During server bootstrap dif... Hynek Cihlar

09:03 AM Feature #7147 (New): Make FWD log outputs consistent

Hynek Cihlar

02/24/2023

08:20 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

> > Use this as the default level. I don't see a good reason for implementing a minimum level.
>
> Then we should... Greg Shah

08:02 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Greg Shah wrote:
> Use this as the default level. I don't see a good reason for implementing a minimum level.
Th... Galya B

02/23/2023

03:00 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Use this as the default level. I don't see a good reason for implementing a minimum level. Greg Shah

09:09 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

How do we want to treat the logging level from configs? It could be the min level for all loggers or the default leve... Galya B

07:22 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

> At the moment it doesn't work exactly as in Progress where it outputs to the console, as well as to a file with re... Greg Shah

02:16 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

I agree with everything said. Let me just explain about batch. At the moment it doesn't work exactly as in Progress w... Galya B

07:26 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

> up till now FWD logs were written to the console by System.err and redirected to a file, so in practice console log... Greg Shah

02/22/2023

11:23 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Greg Shah wrote:
> I'm not sure we can eliminate the command line use of @>@ because customers may have 4GL code use... Galya B

11:10 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

P.S. Actually not even a redirect. For batch there is a certain method in @ErrorWriterBatch@ that should be reworked ... Galya B

11:07 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Greg Shah wrote:
> Can you help me understand what you mean by "rework it to reuse the same method"? In this case, ... Galya B

11:04 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Galya Bogdanova wrote:
> Greg, when you wrote:
> > I think we need to implement the following:
> > standard redire... Greg Shah

10:58 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

I have no objection to the name. Greg Shah

10:55 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Let me also raise the question about the new logger name.
I've ended up with a few new classes:
* CentralLogger -... Galya B

10:37 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Greg, when you wrote:
> I think we need to implement the following:
> standard redirections
did you have in mind... Galya B

03:44 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

An important question - up till now FWD logs were written to the console by @System.err@ and redirected to a file, so... Galya B

08:27 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...

It won't be until some time next week. We have many performance changes and some regression fixes that need to go fi... Greg Shah

08:10 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...

Greg, I merged the changes to an up-to-date branch 5701b and there were no conflicts (r14485). When do I merge? Galya B

02/17/2023

08:43 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Good Greg Shah

08:40 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Greg Shah wrote:
> If possible. Of course, a network failure while something is pending will be a problem.
I've ... Galya B

08:32 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Whether it is recursion or deadlock, the state synch approach should work. Greg Shah

08:31 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

If possible. Of course, a network failure while something is pending will be a problem. Greg Shah

08:31 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Greg Shah wrote:
> I think this is also the solution to this current deadlock issue since there will be no calls to ... Galya B

08:31 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

> The only concern would be if some logs will be discarded at the end of the application run.
Agreed, we should t... Greg Shah

08:26 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Greg Shah wrote:
> We've previously noted that making an up (client to server) or down (server to client) call to wr... Galya B

08:21 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

We've previously noted that making an up (client to server) or down (server to client) call to write the log output w... Greg Shah

08:10 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Greg, the classes @BlockingSSL@ and @NetSocket@ (@LoggingNetSocket@ / @NIOSslSocket@) log low level details of the rp... Galya B

06:58 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

I made a breakthrough. I was thinking the issues with the freezing client and no exceptions thrown is in the line of ... Galya B

02/16/2023

06:05 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Is there something I need to know about FWD RPC, threads and Conversation thread? Galya B

02/15/2023

11:21 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

I'm stuck on a hurdle I have no clue about. The new network interface (sending logs from the client to the server) wo... Galya B

02/14/2023

12:29 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

The problem with the new interface was missing directory.xml configs. Fixed. Galya B

02/13/2023

10:48 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

I need assistance with FWD RPC. I'm trying to use a new interface for clients to send data to the server, but the cal... Galya B

08:13 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

I'm currently working on a new logger class that encapsulates the previously used Java Logger and handles a lot of th... Galya B

02/07/2023

08:31 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

> Client and server are different processes
This is only because of how we implement in FWD. The equivalent syste... Greg Shah

06:11 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Back to question 1: clients are separate processes started with different process ids and user ids - do we want their... Galya B

03:02 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Greg Shah wrote:
> 2. In regard to "File names are not configurable to make file identification and sorting easier, ... Galya B

02:49 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Greg Shah wrote:
> 1. I don't think we want a separate client and server logging infrastructure. The fact that we h... Galya B

02/06/2023

04:46 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Galya Bogdanova wrote:
> Please review my proposal for standardization of the logging: [[internal-documentation:Logs... Greg Shah

07:37 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Please review my proposal for standardization of the logging: [[internal-documentation:Logs#Future-Improvements|Logs#... Galya B