FWD » Core Development » Runtime Infrastructure

03/16/2023

11:46 AM Bug #5701 (Closed): logfile names for -O outputToFile use the spawner pid instead of the Java (FW...

Feedback status is for when the task is blocked needing information from the Author and/or a customer. Leave it in T... Greg Shah

11:42 AM Bug #5701 (Feedback): logfile names for -O outputToFile use the spawner pid instead of the Java (...

Galya B

04:58 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...

5701b is merged to trunk under r14506 -and works fine, but there are regression issues with the previous revision r14... Galya B

03/14/2023

06:24 PM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...

Please rebase 5701b from trunk rev 14505. Then if it passes your basic tests, you can merge to trunk. Greg Shah

03/13/2023

12:16 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

There is a problem: There are 100 entry points in the code. Most of them have System.out and System.err. If System.er... Galya B

11:36 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

About the interactive tools - I've marked in the [[internal-documentation:Logs#section-42|table]] the classes using S... Galya B

09:34 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Also @ext/sheet/build.gradle@ uses compile time the fwd build folder @../../build/classes@, so I guess p2j.jar is in ... Galya B

03/10/2023

10:35 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

@com.goldencode.p2j.preproc.Preprocessor@ supports cmd line options for writing out, err and warn to separate files. ... Galya B

08:01 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Thank you for the responses. Then I'll leave it for later and will post an example before starting. Galya B

07:58 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Yes, you can make changes to the ANTLR code but please post an example here first and we will review before you go to... Greg Shah

06:29 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Galya, these classes are generated by ANTLR - the changes need to be in their @.g@ part (@text.g@, @fql.g@, @progress... Constantin Asofiei

05:10 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Now that we've decided that the new logger can be used pretty much everywhere, what do we do with the ignored classes... Galya B

03:30 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

I updated the wiki [[internal-documentation:Logs]] to help us better distinguish between different logs in OE and FWD... Galya B

01:33 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Also let's keep OE logging and FWD logging as separate topics. OE logging is #3853 that waits for review. I've notice... Galya B

01:26 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

About the client/server entry points - ClientDriver is the only one that will trigger client mode and ServerDriver is... Galya B

03/09/2023

02:24 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

For now, let's just focus on the single common log per appserver with the properly formatted headers. I thought we h... Greg Shah

01:47 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Greg Shah wrote:
> > for appservers, there is a single log file where all agents of that appserver are adding the me... Constantin Asofiei

01:40 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

> for appservers, there is a single log file where all agents of that appserver are adding the messages
This sound... Greg Shah

01:32 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Greg, for appservers, there is a single log file where all agents of that appserver are adding the messages. Current... Constantin Asofiei

01:11 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

> I think your only concern is the ClientDriver (which starts the FWD client), where the logging as far as I understa... Greg Shah

12:55 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Galya Bogdanova wrote:
> Constantin, please check if I got it right:
>
> * ReportWebServer - I saw it has p2j.jar... Constantin Asofiei

10:27 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Constantin, please check if I got it right:
* ReportWebServer - I saw it has p2j.jar in the classpath in deploy/se... Galya B

03/06/2023

06:27 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

The new logger is very simplified and has no external dependencies. I even removed the dependency on @java.util.loggi... Galya B

06:21 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Greg Shah wrote:
> > We are deprecating this - Greg, if we introduce other jar dependencies to p2jpl.jar, then this ... Constantin Asofiei

06:16 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

> Otherwise, the standalone tool list (and build scripts) still work with the full p2j.jar, and any other jar depende... Greg Shah

06:12 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

> We are deprecating this - Greg, if we introduce other jar dependencies to p2jpl.jar, then this will break fast. I'm... Greg Shah

06:11 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Galya Bogdanova wrote:
> Constantin, sorry for the time taken.
No problem. Please remove the @NIOSslSocket-no-more... Constantin Asofiei

05:59 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

-Oops, there is one @return@ to be removed in @finish@ that prevents the flag @IS_LOGGER_WORK_FINISHED@ to be set to ... Galya B

05:58 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

The deadlock for NIO sockets is on the @NativeSecureConnection@ side:
* this part blocks for a response from the ser... Constantin Asofiei

05:45 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

There are two bugs here:
* NIO sockets are dead-locking, as you mentioned before.
* without NIO sockets, the Native... Constantin Asofiei

05:33 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Actually there are several threads related to logging, but the loggers themselves are not on separate threads. The th... Galya B

05:23 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Some other notes:
* the logger service runs in its own thread(s), as I see; please name these threads so they can be... Constantin Asofiei

05:20 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Fix for the NPE in r14508. The breakpoint in the NPE class helped. By the way the default location for the log file i... Galya B

04:45 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Constantin Asofiei wrote:
> Hard to spot unless you have breakpoints in @java.lang.NullPointerException@ constructor... Galya B

04:42 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

There is a NPE when 'nothing is configured':... Constantin Asofiei

04:40 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Constantin Asofiei wrote:
> Galya, how do I configure the loggers to log to STDOUT, for the FWD server? This should... Galya B

04:36 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Galya, how do I configure the loggers to log to STDOUT, for the FWD server? This should be the default way. Constantin Asofiei

02:25 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Galya, I've looked at your table and split the 'main' classes into this:
* used for standalone testing, not FWD runt... Constantin Asofiei

03/03/2023

04:00 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Server writes @authModeReq@ to socket:
!server-writes-authmodereq.png!
Client doesn't receive packets and hangs:
... Galya B

03/02/2023

09:33 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

I'm introducing a change to @NIOSslSocket#readFully()@ to fix an indefinite loop. Please check the attached file.
... Galya B

02/28/2023

10:46 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

And about the rest of the classes with main methods: Can I try to move all tools to a separate package, so that we kn... Galya B

10:23 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

It seems that some of the main methods are used by Harness for tests.
1. Can we get them out to the test directory... Galya B

07:06 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Also @System.err@ can be found in ignored classes:... Galya B

06:10 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

⚠ Which entry points are NOT used with p2j classpath?
List of all entry points in [[internal-documentation... Galya B

02/27/2023

01:25 PM Feature #7147: Make FWD log outputs consistent

Galya Bogdanova wrote:
> Hynek, there are many issues with the current logging, formatting and init points are just ... Hynek Cihlar

10:40 AM Feature #7147: Make FWD log outputs consistent

Hynek, there are many issues with the current logging, formatting and init points are just some of them. Most of it i... Galya B

08:39 AM Feature #7147: Make FWD log outputs consistent

Galya has been working on a complete rewrite of our logging support. I suspect there is some duplication of effort h... Greg Shah

07:36 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

@TransformDriver@ (ProgressTransformDriver / ConversionDriver) are used as standalone apps and if I'm not wrong they ... Galya B

02/26/2023

09:31 AM Feature #7147: Make FWD log outputs consistent

The attached diff improves the @CleanFormatter@ to shorten the qualified names to only include first letters for the ... Hynek Cihlar

09:11 AM Feature #7147: Make FWD log outputs consistent

The above points are resolved with the attached diff. Please review. Hynek Cihlar

09:10 AM Feature #7147: Make FWD log outputs consistent

There are multiple issues with FWD log outputs for both server and client processes.
* During server bootstrap dif... Hynek Cihlar

09:03 AM Feature #7147 (New): Make FWD log outputs consistent

Hynek Cihlar

02/24/2023

08:20 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

> > Use this as the default level. I don't see a good reason for implementing a minimum level.
>
> Then we should... Greg Shah

08:02 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Greg Shah wrote:
> Use this as the default level. I don't see a good reason for implementing a minimum level.
Th... Galya B

02/23/2023

03:00 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Use this as the default level. I don't see a good reason for implementing a minimum level. Greg Shah

09:09 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

How do we want to treat the logging level from configs? It could be the min level for all loggers or the default leve... Galya B

07:22 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

> At the moment it doesn't work exactly as in Progress where it outputs to the console, as well as to a file with re... Greg Shah

02:16 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

I agree with everything said. Let me just explain about batch. At the moment it doesn't work exactly as in Progress w... Galya B

07:26 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

> up till now FWD logs were written to the console by System.err and redirected to a file, so in practice console log... Greg Shah

02/22/2023

11:23 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Greg Shah wrote:
> I'm not sure we can eliminate the command line use of @>@ because customers may have 4GL code use... Galya B

11:10 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

P.S. Actually not even a redirect. For batch there is a certain method in @ErrorWriterBatch@ that should be reworked ... Galya B

11:07 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Greg Shah wrote:
> Can you help me understand what you mean by "rework it to reuse the same method"? In this case, ... Galya B

11:04 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Galya Bogdanova wrote:
> Greg, when you wrote:
> > I think we need to implement the following:
> > standard redire... Greg Shah

10:58 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

I have no objection to the name. Greg Shah

10:55 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Let me also raise the question about the new logger name.
I've ended up with a few new classes:
* CentralLogger -... Galya B

10:37 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

Greg, when you wrote:
> I think we need to implement the following:
> standard redirections
did you have in mind... Galya B

03:44 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration

An important question - up till now FWD logs were written to the console by @System.err@ and redirected to a file, so... Galya B

08:27 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...

It won't be until some time next week. We have many performance changes and some regression fixes that need to go fi... Greg Shah

08:10 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...

Greg, I merged the changes to an up-to-date branch 5701b and there were no conflicts (r14485). When do I merge? Galya B