Project

General

Profile

Activity

From 04/04/2023 to 05/03/2023

04/28/2023

01:32 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter
As requested in #4065-104 support optional (configurable) shorter versions of package names. Check how other logging ... Galya B

04/27/2023

08:26 AM Feature #1848: make logging settings controllable dynamically at runtime
> A note: With #5703 all levels can be changed dynamically. To not lose logs, when the level is lowered, @isLoggable(... Greg Shah
05:23 AM Feature #1848: make logging settings controllable dynamically at runtime
A note: With #5703 all levels can be changed dynamically. To not lose logs, when the level is lowered, @isLoggable()@... Galya B
05:09 AM Feature #1848: make logging settings controllable dynamically at runtime
A note: For dynamic levels to apply to all child packages and classes, all loggers should have fully qualified names ... Galya B

04/26/2023

09:08 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
I've completed all that was on my mind with this task. Today I added some final touch-ups to the yesterday's changes ... Galya B
09:03 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Actually I was working on @SecurityManager@ two months ago #5703#note-28. I just want to double check.
* Its custom ... Galya B

04/25/2023

10:49 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Since the only security issue here is related to log file output, I think the danger is quite limited. Rather than h... Greg Shah
07:39 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
"Using Expressions in Access Rights":/artifacts/javadoc/latest/api/com/goldencode/p2j/security/package-summary.html#U... Greg Shah
02:25 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Can someone give me an example of @access rights expressions@ (refs com.goldencode.p2j.security.VariablePool)? @getRe... Galya B

04/24/2023

01:10 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
In regard to the @AdminServerImpl@ use of @LOG.setLevel(Level.FINER);@, I think it should be deleted. There is no re... Greg Shah
10:01 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Good Greg Shah
09:59 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Also when server-side enabled I have to fix it to produce separate files by generating them dynamically based on some... Galya B
09:56 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
OK, may I then implement these requirements so:
* there is a directory.xml flag @logging/serverSide@ by default fals... Galya B
09:46 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> > When we are configured for server-side logging, it no longer makes sense for there to be a separate FWD client lo... Greg Shah
08:58 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> When we are configured for server-side logging, it no longer makes sense for there to be a separa... Galya B
08:48 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> Why do we need to write client logs from the server for FWD logs - client logs are generated on the client and serv... Greg Shah
08:43 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Let's put LOG-MANAGER aside and discuss it in #7291.
Why do we need to write client logs from the server for FWD l... Galya B
08:28 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> > Permissions are always an issue in client scenarios, remote or local. The client must have proper permissions fo... Greg Shah
05:04 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Since there is no merging of client and server files in any of the supported cases, I want to present a well-rounded ... Galya B
04:49 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
May I be excused to have the audacity to summarize the requested changes as:
* the same number of files in compariso... Galya B
04:23 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
I'm reading #4065 and the code. I believe the core concept is the only one relevant here. If I understand properly, c... Galya B
01:36 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> Permissions are always an issue in client scenarios, remote or local. The client must have prope... Galya B

04/21/2023

11:26 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> I remember there was a mention of client permissions in the context of remote clients. What... Greg Shah
10:50 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
I remember there was a mention of client permissions in the context of remote clients. What about local clients, isn'... Galya B
10:45 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
The two cases are exclusively server-side and only occur at the very initialization of the logger. The SM case is dr... Greg Shah
10:34 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> Neither of these is dynamic. One is hard coded in the source and the other is read from the dire... Galya B
10:28 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> > Where is it used today?
> On trunk @AdminServerImpl -> LOG.setLevel(Level.FINER);@ and and @SecurityManager -> L... Greg Shah
10:02 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
The question is do we keep it part of the interface of the logger. Galya B
10:01 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Tomorrow it might be used somewhere else, if not disabled. Galya B
10:01 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> Where is it used today?
On trunk @AdminServerImpl -> LOG.setLevel(Level.FINER);@ and and @Securi... Galya B
09:59 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Where is it used today? Greg Shah
09:39 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
I would recommend disabling @setLevel@ for now, if we're not clear how this should work out. It's messy even with one... Galya B
09:38 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Unexpected behavior - isn't it a definition of a bug. If it's not defined, it will be unexpected -> bug. Galya B
09:36 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> Is there a reason to change it right now?
Yes, the logger is now distributed. I need to know wha... Galya B
09:35 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Is there a reason to change it right now? Greg Shah
09:34 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> > > What do you mean by dynamic logging levels?
> > @LOG.setLevel()@ called programmatically.
>... Galya B
09:33 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> And what do we do with the dynamic levels that can be set server-side and client-side in the code at any time?
W... Greg Shah
09:33 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> > What do you mean by dynamic logging levels?
> @LOG.setLevel()@ called programmatically.
Leave this alone unle... Greg Shah
09:32 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
And what do we do with the dynamic levels that can be set server-side and client-side in the code at any time? Galya B
09:31 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> > I don't know that we care about per-context logging levels EXCEPT for the @LOG-MANAGER@ stuff. In the FWD logging... Greg Shah
09:13 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> I don't know that we care about per-context logging levels EXCEPT for the @LOG-MANAGER@ stuff. In... Galya B
09:11 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> What do you mean by dynamic logging levels?
@LOG.setLevel()@ called programmatically.
 Galya B
09:10 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> Greg Shah wrote:
> > > disable dynamic levels on the client
> >
> > No, I don't think w... Greg Shah
09:10 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
At this time we assume that the same logging levels will apply to all contexts. Even in the future where we have imp... Greg Shah
09:07 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> > disable dynamic levels on the client
>
> No, I don't think we need to do that.
So allow d... Galya B
09:05 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> > So any static initializers setting levels will work once for the lifespan of the server JVM and... Galya B
08:58 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> It's not the same, because you can set multiple logging levels in the client configs and then change them programma... Greg Shah
08:45 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
OK, so implement context-local CentralLogger, configured by directory.xml, but with initial overrides from client.xml... Galya B
08:36 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> > The client.xml logging level configs will override the server ones? But the server ones are dyn... Galya B
08:20 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> > The idea is that there are 2 modes for logging: server-side and client-side.
>
> How do I know if the client i... Greg Shah
08:07 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Actually if it was a new software (more web oriented) that was developed, I would suggest if customers want to use re... Galya B
08:00 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> Greg Shah wrote:
> > The idea is that there are 2 modes for logging: server-side and clien... Galya B
07:52 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> The idea is that there are 2 modes for logging: server-side and client-side.
How do I know if ... Galya B
07:37 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> Do I remove all client to server log writes?
No. The idea is that there are 2 modes for logging: server-side an... Greg Shah
03:07 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> Since we just removed the client-side configurations for logging I guess I have to introduc... Galya B
02:56 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg, I'll wait for your confirmation.
Constantin Asofiei wrote:
> Galya Bogdanova wrote:
> > I feel I still don... Galya B
02:55 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> Galya Bogdanova wrote:
> > The current design is that client and server logging levels are indep... Galya B
02:28 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> I feel I still don't understand something:
>
> 1. What do I use state sync for, when the... Constantin Asofiei
01:51 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> * server-side logging is configured
> ** this would be configured similar to the rest of #4065
... Galya B
01:48 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
I feel I still don't understand something:
1. What do I use state sync for, when the client and server loggers are... Galya B
08:15 AM Bug #7291: LOG-MANAGER to log on client-side
Just document the file locking restriction for now. Greg Shah
07:57 AM Bug #7291: LOG-MANAGER to log on client-side
Greg Shah wrote:
> Client side logging is much less likely to have more than one process writing to the same file. ... Galya B
07:43 AM Bug #7291: LOG-MANAGER to log on client-side
Create the minimum API which will be a new remote service exported from the client side. This will provide the remot... Greg Shah
02:39 AM Bug #7291: LOG-MANAGER to log on client-side
*Initial state and facts on @LOG-MANAGER@ (@LegacyLogManagerImpl@):*
* lives server-side;
* receives some logs fr... Galya B
01:57 AM Bug #7291 (Closed): LOG-MANAGER to log on client-side
Galya B

04/20/2023

11:34 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> > by default, FWD client logs to its own log files
>
> Do we ever need the client logs mixed i... Constantin Asofiei
11:32 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Please address these items before the code can be merged to trunk:
* Split client logging into its own log file in... Greg Shah
11:29 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
In regard to all the communications noted in #5703-280, I never intended to have the client logging go into the serve... Greg Shah
11:21 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg, just to summarize, there are a few types of logging done in FWD:
# LOG-MANAGER logging
** this is the legacy ... Constantin Asofiei
10:28 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
*On 7th Feb*
1. #5703#note-23
Greg Shah said:
> 1. I don't think we want a separate client and server logging ... Galya B
09:49 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> If I remember correctly the whole point of the task was to reduce the number of log files b... Greg Shah
09:45 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
If I remember correctly the whole point of the task was to reduce the number of log files by merging them. I initiall... Galya B
09:45 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> you wanted to have all client logs mixed in.
I don't recall wanting that. Greg Shah
09:40 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> Is it separate from the "server log"? If so, I think it is OK. This is the replacement for the ... Galya B
09:35 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Is it separate from the "server log"? If so, I think it is OK. This is the replacement for the old @stderr@ output ... Greg Shah
09:23 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
This is what I mean. Actually the file name is misleading - it's client-side generated log, server-side saved to a file. Galya B
09:20 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
If you are talking about the output redirect, that would remain on the client side. Greg Shah
09:09 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> Since this is related to @LOG-MANAGER@
What about FWD logging for these remote clients?
 Galya B
08:45 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Since this is related to @LOG-MANAGER@ and we just implemented support for @LOG-MANAGER@ to target a separate file, w... Greg Shah
08:43 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
The issue is related to @LOG-MANAGER@ where the 4GL code (or via command line) the customer can specify a client-side... Greg Shah
02:38 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
#5703#note-27
Greg Shah wrote:
> The equivalent system in OE is a single process. For this reason, we cannot caus... Galya B
02:25 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
#5703#note-40
Greg Shah wrote:
> Whether it is recursion or deadlock, the state synch approach should work.
Fr... Galya B
02:22 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
@Status report 01/13/2023@
Galya Bogdanova wrote:
> I'll need a few days to analyze what types of 4GL errors and ... Galya B
01:54 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
(related to @LOG-MANAGER@) On 17th January I've sent you an email named @Status report 01/17/2023@ with an attachment... Galya B
01:38 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> Galya Bogdanova wrote:
> > Greg, you make me worried extremely. Let me repeat what I've said (ho... Galya B

04/19/2023

02:04 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> Greg, you make me worried extremely. Let me repeat what I've said (hoping it's received on ... Greg Shah
12:55 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya, @System.loadLibrary("p2j");@ in @ServerDriver.main@ will force any installation to require the p2j library add... Constantin Asofiei
12:23 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
It's done and done in r14601. Please confirm it's done.
65 revisions later and 508 files updated, let's do it! Galya B
11:48 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
-Constantin, what do I do with that last blocker:- Fixed it.... Galya B
11:42 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Actually even before that, since it needs to be done only on the ServerDriver. Galya B
11:41 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> If you have to implement the pid and it the library is not loaded, then do a late load of the nat... Galya B
11:34 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg, you make me worried extremely. Let me repeat what I've said (hoping it's received on the other end many time al... Galya B
11:06 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> Greg, what do we do with the pid?
If you have to implement the pid and it the library is... Greg Shah
11:03 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> Also please understand that there is no @CentralLogerClient@ and @CentralLoggerServer@, but only @CentralLogger@. T... Greg Shah
10:13 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg, what do we do with the pid? Galya B
10:12 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Ok, r14598 removed workingDir from LOG-MANAGER as well. Now all is going to be dumped by default in the server launch... Galya B
10:09 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> What should be the default folder for @LegacyLogManager@?
If the logging directory is not ... Constantin Asofiei
10:07 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> The questions is how to know if in @CommonDriver#process@ on line 533 the library can be ac... Constantin Asofiei
09:59 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> Greg Shah wrote:
> > We might want to have an explicit step in the @StandardServer.boot... Galya B
09:53 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> We might want to have an explicit step in the @StandardServer.bootstrap()@ process.
>
> Hynek/... Constantin Asofiei
09:22 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
...and appserver logs go to work dir, which is probably quite a server. Galya B
09:18 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Also please understand that there is no @CentralLogerClient@ and @CentralLoggerServer@, but only @CentralLogger@. The... Galya B
09:16 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> Galya Bogdanova wrote:
> > In OE logs go to work dir. In directory.xml you can configur... Galya B
09:00 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> Greg Shah wrote:
> > > Where is @System.loadLibrary("p2j")@ called server-side, so that th... Greg Shah
08:43 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> > Where is @System.loadLibrary("p2j")@ called server-side, so that the native lib can be used to ... Galya B
08:27 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> Where is @System.loadLibrary("p2j")@ called server-side, so that the native lib can be used to access process id (r... Greg Shah
08:26 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> If you think it's worth it to handle file writes and rotation manually for the sake of improved formatting of rotat... Greg Shah
08:16 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
*Changes in r14597:*
* Client @CentralLogger@ initialized after @LogicalTerminal#init()@ completion on the server an... Galya B
05:57 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Any of above-mentioned specifiers will be available for customers to define in the name of the log file. Galya B
05:42 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg, if a formatted rotation number is needed for CentralLogger files, then a custom FileHandler (the core of the cu... Galya B
03:08 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Is it alright in general for @ThinClient.getChanges()@ to be executed before @LogicalTerminal.init()@? I mean do we n... Galya B

04/18/2023

11:31 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Nice! I stand corrected. Greg Shah
11:30 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> I suspect your winner is not my winner. ;)
You underestimate my estimation. :) Galya B
11:28 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
I suspect your winner is not my winner. ;)
Options 1 and 2 are performance killers so we cannot use them.
Optio... Greg Shah
11:24 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
P.S. We'll also have to disable @setLevel()@ on clients. Galya B
11:21 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg,
I think we need to consider a few aspects with this global server-side logging level. With last minute chang... Galya B
11:07 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin, I reverted the loggers in the Json* classes to static, because I cannot reproduce the problem now, but I'... Galya B
11:04 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> Let's confirm: After @LogicalTerminal.init()@ is called *on the client*, then it's safe to ... Constantin Asofiei
10:54 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> > Have you considered moving to another programming language - an event-driven, functional one - ... Galya B
10:53 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> Do you want separate levels for clients at all or one global level for all processes is enough?
A global level ... Greg Shah
10:42 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> This is similar to my listener idea. Design it with a static flag and then change the flag in th... Galya B
10:37 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Or if I got it wrong and @LogicalTerminal.init()@ should be called on the server, then how do I push the init state t... Galya B
10:35 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Let's confirm: After @LogicalTerminal.init()@ is called *on the client*, then it's safe to send logs to be handled in... Galya B
10:30 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Another note, this code in @CentralLoggerClient@:... Constantin Asofiei
10:26 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> Yes, I guess. There was no right synchronizer registered. The logs were not processed by @L... Constantin Asofiei
10:21 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
P.S. OE doesn't allow it (just by the way, again) - the freedom of deciding if you want and how you want a rotation n... Galya B
10:19 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> I'm looking for the position in the filename to be controllable, not the number itself.
How will... Galya B
10:15 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> I don't understand you. Do you want separate levels for clients at all or one global level ... Galya B
10:14 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> Galya Bogdanova wrote:
> > The current design is that client and server logging levels are indep... Galya B
10:12 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> What do you mean by "the separate spawner process"? I'm OK with implementing the flexible format... Galya B
10:06 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> > 2. Constantin Asofiei wrote:
> > > @p2j.net.Protocol.applyChanges@ - this code:
> > ... Galya B
09:37 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> The current design is that client and server logging levels are independent, so that the cl... Greg Shah
09:34 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> We can implement more flexible formatter for log records in a future task, when the separate spawner process is rem... Greg Shah
09:27 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> why not calculate the real logging level (in a different field), cache it on the first isLoggable call, and invalid... Greg Shah
07:41 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
1. Constantin Asofiei wrote:
> > p2j.main.StandardServer.boostrap - there is some commented ... Constantin Asofiei
06:24 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
*Changes in r14595:*
* JavaDoc added for @ClientCore.isNativeLayerInitialized@ and @NetResource.LOG@.
* Wrong log... Galya B
05:12 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> So, why not calculate the real logging level (in a different field), cache it on the fir... Galya B
04:09 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
@!IS_LOGGER_WORK_FINISHED.get()@ is a simple boolean check, while @isLoggable(level)@ is more complex method, no reas... Galya B
04:02 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya, I agree that string literals are kept on the constant pool, and do not pose a garbage-collection problem, but ... Constantin Asofiei
04:01 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> You can add the client-specific code to @ClientDriver.start@ and leave here only this he... Galya B
03:53 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Discussion from email:
On 4/18/23 10:37, Galya Bogdanova wrote:
> Constantin,
>
> I'm not asking about concaten... Constantin Asofiei
03:47 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> 2. Constantin Asofiei wrote:
> > @clientConfig/workingDir@ is for FWD clients. There is no... Constantin Asofiei

04/17/2023

09:55 AM Feature #7147: Make FWD log outputs consistent
Galya Bogdanova wrote:
> Hynek Cihlar wrote:
> > Galya, I will appreciate if you can answer my question. Do you get... Hynek Cihlar
08:54 AM Feature #7147: Make FWD log outputs consistent
Hynek Cihlar wrote:
> Galya, I will appreciate if you can answer my question. Do you get conflicts, which you can no... Galya B
08:31 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
5703a rebased on trunk r14536.
This is not a final response to all code review questions raised. Wait for more.
... Galya B
04:15 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
The current design is that client and server logging levels are independent, so that the client doesn't have to read ... Galya B
08:07 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter
Implement more flexible formatter for log records, configurable in directory.xml.
Currently one and the same forma... Galya B
08:04 AM Feature #7279 (Closed): Enhance CentralLogger to support configurable LogFormatter
Galya B

04/13/2023

12:26 PM Feature #7147: Make FWD log outputs consistent
Hynek Cihlar wrote:
> Galya Bogdanova wrote:
> > Greg, did you allow Hynek to merge the changes to LogHelper? Hynek... Hynek Cihlar
03:58 AM Feature #7147: Make FWD log outputs consistent
Hynek Cihlar wrote:
> Galya Bogdanova wrote:
> > Greg, did you allow Hynek to merge the changes to LogHelper? Hynek... Hynek Cihlar
03:57 AM Feature #7147: Make FWD log outputs consistent
Galya Bogdanova wrote:
> Greg, did you allow Hynek to merge the changes to LogHelper? Hynek, please revert all chang... Hynek Cihlar
03:34 AM Feature #7147: Make FWD log outputs consistent
Greg, did you allow Hynek to merge the changes to LogHelper? Hynek, please revert all changes related to logging. Galya B
11:00 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> Galya Bogdanova wrote:
> > First of all it's dynamic, because all logging is allowed be... Greg Shah
08:58 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Hynek Cihlar wrote:
> We could provide an invalidation mechanism:
>
> [...]
>
> Is it worth the hassle? I'm no... Galya B
08:57 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> When is pre-initialization finished? At FWD server startup (when "Server ready" is writt... Galya B
08:47 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya, another question for review: FWD trunk has a @logging/loggers@ setting in directory.xml where you can specify ... Constantin Asofiei
08:45 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
We could provide an invalidation mechanism:... Hynek Cihlar
08:37 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> Everything happening on the system before the configs are read and applied to CentralLogger... Constantin Asofiei
08:36 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> But the code I'm referring to is not part of initialization; when @RuntimeJastInterprete... Galya B
08:34 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> This is Java logger functionality and as I've said we're doing dynamic isLogging, because o... Constantin Asofiei
08:32 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
This is Java logger functionality and as I've said we're doing dynamic isLogging, because of the delayed initialization. Galya B
08:31 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> First of all it's dynamic, because all logging is allowed before initialization for the sak... Constantin Asofiei
08:29 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> p2j.main.ClientSpawner.spawn - there is CentralLoggerServer.logSpawnerStream after cb.lo... Galya B
08:24 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> *Hynek*, please review the @ext/@ changes.
The changes are good.
 Hynek Cihlar
08:23 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
First of all it's dynamic, because all logging is allowed before initialization for the sake of not loosing logs. The... Galya B
08:22 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
The flag cannot be cached and should not be cached, because it's dynamic. Galya B
08:21 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> @if (LOG.isLoggable(...))@ *should never be called any more* from performance stand point.
... Constantin Asofiei
08:20 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Lets take this code from @RuntimeJastInterpreter.buildTypedExpression@:... Constantin Asofiei
08:15 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Let me repeat just to make sure I'm understood: @isLoggable@ is the first statement in the log methods. Galya B
08:13 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
I had to remove isLoggable actually, but it was too much work. For very heavy log messages use the method overload wi... Galya B
08:11 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
@if (LOG.isLoggable(...))@ *should never be called any more* from performance stand point. Only in cases of very comp... Galya B
07:55 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
This is a review of the full changes in 5703a/14583. What is noted in #5703-182 still stands. Galya, please read th... Constantin Asofiei

04/07/2023

06:23 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> Greg, I recall we wanted to keep the com.goldencode. packages as non-dependent on com.goldencode.p2j as possible. I... Greg Shah
12:58 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> [...]
> can call back to the server, determine the Session ID and the FWD User, and cac... Eugenie Lyzenko
11:49 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
This is a high-level review of 5703a/14578 - I have not gone through all the files. I'll go over all files in the ne... Constantin Asofiei
10:49 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
How does disabling @LOG-MANAGER@ come into this discussion of the server log? If it can be disabled in 5 ways, that ... Greg Shah
10:31 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg, on my interview you said you're reproducing OE with the typos and all its flaws. Galya B
10:30 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> I don't see why @LOG-MANAGER@ output would ever end up in the server log.
All System.err does ... Galya B
10:26 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> As far as "disabling" @LOG-MANAGER@, I guess you mean calling @CLOSE-LOG()@?
There are 5 differ... Galya B
10:22 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> So you're suggesting that we know what log is written to clientlog and not write it to server.log?
I don't know ... Greg Shah
10:11 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> Add the empty thread id
Why is it empty?
> Is this what needs to be done?
If this is the list of deviation... Greg Shah
10:09 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> > @clientlog@ lives its own 4GL life, let's not enhance it.
>
> You are suggesting that we imp... Galya B
10:06 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> > There is this dir config (logging:file:dir) you might have noticed that allows you to choose th... Galya B
10:04 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> ** Legacy spec for @LOG-MANAGER@ output which should be completely compatible with the 4GL spec. ... Galya B
10:03 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> @clientlog@ lives its own 4GL life, let's not enhance it.
You are suggesting that we implement a 2nd logfile for... Greg Shah
10:01 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> There is this dir config (logging:file:dir) you might have noticed that allows you to choose the location. The old ... Greg Shah
09:44 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> If @clientLog@ is specified, then won't we output everything to that log?
>
> This points out ... Galya B
09:38 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> * Use the @Formatter@ conversions as much as possible and add consistent formatting options for s... Galya B
09:30 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> For example, people have very different ideas about how date and time values should be formatted.... Galya B
09:20 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> In the old internal logging approach in FWD, we could configure logging at any class or package l... Galya B
09:00 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> At the moment there are two base log levels to be configured - one for the spawner messages and one for everything ... Greg Shah
08:20 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> Does 5703a depend on any work from 5753d?
No Galya B
08:20 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Does 5703a depend on any work from 5753d?
 Constantin Asofiei

04/06/2023

10:04 AM Bug #5703 (Review): rationalize, standardize and simplify the client-side log file name configura...
Branch 5703a, r14578 based on trunk r14523. Review with @bzr diff -r-56@. More on how to test in #5703#note-161. Galya B
07:45 AM Bug #5701 (Closed): logfile names for -O outputToFile use the spawner pid instead of the Java (FW...
Greg Shah

04/05/2023

03:03 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
The following System.err usages are related to #7180:
* cmd line args -err, -warn in com.goldencode.p2j.preproc.Prep... Galya B

04/04/2023

10:01 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Branch 5703a, r14573 is ready for a pre-final code review. There are still no file headers and I need to go through a... Galya B
09:38 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
It should be though that it's not in use any more. I'll remove it. Galya B
09:37 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
I will run the dependency tree generation and confirm my statement that no class is explicitly imported, but I'm aski... Galya B
09:36 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Roger Borrello wrote:
> How about @./gradlew dependencies@?
Thanks, I see only root references for @+--- org.jboss.... Constantin Asofiei
09:33 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> Roger, I can't find the build dependency tree for all the jar libraries - is this somewh... Roger Borrello
07:16 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
@fwdspi.jar@ doesn't include the logging classes and @FwdCollatorProvider@ fails runtime. I'm not sure how/when the c... Galya B
06:50 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> Does someone know why is this dependency in build.gradle: @fwdConvertServer group: 'org.jbo... Constantin Asofiei
06:46 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Does someone know why is this dependency in build.gradle: @fwdConvertServer group: 'org.jboss.logging', name: 'jboss-... Galya B
06:44 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> There is a script named @gen_headers.py@ in @~/usrbin@, as part of the standard dev setu... Galya B
 

Also available in: Atom