Project

General

Profile

Activity

From 05/29/2023 to 06/27/2023

06/27/2023

10:07 AM Bug #7425: Avoid directory usage in static blocks
*Committed 7388a/rev14637.*
* Removed the @DatabaseStatistics.get@ call in @StandardServer@
* This will be the stan...
Dănuț Filimon
04:31 AM Bug #7425: Avoid directory usage in static blocks
*Review of 7388a*
This also includes the review for #7388.
* In @StandardServer@, you no longer need @DatabaseSta...
Alexandru Lungu
03:53 AM Bug #7425: Avoid directory usage in static blocks
Rebased 7388a from trunk rev. 14633. 7388a is now at rev. 14636. Alexandru Lungu
09:03 AM Bug #7291 (Closed): LOG-MANAGER to log on client-side
The last issue was fixed in task branch 7415c which was merged to trunk as rev 14631. Greg Shah

06/26/2023

01:22 PM Bug #7443 (Closed): performance of CentralLogger
Greg Shah
12:52 PM Bug #7443 (Test): performance of CentralLogger
Galya B
12:29 PM Bug #7443: performance of CentralLogger
Task branch 7443a was merged to trunk as rev 14633 and archived. Galya B
10:56 AM Bug #7443: performance of CentralLogger
Please merge 7443a to trunk. Good work! Greg Shah
10:11 AM Bug #7443: performance of CentralLogger
Greg: I think we can merge this to trunk. Alexandru reported a 3.5% improvement for 7443a (from a 3.5% loss without ... Constantin Asofiei
06:12 AM Bug #7443: performance of CentralLogger
Compilation error fixed with r14637. Galya B
04:47 AM Bug #7443: performance of CentralLogger
Attempting to profile with rev. 14636. I've got:... Alexandru Lungu
03:35 AM Bug #7443: performance of CentralLogger
Constantin Asofiei wrote:
> Galya, one more small optimization, please: this test in @LoggingUtil.addLeadingSymbols@...
Galya B
03:32 AM Bug #7443: performance of CentralLogger
Galya, one more small optimization, please: this test in @LoggingUtil.addLeadingSymbols@ can be @leadingSymbolsCount ... Constantin Asofiei
03:13 AM Bug #7443: performance of CentralLogger
Constantin Asofiei wrote:
> we need to have only one history number per branch
You say that often, but when I add h...
Galya B
02:44 AM Bug #7443: performance of CentralLogger
Eugenie Lyzenko wrote:
> I see the log call used when process *started*, not stopped. So it is not clear for me why ...
Galya B
02:29 AM Bug #7443: performance of CentralLogger
Eugenie Lyzenko wrote:
> I see the log call used when process *started*, not stopped. So it is not clear for me why ...
Galya B

06/23/2023

12:33 PM Bug #7443: performance of CentralLogger
Constantin Asofiei wrote:
> Eugenie: please review the native changes.
>
I have no objection for code itself. H...
Eugenie Lyzenko
11:52 AM Bug #7443: performance of CentralLogger
Constantin Asofiei wrote:
> Alexandru: please do another round of performance testing with 7156b + 7443a. Please no...
Constantin Asofiei
11:42 AM Bug #7443: performance of CentralLogger
Galya, this is a review for 7443a rev 14634:
* @CentraLogger@ - please leave only 006 number and remove 007 and 008 ...
Constantin Asofiei
10:26 AM Bug #7443 (Review): performance of CentralLogger
r14634: Fixed Java (@java.util.logging.LogRecord#needToInferCaller@ set with reflection to stop heavy checks unused b... Galya B
08:52 AM Bug #7443: performance of CentralLogger
If it's not a trouble, can we have a perf test running now, while I wonder what else to change.
P.S. with updated ...
Galya B
08:51 AM Bug #7443: performance of CentralLogger
r14633:
The appserver kept the spawner live, which kept the stderr parsing / logging loop on the server live. It p...
Galya B
05:14 AM Bug #7443: performance of CentralLogger
Please do a profiling and see what else stands out which can be improved. Constantin Asofiei
05:11 AM Bug #7443: performance of CentralLogger
r14632 16% improvement of the @+0.45%@ degradation by replacing @String.format@ in formatting logging context.
I a...
Galya B
02:56 AM Bug #7443: performance of CentralLogger
@CleanFormatter@ and the java logger init code is taken from an old trunk version.... Galya B
02:07 AM Bug #7443: performance of CentralLogger
Galya B wrote:
> If we blindly introduce "improvements" in iterations without any clearly expressed expectations, th...
Constantin Asofiei
02:04 AM Bug #7443: performance of CentralLogger
I'll test it in a unbiased way now, in FWD. Wait for results. Galya B
02:02 AM Bug #7443: performance of CentralLogger
Constantin Asofiei wrote:
> Galya, I think your tests are biased because they do not use the FWD runtime. My point ...
Galya B
01:53 AM Bug #7443: performance of CentralLogger
If we blindly introduce "improvements" in iterations without any clearly expressed expectations, this may not work as... Galya B
01:23 AM Bug #7462: fix 'AS' instead of '4GL' in LOG-MANAGER log lines and add an incompatible FWD and FWD...
OK, sorry about that. I keep forgetting that LOG-MANAGER needs more work. Constantin Asofiei
01:01 AM Bug #7462: fix 'AS' instead of '4GL' in LOG-MANAGER log lines and add an incompatible FWD and FWD...
This is not a bug, this is a unimplemented feature. AS proper support was supposed to be worked under #3853. Galya B

06/22/2023

10:41 AM Bug #7462: fix 'AS' instead of '4GL' in LOG-MANAGER log lines and add an incompatible FWD and FWD...
When used on 4GL client, LOG-MANAGER outputs this:... Constantin Asofiei
10:35 AM Bug #7462 (New): fix 'AS' instead of '4GL' in LOG-MANAGER log lines and add an incompatible FWD a...
Constantin Asofiei
08:56 AM Support #5568: implement application-specific TERMINFO database overrides
With the completion of #5167, we now have the option of using a statically linked ncurses installation rather than th... Greg Shah

06/21/2023

11:00 AM Bug #7443 (WIP): performance of CentralLogger
We know we need proper logging because there are 4GL language features that depend upon it. In addition, we must pro... Greg Shah
09:15 AM Bug #7443: performance of CentralLogger
Another summary:
* @CentralLogger@ (used in new trunk) is 300% slower than @System.err@ redirected to file (used in ...
Galya B
09:02 AM Bug #7443: performance of CentralLogger
Here is the java logger to file with the new formatter. There is slight degradation of performance (+6.3%), because t... Galya B
08:48 AM Bug #7443: performance of CentralLogger
Constantin Asofiei wrote:
> For example, can @String.format@ be replaced with something else, which parses the forma...
Galya B
08:41 AM Bug #7443: performance of CentralLogger
Biased is a synonym for isolated? I have no idea what settings you use in your tests, while I shared my samples. Aren... Galya B
08:34 AM Bug #7443: performance of CentralLogger
Galya, I think your tests are biased because they do not use the FWD runtime. My point was to test from within the F... Constantin Asofiei
08:13 AM Bug #7443: performance of CentralLogger
What I'm implying is: Console writes seem quite expensive, so the java logger performed poorly before, but the day wa... Galya B
08:10 AM Bug #7443: performance of CentralLogger
Constantin Asofiei wrote:
> From your results, are you saying that Java logger is 33seconds and CentraLogger is 14se...
Galya B
08:09 AM Bug #7443: performance of CentralLogger
From your results, are you saying that Java logger is 33seconds and CentraLogger is 14seconds? Constantin Asofiei
08:07 AM Bug #7443: performance of CentralLogger
A little bit of history:
Once upon a time FWD used direct @System.err.print@ and @throwable.printStackTrace()@ sta...
Galya B
08:02 AM Bug #7443: performance of CentralLogger
Here it is, the groundbreaking reality (in src.com.galya.LoggingTest):... Galya B
07:58 AM Bug #7443: performance of CentralLogger
I don't understand what you mean by System.err. Previously, FWD was using @java.util.logging@ for logging support on... Constantin Asofiei
04:39 AM Bug #7443: performance of CentralLogger
Constantin Asofiei wrote:
> using what was before CentraLogger
You mean @System.err@? server.log was "generated" by...
Galya B
04:01 AM Bug #7443: performance of CentralLogger
Galya, please measure the following, for 1mm log lines:
* the LogTest modified program with CentralLogger and 7443a
...
Constantin Asofiei
03:14 AM Bug #7443: performance of CentralLogger
Let's set the requirements first before jumping into fixing. If I make @CentralLogger#describeContext@ (24,755%) and ... Galya B
02:50 AM Bug #7443: performance of CentralLogger
Alexandru Lungu wrote:
> I got a result that is a bit slower than my trunk base-line before @CentralLogger@ (only +0...
Galya B
02:42 AM Bug #7443: performance of CentralLogger
Alexandru, can you please try to run with the following configs:... Galya B
02:42 AM Bug #7443: performance of CentralLogger
> Alexandru, please commit this change to 7443a. I expect 7443a to be merged to trunk before 7026e.
Done! Committe...
Alexandru Lungu
01:41 AM Bug #7443: performance of CentralLogger
Alexandru Lungu wrote:
> Constantin Asofiei wrote:
> > Alexandru Lungu wrote:
> > > I commented an WARNING (that ...
Constantin Asofiei

06/20/2023

04:41 PM Bug #7443: performance of CentralLogger
Galya, Alexandru I think is right, formatting the message is expensive. Please see how this can be improved. I've a... Constantin Asofiei
10:00 AM Bug #7443: performance of CentralLogger
Constantin Asofiei wrote:
> Alexandru Lungu wrote:
> > I commented an WARNING (that is already fixed on another br...
Alexandru Lungu
09:54 AM Bug #7443: performance of CentralLogger
Alexandru Lungu wrote:
> I commented an WARNING (that is already fixed on another branch)
Is this already in trunk...
Constantin Asofiei
09:42 AM Bug #7443: performance of CentralLogger
I've done one set of profiling tests and got a slight improvement comparing to the state before #7443 (which was +3.1... Alexandru Lungu
09:14 AM Bug #7443: performance of CentralLogger
Code Review Task Branch 7443a Revision 14630
The change is good. I like that the code is in @Utils@ instead of @C...
Greg Shah
08:48 AM Bug #7443: performance of CentralLogger
r14630 reverts @LogHelper#createThreadName@, requested in #7143-234. Galya B
04:23 AM Bug #7443: performance of CentralLogger
I pushed r14629 to fix the compilation error. I haven't rebuilt with @all@. Galya B
03:40 AM Bug #7443: performance of CentralLogger
7443a/rev. 14628 doesn't compile: ... Alexandru Lungu
01:47 AM Bug #7443: performance of CentralLogger
Constantin Asofiei wrote:
> Alexandru: please apply (locally) the 7443a changes to 7156b and run a new round of test...
Alexandru Lungu
05:33 AM Bug #7425: Avoid directory usage in static blocks
This bootstrap is triggered only on server start-up from @StandardServer@ hooks. Should we consider other FWD usages ... Alexandru Lungu
04:55 AM Bug #7425: Avoid directory usage in static blocks
There are a few classes that already have an @initialize@ method, so to avoid confusion I @bootstrap@ for the method ... Dănuț Filimon

06/19/2023

11:50 AM Bug #7443: performance of CentralLogger
Galya B wrote:
> 7443a r14628 based on trunk r14627 tested and ready for review.
The changes look reasonable, but t...
Constantin Asofiei
10:40 AM Bug #7443 (Review): performance of CentralLogger
7443a r14628 based on trunk r14627 tested and ready for review. Galya B
04:19 AM Bug #7443 (WIP): performance of CentralLogger
7443a created. Galya B
07:03 AM Bug #7425: Avoid directory usage in static blocks
Danut, try to make the initialization calls hierarchical. That is, do not list all initialization in @StandardServer@... Alexandru Lungu
07:01 AM Bug #7425: Avoid directory usage in static blocks
I found the following static initializers that use @directory.xml@:
* @TemporaryAccountPool@
* @WebHandler@: from t...
Dănuț Filimon

06/16/2023

09:02 AM Bug #7443: performance of CentralLogger
Greg Shah wrote:
> What can't be slow or even as slow as a single map lookup is the @isLoggable()@.
Roger that. I...
Galya B
09:01 AM Bug #7443: performance of CentralLogger
Galya B wrote:
> When invalidating the levels in all instances that will be a performance bottleneck, because all lo...
Greg Shah
02:44 AM Bug #7443: performance of CentralLogger
When invalidating the levels in all instances that will be a performance bottleneck, because all loggers will need to... Galya B

06/15/2023

12:39 PM Bug #7443: performance of CentralLogger
> Galya, beside the FWD server startup, what are the condition under which a logger's level can be changed? Here I m... Greg Shah
12:38 PM Bug #7443: performance of CentralLogger
> 1. Have you done performance testing on Java @isLoggable@ implementation? Think about it carefully.
All of our p...
Greg Shah
12:37 PM Bug #7443: performance of CentralLogger
Galya, beside the FWD server startup, what are the condition under which a logger's level can be changed? Here I mea... Constantin Asofiei
11:47 AM Bug #7443: performance of CentralLogger
I'm not sure if that got understood, but all loggers should listen to the change, this means a few hundred objects wr... Galya B
11:41 AM Bug #7443: performance of CentralLogger
What I'm trying to say is that listeners and more state are a bad idea. It should be implemented with @WeakReference@... Galya B
11:33 AM Bug #7443: performance of CentralLogger
Also Java logger has a tree :( I wanted to implement a tree as well, but didn't have the capacity of a Java team. Galya B
11:24 AM Bug #7443: performance of CentralLogger
I made an expensive mistake, that removed will improve things 3 times... Now @getLevel@ checks in 3 concurrent maps, ... Galya B
11:13 AM Bug #7443: performance of CentralLogger
Galya B wrote:
> Galya B wrote:
> > To me removing 50% of the calls sounds quite right. Or am I misreading your scr...
Constantin Asofiei
10:59 AM Bug #7443: performance of CentralLogger
Galya B wrote:
> To me removing 50% of the calls sounds quite right. Or am I misreading your screenshot?
I didn't s...
Galya B
10:58 AM Bug #7443: performance of CentralLogger
Also as I've said, I have a mistake to fix.
Galya B
10:57 AM Bug #7443: performance of CentralLogger
To me removing 50% of the calls sounds quite right. Or am I misreading your screenshot? Galya B
10:54 AM Bug #7443: performance of CentralLogger
Galya B wrote:
> Give me 1h to rework @TransactionManager@ to my liking and see if it fixes something.
Reworking co...
Constantin Asofiei
10:52 AM Bug #7443: performance of CentralLogger
Do we have a branch here? Galya B
10:51 AM Bug #7443: performance of CentralLogger
Give me 1h to rework @TransactionManager@ to my liking and see if it fixes something. Galya B
10:49 AM Bug #7443: performance of CentralLogger
Constantin, I started with a similar implementation, where the state also included the level, but there are other cav... Galya B
10:46 AM Bug #7443: performance of CentralLogger
@isLoggable@ is meant to be used when there is a cost with resolving the arguments passed to the @log@ method. That'... Constantin Asofiei
10:44 AM Bug #7443: performance of CentralLogger
Even if I bend due to pure pressure and implement it, I don't recommend using @isLoggable@ just for the sake of looki... Galya B
10:29 AM Bug #7443: performance of CentralLogger
Constantin Asofiei wrote:
> It doesn't matter if the same logger name is being used by multiple logger instances, th...
Galya B
10:20 AM Bug #7443: performance of CentralLogger
Greg Shah wrote:
> Bypassing everything but the logging level check has served us well. There is a performance reas...
Galya B
10:20 AM Bug #7443: performance of CentralLogger
Galya, the problem is not @isLoggable@ being called excessively. @canLog@ relies too on @isLoggable@, so getting rid ... Constantin Asofiei
10:14 AM Bug #7443: performance of CentralLogger
Bypassing everything but the logging level check has served us well. There is a performance reason those checks were... Greg Shah
10:13 AM Bug #7443: performance of CentralLogger
This is the entire @logging@ node. The @loggers@ levels is the same from before testing with @CentralLogger@.... Constantin Asofiei
10:08 AM Bug #7443: performance of CentralLogger
Constantin, what is the logging level you tested with on this screenshot? Galya B
09:50 AM Bug #7443: performance of CentralLogger
Also let's not forget that resource consumption is part of execution of applications and this feature was not existin... Galya B
09:44 AM Bug #7443: performance of CentralLogger
There is no free lunch, it's either the CPU or the RAM. If I need to work on this task, I'll remove @isLoggable@ from... Galya B
09:40 AM Bug #7443: performance of CentralLogger
And we know the complexity of accessing string keyed map. Do you think the concurrency of the map adds to the CPU usage? Galya B
09:39 AM Bug #7443: performance of CentralLogger
Actually the cache map should have been the first lookup in the method. This is my bad. Galya B
09:33 AM Bug #7443: performance of CentralLogger
Constantin Asofiei wrote:
> We need to remove the map lookup. The log level needs to be cached at the logger instan...
Galya B
09:32 AM Bug #7443: performance of CentralLogger
Galya B wrote:
> We can lower it to 1.8 million executions removing the unnecessary @if (LOG.isLoggable(Level.FINE))...
Constantin Asofiei
09:31 AM Bug #7443: performance of CentralLogger
~1% of resources for 3.6 million executions sounds great to me!
Jokes aside...
We can lower it to 1.8 million e...
Galya B
08:13 AM Bug #7443: performance of CentralLogger
@CentralLogger.isLoggable@ is called 3.6 million times when testing an application. In the profiler, this highlights... Constantin Asofiei
08:08 AM Bug #7443 (Closed): performance of CentralLogger
Constantin Asofiei
10:52 AM Bug #7425 (WIP): Avoid directory usage in static blocks
Danut, this is close to your work on #7388. I will do the review on caches there asap.
Please extend your research...
Alexandru Lungu

06/13/2023

02:15 AM Bug #7291: LOG-MANAGER to log on client-side
I'll merge it with 7415c when ready. Galya B

06/12/2023

02:32 AM Bug #7291: LOG-MANAGER to log on client-side
Constantin Asofiei wrote:
> Galya, I missed something. Appserver logging must not be forced on server-side.
Well, ...
Galya B

06/11/2023

05:59 AM Bug #7291: LOG-MANAGER to log on client-side
Galya, I missed something. Appserver logging must not be forced on server-side.... Constantin Asofiei

06/09/2023

10:01 AM Bug #7291: LOG-MANAGER to log on client-side
> I can name it @merge notification for task 7291@ if there is no standard one.
That works.
Greg Shah
09:59 AM Bug #7291: LOG-MANAGER to log on client-side
Fix merged to trunk as rev 14621. Galya B
09:53 AM Bug #7291: LOG-MANAGER to log on client-side
I can name it @merge notification for task 7291@ if there is no standard one. Galya B
09:51 AM Bug #7291: LOG-MANAGER to log on client-side
Greg Shah wrote:
> In the future, when you post something like this that is expected to be committed immediately, pl...
Galya B
09:50 AM Bug #7291: LOG-MANAGER to log on client-side
In the future, when you post something like this that is expected to be committed immediately, please include history... Greg Shah
09:45 AM Bug #7291: LOG-MANAGER to log on client-side
Diff attached. Fixes two NPEs when configs not present. Galya B
09:27 AM Bug #7291: LOG-MANAGER to log on client-side
No, just post the full diff here for a quick review. Greg Shah
09:03 AM Bug #7291: LOG-MANAGER to log on client-side
Do I create a whole new branch just for a null check? Galya B
06:32 AM Bug #7291 (Test): LOG-MANAGER to log on client-side
Galya B
03:22 AM Bug #7291: LOG-MANAGER to log on client-side
Task branch 7291a was merged to trunk as rev 14620 and archived. Email sent. Galya B
08:49 AM Bug #5703 (Closed): rationalize, standardize and simplify the client-side log file name configura...
Greg Shah
04:35 AM Bug #7425: Avoid directory usage in static blocks
After discussing with Constantin, mostly in regard to #7398, there are several places in FWD where the directory is r... Alexandru Lungu
04:23 AM Bug #7425 (Test): Avoid directory usage in static blocks
Alexandru Lungu

06/08/2023

02:53 PM Bug #7291: LOG-MANAGER to log on client-side
You can merge now. Greg Shah
11:40 AM Bug #7291: LOG-MANAGER to log on client-side
Pushed a tiny NPE fix in r14629. Tested with gui and chui.
When do I merge?
Galya B
10:37 AM Bug #7291: LOG-MANAGER to log on client-side
Constantin Asofiei wrote:
> * @Utils.pollAll@ needs to return null if there is no message, there is no reason to tra...
Galya B
09:46 AM Bug #7291: LOG-MANAGER to log on client-side
Constantin Asofiei wrote:
> I've looked through all the changes, I don't see anything else wrong. Did you test agai...
Galya B
09:45 AM Bug #7291: LOG-MANAGER to log on client-side
Galya B wrote:
> Constantin, please go ahead with reviewing the rest of the code, when you have time. I'll fix all, ...
Constantin Asofiei
07:54 AM Bug #7291: LOG-MANAGER to log on client-side
Constantin, please go ahead with reviewing the rest of the code, when you have time. I'll fix all, when you're done. Galya B
06:56 AM Bug #7291: LOG-MANAGER to log on client-side
> Greg, this is not documented in the coding standards, please correct me if I'm wrong.
I think this is correct. ...
Greg Shah
06:43 AM Bug #7291: LOG-MANAGER to log on client-side
Review for 7291a/14627:
* we don't usually use static imports except for interface constants. Without qualifying a ...
Constantin Asofiei
06:28 AM Bug #7291: LOG-MANAGER to log on client-side
7291a r14627 file headers. Galya B
08:09 AM Feature #7418: assess the security of the Jetty web server
And we need to differentiate between FWD server jetty and FWD client jetty. Greg Shah
08:04 AM Feature #7418: assess the security of the Jetty web server
I think we should also document the full stack for each exposed endpoint including versions. For example for Keikai t... Hynek Cihlar
07:59 AM Feature #7418: assess the security of the Jetty web server
Constantin Asofiei wrote:
> * Hynek, is sheet.war starting another web server? If so, what URL is it using?
No, ...
Hynek Cihlar
06:54 AM Feature #7418: assess the security of the Jetty web server
The main internet-exposed point of FWD is the Jetty web server. This includes the web server running on the FWD serv... Constantin Asofiei
06:45 AM Feature #7418 (New): assess the security of the Jetty web server
Constantin Asofiei

06/07/2023

07:19 PM Bug #7291: LOG-MANAGER to log on client-side
> Do I add the file headers before or after the review?
Generally, before. It helps explain the changes which mak...
Greg Shah
02:21 PM Bug #7291: LOG-MANAGER to log on client-side
Galya B wrote:
> Galya B wrote:
> > How do I configure @OSResourceManager.getInstance().isServerSideFileSystem()@ i...
Greg Shah
09:34 AM Bug #7291: LOG-MANAGER to log on client-side
Do I add the file headers before or after the review? Galya B
09:33 AM Bug #7291 (Review): LOG-MANAGER to log on client-side
7291a rebased on trunk r14616.
7291a r14626 tested and ready for review.
Galya B
09:31 AM Bug #7291: LOG-MANAGER to log on client-side
Galya B wrote:
> How do I configure @OSResourceManager.getInstance().isServerSideFileSystem()@ in directory.xml?
...
Galya B
04:40 AM Bug #7291: LOG-MANAGER to log on client-side
How do I configure @OSResourceManager.getInstance().isServerSideFileSystem()@ in directory.xml? Galya B

06/05/2023

01:20 PM Bug #7291: LOG-MANAGER to log on client-side
A few notes:
* Java file lock is respected by other Java processes on Windows and Linux and they will wait indefinit...
Galya B

06/01/2023

09:46 AM Bug #7291: LOG-MANAGER to log on client-side
> Can we have clients running in the server JVM? Basically my question is if @ThinClient@ static fields will always b... Greg Shah
07:16 AM Bug #7291: LOG-MANAGER to log on client-side
Can we have clients running in the server JVM? Basically my question is if @ThinClient@ static fields will always be ... Galya B
06:46 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Task branch 5703d was merged to trunk as rev 14595 and archived. Email sent. Galya B
06:29 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> Can you confirm this change ?
Yes, confirmed. It is a matter of preference. Some will like the change, some wi...
Greg Shah
05:01 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Also most FWD devs trace issues on the console, while I do it using the files, so my opinion may differ based on that... Galya B
04:56 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> In @LoggingUtil@ please set @SORTABLE_DATETIME_FORMAT@ to "%tY%tm%td_%tH%tM%tS". It just condens...
Galya B

05/31/2023

03:00 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Code Review Task Branch 5703d Revisions 14593 and 14594
The changes are good.
In @LoggingUtil@ please set @SORT...
Greg Shah
02:09 PM Bug #7291: LOG-MANAGER to log on client-side
I'm fine with the plan. Greg Shah
12:25 PM Bug #7291: LOG-MANAGER to log on client-side
Then what about making the design as simple and and clear as possible.
* @LOG-MANAGER@ will live on the server and t...
Galya B
09:06 AM Bug #7291: LOG-MANAGER to log on client-side
We need to move ahead with this task. We cannot assume that all customers can use server-side logging for @LOG-MANAG... Greg Shah

05/30/2023

12:21 PM Bug #7291: LOG-MANAGER to log on client-side
Pause the work while I consider what we lose by dropping this. Greg Shah
11:37 AM Bug #7291: LOG-MANAGER to log on client-side
Greg, I think LOG-MANAGER client-side implementation will end up:
* very fragile;
* with multiple rpc calls for one...
Galya B
08:24 AM Bug #7291: LOG-MANAGER to log on client-side
Greg, it's not that I'm lazy, but it really doesn't make sense to have LOG-MANAGER client-side. It's way too intertwi... Galya B
08:19 AM Bug #7291: LOG-MANAGER to log on client-side
Constantin Asofiei wrote:
> This is what I meant. It may work if all the validation/checks (which can raise OE erro...
Galya B
08:12 AM Bug #7291: LOG-MANAGER to log on client-side
Galya B wrote:
> ... but there are plenty of OE errors in initialization and the setters.
This is what I meant. It...
Constantin Asofiei
08:11 AM Bug #7291: LOG-MANAGER to log on client-side
Galya B wrote:
> but there are plenty of OE errors in initialization and the setters.
... which is (as we already...
Galya B
08:09 AM Bug #7291: LOG-MANAGER to log on client-side
There are no Java exceptions thrown, but there are plenty of OE errors in initialization and the setters.
It just ...
Galya B
07:51 AM Bug #7291: LOG-MANAGER to log on client-side
Galya, is there any condition which can be raised by any APIs which would use state sync? If this is so, then we must... Constantin Asofiei
05:00 AM Bug #7291: LOG-MANAGER to log on client-side
State sync doesn't seem to work well. On top of the the six getters, the following methods should also return a value... Galya B
08:34 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Roger Borrello wrote:
> Galya B wrote:
> Are you using a real Windows system?
I set up a VirtualBox VM, here is t...
Galya B
08:23 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya B wrote:
> Roger, I always have troubles with Windows builds, but when that is out of the way I can confirm th...
Roger Borrello
02:43 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Roger, I always have troubles with Windows builds, but when that is out of the way I can confirm that the latest trun... Galya B
02:11 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Roger Borrello wrote:
> Have you been able to run hotel_gui on Windows? I am having a lot of trouble getting clien...
Galya B

05/29/2023

02:40 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya B wrote:
> The Jetty info msg is not causing issues on any deployments. Do you still have this issue and can y...
Roger Borrello
01:02 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
5703d r14593 loggers to fallback to the default log file name if the provided path is invalid (can't be created or no... Galya B
10:07 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> Can you define @fail gracefully@? It will in all cases produce a crash log and the log does have a warning about th... Greg Shah
06:07 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya B wrote:
> Can you define @fail gracefully@? It will in all cases produce a crash log and the log does have a ...
Galya B
03:52 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote (#7378-909):
> Galya: The NPE is a bug that needs to be fixed. It needs to fail gracefully instead o...
Galya B
03:30 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Roger Borrello wrote:
> Well the result is the server no longer functions. This is on a Windows VM for which I have ...
Galya B
 

Also available in: Atom