Project

General

Profile

Activity

From 01/05/2024 to 02/03/2024

02/02/2024

05:01 PM Bug #8206: Logging manager issues
Vladimir Tsichevski wrote:
> As of trunk rev 14926, the following issues are known, which relate to legacy logging:
...
Theodoros Theodorou
11:29 AM Bug #8206: Logging manager issues
Galya B wrote:
> I expect @PostInitErrorManager@ to run after the initialization as the name suggests, even if you p...
Theodoros Theodorou
09:46 AM Bug #8206: Logging manager issues
Theodoros Theodorou wrote:
> Galya B wrote:
> > The error is thrown after initialization and the value is considere...
Galya B
09:37 AM Bug #8206: Logging manager issues
Galya B wrote:
> The error is thrown after initialization and the value is considered @null@ for the time being, whi...
Theodoros Theodorou
02:46 AM Bug #8206: Logging manager issues
Theodoros Theodorou wrote:
> Galya B wrote:
> > A found issue with the numeric parameters in @LegacyLogManagerImpl@...
Galya B
01:03 PM Feature #6692: move FWD to Java 17
Tomasz Domin wrote:
> That was already fixed by adding @--add-opens java.logging/java.util.logging=ALL-UNNAMED"@. Un...
Tomasz Domin

02/01/2024

03:58 PM Bug #8206: Logging manager issues
Theodoros Theodorou wrote:
> Does anyone understand what is going on? Can anyone confirm my findings?
OE parses t...
Vladimir Tsichevski
03:21 PM Bug #8206: Logging manager issues
Vladimir Tsichevski wrote (in #8195-50):
> Also, I found additional minor issues:
> # FWD reports if the maximum nu...
Theodoros Theodorou
12:46 PM Bug #8206: Logging manager issues
Galya B wrote:
> A found issue with the numeric parameters in @LegacyLogManagerImpl@ is supposed to stop the initial...
Theodoros Theodorou
02:48 AM Bug #8206: Logging manager issues
A found issue with the numeric parameters in @LegacyLogManagerImpl@ is supposed to stop the initialization process. H... Galya B

01/31/2024

06:09 PM Bug #8206 (WIP): Logging manager issues
Theodoros Theodorou
05:57 PM Bug #8206: Logging manager issues
My goal was to remove the duplicate code which checks if the integer startup parameters are valid. I worked on the @S... Theodoros Theodorou
06:01 AM Bug #7443: performance of CentralLogger
Tomasz Domin wrote:
> As calling to @LogRecord.setSourceClassName@ or @LogRecord.setSourceMethodName@ implicitly cle...
Galya B
05:36 AM Bug #7443: performance of CentralLogger
Galya B wrote:
> We'll be overriding only those two methods, the rest can continue working as it was before. But you...
Tomasz Domin

01/26/2024

09:17 AM Feature #6692: move FWD to Java 17
While regression testing I found another IllegalAccessException:... Tomasz Domin
05:31 AM Bug #7443: performance of CentralLogger
Tomasz Domin wrote:
> Galya B wrote:
> > Tomasz Domin wrote:
> > > Galya B wrote:
> > > I was considering that op...
Galya B
05:28 AM Bug #7443: performance of CentralLogger
Galya B wrote:
> Tomasz Domin wrote:
> > Galya B wrote:
> > I was considering that option but it seems @java.util....
Tomasz Domin
05:12 AM Bug #7443: performance of CentralLogger
Tomasz Domin wrote:
> Galya B wrote:
> I was considering that option but it seems @java.util.logging.LogRecord@ was...
Galya B
03:51 AM Bug #7443: performance of CentralLogger
Galya B wrote:
> The new class should in be in the package @com.goldencode.p2j.util.logging@. As for the name (since...
Tomasz Domin

01/25/2024

03:57 AM Bug #7443: performance of CentralLogger
The new class should in be in the package @com.goldencode.p2j.util.logging@. As for the name (since @CentralLogRecord... Galya B
03:52 AM Bug #7443: performance of CentralLogger
#7143-253, #7143-255.
Instead of replacing @java.util.logging.LogRecord@ there could be another option, extend it ...
Galya B
03:20 AM Bug #7443: performance of CentralLogger
Galya B wrote:
> Tomasz Domin wrote:
> > Galya B wrote:
> > > r14634: Fixed Java (@java.util.logging.LogRecord#nee...
Tomasz Domin
03:11 AM Bug #7443: performance of CentralLogger
Tomasz Domin wrote:
> Galya B wrote:
> > r14634: Fixed Java (@java.util.logging.LogRecord#needToInferCaller@ set wi...
Galya B
03:05 AM Bug #7443: performance of CentralLogger
Galya B wrote:
> r14634: Fixed Java (@java.util.logging.LogRecord#needToInferCaller@ set with reflection to stop hea...
Tomasz Domin

01/24/2024

04:17 PM Feature #6692: move FWD to Java 17
Tomasz Domin wrote:
> Tomasz Domin wrote:
> After starting regression tests which is more or less the real applicat...
Tomasz Domin
09:50 AM Feature #6692: move FWD to Java 17
Tomasz Domin wrote:
> Regarding Java 17 and modules - there are few places I need to add @--add-opens@ JVM option to...
Tomasz Domin

01/23/2024

01:54 PM Feature #6692: move FWD to Java 17
I've cleaned @6692@ from compiler warnings by updating FWD code.
There were two cases where I had to add @deprecated...
Tomasz Domin
12:41 PM Feature #6692: move FWD to Java 17
> Greg, are there any broader guidelines regarding FWD and Java Modules (JPMS) ?
Not yet. I am open to recommenda...
Greg Shah
10:04 AM Feature #6692: move FWD to Java 17
Regarding Java 17 and modules - there are few places I need to add @--add-opens@ JVM option to allow access of base m... Tomasz Domin
10:00 AM Feature #6692: move FWD to Java 17

There are 27 warnings mainly related with code deprecation. I will check them one by one and try to clear them mini...
Tomasz Domin

01/22/2024

02:53 AM Bug #8206: Logging manager issues
Theodoros, the change was introduced for #7732. The two parameters in concern are only used in @LegacyLogManagerImpl@... Galya B
02:48 AM Bug #8206: Logging manager issues
Vladimir Tsichevski wrote:
> Error reporting:
>
> # 1-2 dots are forcedly appended to error messages, there no do...
Galya B
02:46 AM Bug #8206: Logging manager issues
There is a change introduced in r14848 that deletes a substantial portion of the integer parameters parsing logic in ... Galya B

01/19/2024

01:47 PM Bug #8206: Logging manager issues
As of trunk rev 14926, the following issues are known, which relate to legacy logging:
Parse *integer* logging con...
Vladimir Tsichevski
01:17 PM Bug #8206 (Internal Test): Logging manager issues
Vladimir Tsichevski

01/17/2024

02:37 PM Feature #6692: move FWD to Java 17
Restarting the tasks.
After rebasing to latest @trunk@ refreshing @gradle@ configuration.
Tomasz Domin

01/11/2024

09:12 AM Bug #7589 (Test): org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Greg Shah
09:09 AM Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Branch 7589c was rebased to trunk_14916 and is at revision 14918.
Branch 7589c was merged to trunk as revision 149...
Roger Borrello

01/10/2024

11:07 AM Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Greg Shah wrote:
> You can merge after 7667b.
I'll rebase and merge as soon as I see it hits.
Roger Borrello
11:02 AM Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
You can merge after 7667b. Greg Shah
08:40 AM Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Roger Borrello wrote:
> Great feedback... committed revision 14917.
Greg, it's good for merge.
Galya B
08:37 AM Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Galya B wrote:
> Two conditions are introduced, that can be merged together: @[ -f "$SLF4J_IMPL" ] && cp -f $SLF4J_I...
Roger Borrello
07:20 AM Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Two conditions are introduced, that can be merged together: @[ -f "$SLF4J_IMPL" ] && cp -f $SLF4J_IMPL ${spawn_dir}/s... Galya B

01/09/2024

05:56 PM Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Branch *7589c* was rebased to trunk_14915 and is at revision 14916. Roger Borrello
11:17 PM Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Galya B wrote:
> Roger, did you create 7589b? 7589b is merged. It should have been 7589c.
Oops... I've correct it...
Roger Borrello

01/08/2024

01:34 AM Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Roger, did you create 7589b? 7589b is merged. It should have been 7589c. Galya B

01/05/2024

12:08 PM Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Branch 7589b was rebased to trunk_14912 and is at revision 14914. Roger Borrello
10:50 AM Bug #7589 (Review): org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Galya: Please review. Greg Shah
10:41 AM Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
I tested @postbuild.sh@ with a bogus file, such that I would be able to test my dockerfile's ability to handle a @bui... Roger Borrello
 

Also available in: Atom