General

Profile

Greg Shah's activity

From 10/29/2024 to 11/27/2024

11/27/2024

12:37 PM Base Language Bug #8309: Do the error handling for r-index and extend implementation to INDEX and LONGCHAR
> Does this mean we shall make FWD runtime honor the version returned by @EnvironmentOps@?
Yes, exactly this. Luc...
Greg Shah
10:59 AM Base Language Bug #8309: Do the error handling for r-index and extend implementation to INDEX and LONGCHAR
I know it isn't nice to write, but in the 4GL code we can use @PROVERSION@ and have conditional matching code. On th... Greg Shah
08:46 AM Base Language Bug #8309: Do the error handling for r-index and extend implementation to INDEX and LONGCHAR
Marian's team currently writes everything for 12.2 since that is what they have. That doesn't meant that that is the... Greg Shah
08:22 AM Base Language Bug #8309: Do the error handling for r-index and extend implementation to INDEX and LONGCHAR
We MUST support both. Please add runtime version checking using the @EnvironmentOps@ "Progress" version helpers. Greg Shah
11:31 AM Base Language Bug #8643 (Merge Pending): ErrorManager not handling caught errors and error-status:error attribu...
You can merge after 9342a. Greg Shah

11/26/2024

02:23 PM Base Language Bug #8309: Do the error handling for r-index and extend implementation to INDEX and LONGCHAR
> > * there are many places where @final@ was added to the method parameters. This remembered me of the "Overuse-of-f... Greg Shah
09:04 AM User Interface Bug #7657: 8-bit character entry problem in ChUI
+Tomasz Greg Shah
09:03 AM User Interface Bug #7657: 8-bit character entry problem in ChUI
> The idea is to use platform default encoding for regression testcases. If we need to keep "ISO-8859-1" for some cas... Greg Shah

11/22/2024

10:22 AM Base Language Bug #8309: Do the error handling for r-index and extend implementation to INDEX and LONGCHAR
Please coordinate with Marian to check these into the [[p2j:Testcases]] project. Greg Shah

11/21/2024

08:19 AM User Interface Bug #8673 (Review): Deduce the logic behind OE focus management and implement in FWD
Greg Shah
08:00 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Galya: Please summarize any questions that are still pending. Greg Shah
07:27 AM Database Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
Carson Mader wrote:
> Will the runtime still support running in single-tenant and multi-tenant mode without the need...
Greg Shah
06:44 AM Database Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
> a new set of FindQuery APIs which would accept both tuple of (fql, client-where, args). I think we can keep the cur... Greg Shah
04:34 AM Database Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
Are you expecting conversion to be specific to MT in this case? It would be the first thing that was hard coded in t... Greg Shah
05:27 AM Database Bug #9251 (Merge Pending): cache the translated FQL in FQLPreprocessor.translate
You can merge to trunk now. Greg Shah
04:46 AM Database Bug #9251: cache the translated FQL in FQLPreprocessor.translate
What are the next steps with 9251b? Greg Shah

11/20/2024

06:56 PM Database Feature #9302 (Closed): new reports for abbreviated field names and abbreviated table names
Greg Shah
06:32 PM Database Feature #9302 (Merge Pending): new reports for abbreviated field names and abbreviated table names
You can merge to trunk now. Greg Shah
05:53 PM Database Feature #9302: new reports for abbreviated field names and abbreviated table names
The multiple buckets version is the useful case for actually interacting with the report online.
If we need this k...
Greg Shah
05:02 PM Database Feature #9302: new reports for abbreviated field names and abbreviated table names
> Is there a way to set the match expression in the profile.rpt?
Instead of setting @dumpType@, you set @dumpExpr@...
Greg Shah
07:03 AM Base Language Bug #6389: LENGTH function with COLUMN option
Are these results from OE? Greg Shah

11/19/2024

09:53 AM Testing Feature #3704: enable automated testing for GUI (Swing and web clients)
> I don't see the declaration of this @hEvent@.
Yes, that is broken 4GL code (or a bug in preprocessing). The cac...
Greg Shah
08:44 AM Testing Feature #3704: enable automated testing for GUI (Swing and web clients)
> ./abl/sikuli/ui/support/windows/TestSikuli.w:221:8: unexpected token: hEvent
What is the line that fails from th...
Greg Shah
08:04 AM Base Language Bug #6389: LENGTH function with COLUMN option
Ovidiu and Eugenie: Please review. Greg Shah

11/18/2024

10:43 AM Build and Source Control Support #9349: license report inputs clutter the root of the project
Tomasz: Please review.
As to the other issues, you can work them wherever.
Greg Shah
09:57 AM Build and Source Control Support #9349: license report inputs clutter the root of the project
> There are a couple of other minor build changes I'd like to check into the same branch, as well, with permission.
...
Greg Shah
07:16 AM Build and Source Control Support #9349: license report inputs clutter the root of the project
These files clutter the project root:... Greg Shah
07:14 AM Build and Source Control Support #9349 (Closed): license report inputs clutter the root of the project
Greg Shah
08:11 AM Base Language Bug #9350: gap marking for LOG-MANAGER attributes and methods is probably wrong
We have analytics tooling that allows us to evaluate the level of support for each 4GL language feature. This is rep... Greg Shah
08:06 AM Base Language Bug #9350: gap marking for LOG-MANAGER attributes and methods is probably wrong
See [[p2j:Gap Analysis]]. Greg Shah
08:05 AM Base Language Bug #9350: gap marking for LOG-MANAGER attributes and methods is probably wrong
These are some items in reports for an application being evaluated.
* attributes
** @LOGGING-LEVEL@ (conversion f...
Greg Shah
07:55 AM Base Language Bug #9350 (Internal Test): gap marking for LOG-MANAGER attributes and methods is probably wrong
Greg Shah

11/15/2024

11:47 AM Database Feature #7020: always use "expanded" extent fields
Ovidiu: What is the list of remaining work/testing to finish this task? Greg Shah
08:48 AM User Interface Bug #9340: CHOOSE statement does not display widget help string in ChUI
And this doesn't cause ChUI regression testing to fail? That is surprising. Greg Shah
08:32 AM User Interface Bug #9340: CHOOSE statement does not display widget help string in ChUI
What trunk revision shows this bug? This seems like a regression. Greg Shah
07:11 AM Runtime Infrastructure Feature #9341: allow specification of startup parameters in OE command line option form
We already do some level of parsing of the @CONNECT@ options/parameters and even @-pf@ files (e.g. #4392). If we pro... Greg Shah
07:04 AM Runtime Infrastructure Feature #9341 (New): allow specification of startup parameters in OE command line option form
Greg Shah
06:55 AM Database Feature #8834: add bootstrap configuration support for -db OE command line parameter (and related...
> Are @-H@, @-S@ and @-P@ used only for the db? If so, it's best to have an array of custom objects with all the conf... Greg Shah

11/14/2024

03:53 PM Database Feature #9302: new reports for abbreviated field names and abbreviated table names
> The use of @record_types_rel@ threw me... should I be using that in the check for abbreviations instead of @evalLib... Greg Shah
07:51 AM Database Feature #9302: new reports for abbreviated field names and abbreviated table names
Code Review Task Branch 9302a Revisions 15556 and 15557
This is much better.
1. Unless you have found that data...
Greg Shah

11/13/2024

05:36 PM Database Feature #9302: new reports for abbreviated field names and abbreviated table names
> My guess is that trying to include database abbreviations is just a waste.
I would say so, since database names...
Greg Shah

11/12/2024

04:06 PM Database Feature #9302: new reports for abbreviated field names and abbreviated table names
> When we get to the @text@, how can I use @EntityName@ to parse? I need a leg up on that, because it is kind of free... Greg Shah
03:06 PM Database Feature #9302: new reports for abbreviated field names and abbreviated table names
Code Review Task Branch 9302a Revisions 15553 through 15555
I think you should separate the table and field proces...
Greg Shah
09:51 AM Database Feature #9302: new reports for abbreviated field names and abbreviated table names
Roger Borrello wrote:
> Greg Shah wrote:
> > Make @fieldname_abbreviated@ a @boolean@. Same for @tablename_abbrevi...
Greg Shah
08:13 AM Database Feature #9302: new reports for abbreviated field names and abbreviated table names
Make @fieldname_abbreviated@ a @boolean@. Same for @tablename_abbreviated@. It just tells someone that the field or... Greg Shah

11/08/2024

08:26 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
Note to self, review/explore the following things:
* How Java 17 affects lambda/method handle usage.
* Investigat...
Greg Shah
06:40 AM Database Bug #8200 (Test): Explicit buffer used instead of the implicit one for a persistent table
Greg Shah
05:43 AM Database Feature #9302: new reports for abbreviated field names and abbreviated table names
Roger Borrello wrote:
> The code that is checked in does find abbreviated db/table/field in the fieldtype, and annot...
Greg Shah
05:41 AM Database Feature #9302: new reports for abbreviated field names and abbreviated table names
> If there are 2 @'.'@ characters, that's a good indication that there are DB/table qualifiers.
A "good" indicatio...
Greg Shah

11/07/2024

03:35 PM Database Feature #9302: new reports for abbreviated field names and abbreviated table names
Make sure that any abbreviation uniquely references a single table or a single field (of a single table). So: @roo@ ... Greg Shah
02:52 PM Database Feature #9302: new reports for abbreviated field names and abbreviated table names
@evalLib("fieldtype", type)@ is correct for looking at fields. Use @evalLib("record_types")@ to look at table/buffer... Greg Shah
01:23 PM Database Feature #9302: new reports for abbreviated field names and abbreviated table names
> I don't think the 'quirk' with the space before the field is relevant for this report.
Yes, you're right. We ha...
Greg Shah
01:21 PM Database Feature #9302: new reports for abbreviated field names and abbreviated table names
> So @record.field@ can be @record. field@ or @record .field@ or @record . field@ ?
...
Greg Shah
11:56 AM Database Feature #9302: new reports for abbreviated field names and abbreviated table names
From our parser:... Greg Shah
11:34 AM Database Feature #9302: new reports for abbreviated field names and abbreviated table names
The @original-text@ annotation comes from the parser, so it will already be there *if it is going to be there*.
To...
Greg Shah
11:14 AM Database Feature #9302: new reports for abbreviated field names and abbreviated table names
> I plan to determine if the length of the @text@ doesn't match the length of the appropriate location in @schemaname... Greg Shah
11:10 AM Database Feature #9302: new reports for abbreviated field names and abbreviated table names
Yes, forget about ambiguous. The issue here is abbreviations. Greg Shah
09:32 AM Database Feature #9302: new reports for abbreviated field names and abbreviated table names
If a table is named @rogers-fav@, then an abbreviated name would be "rog" or "roge" or "roger" or...
The concept i...
Greg Shah
09:31 AM Database Feature #9302: new reports for abbreviated field names and abbreviated table names
Sorry, I should not have used "ambiguous". That is something completely different. We are needing to identify abbre... Greg Shah
07:00 PM Database Feature #9302: new reports for abbreviated field names and abbreviated table names
@eliminate_field_abbreviations.xml@ isn't used in any conversion or report. It just shows some example code that imp... Greg Shah

11/06/2024

07:48 PM Database Feature #9302: new reports for abbreviated field names and abbreviated table names
Please create 2 reports for:
* Abbreviated Field Names
* Abbreviated Table Names
You will need to create 2 hel...
Greg Shah
07:47 PM Database Feature #9302 (Closed): new reports for abbreviated field names and abbreviated table names
Greg Shah

11/05/2024

10:41 AM Database Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
Eric and Radu: please review. Greg Shah

11/04/2024

06:46 AM Database Bug #9267 (WIP): Index Selection in case of a multiple index matches.
Greg Shah
 

Also available in: Atom