Golden Code Redmine

10/16/2025

09:07 AM Conversion Tools Bug #10626: DMO names can collide on case-insensitive file-system

Greg Shah wrote:
> Code Review Task Branch 10626a Revision 16221
>
> I don't have a problem with the changes. Pl... Dănuț Filimon

02:30 AM Conversion Tools Bug #10626 (Review): DMO names can collide on case-insensitive file-system

Greg, please review. Dănuț Filimon

02:29 AM Conversion Tools Bug #10626: DMO names can collide on case-insensitive file-system

Dănuț Filimon wrote:
> Greg Shah wrote:
> > Is this ready for review? What is the % Done?
>
> I looked into th... Dănuț Filimon

07:08 AM Conversion Tools Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

The following pattern:... Dănuț Filimon

04:10 AM Conversion Tools Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

I managed to make 7180a build, but I don't like a few changes so I'll be working a bit on 7180a and also take care of... Dănuț Filimon

10/15/2025

08:52 AM Conversion Tools Feature #7180 (WIP): create a centralized manager for the conversion list and per-file/project st...

Rebased *7180a* to latest *trunk/16220*, the branch is now at revision *16244*. I'll have to commit a few compatibili... Dănuț Filimon

05:44 AM Conversion Tools Feature #7180: create a centralized manager for the conversion list and per-file/project status a...

Greg Shah wrote:
> Code Review Task Branch 7180a Revisions 16121 through 16139
I plan to rebase and address a few... Dănuț Filimon

06:37 AM Conversion Tools Bug #10626: DMO names can collide on case-insensitive file-system

Greg Shah wrote:
> Is this ready for review? What is the % Done?
I looked into the ChUI project for some other ... Dănuț Filimon

04:50 AM Conversion Tools Bug #10626: DMO names can collide on case-insensitive file-system

Committed *10626a/16221*. Generates names for menus, sub-menus, dmos, pojos, frames that do not collide in case-insen... Dănuț Filimon

10/14/2025

09:40 AM Conversion Tools Bug #10626: DMO names can collide on case-insensitive file-system

Dănuț Filimon wrote:
> I discussed with Octavian and he mentioned I could use @createString2StringMap@ to get a map ... Dănuț Filimon

07:21 AM Conversion Tools Bug #10626: DMO names can collide on case-insensitive file-system

I discussed with Octavian and he mentioned I could use @createString2StringMap@ to get a map across other rules. I ha... Dănuț Filimon

06:14 AM Conversion Tools Bug #10626: DMO names can collide on case-insensitive file-system

I thought of using another set of rules to store a case sensitive map that maps the namings, but I don't think this i... Dănuț Filimon

03:44 AM Conversion Tools Bug #10626: DMO names can collide on case-insensitive file-system

This bit of code:... Dănuț Filimon

03:20 AM Conversion Tools Bug #10626: DMO names can collide on case-insensitive file-system

The issue with menus starts with this piece of code:... Dănuț Filimon

06:09 AM Conversion Tools Bug #10469 (Test): incremental conversion when basepath is more than one folder (aka abl/foo) wit...

Branch 6083a was merged to trunk revision 16220 and archived. Dănuț Filimon

06:08 AM Conversion Tools Bug #6738 (Test): incremental conversion when deleting program or class files

Branch 6083a was merged to trunk revision 16220 and archived. Dănuț Filimon

06:08 AM Database Bug #7793 (Test): incremental conversion with deleted table from .df

Branch 6083a was merged to trunk revision 16220 and archived. Dănuț Filimon

06:07 AM Conversion Tools Feature #6083 (Test): schema (.df) changes in incremental conversion mode should only reconvert t...

Branch 6083a was merged to trunk revision 16220 and archived. Dănuț Filimon

10/13/2025

07:32 AM Conversion Tools Bug #10626: DMO names can collide on case-insensitive file-system

I setup and tested POJOs on hotel and found no issues, the hotel.p2o ends up using the correct class names (FooBarSom... Dănuț Filimon

05:47 AM Conversion Tools Bug #10626: DMO names can collide on case-insensitive file-system

Dănuț Filimon wrote:
> Perfect, I'll just have to implement the contains() method for CaseInsensitiveHashMap in this... Dănuț Filimon

05:44 AM Conversion Tools Bug #10626: DMO names can collide on case-insensitive file-system

Constantin Asofiei wrote:
> Dănuț Filimon wrote:
> > Constantin Asofiei wrote:
> > > We need to generate the same ... Dănuț Filimon

05:15 AM Conversion Tools Bug #10626: DMO names can collide on case-insensitive file-system

Constantin Asofiei wrote:
> We need to generate the same .java names regardless of OS - so I think that collection n... Dănuț Filimon

04:50 AM Conversion Tools Bug #10626 (WIP): DMO names can collide on case-insensitive file-system

Error from windows:... Dănuț Filimon

10/10/2025

08:36 AM Conversion Tools Bug #10626: DMO names can collide on case-insensitive file-system

Good, opsys is out of the question.
I converted the two tables, Foo_BARSomething and Foo_BAR_Something, and got a ... Dănuț Filimon

07:07 AM Conversion Tools Bug #10626: DMO names can collide on case-insensitive file-system

We use @opsys@ to determine what OS is being used (default is Unix OS). opsys can be set in @p2j.cfg.xml@, so there's... Dănuț Filimon

06:40 AM Testing Support #6859: preprocessor tests

Committed *testcases/1811*. Added semicolon preprocessor tests. Dănuț Filimon

06:09 AM Testing Support #6859: preprocessor tests

I wrote the test for #10109 + semicolon tests, can I commit them to testcases? As for the AdaptiveFind scenario, I co... Dănuț Filimon

03:56 AM Testing Support #6859: preprocessor tests

Greg Shah wrote:
> Dănuț Filimon wrote:
> > I am investigating #10262-31 and I am also looking into expanding the t... Dănuț Filimon

06:02 AM Conversion Tools Feature #10265 (Internal Test): schema-only conversion

Greg Shah wrote:
> Code Review Task Branch 10265a Revision 16214
>
> This is good. The only change that may be n... Dănuț Filimon

03:08 AM Conversion Tools Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...

Committed *6083a/16224*. Fixed file copy and file separator. Dănuț Filimon

10/09/2025

08:26 AM Conversion Tools Bug #10626: DMO names can collide on case-insensitive file-system

I've made a similar patch to #10626-2 in #9917, it was for the frames and menus (explained the issue in #9917-10, the... Dănuț Filimon

06:16 AM Testing Support #6859: preprocessor tests

I am investigating #10262-31 and I am also looking into expanding the test cases where possible. Dănuț Filimon

06:01 AM Conversion Tools Bug #10569: Semicolon is skipped while preprocessing

Radu Apetrii wrote:
> Alex/Danut: if you don't plan on assigning this issue to somebody from your team, can you plea... Dănuț Filimon

03:50 AM Conversion Tools Feature #10265: schema-only conversion

Rebased *10265a* to latest *trunk/16212*, the branch is now at revision *16214*. Dănuț Filimon

03:14 AM Conversion Tools Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes

Octavian, please check #10536-27 - #10536-32 and #10536-38 - #10536-39. Dănuț Filimon

10/08/2025

07:19 AM Base Language Bug #10613 (Test): Incremental conversion issue: temp-table dmo does not get converted

Branch 10613a was merged to trunk rev 16212 and archived. Dănuț Filimon

06:52 AM Base Language Bug #10613: Incremental conversion issue: temp-table dmo does not get converted

Dănuț Filimon wrote:
> The changes are pretty simple, so the test plan includes running ChUI and a customer conversi... Dănuț Filimon

04:57 AM Base Language Bug #10613: Incremental conversion issue: temp-table dmo does not get converted

The changes are pretty simple, so the test plan includes running ChUI and a customer conversion/incremental. Dănuț Filimon

03:04 AM Base Language Bug #10613 (Internal Test): Incremental conversion issue: temp-table dmo does not get converted

Committed the @hasSchemaChanges()@ to *10613a/16211*. Dănuț Filimon

07:15 AM Testing Support #6859: preprocessor tests

I updated https://proj.goldencode.com/projects/p2j/wiki/Preprocessor_Testcases#Current-Status and https://proj.golden... Dănuț Filimon

05:59 AM Conversion Tools Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...

Greg Shah wrote:
> Code REview Task Branch 6083a Revision 1622
>
> I'm fine with the changes.
>
> Please do en... Dănuț Filimon

03:57 AM Conversion Tools Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...

Dănuț Filimon wrote:
> Greg Shah wrote:
> > I have reconsidered the @name_map.xml@ changes. It was my mistake to f... Dănuț Filimon

04:53 AM Runtime Infrastructure Feature #10685: Move name_map.xml to the cvt folder

The purpose of this task is to move the name_map.xml to the conversion folder, this is a breaking change which will r... Dănuț Filimon

04:52 AM Runtime Infrastructure Feature #10685 (Closed): Move name_map.xml to the cvt folder

Dănuț Filimon

10/07/2025

10:09 AM Conversion Tools Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...

Greg Shah wrote:
> I have reconsidered the @name_map.xml@ changes. It was my mistake to force that into this task. ... Dănuț Filimon

09:19 AM Base Language Bug #10613 (Review): Incremental conversion issue: temp-table dmo does not get converted

Committed *10613a/16210*. Fixed incremental conversion when modifying a temp-table.
Greg, please review. Dănuț Filimon

08:48 AM Base Language Bug #10613: Incremental conversion issue: temp-table dmo does not get converted

Created *10613a* from the latest *trunk/16209*. Dănuț Filimon

08:08 AM Base Language Bug #10613: Incremental conversion issue: temp-table dmo does not get converted

I am considering removing:... Dănuț Filimon

06:54 AM Base Language Bug #10613: Incremental conversion issue: temp-table dmo does not get converted

This is the patch I came up with:... Dănuț Filimon

06:33 AM Base Language Bug #10613: Incremental conversion issue: temp-table dmo does not get converted

Dănuț Filimon wrote:
> The .dict file is created again when @TransformDriver.runScanDriver()@ is called (ends up in ... Dănuț Filimon

05:43 AM Base Language Bug #10613: Incremental conversion issue: temp-table dmo does not get converted

The .dict file is created again when @TransformDriver.runScanDriver()@ is called (ends up in @AstGenerator.parse()@),... Dănuț Filimon

04:46 AM Base Language Bug #10613 (WIP): Incremental conversion issue: temp-table dmo does not get converted

Indeed, the .dict file has the right f2 field, but the .p2o and .schema do not. There's P2OLookup.addJavaName which i... Dănuț Filimon

10/06/2025

06:04 AM Base Language Bug #10522: Bring changes from 7156e/15727 to trunk

Dănuț Filimon wrote:
> Committed *10522a/16177*. Changes from 7156e/15727 built on trunk/15726: Added change to coll... Dănuț Filimon

04:54 AM Base Language Bug #10613: Incremental conversion issue: temp-table dmo does not get converted

I can still reproduce #10613-1 with the latest 6083a. As far as I can remember, I did not fix this in the branch beca... Dănuț Filimon