FWD » Core Development » Runtime Infrastructure

• FWD: ./tools/scripts/setup_ncurses6x.sh
• gcd_systems: ./roles/ncurses/files/setup_ncurses6x.sh

It looks like my Ubuntu uses ncurses-6.4+20240113. Both scripts above attempt to patch v6.1_20200708 and fail, because of the code mismatches.

I did one more search and linked the most related tasks on similar topics.

Ovidiu Maxiniuc wrote:

It looks like my Ubuntu uses ncurses-6.4+20240113. Both scripts above attempt to patch v6.1_20200708 and fail, because of the code mismatches.

The 2 scripts I mentioned are the same. I keep them in synch (the gcd_systems for our workstations, and FWD for Docker and customer use).

If there are updates made to the ncurses code, we should update those script to match, not make new ones. I see several regressions in the attached version, most notably the handling of sources.list.d. And we should update the level of support on https://proj.goldencode.com/downloads/ncurses/ after testing. I believe the Wiki should be updated to reference the FWD version for our customers use, and not include them as attachments.

Ovidiu, what happens if you use the -a option? I'm just trying to understand when this started happening. Was there a new ncurses positioned?

I did this previously and I did not like it. The -a parameter requires sudo. As result, the result of the patch/build process will be accessible only to super user, not normal user I use 99.999995% (approximate value) of the time.

The ./setup_ncurses6_4-noWide.sh script ends with success, but attempting to compile the FWD will result in the following error:

gcc -c /mnt/nvme2/projects/work/p2j/src/native/process.c -o process.o -DWORD_SIZE_64 -DFWD_VERSION="\"4.0.0_p2j_trunk_16599\"" -I/usr/lib/jvm/java-17-openjdk-amd64/include -I/usr/lib/jvm/java-17-openjdk-amd64/include/linux -I/mnt/nvme2/projects/work/p2j/src/native -I/home/om/projects/gcd_systems/newNcursesPatch/ncurses-6.4+20240113/include -Wall -fpic -DNCURSES_FWD_USE_PATCH
cc1: error: /home/om/projects/gcd_systems/newNcursesPatch/ncurses-6.4+20240113/include: Permission denied
make: *** [makefile:289: process.o] Error 1

Unfortunately, no. The same error when building the native lib.

Of course, I did sudo rm -rf ncurses* before launching the new setup_ncurses6_4-noWide+.sh to be sure the old artefacts are removed.

Here is how it looks after patching:

om@ThinkBook16:~/projects/gcd_systems/newNcursesPatch$ ll ncurses-6.4+20240113/
ls: cannot open directory 'ncurses-6.4+20240113/': Permission denied

• setup_ncurses6_4-noWide.sh
• libncurses_curses_h_in_v6.4+20240113.patch
• libncurses_lib_getch_c_v6.4+20240113.patch

into ~/projects/ncurses and ran the command: ./setup_ncurses6_4-noWide.sh -ap /home/rfb/ncurses

I was prompted for sudo for the apt commands, then the configure ran. I'm left with my build area:

rfb@rfbvm:~/projects/ncurses$ ls -lart
total 3692
-rw-r--r--  1 rfb rfb     729 Jan 16  2024 ncurses_6.4+20240113.orig.tar.gz.asc
-rw-r--r--  1 rfb rfb 3688489 Jan 16  2024 ncurses_6.4+20240113.orig.tar.gz
-rw-r--r--  1 rfb rfb    3963 Apr  8  2024 ncurses_6.4+20240113-1ubuntu2.dsc
-rw-r--r--  1 rfb rfb   49372 Apr  8  2024 ncurses_6.4+20240113-1ubuntu2.debian.tar.xz
-rwxrwx---  1 rfb rfb    7008 Jun 15 08:29 setup_ncurses6_4-noWide.sh
drwxrwxr-x  4 rfb rfb    4096 Jun 15 08:30 ..
-rw-rw----  1 rfb rfb     536 Jun 15 08:30 libncurses_curses_h_in_v6.4+20240113.patch
-rw-rw----  1 rfb rfb    1005 Jun 15 08:30 libncurses_lib_getch_c_v6.4+20240113.patch
drwxrwx---  3 rfb rfb    4096 Jun 15 08:35 .
drwxrwx--- 20 rfb rfb    4096 Jun 15 08:36 ncurses-6.4+20240113

Show /home/rfb/ncurses stuffShow /home/rfb/ncurses stuff

rfb@rfbvm:~/projects/ncurses$ ls -l ~/
total 56
drwxrwxr-x 2 rfb rfb 4096 Jun 11 17:53 bin
-rwxrwx--- 1 rfb rfb 2940 Jun 11 16:25 bootstrap.sh
drwxr-xr-x 2 rfb rfb 4096 Jun 11 16:14 Desktop
drwxr-xr-x 2 rfb rfb 4096 Jun 11 16:14 Documents
drwxr-xr-x 2 rfb rfb 4096 Jun 15 08:31 Downloads
drwxr-xr-x 2 rfb rfb 4096 Jun 11 16:14 Music
drwxr-xr-x 4 rfb rfb 4096 Jun 11 17:56 ncurses
drwxr-xr-x 2 rfb rfb 4096 Jun 11 16:14 Pictures
drwxrwxr-x 4 rfb rfb 4096 Jun 15 08:30 projects
drwxr-xr-x 2 rfb rfb 4096 Jun 11 16:14 Public
drwxrwxr-x 2 rfb rfb 4096 Jun 11 16:35 secure
drwx------ 5 rfb rfb 4096 Jun 14 09:13 snap
drwxr-xr-x 2 rfb rfb 4096 Jun 11 16:14 Templates
drwxr-xr-x 2 rfb rfb 4096 Jun 11 16:14 Videos
rfb@rfbvm:~/projects/ncurses$ ls -l ~/ncurses/
total 8
drwxr-xr-x 2 rfb rfb 4096 Jun 15 08:38 include
drwxr-xr-x 2 rfb rfb 4096 Jun 11 17:56 lib
rfb@rfbvm:~/projects/ncurses$ ls -l ~/ncurses/lib/
total 9284
-rw-r--r-- 1 rfb rfb  138660 Jun 15 08:38 libformt.a
-rw-r--r-- 1 rfb rfb  941394 Jun 15 08:38 libformt_g.a
-rw-r--r-- 1 rfb rfb   72254 Jun 15 08:38 libmenut.a
-rw-r--r-- 1 rfb rfb  512804 Jun 15 08:38 libmenut_g.a
-rw-r--r-- 1 rfb rfb  826268 Jun 15 08:38 libncurses++t.a
-rw-r--r-- 1 rfb rfb  347748 Jun 15 08:38 libncursest.a
-rw-r--r-- 1 rfb rfb  826284 Jun 15 08:38 libncurses++t_g.a
-rw-r--r-- 1 rfb rfb 2892420 Jun 15 08:38 libncursest_g.a
-rw-r--r-- 1 rfb rfb   28434 Jun 15 08:38 libpanelt.a
-rw-r--r-- 1 rfb rfb  347016 Jun 15 08:38 libpanelt_g.a
-rw-r--r-- 1 rfb rfb  407122 Jun 15 08:38 libtinfot.a
-rw-r--r-- 1 rfb rfb 2148208 Jun 15 08:38 libtinfot_g.a
rfb@rfbvm:~/projects/ncurses$ ls -l ~/ncurses/include/
total 972
-rw-r--r-- 1 rfb rfb  4368 Jun 15 08:38 capdefaults.c
-rw-r--r-- 1 rfb rfb 53228 Jun 15 08:38 Caps
-rw-r--r-- 1 rfb rfb 58229 Jun 15 08:38 Caps.aix4
-rw-r--r-- 1 rfb rfb 53920 Jun 15 08:38 Caps.hpux11
-rw-r--r-- 1 rfb rfb 58472 Jun 15 08:38 Caps.keys
-rw-r--r-- 1 rfb rfb 21904 Jun 15 08:38 Caps-ncurses
-rw-r--r-- 1 rfb rfb 55555 Jun 15 08:38 Caps.osf1r5
-rw-r--r-- 1 rfb rfb 43038 Jun 15 08:38 Caps.uwin
-rw-r--r-- 1 rfb rfb     0 Jun 15 08:38 config.h
-rw-r--r-- 1 rfb rfb  1403 Jun 15 08:38 curses.events
-rw-r--r-- 1 rfb rfb 82906 Jun 15 08:38 curses.h
-rw-r--r-- 1 rfb rfb 70322 Jun 15 08:38 curses.head
-rw-r--r-- 1 rfb rfb 71540 Jun 15 08:38 curses.h.in
-rw-r--r-- 1 rfb rfb  8237 Jun 15 08:38 curses.tail
-rw-r--r-- 1 rfb rfb 18077 Jun 15 08:38 curses.wide
-rwxr-xr-x 1 rfb rfb  3018 Jun 15 08:38 edit_cfg.sh
-rw-r--r-- 1 rfb rfb  2969 Jun 15 08:38 eti.h
-rw-r--r-- 1 rfb rfb 18899 Jun 15 08:38 form.h
-rw-r--r-- 1 rfb rfb  3623 Jun 15 08:38 hashed_db.h
-rw-r--r-- 1 rfb rfb   109 Jun 15 08:38 hashsize.h
-rw-r--r-- 1 rfb rfb  2623 Jun 15 08:38 headers
-rw-r--r-- 1 rfb rfb  7063 Jun 15 08:38 Makefile
-rw-r--r-- 1 rfb rfb  5909 Jun 15 08:38 Makefile.in
-rw-r--r-- 1 rfb rfb 11875 Jun 15 08:38 menu.h
-rw-r--r-- 1 rfb rfb  4020 Jun 15 08:38 mf_common.h
-rwxr-xr-x 1 rfb rfb  2681 Jun 15 08:38 MKhashsize.sh
-rwxr-xr-x 1 rfb rfb  5596 Jun 15 08:38 MKkey_defs.sh
-rwxr-xr-x 1 rfb rfb  3339 Jun 15 08:38 MKncurses_def.sh
-rwxr-xr-x 1 rfb rfb  3727 Jun 15 08:38 MKparametrized.sh
-rw-r--r-- 1 rfb rfb 17788 Jun 15 08:38 MKterm.h.awk
-rw-r--r-- 1 rfb rfb 18155 Jun 15 08:38 MKterm.h.awk.in
-rw-r--r-- 1 rfb rfb  3398 Jun 15 08:38 nc_access.h
-rw-r--r-- 1 rfb rfb  4835 Jun 15 08:38 nc_alloc.h
-rw-r--r-- 1 rfb rfb  3418 Jun 15 08:38 nc_mingw.h
-rw-r--r-- 1 rfb rfb  3410 Jun 15 08:38 nc_panel.h
-rw-r--r-- 1 rfb rfb  4139 Jun 15 08:38 nc_string.h
-rw-r--r-- 1 rfb rfb  5087 Jun 15 08:38 nc_termios.h
-rw-r--r-- 1 rfb rfb  4813 Jun 15 08:38 nc_tparm.h
-rw-r--r-- 1 rfb rfb  7832 Jun 15 08:38 ncurses_cfg.h
-rw-r--r-- 1 rfb rfb  3505 Jun 15 08:38 ncurses_cfg.hin
-rw-r--r-- 1 rfb rfb 13788 Jun 15 08:38 ncurses_def.h
-rw-r--r-- 1 rfb rfb  6191 Jun 15 08:38 ncurses_defs
-rw-r--r-- 1 rfb rfb  4183 Jun 15 08:38 ncurses_dll.h
-rw-r--r-- 1 rfb rfb  4200 Jun 15 08:38 ncurses_dll.h.in
lrwxrwxrwx 1 rfb rfb     8 Jun 15 08:38 ncurses.h -> curses.h
-rw-r--r-- 1 rfb rfb  3500 Jun 15 08:38 ncurses_mingw.h
-rw-r--r-- 1 rfb rfb  6743 Jun 15 08:38 nc_win32.h
-rw-r--r-- 1 rfb rfb  4512 Jun 15 08:38 panel.h
-rw-r--r-- 1 rfb rfb  7074 Jun 15 08:38 parametrized.h
-rw-r--r-- 1 rfb rfb  3468 Jun 15 08:38 termcap.h
-rw-r--r-- 1 rfb rfb  3507 Jun 15 08:38 termcap.h.in
-rw-r--r-- 1 rfb rfb  8650 Jun 15 08:38 term_entry.h
-rw-r--r-- 1 rfb rfb 40986 Jun 15 08:38 term.h
-rw-r--r-- 1 rfb rfb 14305 Jun 15 08:38 tic.h
-rw-r--r-- 1 rfb rfb  3177 Jun 15 08:38 unctrl.h
-rw-r--r-- 1 rfb rfb  3222 Jun 15 08:38 unctrl.h.in
-rw-r--r-- 1 rfb rfb  3493 Jun 15 08:38 win32_curses.h

Can you double check? I was on a system that had run the gcd_systems twice, so it was very clean.

I did see that I was missing a sudo for the apt get. When I added it in, I had issues:

./setup_ncurses6_4-noWide.sh: line 99: pushd: ncurses-6.4+20240113: Permission denied
patch: **** Can't open patch file ../libncurses_curses_h_in_v6.4+20240113.patch : No such file or directory
patch: **** Can't open patch file ../libncurses_lib_getch_c_v6.4+20240113.patch : No such file or directory
./setup_ncurses6_4-noWide.sh: line 109: ./configure: No such file or directory
make: *** No targets specified and no makefile found.  Stop.
./setup_ncurses6_4-noWide.sh: line 116: cd: include: No such file or directory
+------------------------------------------------------------------------------+
|                 Patched NCURSES libraries update completed.                  |
cp: cannot stat 'include': No such file or directory
cp: cannot stat 'lib': No such file or directory
|              Please do FULL FWD rebuild to activate the changes.             |
+------------------------------------------------------------------------------+
./setup_ncurses6_4-noWide.sh: line 185: popd: directory stack empty
rfb@rfbvm:~/projects/ncurses$ ls -l
total 3744
-rw-rw----  1 rfb  rfb      536 Jun 15 08:30 libncurses_curses_h_in_v6.4+20240113.patch
-rw-rw----  1 rfb  rfb     1005 Jun 15 08:30 libncurses_lib_getch_c_v6.4+20240113.patch
drwxrwx--- 17 root root    4096 Jun 15 08:58 ncurses-6.4+20240113
-rw-r--r--  1 root root   49372 Apr  8  2024 ncurses_6.4+20240113-1ubuntu2.debian.tar.xz
-rw-r--r--  1 root root    3963 Apr  8  2024 ncurses_6.4+20240113-1ubuntu2.dsc
-rw-r--r--  1 root root 3688489 Jan 16  2024 ncurses_6.4+20240113.orig.tar.gz
-rw-r--r--  1 root root     729 Jan 16  2024 ncurses_6.4+20240113.orig.tar.gz.asc
lrwxrwxrwx  1 rfb  rfb        8 Jun 15 08:58 ncurses.h -> curses.h
-rw-rw----  1 rfb  rfb    59512 Jun 15 08:59 screenlog.0
-rwxrwx---  1 rfb  rfb     7013 Jun 15 08:58 setup_ncurses6_4-noWide.sh

Let me take a closer look.

Roger Borrello wrote:

I did see that I was missing a sudo for the apt get. When I added it in, I had issues:
[...]

Let me take a closer look.

I think the real original problem is you were not including -u om and running as sudo. I recall now that the entire script would need to be run as sudo so that you can achieve the apt-source updates, and the -u allows you to set permissions properly after the ncurses build is performed.

That being said, I do see some bugs in there. There may need to be some refactoring so that it isn't as confusing. The help doesn't make it clear when -u is needed.

Roger,

• -f to get the patch applied;
• -uom to get the ~/.bashrc updated.

This does not require root privileges and, indeed, will create the files/folders with file-access permission only for current user. That is, other users will not be able to read the ncurses binaries, but momentarily, I do not have other users configured on my machine.

I reckon, this is not the best solution. To improve it, the script should be run with rot credentials, but it should also use chmod to make those artefacts system-wide accessible (I guess -s, which seems like the opposite of -u would do that). Please correct me if I'm wrong.

Ovidiu Maxiniuc wrote:

Roger,

The solution which works for me is running the script using -f -uom parameters:

• -f to get the patch applied;
• -uom to get the ~/.bashrc updated.

This does not require root privileges and, indeed, will create the files/folders with file-access permission only for current user. That is, other users will not be able to read the ncurses binaries, but momentarily, I do not have other users configured on my machine.

I reckon, this is not the best solution. To improve it, the script should be run with root credentials, but it should also use chmod to make those artifacts system-wide accessible (I guess -s, which seems like the opposite of -u would do that). Please correct me if I'm wrong.

I really had to scrape the cobwebs on this, because Eugenie had done the heavy lifting so that we could avoid having to patch ncurses with auto_getch_refresh (ref #2660). That's when the -f option was introduced, so that you could use the old method (dynamically linked) instead of the preferred static linking.

The system-wide update option is not used in the Ansible playbook, whether installing on a workstation or server. It is used in the base docker image creation, so that the base development image contains ncurses setup for static linking:

rfb@basedev_ubuntu_2404_latest_container:~/projects/fwd/trunk$ sudo cat /etc/sudoers.d/10-ncurses 
[sudo] password for rfb: 
Defaults env_keep += NCURSES_FWD_STATIC
Defaults env_keep += NCURSES_FWD_PTHREADS
rfb@basedev_ubuntu_2404_latest_container:~/projects/fwd/trunk$ sudo cat /etc/profile.d/10-ncurses.sh

# set up thread-safe NCURSES root location
# and set up thread-safe NCURSES_FWD_PTHREADS variable
export NCURSES_FWD_STATIC="/opt/ncurses" 
export NCURSES_FWD_PTHREADS=true

That is required so that any environment that is started under the Docker image contains the environment variables. You shouldn't ever need to run with that option.

The -a option is there so that the sources list can be handled by the script itself, and not have to be done outside on your own. This is where there might need to be some better handling of the privileges, because you cannot handle apt without root. You might be able to get away with root for the entire script, if the user setup is done properly.

Most likely, I used -s last week (possibly before that also). But I think I 'repaired' the damage by dropping the artefacts which required account elevation. OTOH, -a seem logical, but momentarily does not work for me for the reasons you also noted in #11515-16.

As noted above, -f -uom works for me currently. But, from #2660, I understand that the auto_getch_refresh is not mandatory any more? Not very clear from the wikis. If this is the case, I/we can safely switch to pthread alternative and drop the patching resources completely.

I forgot to mention that I updated the usage:

Usage: ./setup_ncurses6x.sh [-p<path>] [-fsad] [-u<user>]
Where:
p    = Use specific path instead of current directory
f    = Override thread-safe dynamically linked version with statically linked patched version containing auto_getch_refresh
s    = Set system-wide environment instead of just current user
a    = Handle setup of /etc/apt/sources.list and restore when done (requires sudo)
u    = Update the given user's .bashrc instead of current running user. Typically for when run under sudo
d    = Dry run. Just show commands.

Roger Borrello wrote:

Ovidiu Maxiniuc wrote:

Most likely, I used -s last week (possibly before that also). But I think I 'repaired' the damage by dropping the artefacts which required account elevation. OTOH, -a seem logical, but momentarily does not work for me for the reasons you also noted in #11515-16.

As noted above, -f -uom works for me currently. But, from #2660, I understand that the auto_getch_refresh is not mandatory any more? Not very clear from the wikis. If this is the case, I/we can safely switch to pthread alternative and drop the patching resources completely.

I have completed a Claude code review, and there were a lot of problem spots. The updates are in the attached. I'd love a review, since you've had your nose in this. Eugenie, are you also able to review?

I see that you added the --disable-widec for the patched build. I don't have a problem with that, as I don't know where we would actually need it. We really won't need a separate version, so I will be renaming this to setup_ncurses6x.sh if accepted. Regarding the updated patching, this is also a call from Eugenie and/or Greg, because on the one hand, we should keep updated with NCURSES updates. But on the other, are we not trying to deprecate usage of static linking?

I'm OK with changes.

About --disable-widec. This is mandatory since Ubuntu 24.0. The reason is by default the wide char version of NCURSES is installed on 24.04. You can see it with any package manager. Previously (22.04) it was not true. So the if wide char option is not specified the 24.04 think the wide char feature is enabled. The FWD has no support for wide char so we have to explicitly disable it with NCURSES config. Otherwise wrong libraries will be compiled with wrong name (with *w.* suffix).

Roger,
The latest patches and the script attached to this task only work with Ubuntu 24.4. Older revisions of the OS will not be processed correctly. Shouldn't we have some selector for them?

Also, the patches (if they will be kept) will have to be fetched from GC webpage, because (temporarily, for debugging) the script has the download disabled but expects to find them locally.

We could add the logic in the script like below. If we confirm the patch levels are correct for the releases noted:

# patching the source files
$dry pushd ncurses-6.* > /dev/null || { echo "Unable to enter NCURSES source directory (ncurses-6.*)!"; exit 1; }
if [[ "$patch_ncurses" == true ]]; then
   case "$release" in
      focal|jammy)   # Ubuntu 20.04 / 22.04 (ncurses 6.2 / 6.3)
          patch_h="ncurses_curses_h_in_v6.1_20200708.patch" 
          patch_c="ncurses_lib_getch_c_v6.1_20200708.patch" ;;
      noble)         # Ubuntu 24.04 (ncurses 6.4)
          patch_h="ncurses_curses_h_in_v6.4+20240113.patch" 
          patch_c="ncurses_lib_getch_c_v6.4+20240113.patch" ;;
      *)             # unknown / newer - assume newest, but say so
          echo "Warning: unrecognized release '$release'; using newest NCURSES patch set" >&2
          patch_h="ncurses_curses_h_in_v6.4+20240113.patch" 
          patch_c="ncurses_lib_getch_c_v6.4+20240113.patch" ;;
   esac

   $dry wget https://proj.goldencode.com/downloads/ncurses/${patch_h} || { echo "Failed to download ${patch_h} patch!"; exit 1; }
   $dry wget https://proj.goldencode.com/downloads/ncurses/${patch_c} || { echo "Failed to download ${patch_c} patch!"; exit 1; }
   $dry patch include/curses.h.in ${patch_h}
   $dry patch ncurses/base/lib_getch.c ${patch_c}
   $dry ./configure --with-termlib CFLAGS='-fPIC -O2' --with-abi-version=6 --disable-widec
else
   $dry ./configure --with-termlib CFLAGS='-fPIC -O2' --with-abi-version=6 --disable-widec --with-pthread --enable-pthreads-eintr
fi
$dry make
make_rc=$?
if [ "$make_rc" -ne 0 ] && [ -z "$dry" ]; then
   echo "NCURSES build failed (make returned $make_rc); aborting before any environment changes." >&2
   exit 1
fi

Can we get the ncurses_curses_h_in_v6.4+20240113.patch and ncurses_lib_getch_c_v6.4+20240113.patch files uploaded to https://proj.goldencode.com/downloads/ncurses/ so we can get this task closed?

You have sufficient rights on projsrv01 to do it.

Greg Shah wrote:

You have sufficient rights on projsrv01 to do it.

I'll take that as approval (whereas if you did it, it would certainly be approved :-)

• the name should specify the ncurses exact version (like I did above with setup_ncurses6.4.sh) or
• use the OS version instead: setup_ncurses_24.4.sh. This assumes this OS is always using the same ncurses library.

Shouldn't we then put the script in same location for download? Of course, after enabling the wget lines for the resources Roger has just uploaded.

Why are you changing the naming convention? Please rename the patch files to match the convention used for the older ncurses patch file names.

I think we should have different scripts for each OS. At least for latest 2-3 LTS.

We've always been able to handle multiple versions (of OS and of NCURSES) with a single script. Let's stick with that approach.

Greg Shah wrote:

Why are you changing the naming convention? Please rename the patch files to match the convention used for the older ncurses patch file names.

I was just using what I was given... here's the newly named files, in line:

-r-xr-x--- 1 www-data www-data  561 Nov 11  2016 ncurses_curses_h_in_20060828.patch
-r-xr-x--- 1 www-data www-data  899 Nov 11  2016 ncurses_curses_h_in_v5.9_20160219.solaris.patch
-r-xr-x--- 1 www-data www-data  561 Jul  9  2020 ncurses_curses_h_in_v6.1_20200708.patch
-r-xr-x--- 1 www-data www-data  536 Jun 25 12:35 ncurses_curses_h_in_v6.4_20240113.patch
-r-xr-x--- 1 www-data www-data 1027 Nov 11  2016 ncurses_lib_getch_c_20060828.patch
-r-xr-x--- 1 www-data www-data 1044 Nov 11  2016 ncurses_lib_getch_c_v5.7_20090512.patch
-r-xr-x--- 1 www-data www-data 1044 Nov 11  2016 ncurses_lib_getch_c_v5.9_20160219.solaris.patch
-r-xr-x--- 1 www-data www-data 1044 Jul  9  2020 ncurses_lib_getch_c_v6.1_20200708.patch
-r-xr-x--- 1 www-data www-data 1005 Jun 25 12:35 ncurses_lib_getch_c_v6.4_20240113.patch

I'll update the script to match.

Here's the code block where we decide which to use... we don't have a method to pull in the very old versions for patching.

$dry pushd ncurses-6.* > /dev/null || { echo "Unable to enter NCURSES source directory (ncurses-6.*)!"; exit 1; }
if [[ "$patch_ncurses" == true ]]; then
   case "$release" in
      focal|jammy)   # Ubuntu 20.04 / 22.04 (ncurses 6.2 / 6.3)
          patch_h="ncurses_curses_h_in_v6.1_20200708.patch" 
          patch_c="ncurses_lib_getch_c_v6.1_20200708.patch" ;;
      noble)         # Ubuntu 24.04 (ncurses 6.4)
          patch_h="ncurses_curses_h_in_v6.4_20240113.patch" 
          patch_c="ncurses_lib_getch_c_v6.4_20240113.patch" ;;
      *)             # unknown / newer - assume newest, but say so
          echo "Warning: unrecognized release '$release'; using newest NCURSES patch set" >&2
          patch_h="ncurses_curses_h_in_v6.4_20240113.patch" 
          patch_c="ncurses_lib_getch_c_v6.4_20240113.patch" ;;
   esac

   $dry wget https://proj.goldencode.com/downloads/ncurses/${patch_h} || { echo "Failed to download ${patch_h} patch!"; exit 1; }
   $dry wget https://proj.goldencode.com/downloads/ncurses/${patch_c} || { echo "Failed to download ${patch_c} patch!"; exit 1; }
   $dry patch include/curses.h.in "${patch_h}" 
   $dry patch ncurses/base/lib_getch.c "${patch_c}" 
else
   # Add configure flags for thread-safe dynamically linked ncurses
   ncurses_configure_flags+=(--with-pthread --enable-pthreads-eintr)
fi

Roger Borrello wrote:

Greg Shah wrote:

Why are you changing the naming convention? Please rename the patch files to match the convention used for the older ncurses patch file names.

I was just using what I was given... here's the newly named files, in line:
[...]
I'll update the script to match.

That's my fault. My apologies. I used the names from downloaded library instead of GC convention. Thank you Roger for fixing the file names. The script still used ncurses_curses_h_in_v6.4+20240113.patch instead of ncurses_curses_h_in_v6.4_20240113.patch in r195 although in note-38 and r197 they look OK. Nice update!

Ovidiu Maxiniuc wrote:

That's my fault. My apologies. I used the names from downloaded library instead of GC convention. Thank you Roger for fixing the file names. The script still used ncurses_curses_h_in_v6.4+20240113.patch instead of ncurses_curses_h_in_v6.4_20240113.patch in r195 although in note-38 and r197 they look OK. Nice update!

No problem... The version checked into gcd_systems is correct. We need to include that in a branch.

=== modified file 'roles/ncurses/files/setup_ncurses6x.sh'
--- old/roles/ncurses/files/setup_ncurses6x.sh  2026-06-25 17:52:27 +0000
+++ new/roles/ncurses/files/setup_ncurses6x.sh  2026-06-25 19:05:57 +0000
@@ -128,12 +128,12 @@
           patch_h="ncurses_curses_h_in_v6.1_20200708.patch" 
           patch_c="ncurses_lib_getch_c_v6.1_20200708.patch" ;;
       noble)         # Ubuntu 24.04 (ncurses 6.4)
-          patch_h="ncurses_curses_h_in_v6.4+20240113.patch" 
-          patch_c="ncurses_lib_getch_c_v6.4+20240113.patch" ;;
+          patch_h="ncurses_curses_h_in_v6.4_20240113.patch" 
+          patch_c="ncurses_lib_getch_c_v6.4_20240113.patch" ;;
       *)             # unknown / newer - assume newest, but say so
           echo "Warning: unrecognized release '$release'; using newest NCURSES patch set" >&2
-          patch_h="ncurses_curses_h_in_v6.4+20240113.patch" 
-          patch_c="ncurses_lib_getch_c_v6.4+20240113.patch" ;;
+          patch_h="ncurses_curses_h_in_v6.4_20240113.patch" 
+          patch_c="ncurses_lib_getch_c_v6.4_20240113.patch" ;;
    esac

    $dry wget https://proj.goldencode.com/downloads/ncurses/${patch_h} || { echo "Failed to download ${patch_h} patch!"; exit 1; }