Project

General

Profile

Feature #1598

Feature #1596: complete big decimal implementation

shift LOG implementation (MathOps.log()) to BigDecimal

Added by Greg Shah over 11 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Start date:
01/27/2014
Due date:
01/29/2014
% Done:

100%

Estimated time:
6.00 h
billable:
No
vendor_id:
GCD

hc_upd20140212a.zip (29.2 KB) Hynek Cihlar, 02/12/2014 04:33 PM

hc_upd20140214a.zip (59.2 KB) Hynek Cihlar, 02/14/2014 07:13 AM

History

#1 Updated by Greg Shah over 11 years ago

  • Target version set to Milestone 7

#2 Updated by Greg Shah almost 11 years ago

  • Target version changed from Milestone 7 to Milestone 11

#3 Updated by Greg Shah almost 11 years ago

  • Start date changed from 10/19/2012 to 08/07/2013
  • Due date set to 08/07/2013
  • Assignee set to Ovidiu Maxiniuc

#4 Updated by Greg Shah about 10 years ago

  • Start date changed from 08/07/2013 to 01/27/2014
  • Due date changed from 08/07/2013 to 01/29/2014
  • Assignee changed from Ovidiu Maxiniuc to Hynek Cihlar

#5 Updated by Hynek Cihlar about 10 years ago

  • Status changed from New to WIP

#6 Updated by Hynek Cihlar about 10 years ago

The attached file contains log function implementation and related changes for review.

The implemented log function yields the same outputs as the Progress native log function. The only exception is the logarithm of 1 to base 1. In this case Progress returns zero instead of the expected unknown value.

Testcases committed in the file testcases/uast/math/log.p.

#7 Updated by Greg Shah about 10 years ago

Code Review 0212a

It looks pretty good. Fix these minor issues and get it tested:

1. I'd prefer to add an abstract NumberType.toBigDecimal() instead of adding a static helper to Utils. The sub-classes can implement the non-lossy implementation directly.

2. MathOps copyright end year needs to be update to 2014.

#8 Updated by Hynek Cihlar about 10 years ago

Introduced toBigDecimal abstract method in NumberType and fixed the file headers. The code changes passed regression testing.

Please, review.

#9 Updated by Greg Shah about 10 years ago

Code Review 0214a

The changes look good. You can check them in and distribute them.

#10 Updated by Hynek Cihlar about 10 years ago

Committed to bzr revision 10466.

#11 Updated by Greg Shah about 10 years ago

  • % Done changed from 0 to 100
  • Status changed from WIP to Closed

#12 Updated by Greg Shah over 7 years ago

  • Target version changed from Milestone 11 to Cleanup and Stablization for Server Features

Also available in: Atom PDF