FWD » Core Development » Base Language

02/12/2014

06:27 PM Feature #1598: shift LOG implementation (MathOps.log()) to BigDecimal

Code Review 0212a
It looks pretty good. Fix these minor issues and get it tested:
1. I'd prefer to add an abst... Greg Shah

04:33 PM Feature #1598: shift LOG implementation (MathOps.log()) to BigDecimal

The attached file contains @log@ function implementation and related changes for review.
The implemented @log@ fun... Hynek Cihlar

05:23 PM Feature #1634: implement full native library (.so or DLL) support

> or better:... Greg Shah

03:59 PM Feature #1597 (Closed): shift SQRT implementation (MathOps.sqrt()) to BigDecimal

Greg Shah

02:04 PM Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal

Committed to revision 10461. Hynek Cihlar

10:37 AM Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal

Code Review 0209a
The code looks good. Please commit and distribute it. Greg Shah

10:23 AM Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal

The attached file is the final version.
Note, that the previously added condition of @sqrt(?) == 1@ was removed. ... Hynek Cihlar

01:26 AM Feature #2208: create a java application running web services for testing purposes

Evgeny Kiselev wrote:
> Yes, you are right.
If you think you can solve this in 2-4 hours, then go ahead and solve i... Constantin Asofiei

02/11/2014

05:48 PM Feature #2208: create a java application running web services for testing purposes

Yes, you are right. Evgeny Kiselev

02:12 PM Feature #2208: create a java application running web services for testing purposes

OK, I think I understand your problem: you are you using embedded AXIS2 web server, which does not support HTTPS. An... Constantin Asofiei

08:17 PM Feature #2208: create a java application running web services for testing purposes

I have problem with SSL. It's not possible to do it in the internal Axis2 web server(SimpleHttpServer).
Here is a ... Evgeny Kiselev

05:47 PM Feature #1624: add support for PUT CONTROL

Code Review 0208a
1. Does the @Steam.generateFormattedText()@ have implications when the statement is not PUT CONT... Greg Shah

02/10/2014

08:09 PM Feature #1624: add support for PUT CONTROL

1) Added conversion for @COPY-LOB@ from file to memptr
2) Added implementation for @COPY-LOB@
3) Added for @RAW@ ty... Evgeny Kiselev

02/06/2014

10:17 AM Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal

Looks great! Greg Shah

10:02 AM Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal

Yes, the "4GL" is a typo, thanks for catching it. I am attaching a fix and sending it to regression test. Hynek Cihlar

08:15 AM Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal

Code Review 0205a
This looks good.
My only question is about this table:... Greg Shah

07:20 PM Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal

The input of one is covered by the initial approximation, but yes it won't hurt if stated explicitly.
New in the a... Hynek Cihlar

02/05/2014

09:03 AM Feature #1624: add support for PUT CONTROL

> except wrong conversion of @copy-lob from file "test_put_control.txt" to m.@. P2J convert it's in uncompilable code... Greg Shah

07:58 PM Feature #1624: add support for PUT CONTROL

... Evgeny Kiselev

02/03/2014

06:57 PM Feature #1624: add support for PUT CONTROL

The first testcase above has a bug (you write out 257 bytes but size the memptr at 256).
Also, it doesn't test the... Greg Shah

07:15 PM Feature #1624: add support for PUT CONTROL

updated tests.... Evgeny Kiselev

06:46 PM Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal

Code Review 0203b
Overall, this is very good.
1. Should we put a quick out for BigDecimal.ONE?
2. Add javado... Greg Shah

04:45 PM Feature #1597 (Review): shift SQRT implementation (MathOps.sqrt()) to BigDecimal

Hynek Cihlar

09:51 AM Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal

Attached file changes the precision of the sqrt algorithm to be defined by @decimal.MAX_SCALE@. Hynek Cihlar

05:06 AM Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal

I didn't realize the evaluator already casts the operands to proper types. Attached is the updated code.
Hynek Cihlar

06:25 PM Feature #1599: shift EXP implementation (MathOps.pow()) to BigDecimal

There are 3 other versions of pow() and these all resolve down to using @Math.pow()@ and @double@. These need to be ... Greg Shah

04:49 PM Feature #1599: shift EXP implementation (MathOps.pow()) to BigDecimal

The title of the issue mentions pow and exp. @MathOps@ contains only @pow@ method, but that is already using @BigDeci... Hynek Cihlar

04:44 PM Feature #1598 (WIP): shift LOG implementation (MathOps.log()) to BigDecimal

Hynek Cihlar

02/02/2014

06:42 PM Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal

Attached are the changes for initial review.
The implemented algorithm yields the same results as the native Progr... Hynek Cihlar

01/31/2014

09:20 AM Feature #1624: add support for PUT CONTROL

It is close. Some things to add:
1. I think the testing code is too dependent upon using a delimiter. In a scena... Greg Shah

08:03 AM Feature #1624: add support for PUT CONTROL

Is this test correct ?... Evgeny Kiselev

06:45 AM Feature #1624 (WIP): add support for PUT CONTROL

Evgeny Kiselev

01/30/2014

02:33 PM Feature #2145: eliminate program-name limitations

> This suggests that looking into the java stack trace is not correct.
Yes. At the time it was originally coded, ... Greg Shah

01:46 PM Feature #2145: eliminate program-name limitations

This suggests that looking into the java stack trace is not correct. Instead, @ControlFlowOps@ should keep a stack f... Constantin Asofiei

01:05 PM Feature #2145: eliminate program-name limitations

To understand the limitations of the P2J @PROGRAM-NAME@ implementation, please see the JavaDoc for @EnvironmentOps.ge... Greg Shah

01/29/2014

12:27 PM Feature #1634: implement full native library (.so or DLL) support

... continued
*common-progress.rules*
is good except for the fact that maybe we should make the condition at line ... Ovidiu Maxiniuc

01/28/2014

04:23 PM Feature #1634: implement full native library (.so or DLL) support

Greg Shah wrote:
> ...
> Ovidiu: please review the rules/include/* changes, in regard to assign trigger var def sup... Ovidiu Maxiniuc

07:54 PM Feature #1634: implement full native library (.so or DLL) support

OK. Now we are completely using our own libffi Windows builds.
Building libffi libraries from sources using MSYS a... Eugenie Lyzenko

01/27/2014

05:59 PM Feature #1634: implement full native library (.so or DLL) support

> What if to build libffi in mingw we have to set up MSYS? Is it acceptable?
Yes. But we would only use that envi... Greg Shah

05:44 PM Feature #1634: implement full native library (.so or DLL) support

Greg, the question. What if to build libffi in mingw we have to set up MSYS? Is it acceptable? Eugenie Lyzenko

02:34 PM Feature #1634: implement full native library (.so or DLL) support

The update evl_upd20140127a.zip committed in bzr as 10456. No regression testing required, only Windows syntax code w... Eugenie Lyzenko

01:38 PM Feature #1634: implement full native library (.so or DLL) support

Conversion regression testing for ges_upd20140127a.zip has passed. No change occurs in the output. This has been ch... Greg Shah

01:31 PM Feature #1634: implement full native library (.so or DLL) support

Code Review evl_upd20140127.zip
The change is fine. Check it in and distribute it. Then post the revision number... Greg Shah

01:02 PM Feature #1634: implement full native library (.so or DLL) support

The updates fixes compilation error on Wndows. Also the binaries allow to build p2j.dll on Windows. Has both 64-bit a... Eugenie Lyzenko

11:27 AM Feature #1634: implement full native library (.so or DLL) support

This update has some important fixes to make the commons cases work. There is still at least 1 known problem (dealin... Greg Shah

08:49 AM Feature #1634: implement full native library (.so or DLL) support

Do you have the compilation fixes ready now? If so, please upload them for review.
Have you resolved the way to b... Greg Shah

01/25/2014

11:04 AM Feature #1634: implement full native library (.so or DLL) support

> Eugenie: it is OK to get the compilation issues and the libffi.dll built properly. But after that, pause your work ... Eugenie Lyzenko

09:37 AM Feature #1634: implement full native library (.so or DLL) support

Eugenie: it is OK to get the compilation issues and the libffi.dll built properly. But after that, pause your work o... Greg Shah

01/24/2014

06:43 PM Feature #1597 (WIP): shift SQRT implementation (MathOps.sqrt()) to BigDecimal

Hynek Cihlar

08:29 AM Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal

I don't know the answer. Often, if the input is a decimal value, then the output can have the same precision. Other... Greg Shah

07:58 AM Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal

What is the expected precision of the algorithm? Hynek Cihlar

06:27 PM Feature #1634: implement full native library (.so or DLL) support

Building on Windows notes:
The first thing after including ffi.h into compilation preocess is to change the library_... Eugenie Lyzenko

09:46 PM Feature #1634 (Closed): implement full native library (.so or DLL) support

Greg Shah

09:37 PM Feature #1634: implement full native library (.so or DLL) support

The CTRL-C 3-way tests failed (expected) and there were 5 failures in @tc_job*@ and @tc_dc*@ tests (1 of which always... Greg Shah

08:33 AM Feature #1596: complete big decimal implementation

We had moved from use of double to BigDecimal in the past because we found deviations from the 4GL implementation tha... Greg Shah

09:47 PM Feature #1641 (Closed): implement SAX XML support

Greg Shah

08:33 PM Feature #1641: implement SAX XML support

SAX testcases committed at bzr revision 1088. Evgeny Kiselev

09:46 PM Feature #1988 (Closed): runtime support for SAX

Greg Shah

09:45 PM Support #2234: test and fix native API support on Windows

Put all history in #1634. Greg Shah

09:43 PM Support #2234 (Closed): test and fix native API support on Windows

Greg Shah

09:45 PM Support #2233: test and fix the native API support on Linux

Put all history in #1634. Greg Shah

09:43 PM Support #2233 (Closed): test and fix the native API support on Linux

Greg Shah

09:41 PM Feature #2121 (Closed): implement Java runtime support for native libraries

Greg Shah

09:41 PM Feature #1959 (Closed): implement JNI runtime support for native libraries

Greg Shah

01/23/2014

04:51 PM Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server

Using the server created in #2208, test the web services using wrapped mode and fix any found problems.
Also, fix ... Constantin Asofiei

04:45 PM Feature #2232 (Closed): finish testing the wrapped mode using the web services exposed by the tes...

Constantin Asofiei

04:41 PM Feature #1644 (Closed): implement SOAP support

Greg Shah

04:40 PM Feature #1995 (Closed): runtime support for SOAP

Greg Shah

04:40 PM Feature #1645 (Closed): implement web services support

Greg Shah

04:39 PM Feature #2022 (Closed): runtime support for web services

Greg Shah

12:57 PM Feature #1634: implement full native library (.so or DLL) support

This is a version with more fixes, but it is not finished. Still, it is a good version to put into regression testin... Greg Shah

10:29 AM Feature #1634: implement full native library (.so or DLL) support

This version fixes a conversion regression found in testing. It has passed conversion regression testing and it also... Greg Shah

07:37 PM Feature #1634: implement full native library (.so or DLL) support

This is a version that has many fixes implemented. Many native API use cases are now working, but not all use cases ... Greg Shah

01/22/2014

12:30 PM Feature #1634: implement full native library (.so or DLL) support

This update resolves all issues from the code review and merges to the bzr 10445 level (the latest at this writing).
... Greg Shah

09:50 AM Feature #2013 (Closed): implement the SELF system handle

Greg Shah

09:21 AM Feature #2013: implement the SELF system handle

Passed conversion and runtime testing, committed to bzr rev 10445. Constantin Asofiei

09:50 AM Feature #2015 (Closed): runtime support for SELF system handle

Greg Shah

01/21/2014

04:57 PM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...

First of all I need to understand the problem. As we can see from the tests Java program does not clear error list, b... Vadim Gindin

11:29 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Based on the NO-ECHO testcases created in #1629, test the P2J implementation for NO-ECHO and make any functional addi... Greg Shah

04:19 AM Feature #1645: implement web services support

Evgeny Kiselev wrote:
> Code Review 0116a:
> 1) @com.goldencode.p2j.xml.XNodeRefImpl#getOwnerDocument()@
> Does @R... Constantin Asofiei

01/20/2014

02:13 PM Feature #1645: implement web services support

Code Review 0116a:
1) @com.goldencode.p2j.xml.XNodeRefImpl#getOwnerDocument()@
Does @RESTRICTED_DOCUMENT@ can affai... Evgeny Kiselev

09:52 AM Feature #2013: implement the SELF system handle

Code Review 0120a
I am fine with the changes. Commit and distribute them when they pass testing. Greg Shah

09:18 AM Feature #2013: implement the SELF system handle

This removes NullWidget and makes both SELF and FOCUS act as real handles. Manual testing looks OK, waiting for the a... Constantin Asofiei

09:17 AM Feature #2015 (WIP): runtime support for SELF system handle

Constantin Asofiei

01/19/2014

10:36 AM Feature #1634: implement full native library (.so or DLL) support

I haven't addressed the code review items yet. This is a version with a fix for the package names which match reserv... Greg Shah

01/18/2014

05:34 AM Feature #1634: implement full native library (.so or DLL) support

Review for @0117b.zip@:
* @collect_names.rules@
- line 406: this @<rule>downPath("KW_OUTPUT") or downPath("KW_RETUR... Constantin Asofiei

01/17/2014

06:09 PM Feature #1634: implement full native library (.so or DLL) support

Updated version with conversion fixes and some added functionality to make the testcases work (hex-decode and hex-enc... Greg Shah

02:40 PM Feature #1634: implement full native library (.so or DLL) support

> The only question is what about ffi.h header?
On Ubuntu, install this package:
sudo apt-get install libffi-de... Greg Shah

02:10 PM Feature #1634: implement full native library (.so or DLL) support

> Eugenie: please review the filesys.c change as well as the other native code changes.
I'm OK with changes. The o... Eugenie Lyzenko

10:41 AM Feature #1634: implement full native library (.so or DLL) support

Complete first implementation. I am about to start testing, so this is likely to change. But it has all features ful... Greg Shah

01/16/2014

03:12 PM Feature #1634: implement full native library (.so or DLL) support

Greg Shah wrote:
> Constantin: What is the easiest way to determine if a given BDT[] instance is an indeterminate le... Constantin Asofiei

02:33 PM Feature #1634: implement full native library (.so or DLL) support

Constantin: What is the easiest way to determine if a given BDT[] instance is an indeterminate length array? I have ... Greg Shah

10:50 AM Bug #1969 (Closed): buffer names in get-signature

Greg Shah

10:36 AM Bug #1969: buffer names in get-signature

Committed to bzr revision 10440. Constantin Asofiei

10:06 AM Bug #1969: buffer names in get-signature

> I think you missed something in the SchemaDictionary change:
You're right, I missed that. Sorry.
I'm fine wi... Greg Shah

10:03 AM Bug #1969: buffer names in get-signature

Greg Shah wrote:
> 1. The SchemaDictionary lowercases the name before it saves off the legacy_name annotation, but s... Constantin Asofiei

09:25 AM Bug #1969: buffer names in get-signature

Code Review 0115a
1. The SchemaDictionary lowercases the name before it saves off the legacy_name annotation, but ... Greg Shah

08:43 AM Bug #1969 (Review): buffer names in get-signature

PS: conversion testing has passed, runtime testing is not needed. Constantin Asofiei

08:43 AM Bug #1969 (WIP): buffer names in get-signature

Attached update fixes the BUFFER and TABLE parameter names reported by GET-SIGNATURE.
The legacy, case-sensitive n... Constantin Asofiei

07:19 AM Feature #1645: implement web services support

Committed to bzr revision 10439. Constantin Asofiei

06:42 AM Feature #1645: implement web services support

Code Review 0116a
I am fine with the changes. Go ahead and check it in.
Evgeny: I still want you to review t... Greg Shah

03:27 AM Feature #1645: implement web services support

and the update... Constantin Asofiei

03:26 AM Feature #1645: implement web services support

main part of runtime testing has passed. need to double check the CTRL-C part.
Attached version is merged with rev... Constantin Asofiei

06:55 AM Feature #1641: implement SAX XML support

Please check in your SAX testcases. Greg Shah

07:39 PM Feature #1641: implement SAX XML support

Committed to bzr revision 10438. Evgeny Kiselev

01/15/2014

01:53 AM Feature #1641: implement SAX XML support

Review for 0113a.zip: the update is OK, but please make the @XCommonImpl.isValid@ field protected instead of package-... Constantin Asofiei

08:40 PM Feature #1641: implement SAX XML support

Constantin Asofiei wrote:
> Review for 0112a.zip:
> * all files are missing history entries. When you add history e... Evgeny Kiselev