Harness

It seems that there is a misprint in the com.goldencode.harness.test.SendKey. The format specification SPEC3 is:

   /** Another format specification for drain mode. */
   private static final String SPEC3 = "timeout occurred before all output " +
                                       "could be read (%d bytes read)";

and it is used as:

                  reason = String.format(SPEC3, reason, newCount);

which results in a confusing error message. I suggest to modify the format like this:

   private static final String SPEC3 = "timeout occurred before all output " +
                                       "could be read [%s] (%d bytes read)";

created task branch 2639a

Fixed format literal.
Commited to branch 2639a, revno 8

Code Review Task Branch 2639a Revision 8

It looks good. Merge to trunk when it passes your testing.

It seems that the changed harness works fine. Can I merge my changes?
Thank you.

Yes, please do. As with #2603, when you send out the notification email, make sure you explain to people that how they can pull down the latest harness code to their devsrv01 testing environments.

The task branch passed regression testing and was merged with the harness trunk and checked in as revision 8.

make sure you explain to people that how they can pull down the latest harness code to their devsrv01 testing environments.

I think you forgot this part.

Also: please archive both task branches 2603a and 2639a.

Greg Shah wrote:

make sure you explain to people that how they can pull down the latest harness code to their devsrv01 testing environments.

I think you forgot this part.

Also: please archive both task branches 2603a and 2639a.

Sorry, I've sent an additional mail. Actually I've archived 2603a and 2639a. There was however 2603aa branch which I've created by mistake. It is removed now.