Project

General

Profile

Bug #2834

Bug #2677: fix drawing and functional differences between P2J GUI and 4GL GUI

GUI combo-box multiple drop-downs can be shown

Added by Hynek Cihlar over 8 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Eugenie Lyzenko
Target version:
FWD - GUI Support for a Complex ADM2 App
Start date:
Due date:
% Done:

100%

billable:
No
vendor_id:
GCD
case_num:

evl_upd20151118b.zip - Fix for the bug (6.33 KB) Eugenie Lyzenko, 11/18/2015 02:39 PM

History

#1 Updated by Hynek Cihlar over 8 years ago

Steps to recreate:
Activate drop-down in one combo-box. When drop-down visible click on a the drop-down button of a second combo-box.

#2 Updated by Greg Shah over 8 years ago

This issue is in the trunk?

#3 Updated by Hynek Cihlar over 8 years ago

Greg Shah wrote:

This issue is in the trunk?

Yes.

#4 Updated by Greg Shah over 8 years ago

  • Start date deleted (11/09/2015)
  • Assignee set to Eugenie Lyzenko
  • Target version set to Milestone 12

#5 Updated by Eugenie Lyzenko over 8 years ago

The issue investigation has been performed. The original event processing logic need to be restored inside ScrollableSelectionListGuiImpl. The idea to handle the condition like this is to emit ESCAPE key for drop-down when pressing mouse outside the drop-down. This cause the drop-down to be closed because it generates the LEAVE event. After processing LEAVE the proper exitDropDown() is called automatically. If someone has consideration for why we need this extra exit call - let me know please.

So we do not need to explicitly call exitDropDown() at the end of the leaveAndRepostMouse(). Moreover this method is very sensitive to the event ordering. It is not correct to call exitDropDown() twice for drop-down.

The attached fix resolves this issue.

#6 Updated by Greg Shah over 8 years ago

Code Review evl_upd20151118b.zip

(Originally posted to #2831 by accident)

I am fine with the change. My only concern is what it may regress, since the code was put there deliberately by Constantin in ScrollableSelectionListGuiImpl.java change 008 (rev 10944).

Constantin: what do you think?

#7 Updated by Constantin Asofiei over 8 years ago

Greg Shah wrote:

Code Review evl_upd20151118b.zip

(Originally posted to #2831 by accident)

I am fine with the change. My only concern is what it may regress, since the code was put there deliberately by Constantin in ScrollableSelectionListGuiImpl.java change 008 (rev 10944).

Constantin: what do you think?

I'm OK with the change.

#8 Updated by Greg Shah over 8 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

Update evl_upd20151119a.zip (for both #2833 and #2834) committed to 2677a as revision 11071.

#9 Updated by Greg Shah over 7 years ago

  • Target version changed from Milestone 12 to GUI Support for a Complex ADM2 App

Also available in: Atom PDF