FWD

The following code::

DEF INPUT PARAM inParam AS INT NO-UNDO.
DEF OUTPUT PARAM ouResult AS INT NO-UNDO.

FUNCTION test-func RETURNS INT (INPUT ipParam AS INT):

  DEF BUFFER bf_TestDoc FOR TestDoc.

  DEF VAR vCnt AS INT NO-UNDO.

  FOR EACH bf_TestDoc NO-LOCK
     WHERE bf_TestDoc.DocID >= inParam
     :
     ACCUMULATE bf_TestDoc.DocID (COUNT).
  END.

  RETURN ACCUM COUNT bf_TestDoc.DocID.

END.

ouResult = test-func(inParam).

is translated to the following non-compilable code:

public class TestProc3
{
   integer inParam;

   FieldReference fieldRef0 = new FieldReference(bfTestdoc, "docid");

   CountAccumulator accumCount0 = new CountAccumulator();

   /**
    * External procedure (converted to Java from the 4GL source code
    * in wd_test/test.proc3.p).
    */
   public void execute(final integer _inParam, final integer ouResult)
   {
      integer inParam = TypeFactory.initInput(_inParam);

      externalProcedure(TestProc3.this, new Block((Init) () -> 
      {
         TestProc3.this.inParam = inParam;
         TypeFactory.initOutput(ouResult);
      }, 
      (Body) () -> 
      {
         ouResult.assign(testFunc(inParam));
      }));
   }

   public integer testFunc(final integer _ipParam)
   {
      integer ipParam = TypeFactory.initInput(_ipParam);
      Testdoc.Buf bfTestdoc = RecordBuffer.define(Testdoc.Buf.class, "xdb", "bfTestdoc", "bf_TestDoc");

      return function("test-func", integer.class, new Block((Body) () -> 
      {
         AdaptiveQuery query0 = new AdaptiveQuery();

         forEach("loopLabel0", new Block((Init) () -> 
         {
            RecordBuffer.openScope(bfTestdoc);
            query0.initialize(bfTestdoc, "bfTestdoc.docid >= ?", null, "bfTestdoc.docid asc", new Object[]
            {
               inParam
            }, LockType.NONE);
            query0.addAccumulator(accumCount0);
            accumCount0.reset();
         }, 
         (Body) () -> 
         {
            query0.next();
            accumCount0.accumulate();
         }));

         returnNormal(accumCount0.getResult());
      }));
   }
}

The reason is that new FieldReference(bfTestdoc, "docid") is put to the top-level scope where bfTestdoc is not accessible (because it is defined locally in testFunc method).

Constantin, I've addressed the root cause of this issue by moving the scope of all Accumulator instances (and the fields and expressions they reference) to emit as data members of the Java block corresponding to the nearest enclosing, top-level 4GL block. This means they are declared/defined just inside the Java methods for the external procedure, internal procedure, function, etc. in which they are used.

In some cases, however, this has regressed the special IF statement and looping block processing you added (e.g., the calls to reset, postponeUnknown, etc.). These calls (and the try-finally they are in) have been dropped unintentionally with my changes. I think this is due to my removal of the promote-accum annotation in certain cases, but I'm tracking that down to be sure.

What is the significance of the promote-accum annotation w.r.t. this particular processing? For example, rules/convert/accumulate.rules checks for this in a while block with the following condition:

            pref.isRoot() == false and (targetref.isAncestorOf(0, pref) or
            targetref.id == pref.id or (getNoteBoolean("promote_accum") != null
            and getNoteBoolean("promote_accum")))

Also, can you please point me at the test case(s) you used originally to implement this feature set?

See the testcases/uast/accum_tests_if*.p and other accum*.p tests.

For the other questions, I'll have to think a little more...

Constantin Asofiei wrote:

See the testcases/uast/accum_tests_if*.p and other accum*.p tests.

Thanks.

For the other questions, I'll have to think a little more...

Don't worry about it, I think I have a fix for the regression. Testing it now.

After another round of regression fixes, 3325a rev 11167 finally has passed conversion regression testing. I am running runtime regression testing now and I expect to run further runtime tests (ETF) tomorrow.

The fix for this task is included in FWD v3.1 which was recently released. Download it from https://proj.goldencode.com/projects/p2j/wiki/FWD_v3_1_0

Please let us know if this issue can be closed.