FWD » Core Development » Base Language

Ovidiu, in testcases/uast/dsh_th_args there are tests which show how a table field or class property can work as an argument for TABLE-HANDLE and DATASET-HANDLE . I think I've covered all cases, but there are still some issues.

For example , there is no TableParameter emitted at all for fields and class properties (I assume for vars is emitted, didn't test). This and another issue related to DYNAMIC-NEW I think are what's left.

The current patch is pretty simple, I just fixed set_handle_stmts in common-progress.rules:

### Eclipse Workspace Patch 1.0
#P p2j6129a
Index: rules/include/common-progress.rules
===================================================================
--- rules/include/common-progress.rules    (revision 3611)
+++ rules/include/common-progress.rules    (working copy)
@@ -3586,6 +3586,23 @@
                target.upPath("STATEMENT/CREATE_WIDGET")
             <action>match = true</action>
          </rule>
+         
+         <rule>target.parent.type == prog.kw_dset_hnd or target.parent.type == prog.kw_tab_hand
+            <rule>target.upPath("KW_RUN/LPARENS/PARAMETER/EXPRESSION/KW_DSET_HND") or 
+                  target.upPath("KW_RUN/LPARENS/PARAMETER/EXPRESSION/KW_TAB_HAND")
+               <!-- check to be an OUTPUT or INPUT-OUTPUT parameter -->
+               <action>
+                  match = target.parent.parent.parent.downPath("KW_OUTPUT") or 
+                          target.parent.parent.parent.downPath("KW_IN_OUT")
+               </action>
+            </rule>
+   
+            <rule>evalLib("call_to_user_defined_function", target.parent.parent) or
+                  evalLib("oo_call_type", target.parent.parent, target.parent)
+               <!-- check to be an OUTPUT or INPUT-OUTPUT parameter -->
+               <action>match = not evalLib("input_argument", target.parent)</action>
+            </rule>
+         </rule>
       </function>

       <function name="set_field_comhandle_stmts">

If you can fix it tonight, do let me know. Otherwise, I'll pick it up in the morning.

Fixed in 6129a/13880

Ovidiu, please review.