Project

General

Profile

Activity

From 04/26/2022 to 05/25/2022

05/25/2022

06:48 PM Bug #6401 (Review): dynamic query can reference any buffer part of the added buffer's dataset
Although, at first, I was a bit circumspect about adding all buffers from the dataset, it appears that this is how 4G... Ovidiu Maxiniuc
04:37 PM Bug #6401 (WIP): dynamic query can reference any buffer part of the added buffer's dataset
I am looking at this now and report if your patch is correct. Ovidiu Maxiniuc
04:40 PM Feature #6411: LOB-DIR I/O option support
@LOB-DIR <directory>@ can be added as an option to:
* @INPUT FROM@ which then sets the default location for readin...
Greg Shah
04:29 PM Feature #6411 (Closed): LOB-DIR I/O option support
Greg Shah
04:23 PM Bug #6402: serialize-name for write-/read-json is not working
Actually, they are not. At least when they are read. But when they are serialized, the exact serialize-name is used. ... Ovidiu Maxiniuc
04:52 AM Bug #6402: serialize-name for write-/read-json is not working
Ovidiu, the JSON keys and XML elements AFAIK are case-sensitive. In @TempTableSchema.columns@, the names are lower-c... Constantin Asofiei
03:50 PM Feature #6410: implement additional built-in OO classes/interfaces
Complete the support for the following classes:
* @openedge.core.collections.list (partial/stubs)@
...
Greg Shah
03:49 PM Feature #6410 (Review): implement additional built-in OO classes/interfaces
Greg Shah
12:57 PM Bug #6404: conversion for dataset-handle and table-handle parameters with table fields or class p...
Constantin Asofiei wrote:
> Ovidiu, maybe you recall better - but wasn't it possible to pass table-handle to table p...
Greg Shah
12:55 PM Bug #6404: conversion for dataset-handle and table-handle parameters with table fields or class p...
Ovidiu, maybe you recall better - but wasn't it possible to pass table-handle to table parameter and table to table-h... Constantin Asofiei
12:52 PM Bug #6404: conversion for dataset-handle and table-handle parameters with table fields or class p...
Yes, I think so. I did it slightly differently because I introduced specific subclasses to handle the combinations o... Greg Shah
12:38 PM Bug #6404: conversion for dataset-handle and table-handle parameters with table fields or class p...
I have reviewed the changes in 13880 and they look OK to me.
Does this completely overlap with #4350 patches?
Ovidiu Maxiniuc
08:32 AM Bug #6404: conversion for dataset-handle and table-handle parameters with table fields or class p...
Unfortunately, we are duplicating effort here. I've already resolved this in #4350 but need time to fix the issues b... Greg Shah
05:31 AM Bug #6404 (Review): conversion for dataset-handle and table-handle parameters with table fields o...
Fixed in 6129a/13880
Ovidiu, please review.
Constantin Asofiei
10:36 PM Bug #6404: conversion for dataset-handle and table-handle parameters with table fields or class p...
Sorry, no, I could not come up with a better solution for this issue. Ovidiu Maxiniuc
11:18 AM Feature #6407: name_map.xml improvements
We have applications which support 4GL code extensions that are not part of the core application itself. For example... Greg Shah
11:08 AM Feature #6407 (Review): name_map.xml improvements
Greg Shah
10:56 PM Bug #6400 (Review): ADD-SOURCE-BUFFER can have the fields qualified with the table name
Fixed in r13879 of 6129a. Ovidiu Maxiniuc
10:54 PM Bug #6400 (WIP): ADD-SOURCE-BUFFER can have the fields qualified with the table name
Ovidiu Maxiniuc

05/24/2022

03:35 PM Bug #6404: conversion for dataset-handle and table-handle parameters with table fields or class p...
Ovidiu, in @testcases/uast/dsh_th_args@ there are tests which show how a table field or class property can work as an... Constantin Asofiei
02:36 PM Bug #6404 (Test): conversion for dataset-handle and table-handle parameters with table fields or ...
Constantin Asofiei
03:28 PM Bug #6402 (Review): serialize-name for write-/read-json is not working
Fixed reading a dataset/table with explicit serialize-name attribute.
Committed revision 13877.
Ovidiu Maxiniuc
02:08 PM Bug #6402 (WIP): serialize-name for write-/read-json is not working
Ovidiu Maxiniuc
12:15 PM Bug #6402: serialize-name for write-/read-json is not working
Ovidiu, please take this one next:... Constantin Asofiei
12:14 PM Bug #6402 (Test): serialize-name for write-/read-json is not working
Constantin Asofiei
02:20 PM Bug #6389: LENGTH function with COLUMN option
Maybe the sample attached to this KB entry could help.
[[https://community.progress.com/s/article/P193813]]
Marian Edu
02:08 PM Bug #6389 (Review): LENGTH function with COLUMN option
Ovidiu Maxiniuc
02:07 PM Bug #6389: LENGTH function with COLUMN option
I added runtime support for @LENGTH(..., 'COLUMN')@. For the moment it delegates to @LENGTH(..., 'CHARACTER')@ routin... Ovidiu Maxiniuc
11:56 AM Bug #6389: LENGTH function with COLUMN option
Thank you. My search were in vain. So it is the 3rd bullet (CJK glyphs).
I tried to launch the pro/prowin with the...
Ovidiu Maxiniuc
11:42 AM Bug #6389: LENGTH function with COLUMN option
I think this is related to chinese characters:... Constantin Asofiei
07:29 AM Bug #6389: LENGTH function with COLUMN option
Greg Shah wrote:
> Marian: Please review #6389-3 and post any thoughts.
Greg, I've never used @COLUMN@ type on @L...
Marian Edu
06:32 AM Bug #6389: LENGTH function with COLUMN option
Marian: Please review #6389-3 and post any thoughts. Greg Shah
12:24 AM Bug #6389: LENGTH function with COLUMN option
The conversion is fixed in 6129a. Please make the changes in 6129a. Constantin Asofiei
09:19 PM Bug #6389 (WIP): LENGTH function with COLUMN option
The FWD conversion automatically detects the length unit/type and report an error for @COLUMN@. This can be easily ad... Ovidiu Maxiniuc
01:27 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
Here is the version that can be applied over 6129a rev 13874.
If you use the zip, make sure to delete @src/com/gol...
Greg Shah
01:50 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
Greg Shah wrote:
> ** the runtime support for constructor selection is not handled at all yet
The runtime for const...
Constantin Asofiei
11:52 AM Bug #6401: dynamic query can reference any buffer part of the added buffer's dataset
This patch solves my problem:... Constantin Asofiei
11:10 AM Bug #6401: dynamic query can reference any buffer part of the added buffer's dataset
Ovidiu, have you seen something like this before?... Constantin Asofiei
11:09 AM Bug #6401 (Test): dynamic query can reference any buffer part of the added buffer's dataset
Constantin Asofiei
10:49 AM Bug #6400: ADD-SOURCE-BUFFER can have the fields qualified with the table name
I've seen in customer code a call like @ADD-SOURCE-BUFFER(bufHandle, "tt1.f1,tt1.f2,tt1.f3")@, i.e. the fields are qu... Constantin Asofiei
10:47 AM Bug #6400 (Test): ADD-SOURCE-BUFFER can have the fields qualified with the table name
Constantin Asofiei
09:55 AM Bug #6399: ENCRYPT/DECRYPT built-in function results different than 4GL when IV is shorter than r...
From #5915-104:
> FWD implementation for ENCRYPT produces different result than 4GL when the cipher requires IV an...
Greg Shah
09:55 AM Bug #6399 (Closed): ENCRYPT/DECRYPT built-in function results different than 4GL when IV is short...
Greg Shah
09:10 AM Feature #6300 (Test): class definitions with USE-WIDGET-POOL
Greg Shah
09:09 AM Feature #6300: class definitions with USE-WIDGET-POOL
Greg Shah wrote:
> This is handled at runtime as well as conversion?
Yes.
Constantin Asofiei
09:07 AM Feature #6300: class definitions with USE-WIDGET-POOL
This is handled at runtime as well as conversion? Greg Shah
08:50 AM Bug #6392: buffer flush and validation when the external program gets deleted can cause unique in...
In the end I think the root cause was the fact that @BufferManager.dirtyBuffer@ was still referencing the deleted pr... Constantin Asofiei
08:37 AM Bug #6392 (WIP): buffer flush and validation when the external program gets deleted can cause uni...
Constantin Asofiei
07:53 AM Bug #6392: buffer flush and validation when the external program gets deleted can cause unique in...
Constantin Asofiei wrote:
> I've added a trigger, and this gets invoked before the @proc0@ internal procedure return...
Constantin Asofiei
07:51 AM Bug #6392: buffer flush and validation when the external program gets deleted can cause unique in...
I've added a trigger, and this gets invoked before the @proc0@ internal procedure returns. Constantin Asofiei
07:39 AM Bug #6392: buffer flush and validation when the external program gets deleted can cause unique in...
There is this interesting note here https://docs.progress.com/bundle/openedge-abl-reference-117/page/DELETE-PROCEDURE... Constantin Asofiei
06:57 AM Bug #6392: buffer flush and validation when the external program gets deleted can cause unique in...
The better recreate is this:... Constantin Asofiei
02:28 AM Bug #6392: buffer flush and validation when the external program gets deleted can cause unique in...
This is a recreate of a buffer being flushed when the external program gets deleted.
The table:...
Constantin Asofiei
02:21 AM Bug #6392 (WIP): buffer flush and validation when the external program gets deleted can cause uni...
Constantin Asofiei

05/23/2022

06:15 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
The attached update can be applied over 6129a revision 13867. This is the list of remaining work:
* compile issue...
Greg Shah
12:55 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
This is a status update.
Every time I move the code to follow recent updates the code breaks badly and takes days ...
Greg Shah
04:06 PM Bug #6388 (WIP): save-where-string works without the buffer attached to a dataset
It seems that if the attribute is set manually, the error in getter is not thrown any more (removing the line no. 7 (... Ovidiu Maxiniuc
01:14 PM Bug #6388: save-where-string works without the buffer attached to a dataset
Probably the condition must be refined. See the attached procedure which shows the error. I am investigating addition... Ovidiu Maxiniuc
12:15 PM Bug #6388: save-where-string works without the buffer attached to a dataset
This test shows that @save-where-string@ works without the buffer attached to a dataset:... Constantin Asofiei
12:14 PM Bug #6388 (Test): save-where-string works without the buffer attached to a dataset
Constantin Asofiei
01:40 PM Bug #6389: LENGTH function with COLUMN option
The @LENGTH(..., COLUMN)@ function in @TextOps.columnLength@ needs to be implemented. Constantin Asofiei
01:39 PM Bug #6389 (WIP): LENGTH function with COLUMN option
Constantin Asofiei
11:37 AM Bug #6384: dynamic query conversion issues
Done. Revision is 13866. Ovidiu Maxiniuc
07:20 AM Bug #6384: dynamic query conversion issues
Ovidiu, please copy the changes to 6129a. Constantin Asofiei
11:43 PM Bug #6384: dynamic query conversion issues
Constantin, please use r13911.
For some reasons, the conversion detected a collision between the buffer and ... itse...
Ovidiu Maxiniuc

05/22/2022

02:25 PM Bug #6384 (Review): dynamic query conversion issues
Ovidiu Maxiniuc
02:24 PM Bug #6384: dynamic query conversion issues
Constantin, please use r13909 to test the original issue. It makes both your isolated testcases work.
However, acc...
Ovidiu Maxiniuc
03:41 AM Bug #6384: dynamic query conversion issues
The recreate for the issue in previous note is related to 'replace' mode in @copy-temp-table@:... Constantin Asofiei

05/21/2022

03:10 AM Bug #6384: dynamic query conversion issues
Ovidiu, thanks, @force_dmo_alias@ placed me on the right track. This patch seems to have solved the issue:... Constantin Asofiei
10:12 PM Bug #6384 (WIP): dynamic query conversion issues
The issue seems familiar to me. I think I encountered something similar in the last year or so, but momentarily I do ... Ovidiu Maxiniuc

05/20/2022

02:00 PM Bug #6384: dynamic query conversion issues
Ovidiu, this test-case which uses the before-table in a dynamic query abends with this:... Constantin Asofiei
01:50 PM Bug #6384 (Test): dynamic query conversion issues
Constantin Asofiei
07:43 AM Bug #6382: XML serialization for ATTRIBUTE and TEXT XML-NODE-TYPE fields
6129a/13861 adds missing runtime support for TEXT and ATTRIBUTE XML-NODE-TYPE field option. This fixes the table (d... Constantin Asofiei
07:39 AM Bug #6382 (New): XML serialization for ATTRIBUTE and TEXT XML-NODE-TYPE fields
Constantin Asofiei

05/19/2022

04:03 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
We have an issue with compile-time issue with fuzzy matching and the @OutputExtentParameter@.
In @oo/params/overlo...
Greg Shah

05/17/2022

10:47 AM Feature #6373: direct Java object access to converted Java code from in-JVM non-converted Java code
A customer with very heavy appserver usage currently runs their Open Java Client code in a separate Tomcat JVM. This... Greg Shah
10:34 AM Feature #6373 (New): direct Java object access to converted Java code from in-JVM non-converted J...
Greg Shah

05/16/2022

01:34 PM Feature #4658: OO serialization support
There are @SERIALIZABLE@ and @NON-SERIALIZABLE@ options at the property and variable definition.
In 6129a/13857 I...
Constantin Asofiei
01:34 PM Feature #6300 (Review): class definitions with USE-WIDGET-POOL
This is solved in 6129a/13857.
Nothing more needs to be done, a plain unnamed widget pool is created for such an i...
Constantin Asofiei
08:45 AM Feature #4065: server-side processing of client platform dependencies
> Please rename @RoaringBitmap-0.9.0.jar_LICENSE.txt@ to @RoaringBitmap-0.9.27.jar_LICENSE.txt@ on the web server: @h... Greg Shah
08:42 AM Feature #4065: server-side processing of client platform dependencies
Roger Borrello wrote:
> Greg Shah wrote:
> > Roger: As part of rev 13885, the RoaringBitmap library version has cha...
Roger Borrello
08:24 AM Feature #4065: server-side processing of client platform dependencies
Greg Shah wrote:
> Roger: As part of rev 13885, the RoaringBitmap library version has changed from 0.9.0 to 0.9.27. ...
Roger Borrello
07:51 AM Feature #4065: server-side processing of client platform dependencies
Code Review Task Branch 3821c Revision 13886
It looks good.
Greg Shah
03:29 AM Feature #4065: server-side processing of client platform dependencies
I've fixed the per-context support of server-side-resources in 3821c/13886. Constantin Asofiei

05/15/2022

12:54 PM Feature #4065: server-side processing of client platform dependencies
Greg Shah wrote:
> 1. I don't fully understand the use of statics in @OSResourceManager@ (and subclasses). Its data...
Constantin Asofiei
12:18 PM Feature #4065: server-side processing of client platform dependencies
Roger: As part of rev 13885, the RoaringBitmap library version has changed from 0.9.0 to 0.9.27. Would you please ha... Greg Shah
12:13 PM Feature #4065: server-side processing of client platform dependencies
Code Review Task branch 3821c Revision 13885
Overall, I very much like the changes.
1. I don't fully understand...
Greg Shah
08:16 AM Feature #4065 (WIP): server-side processing of client platform dependencies
The server-side support for OS resources and memptr/library server-side support is in 3821c/13885.
What's left is ...
Constantin Asofiei
04:56 AM Feature #4065: server-side processing of client platform dependencies
The code is complete for memptr and library, I need to finish a testing of #6075 and some other scenarios.
I've ad...
Constantin Asofiei

05/13/2022

04:02 PM Feature #4065: server-side processing of client platform dependencies
> should I add support for server-side LibraryDaemon together with memptr? They are tightly coupled in the p2j.librar... Greg Shah
03:40 PM Feature #4065: server-side processing of client platform dependencies
Also, is it enough to raise an ERROR condition if the application code tries a @set-pointer-value()@ to something out... Constantin Asofiei
03:16 PM Feature #4065: server-side processing of client platform dependencies
Greg, some questions/notes:
* should I add support for server-side LibraryDaemon together with memptr? They are tigh...
Constantin Asofiei
09:43 AM Feature #3326: implement the equivalent to the .NET Open Client
In some recent work for a customer that wanted to try SQLServer (see #6274), Ovidiu found that the iKVM project is no... Greg Shah

05/10/2022

02:39 PM Feature #6343: class-based appserver exports
The 4GL enables the export of external procedures, internal procedures and user-defined functions over an appserver c... Greg Shah
01:08 PM Feature #6343 (New): class-based appserver exports
Greg Shah
01:06 PM Feature #6342: provide a simple mechanism to call into converted code
From 4GL code, we have a very clean [[p2j:Direct Java Access]] approach to call "out" into arbitrary Java code.
Th...
Greg Shah
12:58 PM Feature #6342 (New): provide a simple mechanism to call into converted code
Greg Shah
08:59 AM Feature #4065: server-side processing of client platform dependencies
Greg Shah wrote:
> I assume (for now) that you are not removing the ability to use @memptr@ on the client. Perhaps ...
Constantin Asofiei
08:54 AM Feature #4065: server-side processing of client platform dependencies
I assume (for now) that you are not removing the ability to use @memptr@ on the client. Perhaps we will find that lo... Greg Shah

05/07/2022

03:46 PM Feature #4065: server-side processing of client platform dependencies
I have some changes which brings memptr fully on server-side (very pin-pointed changes, no major refactoring).
But...
Constantin Asofiei

05/06/2022

01:32 AM Bug #6293 (Rejected): dataset/temp-table options defined in interface
Ovidiu, most likely this is not a real issue. I'm closing it. Constantin Asofiei

05/05/2022

04:23 PM Bug #6293 (WIP): dataset/temp-table options defined in interface
I am trying to duplicate this but I cannot. Incrementally I created and modified additional classes like this:... Ovidiu Maxiniuc
03:51 AM Bug #6293: dataset/temp-table options defined in interface
This was created after reviewing some customer application code, where I noticed that the temp-table at the interface... Constantin Asofiei

04/30/2022

02:17 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
In @annotations/naming.rules@ we use @ConvertedClassName.addMethod()@ to add entries for the c'tors. It seems like t... Greg Shah
02:12 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
Greg Shah wrote:
> > If that is removed, the prerequisite (for conversion to complete) will be to have stubbed skele...
Constantin Asofiei
02:07 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
> If that is removed, the prerequisite (for conversion to complete) will be to have stubbed skeletons in p2j.oo for a... Greg Shah

04/28/2022

01:34 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
Greg Shah wrote:
> > The main reason the converter is used is the case when we don't have a counterpart skeleton in ...
Constantin Asofiei
01:28 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
> The main reason the converter is used is the case when we don't have a counterpart skeleton in FWD, just the .cls f... Greg Shah
09:40 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
Greg Shah wrote:
> I've spent the last few days trying to stabilize and finish my previous work. I'm deep into the ...
Constantin Asofiei
09:15 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
I've spent the last few days trying to stabilize and finish my previous work. I'm deep into the changes to eliminate... Greg Shah
06:59 AM Feature #3310: add support for the equivalent of the OpenEdge Web Services Adapter (and ProxyGen)...
Constantin Asofiei wrote:
> Greg Shah wrote:
> > > In FWD, I don't see a reason to emit this 'book' class which ju...
Constantin Asofiei

04/27/2022

03:21 PM Feature #3310: add support for the equivalent of the OpenEdge Web Services Adapter (and ProxyGen)...
Greg Shah wrote:
> > In FWD, I don't see a reason to emit this 'book' class which just allows to call 'book.create'...
Constantin Asofiei
03:19 PM Feature #3310: add support for the equivalent of the OpenEdge Web Services Adapter (and ProxyGen)...
> In FWD, I don't see a reason to emit this 'book' class which just allows to call 'book.create' instead of working ... Greg Shah
01:53 PM Feature #3310: add support for the equivalent of the OpenEdge Web Services Adapter (and ProxyGen)...
Greg, in OE the proxy Java Open Client allows a 'SubAppObject' which groups access to the programs in its own Java cl... Constantin Asofiei

04/26/2022

01:46 PM Feature #6300 (Closed): class definitions with USE-WIDGET-POOL
Greg Shah
01:07 PM Feature #4354 (Closed): add GET-CLASS() function support
Greg Shah
01:06 PM Feature #4354: add GET-CLASS() function support
Greg Shah wrote:
> Is there anything remaining to work on for this task?
No.
Constantin Asofiei
01:05 PM Feature #4354: add GET-CLASS() function support
Is there anything remaining to work on for this task? Greg Shah
 

Also available in: Atom