FWD » Core Development » Database

The following features need implementation/improvement:

• DBPARAM builtin function - not all CONNECT params reported (but as long as we report all params we support, we are good; this has to stay up to date with CONNECT statement support)
• DBRESTRICTIONS builtin function is marked runtime stubs
• RCODE-INFO TABLE-LIST attribute - just need to check if the conversion handles the legacy name correctly (case-sensitivity, etc)

• As I can see from the code DBPARAM reports all parameters supported by FWD for CONNECT
• It looks that the only database restriction we have to support is READ-ONLY. Should be reported if the database was opened with -RO option. Not sure about SET-CURRENT-VALUE ("Cannot set the current value of sequence generators.").

Working on RCODE-INFO:TABLE-LIST.

Igor, RCODE-INFO:TABLE-LIST is already added in 6129b.

Constantin Asofiei wrote:

Igor, RCODE-INFO:TABLE-LIST is already added in 6129b.

Constantin,
I see only RcodeInfo interface in our code, however I understand that I have to check the functionality.
Where can I find a description of RCODE-INFO support in FWD. I understand that r-code has no counterpart in FWD.
Thank you.

Igor Skornyakov wrote:

Constantin Asofiei wrote:

Igor, RCODE-INFO:TABLE-LIST is already added in 6129b.

Constantin,
I see only RcodeInfo interface in our code, however I understand that I have to check the functionality.

Look in the RcodeInfoOps.java file - this is a static proxy which implements the RcodeInfo interface.

Constantin Asofiei wrote:

Igor Skornyakov wrote:

Constantin Asofiei wrote:

Igor, RCODE-INFO:TABLE-LIST is already added in 6129b.

Constantin,
I see only RcodeInfo interface in our code, however I understand that I have to check the functionality.

Look in the RcodeInfoOps.java file - this is a static proxy which implements the RcodeInfo interface.

Thank you!

I've noticed the following problem.
The statement

  DISPLAY 
    RCODE-INFO:CRC-VALUE LABEL "CRC" 
    RCODE-INFO:DB-REFERENCES LABEL "DB-REFERENCES" 
    RCODE-INFO:TABLE-LIST LABEL "TABLE-LIST" 
    RCODE-INFO:LANGUAGES FORMAT "x(60)" LABEL "Languages" 
    WITH FRAME rc-info SIDE-LABELS TITLE "R-code Check".

Is compiled to

            FrameElement[] elementList1 = new FrameElement[]
            {
               new Element(, rcInfoFrame.widgetExpr2()),
               new Element(RcodeInfoOps.getDbReferences(), rcInfoFrame.widgetExpr3()),
               new Element(RcodeInfoOps.getTableList(), rcInfoFrame.widgetExpr4()),
               new Element(, rcInfoFrame.widgetExpr5())
            };

            rcInfoFrame.display(elementList1);

I understand that this is because we do not have even stubs for RCODE-INFO:CRC-VALUE and RCODE-INFO:LANGUAGES.
Does it make sense to add stubs for these (and other missing RCODE-INFO attributes) now?
Thank you.

As far as I can see, RCODE-INFO:TABLE-LIST inplementation in FWD uses the value of the tables attribute of the @DatabaseReferences annotation. So the question is about this annotation.
Strangely enough I have found no @DatabaseReferences annotation in a converted large customer application (a pretty old version) with non-empty tables attribute. However, in my test this attribute exists and looks OK.

I understand that this is because we do not have even stubs for RCODE-INFO:CRC-VALUE and RCODE-INFO:LANGUAGES.
Does it make sense to add stubs for these (and other missing RCODE-INFO attributes) now?

Yes, please do. Make sure to update the gap analysis too.

Greg Shah wrote:

I understand that this is because we do not have even stubs for RCODE-INFO:CRC-VALUE and RCODE-INFO:LANGUAGES.
Does it make sense to add stubs for these (and other missing RCODE-INFO attributes) now?

Yes, please do. Make sure to update the gap analysis too.

OK, thank you.

Igor Skornyakov wrote:

Strangely enough I have found no @DatabaseReferences annotation in a converted large customer application (a pretty old version) with non-empty tables attribute.

The conversion needs to be with 6129b for tables attribute to be populated.

Constantin Asofiei wrote:

Igor Skornyakov wrote:

Strangely enough I have found no @DatabaseReferences annotation in a converted large customer application (a pretty old version) with non-empty tables attribute.

The conversion needs to be with 6129b for tables attribute to be populated.

Oh, I see. Thank you!

Greg Shah wrote:

I understand that this is because we do not have even stubs for RCODE-INFO:CRC-VALUE and RCODE-INFO:LANGUAGES.
Does it make sense to add stubs for these (and other missing RCODE-INFO attributes) now?

Yes, please do. Make sure to update the gap analysis too.

Added stubs for missed RCODE-INFO attributes.
Committed to 6129b/14335.

Igor, other than requiring review for the patch in #6454-11 and for 6129b/14335, is this task finished from your point of view? Have the changes been tested? If so, please mark it 100% and status "Review". Thanks.

Igor Skornyakov wrote:

Eric Faulhaber wrote:

Igor, other than requiring review for the patch in #6454-11 and for 6129b/14335, is this task finished from your point of view? Have the changes been tested? If so, please mark it 100% and status "Review". Thanks.

Eric,
Yes, I think that the only remaining think is reviewing #6454-11. I've tested the changes.

The changes in dbrestrictions.diff look good. Please commit it to 6129b. 6129b/14335 also looks good.

Eric Faulhaber wrote:

The changes in dbrestrictions.diff look good. Please commit it to 6129b. 6129b/14335 also looks good.

Committed to 6129b/14342.