FWD » Core Development » Database

While testing the unit tests of a customer, I noticed that there are a few instances of FieldReference arguments that will reach DirectAccessHelper.findByUniqueIndex() and those values will throw an exception because DirectAccessHelper.normalizeValue() can't handle them.

Similar to FqlPreprocessor.getFindByRowid() where the value is extracted when there is a FieldReference, normalizeValue() should be able to do the same.

The following patch solves this issue and allows direct access to be used in more cases:

=== modified file 'src/com/goldencode/p2j/persist/orm/DirectAccessHelper.java'
--- old/src/com/goldencode/p2j/persist/orm/DirectAccessHelper.java    2023-12-12 16:08:14 +0000
+++ new/src/com/goldencode/p2j/persist/orm/DirectAccessHelper.java    2024-06-11 06:45:27 +0000
@@ -80,6 +80,7 @@
 import org.h2.jdbc.JdbcConnection;

 import com.goldencode.p2j.oo.lang._BaseObject_;
+import com.goldencode.p2j.persist.FieldReference;
 import com.goldencode.p2j.persist.PersistenceException;
 import com.goldencode.p2j.persist.Record;
 import com.goldencode.p2j.persist.UniqueIndexLookup;
@@ -307,6 +308,12 @@
          // already normalized
          return arg;
       }
+      
+      if (arg instanceof FieldReference)
+      {
+         arg = ((FieldReference) arg).get();
+      }
+      
       if (arg instanceof BaseDataType)
       {
          if (((BaseDataType) arg).isUnknown())

Eric: Please review.

Greg Shah wrote:

Eric: Please review.

Code review 8868a/15280:

H2 direct access is not an area of the code I am that familiar with, but the change seems simple and safe enough. I am ok with it.

Are there any other types which could be returned by UniqueIndexLookup.getValues which, like FieldReference before this fix, are not currently accounted for?

A pre-existing coding standard issue: please use wildcards for the import statements, unless more specific names are needed for disambiguation.

Eric Faulhaber wrote:

Greg Shah wrote:

Eric: Please review.

Code review 8868a/15280:

Are there any other types which could be returned by UniqueIndexLookup.getValues which, like FieldReference before this fix, are not currently accounted for?

I am not sure, maybe Alexandru can answer this?

A pre-existing coding standard issue: please use wildcards for the import statements, unless more specific names are needed for disambiguation.

Committed 8868a/rev.15281, added wildcard import statement (I did not add a history entry for this).