FWD » Core Development » Base Language

I can reproduce the issue. The problem is in object.ref:

   public T ref()
   {
      if (isUnknown())
      {
         String msg = "Invalid handle.  Not initialized or points to a deleted object";
         ErrorManager.recordOrThrowError(3135, msg, false);

         // TODO: is there any scenario where we can actually return null in silent error mode?
         //       (If so, that is very bad.)
         return null;
      }

      return ref;
   }

We need to make a distinction between chained and unchained objects so that both of these snippets throw the correct error:

new MyClass():my_class:mtd().

define var obj as MyClass no-undo.
obj:mtd().

class MyClass:
define public variable my_class as class MyOtherClass.
method void mtd1():
    message "executing...".
end method.
end class.

class MyOtherClass:
method void mtd():
    message "executing...".
end method.
end class.

Let's look at the following OE cases:

I:

new MyClass():my_class:mtd().

II:

define var obj as MyClass no-undo.
obj:mtd1(). 

FWD & OE Output: Invalid handle. Not initialized or points to a deleted object. (3135)

III:

def var x as MyClass no-undo.
x:my_class:mtd().

FWD & OE Output: Invalid handle. Not initialized or points to a deleted object. (3135) then another window with Lead attributes in a chained-attribute expression (a:b:c) must be type HANDLE or a user-defined type and valid (not UNKNOWN). (10068)

My changes:

=== modified file 'rules/convert/oo_calls.rules'
--- old/rules/convert/oo_calls.rules    2023-10-31 13:04:48 +0000
+++ new/rules/convert/oo_calls.rules    2024-12-12 13:10:29 +0000
@@ -419,8 +419,23 @@
                                          lastid)
                </action>
             </rule>
-            
-            <action>lastid = createJavaAst(java.method_call, "ref", lastid)</action>
+
+
+
+            <rule>copy.type == prog.object_invocation and downPath(copy, prog.object_invocation)
+               <action on="true">
+                  lastid = createJavaAst(java.method_call, "chainedRef", lastid)
+               </action>
+               <rule on="false">copy.type == prog.object_invocation and upPath(copy, prog.object_invocation)
+                  <action on="true">
+                     lastid = createJavaAst(java.method_call, "firstChainedRef", lastid)
+                  </action>
+                  <action on="false">
+                     lastid = createJavaAst(java.method_call, "ref", lastid)
+                  </action>
+               </rule>
+            </rule>
+
             <action>ref1.putAnnotation("peerid", lastid)</action>

             <!-- unqualified method invocations as the first referent, this can only happen for

=== modified file 'src/com/goldencode/p2j/util/object.java'
--- old/src/com/goldencode/p2j/util/object.java    2024-03-24 09:17:59 +0000
+++ new/src/com/goldencode/p2j/util/object.java    2024-12-12 13:32:36 +0000
@@ -265,6 +265,39 @@

       return ref;
    }
+
+   public T chainedRef()
+   {
+      if (isUnknown())
+      {
+         String msg = "Lead attributes in a chained-attribute expression (a:b:c) must be type HANDLE or a user-defined type and valid (not UNKNOWN)";
+         ErrorManager.recordOrThrowError(10068, msg, false);
+
+         // TODO: is there any scenario where we can actually return null in silent error mode?
+         //       (If so, that is very bad.)
+         return null;
+      }
+
+      return ref;
+   }
+
+   public T firstChainedRef()
+   {
+      if (isUnknown())
+      {
+         String msg1 = "Invalid handle.  Not initialized or points to a deleted object";
+
+         String msg2 = "Lead attributes in a chained-attribute expression (a:b:c) must be type HANDLE or a " +
+            "user-defined type and valid (not UNKNOWN)";
+
+         ErrorManager.recordOrThrowError(new int[] { 3135, 10068 }, new String[] { msg1, msg2 }, false);
+         // TODO: is there any scenario where we can actually return null in silent error mode?
+         //       (If so, that is very bad.)
+         return null;
+      }
+
+      return ref;
+   }

    /**
     * Compares this instance with the specified instance and returns -1 if this instance is less than the

Should I:
A) Make a single ref method with a flag parameter that takes care of all the cases? (i.e normal ref, chainedRef, firstChainedRef)
B) Have two refs: the original ref and chainedRef with a flag parameter that takes care of chainedRef & firstChainedRef

There are some prints for debugging reasons.

=== modified file 'rules/convert/oo_calls.rules'
--- old/rules/convert/oo_calls.rules    2023-10-31 13:04:48 +0000
+++ new/rules/convert/oo_calls.rules    2024-12-16 14:02:55 +0000
@@ -419,8 +419,31 @@
                                          lastid)
                </action>
             </rule>
-            
-            <action>lastid = createJavaAst(java.method_call, "ref", lastid)</action>
+
+
+
+            <rule>copy.type == prog.object_invocation and downPath(copy, prog.object_invocation)
+               <action on="true">
+                  lastid = createJavaAst(java.method_call, "chainedRef", lastid)
+               </action>
+               <rule on="false">copy.type == prog.object_invocation and upPath(copy, prog.object_invocation)
+                  <action on="true">
+                     lastid = createJavaAst(java.method_call, "chainedRef", lastid)
+                  </action>
+                  <action on="true">
+                     copy.putAnnotation("first-chained-ref", #(java.lang.Boolean) true)
+                  </action>
+                  <action on="true">
+                     print("YYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYY")
+                  </action>
+                  <action on="false">
+                     lastid = createJavaAst(java.method_call, "ref", lastid)
+                  </action>
+               </rule>
+            </rule>
+
+
+
             <action>ref1.putAnnotation("peerid", lastid)</action>

             <!-- unqualified method invocations as the first referent, this can only happen for

=== modified file 'rules/convert/variable_references.rules'
--- old/rules/convert/variable_references.rules    2024-07-30 07:32:38 +0000
+++ new/rules/convert/variable_references.rules    2024-12-16 14:28:02 +0000
@@ -667,7 +667,7 @@
             </rule>
          </rule>
       </rule>
-         
+
       <!-- convert variable references, bypass widget references and handles referenced into
            TABLE-HANDLE FOR -->
       <rule>evalLib("variables")                            and
@@ -1016,7 +1016,21 @@

                   <!-- emit variable/accessor -->
                   <action>createPeerAst(methodType, methodTxt, lastid)</action>
-                  
+
+                  <rule>parent.type == prog.var_class
+                     <action>
+                        print("######")
+                     </action>
+                  </rule>
+                  <rule>copy.parent.type == prog.object_invocation and
+                        #(java.lang.Boolean) copy.parent.getAnnotation("first-chained-ref")
+                     <action>
+                        printf("%d", this.type)
+                     </action>
+                     <action>
+                        lastid = createJavaAst(java.bool_true, "", lastid)
+                     </action>
+                  </rule>
                   <rule>numImmediateChildren == 0 and copy.isAnnotation("wrapNodeId")
                      <!-- simple vars: emit the 'io' = true parameter here -->
                      <action>lastid = copy.getAnnotation("wrapNodeId")</action>

=== modified file 'src/com/goldencode/p2j/util/object.java'
--- old/src/com/goldencode/p2j/util/object.java    2024-03-24 09:17:59 +0000
+++ new/src/com/goldencode/p2j/util/object.java    2024-12-13 08:07:59 +0000
@@ -265,6 +265,33 @@

       return ref;
    }
+
+   public T chainedRef()
+   {
+      return chainedRef(false);
+   }
+
+   public T chainedRef(boolean isFirst)
+   {
+      if(isUnknown())
+      {
+         String msg1 = "Invalid handle.  Not initialized or points to a deleted object";
+         String msg2 = "Lead attributes in a chained-attribute expression (a:b:c) must be type HANDLE or a " +
+            "user-defined type and valid (not UNKNOWN)";
+         if(isFirst)
+         {
+            ErrorManager.recordOrThrowError(new int[] { 3135, 10068 }, new String[] { msg1, msg2 }, false);
+         }
+         else
+         {
+            ErrorManager.recordOrThrowError(10068, msg2, false);
+         }
+         return null;
+      }
+
+      return ref;
+   }
+

    /**
     * Compares this instance with the specified instance and returns -1 if this instance is less than the

This works fine on #9354-8 and #9354-7 II and III but on I it fails because it doesn't manage to set the first chainedRef to true. I need to find a better place for lastid = createJavaAst(java.bool_true, "", lastid) to take place.

I will take this over as there some tests in tests/table/parameter which have the same root cause as this one.

Committed on 9354a, rev. 16442, patch from #9354-12 + some additional fixes. I have tested CHUI conversion and build (will convert large GUI application today).