FWD » Core Development » Base Language

01/07/2013

05:22 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

The Windows detection code has been moved to separate statis method of the EnvironmentOps class.
Also I made one s... Eugenie Lyzenko

04:33 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

Yes, please make a new method for isUnderWindowsFamily() and use that everywhere necessary. Then upload the latest c... Greg Shah

03:47 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

The new archive has been uploaded here for you to review.
The question: In getLegacyCaseSensitive() I have used "i... Eugenie Lyzenko

02:54 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

Feedback:
1. In ExpressionConversionWorker, instead of this:... Greg Shah

01:51 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

The cumulative fix has been uploaded here. Eugenie Lyzenko

01:26 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

Please upload the complete update zip into this task so that I can do a final code review. Greg Shah

02:32 PM Feature #1626: implement OS-DIR support as an INPUT stream

To be clear, I think that when Progress says "You might also get one or more of the following characters:" they mean ... Greg Shah

02:29 PM Feature #1626: implement OS-DIR support as an INPUT stream

Implement option 2 (create the Linux implementation even though we cannot test the 4GL on Linux today). Please note ... Greg Shah

01:50 PM Feature #1626: implement OS-DIR support as an INPUT stream

The pipes case may be a problem to detect, since files and FIFO pipes are both marked with "F" only nonFIFO pipes w... Costin Savin

02:04 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...

Please implement full process launching support for Windows. This means that src/native/process.c will need modifica... Greg Shah

11:07 AM Feature #1920: implement persistent procedures

Yes, you've got the idea.
I think your implementation approach (e.g. CommonProcedure) makes sense.
One note: us... Greg Shah

08:14 AM Feature #1920: implement persistent procedures

Ok, now I undestand what you mean: when the resource is of a known type (widget, persistent procedure,etc), unwrap wi... Constantin Asofiei

10:15 AM Feature #1611: implement QUOTER utility

The latest update for this tast is cs_upd20121219a.zip the cs_upd20121231a? is for the other quoter (built-in) #1591.... Costin Savin

10:09 AM Feature #1611: implement QUOTER utility

> Did you get a chance to work on it?
Costin,
Have you updates ready to test in lightning? Is it only cs_upd20... Eugenie Lyzenko

03:02 AM Feature #1591: implement QUOTER built-in function

I've applied the update to staging and P2J is rebuilt. Constantin Asofiei

01/04/2013

11:31 AM Feature #1626: implement OS-DIR support as an INPUT stream

For Windows stat() seems to do the job, but in Unix lstat() must be used or link will not be corectly detected.
2-> ... Costin Savin

11:06 AM Feature #1626: implement OS-DIR support as an INPUT stream

It is OK to be linux-specific right now. We will have separate tasks to port this to Windows.
Some initial feedba... Greg Shah

10:32 AM Feature #1626: implement OS-DIR support as an INPUT stream

Actually , I realize this will have to be tested on a windows system since there might be problems with lstat(). Costin Savin

10:21 AM Feature #1626: implement OS-DIR support as an INPUT stream

The code for filesys.c... Costin Savin

09:52 AM Feature #1626: implement OS-DIR support as an INPUT stream

Good. Please post your prototype code for review. Just paste the code into your redmine issue update if it is small... Greg Shah

09:42 AM Feature #1626: implement OS-DIR support as an INPUT stream

This also requires some changes to the ant task "native" ,
otherwise I made the changes and tested for symbolic lin... Costin Savin

08:10 AM Feature #1626: implement OS-DIR support as an INPUT stream

Yes, this solution is OK. We already have a libp2j.so (which we will have to also port to Windows as p2j.dll). Righ... Greg Shah

01/03/2013

10:21 AM Feature #1626: implement OS-DIR support as an INPUT stream

Java (at least until Java 7 NIO 2) doesn't seem to have a way of detecting symbolic links( the problem it's likely th... Costin Savin

12/31/2012

11:34 AM Feature #1591: implement QUOTER built-in function

OK, it looks good. These additions should not be able to cause any runtime regressions. So I am going to bypass reg... Greg Shah

06:41 AM Feature #1591: implement QUOTER built-in function

Added proposed update Costin Savin

10:57 AM Feature #1920: implement persistent procedures

... Greg Shah

12/27/2012

03:37 PM Support #1928: update documentation to explain how to convert, develop and run P2J on Windows

Small changes to Windows specific has been uploaded. The issues for conversion INPUT THROUGH, OUTPUT THROUGH and INPU... Eugenie Lyzenko

12/25/2012

05:08 PM Support #1928: update documentation to explain how to convert, develop and run P2J on Windows

The updated versions of the document have been uploaded here. Also the new document part describing the run-time setu... Eugenie Lyzenko

12/22/2012

07:43 AM Feature #1920: implement persistent procedures

If I understood right, then there will be "handle.unwrap<Resource>" APIs, like:
* handle.unwrapWidget for widget han... Constantin Asofiei

12/21/2012

02:29 PM Support #1928: update documentation to explain how to convert, develop and run P2J on Windows

I've uploaded two draft files here, one for conversion handbook, another for developer guide. Now I'm thinking and st... Eugenie Lyzenko

01:26 PM Feature #1591: implement QUOTER built-in function

Feedback:
1. Remove the builtin_functions.rules from your zip. There are no changes there.
2. The character.ja... Greg Shah

01:09 PM Feature #1591: implement QUOTER built-in function

Added proposed update with the String overloaded methods. Costin Savin

12:12 PM Feature #1591: implement QUOTER built-in function

Yes. Greg Shah

12:09 PM Feature #1591: implement QUOTER built-in function

A quoter version which supports String instead of BaseDataType should probably be added to be reused for places where... Costin Savin

05:39 AM Feature #1591: implement QUOTER built-in function

Added the entry to expressions.odt Costin Savin

01:11 PM Feature #1920: implement persistent procedures

In addition to the general messiness that comes from having a global or "umbrella" interface, there is another practi... Greg Shah

12:35 PM Feature #1920: implement persistent procedures

The idea is, to be able to use handle.unwrap to access an attribute for any kind of handle (procedure handle, widget ... Constantin Asofiei

12:09 PM Feature #1920: implement persistent procedures

I thought we were going to use resource-specific interfaces instead of a global interface. I prefer it to be resourc... Greg Shah

09:32 AM Feature #1920: implement persistent procedures

Greg,
When collecting all the handle-related APIs in a "global" interface, I found some differences between the retu... Constantin Asofiei

11:33 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

The attached file contains only implementation and test cases for int64.
The changes are both syntactic and semantic... Ovidiu Maxiniuc

12/20/2012

01:36 PM Feature #1591: implement QUOTER built-in function

I forgot to ask you to update the documentation. Please update the builtin functions table in the expressions.odt ch... Greg Shah

08:59 AM Feature #1591 (Closed): implement QUOTER built-in function

Greg Shah

11:16 AM Feature #1921: implement super-procedures

Ok, that makes sense. Constantin Asofiei

10:58 AM Feature #1921: implement super-procedures

... Greg Shah

10:05 AM Feature #1921: implement super-procedures

I found a case which I haven't thought about until now. Consider we have these procedures:
* t1.p:... Constantin Asofiei

10:24 AM Feature #1626: implement OS-DIR support as an INPUT stream

Those parameters should NOT be emitted in the OS-DIR case. Greg Shah

09:58 AM Feature #1626: implement OS-DIR support as an INPUT stream

From default conversion logic p2j will also add 2 boolean parameters when calling StreamFactory.openOsDir: boolean w... Costin Savin

10:23 AM Feature #1611 (Test): implement QUOTER utility

I am OK with the proposed code.
Please work with Eugenie to put this through full runtime testing using lightning ... Greg Shah

10:03 AM Feature #1611: implement QUOTER utility

Actually it's the cs_upd20121219a.zip mistaken between the two quoter folders. Costin Savin

09:02 AM Feature #1611: implement QUOTER utility

This is the wrong update (it is the same one that goes with #1591). Please upload the proper update (probably it is ... Greg Shah

09:40 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Another error I found. The following sample code extracted from _OpenEdge® Development: ABL Reference_ (page 55) fail... Ovidiu Maxiniuc

12/19/2012

07:28 AM Feature #1591: implement QUOTER built-in function

Applied to staging and P2J was rebuilt. MAJIC was not reconverted or rebuilt. Constantin Asofiei

06:35 AM Feature #1611: implement QUOTER utility

Added proposed update.
Also found a bug regarding the error message when input file does not exist and fixed it, th... Costin Savin

03:23 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Current status:
* added .rules changes and in various files (like ExpressionConversion etc) for int64 support (more ... Ovidiu Maxiniuc

12/18/2012

01:10 PM Feature #1591: implement QUOTER built-in function

OK, it looks good.
Good ahead and do the following:
1. Work with Constantin to get the update applied to stagin... Greg Shah

12:27 PM Feature #1591: implement QUOTER built-in function

Added update. I assumed null -> &lt;code&gt;null&lt;/code&gt;
Costin Savin

11:32 AM Feature #1591: implement QUOTER built-in function

There is still a javadoc problem.... Greg Shah

06:43 AM Feature #1591: implement QUOTER built-in function

Done conversion regression testing, there are no differences. Costin Savin

12:49 PM Feature #1626: implement OS-DIR support as an INPUT stream

... Greg Shah

11:45 AM Feature #1626: implement OS-DIR support as an INPUT stream

Updated the Input from OS-Dir Specifications.
Certain things are not 100% clear:
From the list of arguments only NO-... Costin Savin

12:33 PM Feature #1611: implement QUOTER utility

8. Yes ran all the tests and checked results it all looks good.
Will also test again after making the changes from r... Costin Savin

12:02 PM Feature #1611: implement QUOTER utility

Feedback:
1. The text "This may be specified as a file or as a stream." in the javadoc for can be removed. Statin... Greg Shah

12:03 PM Feature #1920: implement persistent procedures

That is fine with me. Greg Shah

08:58 AM Feature #1920: implement persistent procedures

The MAJIC sources, beside the ControlFlowOps and handle.unwrap changes, has this change: frame.getScreeValue(widget) ... Constantin Asofiei

12/17/2012

02:39 PM Feature #1591: implement QUOTER built-in function

Attached wrong update before. This is the correct one Costin Savin

02:30 PM Feature #1591: implement QUOTER built-in function

Added proposed update, started the regression test Costin Savin

12:57 PM Feature #1611: implement QUOTER utility

I understand , the final code should be be fully documented, respect the coding standards entirely , tested and broug... Costin Savin

12:16 PM Feature #1611: implement QUOTER utility

7. The text description is wrong it's 4't included not 5'th included. Corrected
Costin Savin

11:50 AM Feature #1584 (WIP): add conversion and runtime support for INT64 and DATETIME data types

Ovidiu Maxiniuc

12/15/2012

05:54 PM Feature #1591: implement QUOTER built-in function

Feedback:
This javadoc for the 2 parameter version needs to be changed:... Greg Shah

12/14/2012

03:26 PM Support #1928 (WIP): update documentation to explain how to convert, develop and run P2J on Windows

Yes, these are the projects that need to be updated.... Greg Shah

02:15 PM Support #1928: update documentation to explain how to convert, develop and run P2J on Windows

If my understanding is OK the you mean the following directories need to be updated:
p2j_books/conversion_handbook
... Eugenie Lyzenko

03:22 PM Feature #1611: implement QUOTER utility

Feedback, Part 2:
14. I think that preProcessQuoter() needs to be renamed. It leaves the impression that it is ju... Greg Shah

12:58 PM Feature #1611: implement QUOTER utility

Feedback, Part 1:
ProcessDaemon:
1. The file needs its copyright date updated.
2. The changes in prepareComm... Greg Shah

06:20 AM Feature #1611 (Review): implement QUOTER utility

Costin Savin

06:16 AM Feature #1611: implement QUOTER utility

Submitted testcases to bazaar added proposed update (revised and re-tested) Costin Savin

01:34 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Please focus on the conversion aspects of this task first and only stub out the runtime support at first. Start with... Eric Faulhaber

09:49 AM Feature #1626: implement OS-DIR support as an INPUT stream

After testing the simple case of OS-DIR usage (no options)... Costin Savin

07:27 AM Feature #1626 (WIP): implement OS-DIR support as an INPUT stream

Costin Savin

07:16 AM Feature #1591: implement QUOTER built-in function

Added revised proposed update. From what I understand there are plans to move code that is not character specific fro... Costin Savin

12/13/2012

06:33 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

Testing on both Linux and Windows reports the changes in
com/goldencode/p2j/util/character.java
com/goldencode/p2j/... Eugenie Lyzenko

02:38 PM Feature #1611: implement QUOTER utility

discovered a bug will add new update once fixed. Costin Savin

01:26 PM Feature #1611: implement QUOTER utility

Added proposed update and edited the quoter description post . Costin Savin

11:45 AM Feature #1611: implement QUOTER utility

I know of these cases, but the current ProcessDaemon code does not support them. You don't need to support it at thi... Greg Shah

11:26 AM Feature #1611: implement QUOTER utility

implemented logic to check for quoter case in all the cases, however there are cases like:... Costin Savin

12/12/2012

06:22 PM Feature #1611: implement QUOTER utility

Assuming you have handled all the known issues, you can prepare/upload the update. Make sure the documentation you h... Greg Shah

06:21 PM Feature #1611: implement QUOTER utility

The documentation is pretty good. Some comments:... Greg Shah

02:56 PM Feature #1611: implement QUOTER utility

*QUOTER UTILITY DESCRIPTION*
The quoter utility will put the elements identified and extracted from the
input... Costin Savin

02:55 PM Feature #1611: implement QUOTER utility

1. If a quoter command will be split in this way in p2j it will also not work in Progress. Checked.
2. This doesn'... Costin Savin

02:33 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

Your latest approach is all good except that we don't need a new p2j.cfg.xml parameter. We already have one that is ... Greg Shah

01:37 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

> Do not use the current conversion platform to determine how we convert strings. We can't go this route.
OK. I se... Eugenie Lyzenko

12/11/2012

05:27 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

Do not use the current conversion platform to determine how we convert strings. We can't go this route. The problem... Greg Shah

03:32 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

Fix for backslash processing for conversion on Windows.
The suggested solution will be activated only when running... Eugenie Lyzenko

09:22 AM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

This is all a single update. Greg Shah

09:08 AM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

The Windows tests is OK too. I would like to make more tests with simulated two chars path separator to be sure this ... Eugenie Lyzenko

08:22 AM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

Looks good. Greg Shah

02:49 PM Feature #1611: implement QUOTER utility

... Greg Shah

02:41 PM Feature #1611: implement QUOTER utility

Please show an example here that reproduces the problem. And show the error output from the 4GL. Greg Shah

02:39 PM Feature #1611: implement QUOTER utility

There is one case of error message which might not be able to be reproduced exactly as in Progress. When we pass the ... Costin Savin

03:33 AM Feature #1611: implement QUOTER utility

That would be much easier since I already have these checks in place before doing the pattern check which is supposed... Costin Savin

12:44 PM Support #1928: update documentation to explain how to convert, develop and run P2J on Windows

Update all P2J books to describe how to:
- run conversion on Windows
- run P2J (client and server) on Windows
- se... Greg Shah

12:42 PM Support #1928 (Closed): update documentation to explain how to convert, develop and run P2J on Wi...

Greg Shah

11:04 AM Feature #1921: implement super-procedures

I'm OK with your approach. Greg Shah

10:48 AM Feature #1921: implement super-procedures

After looking at progress.g, SymbolResolver.addFunction and Function.annotateOptions, the simplest way I see to solve... Constantin Asofiei

10:12 AM Feature #1921: implement super-procedures

If there are frame definition inside a "to-be-hidden" local function or procedure, then the frame definition "leaks" ... Constantin Asofiei

09:29 AM Feature #1921: implement super-procedures

My first approach is to just drop the sub-trees.
Thanks for the frame definition tip, I'll check also how these case... Constantin Asofiei

09:21 AM Feature #1921: implement super-procedures

What is your approach to handling this behavior? Do you just hide or drop the sub-trees?
One thing to consider: a... Greg Shah

09:02 AM Feature #1921: implement super-procedures

Greg, the order of the procedure/function is not important. No matter how you mix the procedures/functions in the abo... Constantin Asofiei

08:28 AM Feature #1921: implement super-procedures

Good findings. I find it hard to understand the value of this complexity. Much of the behavior seems arbitrary.
... Greg Shah

07:51 AM Feature #1921: implement super-procedures

4GL allows procedure (and function) definitions with the same name, under some circumstances.
If two or more procedu... Constantin Asofiei

12/10/2012

05:39 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

The new version of the fixupPropath() method.
1. Handles the arbitrary length of the path separator
2. Optimizing f... Eugenie Lyzenko

09:58 AM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

... Greg Shah

09:16 AM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

> The fixupPropath() should be a little different. I don't want getPathSeparator() called more than once, because it ... Eugenie Lyzenko

08:24 AM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

I am OK with the changes to setSearchPath(), getPathSeparator(), getLegacyPathSeparator() and getLegacyFileSeparator(... Greg Shah

03:07 PM Feature #1611: implement QUOTER utility

Is there anything wrong with my assumption that the path and the executable name will be in the same string AND that ... Greg Shah

03:01 PM Feature #1611: implement QUOTER utility

I've tried to cover that, here is an example for the latest pattern I've gotten today:... Costin Savin

02:55 PM Feature #1611: implement QUOTER utility

Costin: yes, we should handle paths on network shares.
Are we making this too difficult? The basic matching seem... Greg Shah

01:48 PM Feature #1611: implement QUOTER utility

> Should also windows network paths be detected as paths for quoter?
> I'm having a little trouble with the regular ... Eugenie Lyzenko

01:40 PM Feature #1611: implement QUOTER utility

Should also windows network paths be detected as paths for quoter?
I'm having a little trouble with the regular expr... Costin Savin