FWD » Core Development » Base Language

01/18/2013

06:18 PM Feature #1920: implement persistent procedures

Feedback on the Java implementation:
1. StaticProxy.invoke() is missing the method level description text in javad... Greg Shah

05:07 PM Feature #1920: implement persistent procedures

... Greg Shah

04:55 PM Feature #1920: implement persistent procedures

OK, I understand now what you mean, emit workers in the generated code. About the hints - if a file contains multiple... Constantin Asofiei

04:47 PM Feature #1920: implement persistent procedures

And of course, the BlockManager.*Function() methods would need variants that take the extra parameter. Greg Shah

04:46 PM Feature #1920: implement persistent procedures

I was thinking more along the lines of:... Greg Shah

04:41 PM Feature #1920: implement persistent procedures

When I said the DYNAMIC-FUNCTION return type is static, I mean that if the target is hard coded, then the DYNAMIC-FUN... Greg Shah

04:28 PM Feature #1920: implement persistent procedures

About entry 89 - I need to keep in mind that at least TARGET-PROCEDURE handle might be used in cojunction with the SE... Constantin Asofiei

04:18 PM Feature #1920: implement persistent procedures

I don't think DYNAMIC-FUNCTION's return type is "static"... I think it's something more like the Object type in Java.... Constantin Asofiei

04:08 PM Feature #1920: implement persistent procedures

... Greg Shah

03:59 PM Feature #1920: implement persistent procedures

Here are some results from my searches.
In my latest scan, there are 12690 instances of DYNAMIC-FUNCTION. Of thos... Greg Shah

03:31 PM Feature #1920: implement persistent procedures

First, about the DYNAMIC-FUNCTION's case: idea is, 4GL does compile such code (where the type of the operand is evalu... Constantin Asofiei

02:39 PM Feature #1920: implement persistent procedures

... Greg Shah

11:32 AM Feature #1920: implement persistent procedures

> 1. Did you check on the effect to Majic of removing of the move of the define parameter of a buffer in record_scopi... Constantin Asofiei

11:30 AM Feature #1920: implement persistent procedures

Unfortunately, another issue appears: DYNAMIC-FUNCTION calls can be used in complex expressions (arithmetic, logical,... Constantin Asofiei

11:16 AM Feature #1920: implement persistent procedures

> 1. Did you check on the effect to Majic of removing of the move of the define parameter of a buffer in record_scopi... Constantin Asofiei

10:58 AM Feature #1920: implement persistent procedures

Feedback on the latest rules changes:
1. Did you check on the effect to Majic of removing of the move of the defin... Greg Shah

10:00 AM Feature #1920: implement persistent procedures

> Why does the first convert to a BlockManager.doWhile() but the second converts to a Java while() loop? If the dyna... Constantin Asofiei

09:55 AM Feature #1920: implement persistent procedures

... Greg Shah

09:01 AM Feature #1920: implement persistent procedures

Another idea for the @IF <func-name>()@ case would be: why not emit directly something like @if (((logical)ControlFlo... Constantin Asofiei

08:37 AM Feature #1920: implement persistent procedures

Attached update has the following new fixes:
* javadoc fixes
* merged with latest bazaar files
* fixed conversion of ... Constantin Asofiei

03:16 AM Feature #1920: implement persistent procedures

> 1. The read_only_attribute function in common-progress.rules seems like it will be painful to maintain over time, s... Constantin Asofiei

07:43 PM Feature #1920: implement persistent procedures

Feedback:
0. First: WOW! Really good work.
1. The read_only_attribute function in common-progress.rules seems ... Greg Shah

02:10 PM Feature #1639: implement socket support

Commited to bazaar an initial set of testcases #1957: Use cases for the socket and server-socket attributes and metho... Costin Savin

12:17 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

I added @SESSION:YEAR-OFFSET@, @DATETIME@ fields in a temp-table and support arrays (@EXTEND@) of @int64@ and @DATETI... Ovidiu Maxiniuc

08:43 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Code review 20130117a:
* Nice functional addition! A bit more to go for Milestone 4 (e.g., defining DATETIME in a... Eric Faulhaber

09:34 AM Feature #1962: modify parser to add a readOnly boolean annotation to all attributes and change po...

1. Change the SymbolResolver.addAttributeOrMethod() to take a 3rd parameter: boolean readOnly. It should store this i... Greg Shah

09:31 AM Feature #1962 (New): modify parser to add a readOnly boolean annotation to all attributes and cha...

Greg Shah

01/17/2013

06:44 PM Feature #1649: implement Windows environment/registry access

... Greg Shah

06:27 PM Feature #1649: implement Windows environment/registry access

Greg,
I have followed with the conversion process and found the language keywords are already supported in progres... Eugenie Lyzenko

05:30 PM Feature #1626: implement OS-DIR support as an INPUT stream

Two more additions to the feedback:
7. DirStream should use com.goldencode.util.PlatformHelper.isUnderWindowsFamil... Greg Shah

05:13 PM Feature #1626: implement OS-DIR support as an INPUT stream

You don't need separate history entries for #1613 and #1626. Just merge the text into a single entry and use the sam... Greg Shah

05:00 PM Feature #1626: implement OS-DIR support as an INPUT stream

Feedback on cs_upd20130117a.zip:
1. The FileSystemDaemon changes are definitely wrong. For example, it is valid f... Greg Shah

11:35 AM Feature #1626: implement OS-DIR support as an INPUT stream

added cs_upd20130116b Costin Savin

11:03 AM Feature #1626: implement OS-DIR support as an INPUT stream

The regression testing for cs_upd20130116a.zip has passed, but to clear testing we had to roll back the StreamWrapper... Greg Shah

05:40 AM Feature #1626: implement OS-DIR support as an INPUT stream

Solved the pipe problem by opening the file in non-blocking mode, which is good that worked since there is no other w... Costin Savin

05:09 PM Feature #1613: finish FILE-INFO system handle support

See the code feedback notes in #1626. As noted there, DO NO FURTHER WORK ON THIS UNTIL AFTER THE MILESTONE 4 DELIVER... Greg Shah

11:27 AM Feature #1613: finish FILE-INFO system handle support

Added proposed update with described changes (also contains FileChecker and filesys.c hopefully it will not collide w... Costin Savin

11:03 AM Feature #1613: finish FILE-INFO system handle support

Finished the update, however modification to search(String[] paths, boolean caseSens, String filename) from FileSy... Costin Savin

06:49 AM Feature #1920: implement persistent procedures

Some other notes related to functions/procedures which have buffer parameters. For these cases, the actual parameter ... Constantin Asofiei

06:39 AM Feature #1920: implement persistent procedures

This update adds:
- a first phase of SEARCH-TARGET mode for super calls
- support for parameter mode validation for... Constantin Asofiei

04:48 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

The update pack includes a sample testcase with an expected output sample (as obtained from windev01). It contains th... Ovidiu Maxiniuc

01/16/2013

06:08 PM Feature #1626: implement OS-DIR support as an INPUT stream

You can't open a pipe like a regular file. It is a very special fake filename that is implemented by code in the kern... Greg Shah

12:42 PM Feature #1626: implement OS-DIR support as an INPUT stream

Finished the logic for unix/windows adding another bitfield to the result that will point if unix or windows logic wi... Costin Savin

07:03 AM Feature #1626: implement OS-DIR support as an INPUT stream

OK, I will apply the update to staging so we can retest. If it passes we will check it in, even though there are dev... Greg Shah

05:37 AM Feature #1626: implement OS-DIR support as an INPUT stream

Tested the behavior for UNIX 4GL and noticed notable differences than the Windows 4GL:
- The current dir "." is no... Costin Savin

03:19 AM Feature #1626: implement OS-DIR support as an INPUT stream

Added proposed update which changes in: StreamWrapper.assign(Stream s) on how the inOk and outOk are assigned to avoi... Costin Savin

06:04 PM Feature #1920: implement persistent procedures

I think the issue is caused by this code:... Greg Shah

10:37 AM Feature #1920: implement persistent procedures

Constantin Asofiei wrote:
> The parameter mode for function calls (DYNAMIC-FUNCTION or simple function call) is remo... Constantin Asofiei

10:23 AM Feature #1920: implement persistent procedures

The parameter mode for function calls (DYNAMIC-FUNCTION or simple function call) is removed by some code I guess in p... Constantin Asofiei

09:35 AM Feature #1920: implement persistent procedures

I like it. Greg Shah

09:32 AM Feature #1920: implement persistent procedures

Ok, I think I understand now. What you are suggesting is to condense the parameter modes into a string and emit it as... Constantin Asofiei

09:13 AM Feature #1920: implement persistent procedures

... Greg Shah

08:47 AM Feature #1920: implement persistent procedures

Yes, you understood correctly, we need the parameter modes set to the RUN or function call statement.
> I prefer to ... Constantin Asofiei

08:24 AM Feature #1920: implement persistent procedures

If I understand properly, the problem is that the calling side does not supply the missing signature information (ess... Greg Shah

04:20 AM Feature #1920: implement persistent procedures

Another issues which we need to decide if we support it or not is the attribute's mode set when the function/procedur... Constantin Asofiei

09:24 AM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

Updated archive uploaded. Eugenie Lyzenko

09:05 AM Feature #1634: implement full native library (.so or DLL) support

OK, so the only remaining questions:
1. What do we do with the PROCEDURE EXTERNAL calls for their purpose of *regi... Greg Shah

04:25 AM Feature #1634: implement full native library (.so or DLL) support

All native procedure calls convert the same way as internal (or external) procedures. The fact that the target is a n... Constantin Asofiei

07:22 AM Feature #1613: finish FILE-INFO system handle support

... Greg Shah

05:21 AM Feature #1613: finish FILE-INFO system handle support

Tested on Unix 4GL:
It seems that FILE-INFO:FILE-CREATE-* doesn't actually return any value on Unix.
File types for... Costin Savin

03:22 AM Feature #1613: finish FILE-INFO system handle support

2. The problem with searchPath is that it only returns the value, if the target is a file, otherwise it returns null,... Costin Savin

06:46 AM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...

... Greg Shah

01/15/2013

06:32 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...

Looks like we now already have properly conversion for DOS statement. The following line
dos dir /w > dir.log.
conv... Eugenie Lyzenko

02:50 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...

Option 2 is certainly how we want to do it. Yes, it is up to the application to only try to run child processes that ... Greg Shah

02:32 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...

At this time I have not found any other statements except DOS to add the conversion support. As far as I understood t... Eugenie Lyzenko

10:56 AM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...

Please provide a summary of your findings so far.
I know that the DOS statement needs conversion support. I would... Greg Shah

04:28 PM Feature #1649: implement Windows environment/registry access

For now, we need to add conversion support (for all features mentioned above) and the minimum runtime stubs to make t... Greg Shah

04:26 PM Feature #1961: implement runtime backing for Windows environment/registry access

This task is only for tracking time. Do NOT put any history entries here. Put all history entries in the parent task... Greg Shah

04:26 PM Feature #1961 (Closed): implement runtime backing for Windows environment/registry access

Greg Shah

04:25 PM Feature #1960: conversion support for Windows environment/registry access

This task is just for tracking spent time. Do NOT put any history entries here. Put all history into the parent tas... Greg Shah

04:24 PM Feature #1960 (Closed): conversion support for Windows environment/registry access

Greg Shah

02:43 PM Feature #1613: finish FILE-INFO system handle support

Feedback:
1. The build.xml and makefile are not changed in your update. Remove them unless you have real changes.... Greg Shah

12:43 PM Feature #1613: finish FILE-INFO system handle support

Added proposed update , will test on Unix 4GL for matching behavior. Costin Savin

12:19 PM Feature #1613: finish FILE-INFO system handle support

Yes, do build the changes on top of the files from #1626 as this is in test and should pass soon. We can always make... Greg Shah

12:11 PM Feature #1613: finish FILE-INFO system handle support

On Unix the only date the system keeps regarding files is the last access date which is probably what Progress on Uni... Costin Savin

01:28 PM Feature #1607: implement full named events support

Yes. As THIS-PROCEDURE needs to return the external procedure handle to which the current statement belongs, I've imp... Constantin Asofiei

12:51 PM Feature #1607: implement full named events support

The ProcedureManager will have enough information to know the immediate caller (in the converted code) and associate ... Greg Shah

12:41 PM Feature #1607: implement full named events support

I don't see any valid reason to emit an explicit ProcedureManager.thisProcedure() call in these cases. The runtime sh... Constantin Asofiei

12:02 PM Feature #1607: implement full named events support

The 4GL documentation suggests that the following are implicit uses of THIS-PROCEDURE:
PUBLISH without a FROM clau... Greg Shah

11:58 AM Feature #1607: implement full named events support

Named events also support the PUBLISHED-EVENTS attribute, which the documentation suggests is a string created at com... Greg Shah

12:02 PM Feature #1920: implement persistent procedures

Summary for more tested issues:
* merged files with latest bzr versions
* proper error messages for read-only assig... Constantin Asofiei

08:17 AM Feature #1920: implement persistent procedures

Yes, your approach makes perfect sense. The 4GL "feature" is absurd. Greg Shah

07:11 AM Feature #1920: implement persistent procedures

In 4GL, code with read-only attributes on the right-side of an expression gets compiled, as in:... Constantin Asofiei

10:07 AM Feature #1958: implement the runtime support for sockets

This task is only meant to capture time spent on the runtime portion of the parent task. Do NOT put any history entr... Greg Shah

10:03 AM Feature #1958 (Closed): implement the runtime support for sockets

Greg Shah

10:06 AM Feature #1959: implement JNI runtime support for native libraries

This task is only meant to capture time spent on the conversion portion of task #1634. Do NOT put any history entrie... Greg Shah

10:06 AM Feature #1959 (Closed): implement JNI runtime support for native libraries

Greg Shah

10:01 AM Feature #1957: develop a set of testcases that utilize all features of the 4GL socket and server ...

This task is only meant to capture time spent on the testcase creation portion of task #1639. Do NOT put any history... Greg Shah

09:59 AM Feature #1957 (Closed): develop a set of testcases that utilize all features of the 4GL socket an...

Greg Shah

09:58 AM Feature #1956: implement conversion support for sockets

This task is only meant to capture time spent on the conversion portion of task #1639. Do NOT put any history entrie... Greg Shah

09:54 AM Feature #1956 (Closed): implement conversion support for sockets

Greg Shah

09:51 AM Feature #1639: implement socket support

Other 4GL socket features:
CREATE SERVER-SOCKET statement
DELETE OBJECT for socket handles and for server socket ... Greg Shah

01/14/2013

06:36 PM Feature #1624: add support for PUT CONTROL

This is already supported. Someone should generate some representative testcases and prove that there are no issues,... Greg Shah

06:30 PM Feature #1630: implement support for UNBUFFERED in I/O statements

Conversion is already supported. But the runtime probably needs changes to support this option. Testcases will have... Greg Shah

05:40 PM Feature #1634: implement full native library (.so or DLL) support

The following need to be supported:
PROCEDURE procname EXTERNAL "dllname":
DEFINE <type> PARAMETER ...
END PR... Greg Shah

05:21 PM Feature #1950: conversion support for native library (.so or .DLL) access

This task is for tracking purposes, but all discussions should take place in the parent task #1634. The runtime chang... Greg Shah

05:20 PM Feature #1950 (Closed): conversion support for native library (.so or .DLL) access

Greg Shah

04:29 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

Status update: My recent update completely passed the harness cycle with the last testing in separate directory. Eugenie Lyzenko

03:44 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

I just finished rebuilding with all updates applied. Eric will be handling the reconversion in 20 minutes. He has t... Greg Shah

03:41 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

Greg,
Please start the P2J rebuild and reconversion now. After this is finished I'll start the DB restore and new ... Eugenie Lyzenko

03:24 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

> I can apply your change and rebuild if it is ready.
I have applied my update.
...
-rw-r--r-- 1 evl gc 113230 ... Eugenie Lyzenko

03:16 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

Yes, we will wait 30 minutes for your previous harness results. Let me know. I can apply your change and rebuild if... Greg Shah

03:07 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

Another question. What about customer_libs subdirectory? Do we need to clean it up before testing? Eugenie Lyzenko

03:02 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

> Are you sure you want to test this separate from other changes? If it has already passed testing, then it should be... Eugenie Lyzenko

02:51 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

Are you sure you want to test this separate from other changes? If it has already passed testing, then it should be ... Greg Shah

02:38 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

The uploaded file contains the merge with the current p2j bzr status. Eugenie Lyzenko

01:17 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

> What is the status of your update? Did it pass harness testing?
The CTRL-C tests have been passed. The main part... Eugenie Lyzenko

01:10 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

What is the status of your update? Did it pass harness testing?
You will need to merge it with the latest level o... Greg Shah

01:17 PM Feature #1626: implement OS-DIR support as an INPUT stream

I have applied this to staging but it is NOT yet rebuilt. Later today, some other changes will be applied, the code ... Greg Shah

11:46 AM Feature #1626: implement OS-DIR support as an INPUT stream

Conversion test passed. Costin Savin

10:20 AM Feature #1626: implement OS-DIR support as an INPUT stream

Added the proposed update , testcases passed - modified and commited to bzr the testcase for seek position since it c... Costin Savin

09:06 AM Feature #1626: implement OS-DIR support as an INPUT stream

I should also note that using multiple chained .append() method calls is more efficient than using the + string conca... Greg Shah

08:47 AM Feature #1626: implement OS-DIR support as an INPUT stream

You are right. I must have been comparing the wrong StreamWrapper file.... Greg Shah

08:35 AM Feature #1626: implement OS-DIR support as an INPUT stream

Found a bug when using relative paths, the path name implemented by File.getAbsolutePath() does not have the same beh... Costin Savin

12:44 PM Feature #1613: finish FILE-INFO system handle support

At this point, I don't think it is a good idea to rely on something only in Java 7. Our current production customer ... Greg Shah

12:39 PM Feature #1613: finish FILE-INFO system handle support

Finished and tested the FILE-INFO:FILE-TYPE logic wit OS-DIR code reuse.
For FILE-INFO:FILE-CREATE-* there might be... Costin Savin

11:28 AM Feature #1613: finish FILE-INFO system handle support

OK, great! Put the update together ASAP and upload it. Greg Shah

10:44 AM Feature #1613: finish FILE-INFO system handle support

> I am OK with reusing the native method, so long as the result is 100% compatible. Does the FILE-TYPE attribute actu... Costin Savin

10:18 AM Feature #1613: finish FILE-INFO system handle support

I am OK with reusing the native method, so long as the result is 100% compatible. Does the FILE-TYPE attribute actua... Greg Shah

11:02 AM Feature #1920: implement persistent procedures

Summary for more tested issues:
* fixed the DYNAMIC-FUNCTION's error messages
* testing of RUN SUPER and SUPER cal... Constantin Asofiei

09:03 AM Feature #1920: implement persistent procedures

Good work! I'm really excited to see this come together.... Greg Shah

01/12/2013

12:37 PM Feature #1920: implement persistent procedures

Summary for more tested issues:
* handle equality tests
* persistent procedure chains (SESSION handle's first-proce... Constantin Asofiei

09:09 AM Feature #1613: finish FILE-INFO system handle support

For FILE-INFO:FILE-TYPE we can reuse the native code for OS-DIR as main type and just keep the read/write type logic ... Costin Savin

06:38 AM Feature #1626: implement OS-DIR support as an INPUT stream

The results of the tests are ok, ran the conversion tests and there weren't any differences. Costin Savin

04:45 AM Feature #1626: implement OS-DIR support as an INPUT stream

1. I checked the StreamWrapper from proposed update against bzr and the changes are on method assignStream(Stream s)
... Costin Savin

01/11/2013

05:55 PM Feature #1613 (WIP): finish FILE-INFO system handle support

Assuming new JNI methods are needed, they can be placed into filesys.c.
The conversion support is in rules/convert... Greg Shah

05:52 PM Feature #1626: implement OS-DIR support as an INPUT stream

I have 2 questions:
1. Where is the StreamWrapper change? The one that is included in the update is identical wit... Greg Shah

01:23 PM Feature #1626: implement OS-DIR support as an INPUT stream

Added the proposed update.
Costin Savin

12:48 PM Feature #1626: implement OS-DIR support as an INPUT stream

... Greg Shah

12:22 PM Feature #1626: implement OS-DIR support as an INPUT stream

> 6. In FileChecker.getFileType(), there needs to be code to handle the -1 (error case). I stubbed it out in my examp... Costin Savin

05:52 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Additional requirements:
* define a DATETIME variable
* define a DATETIME field in a temp-table
* assign a DATET... Eric Faulhaber

05:11 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

The highest priorities for the DATETIME implementation:
NOW
MTIME
ADD-INTERVAL
DATETIME
SESSION:TIME-SOURCE ... Greg Shah

01:23 PM Feature #1920: implement persistent procedures

Summary for what is tested and known to be working:
* FILE-INFO, SESSION, ERROR-STATUS, LAST-KEY, CURRENT-WINDOW hand... Constantin Asofiei

09:55 AM Feature #1920: implement persistent procedures

ErrorManager.isError() is what should be used from converted application code, to access ERROR-STATUS:ERROR. If I re... Greg Shah

09:50 AM Feature #1920: implement persistent procedures

Which ErrorManager API maps the ERROR-STATUS:ERROR flag ? isError or isErrorFlag ? Constantin Asofiei

01/10/2013

05:59 PM Feature #1626: implement OS-DIR support as an INPUT stream

Feedback:
1. In input_output.rules, this change seems wrong:... Greg Shah

12:10 PM Feature #1626: implement OS-DIR support as an INPUT stream

Added proposed update, hope I didn't miss anything. Costin Savin

03:44 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

This plan sounds good.
My only feedback is that it is probably best to encode the time value as a number of mill... Greg Shah

12:30 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

As @date@ / @datetime@ and @datetime-tz@ all represent some kind of timestamp the following question raise:
Isn't i... Ovidiu Maxiniuc

12:23 PM Feature #1920: implement persistent procedures

All of your decisions are good ones. I agree with the deferral of the old API name mapping. Greg Shah

10:58 AM Feature #1920: implement persistent procedures

About the invalid API calls (when the invoked API is not valid for the current referent). 4GL shows these kind of mes... Constantin Asofiei

01/09/2013

03:10 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

> You only need to compare the src/aero/timco/majic directories.
The directories are identical. The next step I'm ... Eugenie Lyzenko

01:59 PM Feature #1626: implement OS-DIR support as an INPUT stream

We will handle that in a different task. We will likely use platform specific files with functions that are called f... Greg Shah

01:32 PM Feature #1626: implement OS-DIR support as an INPUT stream

Finished and tested the filesys.c version that handles all the logic inside the c code using bitfield approach for st... Costin Savin

09:30 AM Feature #1611 (Closed): implement QUOTER utility

Greg Shah

08:40 AM Feature #1611: implement QUOTER utility

Costin: please check in the code to bzr and distribute the update to the team.
I won't be promoting this version o... Greg Shah

01:34 AM Feature #1611: implement QUOTER utility

The testing results have been uploaded into shared GCD drive: 20130107_*.zip 20130108_*.zip(4 files). The all tests c... Eugenie Lyzenko

01/08/2013

04:38 PM Feature #1611: implement QUOTER utility

I have started another harness cycle about a hour ago. We will know today if this issue be repeated. Eugenie Lyzenko

04:24 PM Feature #1611: implement QUOTER utility

Strange. Can you reproduce the problem manually? Greg Shah

03:57 PM Feature #1611: implement QUOTER utility

The current report(The failing line is second in the figures below):... Eugenie Lyzenko

03:24 PM Feature #1611: implement QUOTER utility

It is unlikely, but yes, it is possible. Please show the lines of output in the report that are different. Greg Shah

02:51 PM Feature #1611: implement QUOTER utility

Is there inside the update some code that can affect data sorting algirythm inside report generated? I have one issue... Eugenie Lyzenko

04:18 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

You only need to compare the src/aero/timco/majic directories. Greg Shah

04:01 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

Is it enough to compare just src/aero/timco/majic to make sure the generated java code is identical? Or we need to co... Eugenie Lyzenko

03:21 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

Yes, good plan. Make sure to compare the converted output from staging with the output from your copied build. It s... Greg Shah

02:47 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

> Let me know if there are any questions.
The plan is:
After current staging passes the regression testing I will... Eugenie Lyzenko

12:23 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

It looks good. Please go ahead with testing. It needs both conversion AND runtime testing. The conversion testing ... Greg Shah

12:18 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

OK. The update has been uploaded. Eugenie Lyzenko

11:49 AM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

Feedback on the PlatformHelper:
1. Remove the JPRM column from the header. Since there are no JPRM numbers and JPR... Greg Shah

10:51 AM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

The new update to review. The method isUnderWindowsFamily() has been move to the separate class com.goldencode.util.P... Eugenie Lyzenko

10:17 AM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

Yes, that makes sense. Greg Shah

10:13 AM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

> Please create a new class com.goldencode.util.PlatformHelper. Put the static method isWindowsFamily() in there. Cal... Eugenie Lyzenko

09:23 AM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

Everything looks good except for 1 thing.
We don't want com.goldencode.util to depend upon com.goldencode.p2j.util... Greg Shah

01:26 PM Feature #1626: implement OS-DIR support as an INPUT stream

> 1. I don't like that you have made the status codes mutually exclusive..
> 2. I don't see how you can ever get the... Costin Savin

12:04 PM Feature #1626: implement OS-DIR support as an INPUT stream

This is a step in the right direction, but it is incomplete or wrong in some ways.
1. I don't like that you have m... Greg Shah

11:17 AM Feature #1626: implement OS-DIR support as an INPUT stream

The C implementation "filesys.c" according to Progress documentation... Costin Savin

03:12 AM Feature #1626: implement OS-DIR support as an INPUT stream

> ... they mean that the L, H and P attributes are always IN ADDITION TO the main attribute F, D, S or X
Yes those at... Costin Savin

08:43 AM Support #1928: update documentation to explain how to convert, develop and run P2J on Windows

The latest document update uploaded. With small synytax fix and new line behavior description adding. Eugenie Lyzenko

01/07/2013

05:22 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

The Windows detection code has been moved to separate statis method of the EnvironmentOps class.
Also I made one s... Eugenie Lyzenko

04:33 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

Yes, please make a new method for isUnderWindowsFamily() and use that everywhere necessary. Then upload the latest c... Greg Shah

03:47 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

The new archive has been uploaded here for you to review.
The question: In getLegacyCaseSensitive() I have used "i... Eugenie Lyzenko

02:54 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

Feedback:
1. In ExpressionConversionWorker, instead of this:... Greg Shah

01:51 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

The cumulative fix has been uploaded here. Eugenie Lyzenko

01:26 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

Please upload the complete update zip into this task so that I can do a final code review. Greg Shah

02:32 PM Feature #1626: implement OS-DIR support as an INPUT stream

To be clear, I think that when Progress says "You might also get one or more of the following characters:" they mean ... Greg Shah

02:29 PM Feature #1626: implement OS-DIR support as an INPUT stream

Implement option 2 (create the Linux implementation even though we cannot test the 4GL on Linux today). Please note ... Greg Shah

01:50 PM Feature #1626: implement OS-DIR support as an INPUT stream

The pipes case may be a problem to detect, since files and FIFO pipes are both marked with "F" only nonFIFO pipes w... Costin Savin

02:04 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...

Please implement full process launching support for Windows. This means that src/native/process.c will need modifica... Greg Shah

11:07 AM Feature #1920: implement persistent procedures

Yes, you've got the idea.
I think your implementation approach (e.g. CommonProcedure) makes sense.
One note: us... Greg Shah

08:14 AM Feature #1920: implement persistent procedures

Ok, now I undestand what you mean: when the resource is of a known type (widget, persistent procedure,etc), unwrap wi... Constantin Asofiei

10:15 AM Feature #1611: implement QUOTER utility

The latest update for this tast is cs_upd20121219a.zip the cs_upd20121231a? is for the other quoter (built-in) #1591.... Costin Savin

10:09 AM Feature #1611: implement QUOTER utility

> Did you get a chance to work on it?
Costin,
Have you updates ready to test in lightning? Is it only cs_upd20... Eugenie Lyzenko

03:02 AM Feature #1591: implement QUOTER built-in function

I've applied the update to staging and P2J is rebuilt. Constantin Asofiei

01/04/2013

11:31 AM Feature #1626: implement OS-DIR support as an INPUT stream

For Windows stat() seems to do the job, but in Unix lstat() must be used or link will not be corectly detected.
2-> ... Costin Savin

11:06 AM Feature #1626: implement OS-DIR support as an INPUT stream

It is OK to be linux-specific right now. We will have separate tasks to port this to Windows.
Some initial feedba... Greg Shah

10:32 AM Feature #1626: implement OS-DIR support as an INPUT stream

Actually , I realize this will have to be tested on a windows system since there might be problems with lstat(). Costin Savin

10:21 AM Feature #1626: implement OS-DIR support as an INPUT stream

The code for filesys.c... Costin Savin

09:52 AM Feature #1626: implement OS-DIR support as an INPUT stream

Good. Please post your prototype code for review. Just paste the code into your redmine issue update if it is small... Greg Shah

09:42 AM Feature #1626: implement OS-DIR support as an INPUT stream

This also requires some changes to the ant task "native" ,
otherwise I made the changes and tested for symbolic lin... Costin Savin

08:10 AM Feature #1626: implement OS-DIR support as an INPUT stream

Yes, this solution is OK. We already have a libp2j.so (which we will have to also port to Windows as p2j.dll). Righ... Greg Shah

01/03/2013

10:21 AM Feature #1626: implement OS-DIR support as an INPUT stream

Java (at least until Java 7 NIO 2) doesn't seem to have a way of detecting symbolic links( the problem it's likely th... Costin Savin

12/31/2012

11:34 AM Feature #1591: implement QUOTER built-in function

OK, it looks good. These additions should not be able to cause any runtime regressions. So I am going to bypass reg... Greg Shah

06:41 AM Feature #1591: implement QUOTER built-in function

Added proposed update Costin Savin

10:57 AM Feature #1920: implement persistent procedures

... Greg Shah

12/27/2012

03:37 PM Support #1928: update documentation to explain how to convert, develop and run P2J on Windows

Small changes to Windows specific has been uploaded. The issues for conversion INPUT THROUGH, OUTPUT THROUGH and INPU... Eugenie Lyzenko

12/25/2012

05:08 PM Support #1928: update documentation to explain how to convert, develop and run P2J on Windows

The updated versions of the document have been uploaded here. Also the new document part describing the run-time setu... Eugenie Lyzenko

12/22/2012

07:43 AM Feature #1920: implement persistent procedures

If I understood right, then there will be "handle.unwrap<Resource>" APIs, like:
* handle.unwrapWidget for widget han... Constantin Asofiei

12/21/2012

02:29 PM Support #1928: update documentation to explain how to convert, develop and run P2J on Windows

I've uploaded two draft files here, one for conversion handbook, another for developer guide. Now I'm thinking and st... Eugenie Lyzenko

01:26 PM Feature #1591: implement QUOTER built-in function

Feedback:
1. Remove the builtin_functions.rules from your zip. There are no changes there.
2. The character.ja... Greg Shah

01:09 PM Feature #1591: implement QUOTER built-in function

Added proposed update with the String overloaded methods. Costin Savin

12:12 PM Feature #1591: implement QUOTER built-in function

Yes. Greg Shah

12:09 PM Feature #1591: implement QUOTER built-in function

A quoter version which supports String instead of BaseDataType should probably be added to be reused for places where... Costin Savin

05:39 AM Feature #1591: implement QUOTER built-in function

Added the entry to expressions.odt Costin Savin

01:11 PM Feature #1920: implement persistent procedures

In addition to the general messiness that comes from having a global or "umbrella" interface, there is another practi... Greg Shah

12:35 PM Feature #1920: implement persistent procedures

The idea is, to be able to use handle.unwrap to access an attribute for any kind of handle (procedure handle, widget ... Constantin Asofiei

12:09 PM Feature #1920: implement persistent procedures

I thought we were going to use resource-specific interfaces instead of a global interface. I prefer it to be resourc... Greg Shah

09:32 AM Feature #1920: implement persistent procedures

Greg,
When collecting all the handle-related APIs in a "global" interface, I found some differences between the retu... Constantin Asofiei

11:33 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

The attached file contains only implementation and test cases for int64.
The changes are both syntactic and semantic... Ovidiu Maxiniuc

12/20/2012

01:36 PM Feature #1591: implement QUOTER built-in function

I forgot to ask you to update the documentation. Please update the builtin functions table in the expressions.odt ch... Greg Shah

08:59 AM Feature #1591 (Closed): implement QUOTER built-in function

Greg Shah

11:16 AM Feature #1921: implement super-procedures

Ok, that makes sense. Constantin Asofiei

10:58 AM Feature #1921: implement super-procedures

... Greg Shah

10:05 AM Feature #1921: implement super-procedures

I found a case which I haven't thought about until now. Consider we have these procedures:
* t1.p:... Constantin Asofiei

10:24 AM Feature #1626: implement OS-DIR support as an INPUT stream

Those parameters should NOT be emitted in the OS-DIR case. Greg Shah

09:58 AM Feature #1626: implement OS-DIR support as an INPUT stream

From default conversion logic p2j will also add 2 boolean parameters when calling StreamFactory.openOsDir: boolean w... Costin Savin

10:23 AM Feature #1611 (Test): implement QUOTER utility

I am OK with the proposed code.
Please work with Eugenie to put this through full runtime testing using lightning ... Greg Shah

10:03 AM Feature #1611: implement QUOTER utility

Actually it's the cs_upd20121219a.zip mistaken between the two quoter folders. Costin Savin

09:02 AM Feature #1611: implement QUOTER utility

This is the wrong update (it is the same one that goes with #1591). Please upload the proper update (probably it is ... Greg Shah

09:40 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Another error I found. The following sample code extracted from _OpenEdge® Development: ABL Reference_ (page 55) fail... Ovidiu Maxiniuc