Activity
From 01/02/2013 to 01/31/2013
02/01/2013
- 08:36 PM Feature #1640: implement DOM XML support
- > For an example of how to add the import, search on "createImport" in rules/convert/methods_attributes.rules.
Tha... - 08:21 PM Feature #1640: implement DOM XML support
- Yes, both get-child(x-node-ref, index) and get-document-element(x-node-ref) have expressions of type handle as the 1s...
- 08:15 PM Feature #1640: implement DOM XML support
- There are two methods unusual:
get-child(x-node-ref, index) and get-document-element(x-node-ref). The both of them r... - 07:13 PM Feature #1640: implement DOM XML support
- Yes, make an XEntity interface and make both the XDocument and XNodeRef extend that superinterface. That way they wi...
- 07:26 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- This update merges with the recent changes that should be in bazaar revision 10159. In addition, several javadoc err...
01/31/2013
- 06:25 PM Feature #1640: implement DOM XML support
- The point to discuss.
I'm implementing the attributes/methods conversion. It is OK with the current approach to de... - 02:45 PM Feature #1636: implement peristent trigger support
- PS for 11: and there is no need to save them in a global scope too, because when a persistent trigger is defined for ...
- 02:39 PM Feature #1636: implement peristent trigger support
- I don't think that would do the job, as a non-persistent trigger can hide a persistent trigger; the persistent trigge...
- 02:33 PM Feature #1636: implement peristent trigger support
- Our ScopedSymbolDictionary has a global scope facility that should do most of the work here. The only question I hav...
- 12:49 PM Feature #1636 (WIP): implement peristent trigger support
- 12:16 PM Feature #1636: implement peristent trigger support
- Some other notes related to scoping:
# if there is a non-persistent and a persistent trigger for the same event, the... - 10:31 AM Feature #1636: implement peristent trigger support
- Code feedback:
In registerTriggerPersistent() it says:... - 09:25 AM Feature #1636: implement peristent trigger support
- In regard to the global scope question for LT and TC:
1. The TriggerManager is scope-aware, but it currently has n... - 08:52 AM Feature #1636: implement peristent trigger support
- Adds conversion support; runtime support is missing implementation for the "persistent" nature of these triggers. Bui...
- 08:35 AM Feature #1636: implement peristent trigger support
- The conversion support is done, and a major part of the runtime (i.e. trigger invocation). The only runtime problem r...
- 01:17 PM Feature #1649: implement Windows environment/registry access
- The new update merged with recent code from Constantin and moved used variable to the head of the file because furthe...
- 12:49 PM Feature #1982 (WIP): conversion support for widget pools
- 11:46 AM Feature #1792: implement widget-pool support
- > 1. The WidgetPool.create/delete methods need variants for character expressions.
OK, I've added them.
> 2. Perh... - 10:16 AM Feature #1792: implement widget-pool support
- Code feedback:
1. The WidgetPool.create/delete methods need variants for character expressions.
2. Perhaps I miss... - 09:56 AM Feature #1792: implement widget-pool support
- It seems like there are 4 kinds of pools:
- un-named session pool (created automatically by the 4GL and used as th... - 08:49 AM Feature #1792: implement widget-pool support
- Added update for review (on top of bzr revision 10158).
- 08:41 AM Feature #1792: implement widget-pool support
- From the documentation and some testing, it seems that scoping is done on the nearest executing block; we should be a...
- 11:01 AM Feature #1920: implement persistent procedures
- Looks good.
- 10:49 AM Feature #1920: implement persistent procedures
- This update solves call chains like:...
- 09:17 AM Feature #1920: implement persistent procedures
- > my-handle:BUFFER-FIELD("field-name"):BUFFER-VALUE = <some_expression>.
This case is not covered yet; the method's ... - 09:04 AM Feature #1920: implement persistent procedures
- I am fine with the proposed changes. There is a large update in "front" of this for staging (my datetime, datetimetz...
- 04:50 AM Feature #1920: implement persistent procedures
- I've added non-null protection for the amref case you mentioned. Also, I've fixed another case found by Ovidiu: @BUFF...
- 08:35 AM Feature #1976 (Closed): conversion support for named events
- 08:25 AM Feature #1976 (Feedback): conversion support for named events
- 08:17 AM Feature #1607: implement full named events support
- Passed conversion regression testing, applied to bzr revision 10158. Not applied to staging.
01/30/2013
- 06:58 PM Feature #1640: implement DOM XML support
- Yes, you can put that in language_statements.rules.
- 06:49 PM Feature #1640: implement DOM XML support
- > ...
> And the methods_attributes.rules must be modified to use the proper unwrap type (XDocument or XNodeRef) depe... - 05:40 PM Feature #1640: implement DOM XML support
- ...
- 05:10 PM Feature #1640: implement DOM XML support
- The implementation/design point to discuss. I'm looking for the place where we can implement the required DOM XML sup...
- 10:35 AM Feature #1640: implement DOM XML support
- INSERT-ATTRIBUTE() is a documented method (in the 4GL reference). But it is for the SAX XML support, not for DOM. I ...
- 10:25 AM Feature #1640: implement DOM XML support
- The first release of the DOM XML test uploaded.
And the question:
I have not found the method insert-attribute() ... - 04:22 PM Feature #1983: runtime support for widget pools
- This task is only for tracking spent time and linking this work to milestone 4. All history updates should go into t...
- 04:22 PM Feature #1983 (Closed): runtime support for widget pools
- 04:21 PM Feature #1982: conversion support for widget pools
- This task is only for tracking spent time and linking this work to milestone 4. All history updates should go into t...
- 04:21 PM Feature #1982 (Closed): conversion support for widget pools
- 04:19 PM Feature #1792: implement widget-pool support
- This is heavily used, even on the server since it seems to affect non-UI resources too.
- 04:17 PM Feature #1636: implement peristent trigger support
- Just implement the conversion support for now, unless it is trivial to do the runtime too.
- 03:59 PM Feature #1920: implement persistent procedures
- I am OK with the change so long as amref is never null at line 1372. I suspect it is not ever null, but I haven't in...
- 11:39 AM Feature #1920: implement persistent procedures
- Fixed the case mentioned by Ovidiu. Attached is the fix and testcase.
- 05:50 AM Feature #1920: implement persistent procedures
- While working on some methods and attributes I found the following testcase that fails to convert correctly:...
- 02:44 PM Feature #1649: implement Windows environment/registry access
- OK, this looks good. Let's wait until tomorrow for conversion testing, since Constantin is in testing with another c...
- 01:42 PM Feature #1649: implement Windows environment/registry access
- Merged update has been uploaded.
- 12:29 PM Feature #1649: implement Windows environment/registry access
- I am OK with the changes. But there is a conflict in bzr. Please merge with the latest changes and upload it.
- 02:39 PM Feature #1607: implement full named events support
- There are no conflicts with the stuff in staging. When this passes conversion testing, you can check it in and distr...
- 01:00 PM Feature #1607: implement full named events support
- Good stuff. If it passes conversion testing, we will figure out the check in. I will find out if there are any confl...
- 12:52 PM Feature #1607: implement full named events support
- Added rules to emit the parameter modes, for the PUBLISH statement. I will leave the conversion to run on my machine,...
- 12:49 PM Feature #1607: implement full named events support
- I'm fine with the changes, they look good.
Go ahead with conversion testing. We will bypass runtime testing for t... - 12:19 PM Feature #1607: implement full named events support
- A note: for the PUBLISH statement, the mode for each parameter should be collected and emitted the same as is emitted...
- 11:30 AM Feature #1607: implement full named events support
- Added merged sources.
- 09:06 AM Feature #1607: implement full named events support
- Sources are built on top of their bazaar versions as of today.
Testcases will be committed to bzr shortly.
I'll do ... - 07:50 AM Feature #1607: implement full named events support
- After looking at what was already implemented in the conversion rules and stubed in the runtime, my conclusions are t...
- 02:32 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Note 19 above discusses datetime and datetime-tz support. But the code updates also have a significant number of add...
- 02:11 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- I have spent quite a bit of time working on this. I solved the known problems mentioned above (e.g. array initializa...
- 10:41 AM Feature #1635: implement MEMPTR/RAW support
- Check it in to bzr and distribute the update. I will apply it to staging.
- 09:02 AM Feature #1635: implement MEMPTR/RAW support
- Conversion tests finally passed (I had some problems with ant and antlr failing and it took some time to figure out w...
- 08:56 AM Feature #1639: implement socket support
- -Conversion tests finally passed (I had some problems with ant and antlr failing and it took some time to figure out ...
01/29/2013
- 04:19 PM Feature #1649: implement Windows environment/registry access
- > Please check it into bzr (p2j_repo/testcases/uast/).
Done. - 03:38 PM Feature #1649: implement Windows environment/registry access
- Uploaded updated conversion support.
And I have implementing just (character)null approach for missing parameters.... - 02:54 PM Feature #1649: implement Windows environment/registry access
- ...
- 02:28 PM Feature #1649: implement Windows environment/registry access
- Another question. In the new approach I need to reformat incomplete calls like this:
getKeyValue(String section)
We... - 02:05 PM Feature #1649: implement Windows environment/registry access
- The latest testcase is fine. Please check it into bzr (p2j_repo/testcases/uast/).
- 01:56 PM Feature #1649: implement Windows environment/registry access
- ...
- 01:52 PM Feature #1649: implement Windows environment/registry access
- The new testcase version has been uploaded here.
- 01:34 PM Feature #1649: implement Windows environment/registry access
- > The real worker method should be the form that has all wrapper constructors (e.g. getKeyValue(character, character)...
- 01:13 PM Feature #1649: implement Windows environment/registry access
- Code feedback:
1. The stub methods in EnvironmentOps cannot call character.getValue() (et al) without some unknown... - 01:04 PM Feature #1649: implement Windows environment/registry access
- Feedback on the testcase:
Please add code that shows the use of:
1. LOAD with BASEKEY "INI"
2. PUT-KEY-VALU... - 09:25 PM Feature #1649: implement Windows environment/registry access
- The first version to review. The modification log:
1. The file util/EnvironmentOps.java was changed adding the stubs... - 02:01 PM Feature #1635: implement MEMPTR/RAW support
- This looks OK. Regression test this for conversion only. I think the runtime portions should be safe enough to incl...
- 01:38 PM Feature #1635: implement MEMPTR/RAW support
- Added proposed update
- 01:14 PM Feature #1635: implement MEMPTR/RAW support
- I agree. Go with it.
- 12:58 PM Feature #1635: implement MEMPTR/RAW support
- I thought that the method will get the type depending on the size/type of the variable.
The second idea seems simple... - 12:38 PM Feature #1635: implement MEMPTR/RAW support
- ...
- 12:29 PM Feature #1635: implement MEMPTR/RAW support
- 1 @It is my impression that you are coding it with little regard to the standard and then you clean it up later.@
T... - 10:31 AM Feature #1635: implement MEMPTR/RAW support
- Feedback:
1. Please help me understand why your code formatting is still not matching our coding standards. From ... - 05:37 AM Feature #1635: implement MEMPTR/RAW support
- Added proposed update.
- 01:29 PM Feature #1607: implement full named events support
- > 1. Would these be used directly from the converted code or is this a statement about runtime internals?
I don't th... - 01:18 PM Feature #1607: implement full named events support
- ...
- 01:07 PM Feature #1607: implement full named events support
- Looking at how the PUBLISH and SUBSCRIBE/USUBSCRIBE work, I think these will need to be kept at the external program ...
- 12:54 PM Feature #1640: implement DOM XML support
- As with the other work for milestone 4, please only make the changes required for conversion (and compilation of the ...
- 12:47 PM Feature #1640: implement DOM XML support
- I'm adding myself as watcher to be able to automatically receive the update notifications.
- 12:32 PM Feature #1980 (Closed): runtime support for DOM XML processing
- 12:31 PM Feature #1979: conversion support for DOM XML processing
- This task is only for tracking time spent. Please put all history into the parent task #1640.
- 12:30 PM Feature #1979 (Closed): conversion support for DOM XML processing
- 12:07 PM Feature #1608: implement full appserver support (from 4GL clients only)
- Simple 4GL client code example:...
- 11:36 AM Feature #1644: implement SOAP support
- The full set of related features:
SOAP Header Object:
STATEMENTS: CREATE-SOAP-HEADER
ATTRIBUTES: NUM-HEADER-EN... - 10:48 AM Feature #1977: implement the runtime support for named events
- This task is only to track time spent. All history goes in the parent task #1607.
- 10:48 AM Feature #1977 (Closed): implement the runtime support for named events
- 10:47 AM Feature #1976: conversion support for named events
- This is just a task for managing time spent and for having the conversion work allocated to milestone 4. All history...
- 10:46 AM Feature #1976 (Closed): conversion support for named events
- 10:35 AM Feature #1639: implement socket support
- When I said "Create a class called com/goldencode/p2j/util/Socket for the main socket interfaces.", I was not referri...
- 10:28 AM Feature #1639: implement socket support
- Creating the interface name Socket will cause ambiguities in existing code, is CommonSocket ok as a name replacement?
- 09:44 AM Feature #1639: implement socket support
- Please work on the conversion support for sockets. I expect that you will take my recent feedback on the memptr/raw ...
- 10:35 AM Feature #1884: add some of the v10 data types and core built-ins
- Attached update (although it misses javadoc for a lot of the new APIs) has the following changes:
# added base class...
01/28/2013
- 01:43 PM Feature #1635: implement MEMPTR/RAW support
- Feedback:
1. The update is missing the NumberType.java file.
2. In BinaryData, please use the same approach to ... - 01:07 PM Feature #1635: implement MEMPTR/RAW support
- Added proposed update
- 11:05 AM Feature #1635: implement MEMPTR/RAW support
- The work is decent. Feedback:
1. I know that I said that @get-bits/put-bits should be in integer.java@, but looki... - 10:08 AM Feature #1635: implement MEMPTR/RAW support
- Submited proposed update which supports conversion for the items on list except copy-lob and raw (merged with the mos...
- 09:44 AM Feature #1635: implement MEMPTR/RAW support
- No, don't work on RAW() and RAW stmt for now.
- 08:56 AM Feature #1635: implement MEMPTR/RAW support
- Hi, should raw built-in function/statement be present in the conversion support?
I'm asking because I saw it's low ... - 12:00 PM Feature #1884: add some of the v10 data types and core built-ins
- Sorry, I missed the "builtin-functions" part. Yes, I agree that the built-ins should take the base class.
In rega... - 11:51 AM Feature #1884: add some of the v10 data types and core built-ins
- I refer to the built-in functions which can accept both character and longchar for a parameter, like @replace@. As it...
- 10:34 AM Feature #1884: add some of the v10 data types and core built-ins
- Actually, I was still wanting the parameter set to the specific type. The reason is that this parameter mismatch cas...
- 10:27 AM Feature #1884: add some of the v10 data types and core built-ins
- OK, I think I understand your approach. As we will use a base class (maybe named "text"?), all the built-in functions...
- 10:16 AM Feature #1884: add some of the v10 data types and core built-ins
- Normally, we always define parameters as the exact match to the type originally specified. I prefer to stay with tha...
- 09:46 AM Feature #1884: add some of the v10 data types and core built-ins
- I've re-changed asignee back to me, I've changed it by mistake.
- 09:17 AM Feature #1884: add some of the v10 data types and core built-ins
- More notes about the longchar and character classes. In 4GL, if we have an user-defined function like this:...
- 08:52 AM Feature #1884: add some of the v10 data types and core built-ins
- ...
- 05:23 AM Feature #1884: add some of the v10 data types and core built-ins
- Merged ail_upd20121206a.zip with latest bazaar files (the APIs moved from character to TextOps were re-moved to TextO...
- 09:42 AM Feature #1950 (Closed): conversion support for native library (.so or .DLL) access
- 02:10 AM Feature #1950 (Feedback): conversion support for native library (.so or .DLL) access
- 01:59 AM Feature #1634: implement full native library (.so or DLL) support
- Added testcases for conversion support.
- 01:36 AM Feature #1634: implement full native library (.so or DLL) support
- Passed conversion regression testing, applied to lightning and committed to bzr revision 10156.
- 01:36 AM Feature #1920: implement persistent procedures
- Passed regression testing, applied to lightning and committed to bzr revision 10155.
01/26/2013
- 12:55 PM Feature #1884: add some of the v10 data types and core built-ins
- After looking over Adrian's findings, to me it looks like the best solution is to have two classes - character and lo...
- 09:12 AM Feature #1634: implement full native library (.so or DLL) support
- Actually, I think the runtime part is pretty safe. So if it passes conversion testing, no runtime regression testing...
- 09:11 AM Feature #1634: implement full native library (.so or DLL) support
- This looks good to me. If that is everything that is needed, then you can go ahead and convert/test this.
- 04:57 AM Feature #1634: implement full native library (.so or DLL) support
- Attached update is built on top of https://proj.goldencode.com/redmine/attachments/249/ca_upd20130126a.zip (for #1920...
- 04:50 AM Feature #1920: implement persistent procedures
- The attached update is merged with bzr revision 10154.
01/25/2013
- 11:51 AM Feature #1634: implement full native library (.so or DLL) support
- > The PROCEDURE EXTERNAL doesn't load the library, no matter if it has PERSISTENT or not?
The fact that there is a P... - 10:14 AM Feature #1634: implement full native library (.so or DLL) support
- ...
- 09:19 AM Feature #1634: implement full native library (.so or DLL) support
- A. misc findings for PROCEDURE EXTERNAL case:
- the name used to define this kind of procedure is case-sensitive(to ... - 09:33 AM Feature #1920: implement persistent procedures
- ...
- 07:59 AM Feature #1920: implement persistent procedures
- > This should not affect your work, but it should be mentioned that the 4GL does support what I call "malformed" symb...
- 03:09 AM Feature #1920: implement persistent procedures
- The regressions were caused by the fact that I didn't push the correct this-procedure when a trigger was invoked and ...
01/24/2013
- 03:11 PM Feature #1920: implement persistent procedures
- GSO_419 and tc_po_receiving_009 have failed because I think an ERROR condition (caused in a external program invocati...
- 07:14 AM Feature #1920: implement persistent procedures
- Apply the missing changes from bzr to 1920/staging.merged4/ and start testing there as soon as the TIMCO run finishes.
- 07:04 AM Feature #1920: implement persistent procedures
- staging_ca/1920/staging is a staging copy, without Eric's update (is almost in sync with what is in bazaar, only some...
- 06:39 AM Feature #1920: implement persistent procedures
- I am OK with the update.
But Eric's buffer handle changes are currently in staging and the testing yesterday may h... - 06:16 AM Feature #1920: implement persistent procedures
- This update does the following:
# removed the bogus next-sibling/prev-sibling attributes from progress.g and methods... - 06:07 AM Feature #1920: implement persistent procedures
- Added testcases used for #1920 and #1921. bzr repository was updated too.
- 12:28 PM Feature #1634: implement full native library (.so or DLL) support
- ...
- 12:00 PM Feature #1634: implement full native library (.so or DLL) support
- > After copying the native method info into the name map, how do we handle the PROCEDURE EXTERNAL statement? Do we h...
- 11:39 AM Feature #1634: implement full native library (.so or DLL) support
- Good.
After copying the native method info into the name map, how do we handle the PROCEDURE EXTERNAL statement? ... - 11:28 AM Feature #1634: implement full native library (.so or DLL) support
- > The conversion approach: generate a class for each DLL being called, the class should have static methods represent...
- 11:14 AM Feature #1634: implement full native library (.so or DLL) support
- > 1. What do we do with the PROCEDURE EXTERNAL calls for their purpose of *registration*? I understand that you are ...
- 11:07 AM Feature #1635: implement MEMPTR/RAW support
- In this example, you are just making 2 MEMPTR vars point to the same buffer. I don't think you can make one MEMPTR p...
- 10:33 AM Feature #1635: implement MEMPTR/RAW support
- I understand now, the correct case to exemplify what I wanted to show looks like this:...
- 07:11 AM Feature #1635: implement MEMPTR/RAW support
- You are mis-interpreting the documentation.
There are 2 serious problems with your example:
1. You should not u... - 05:40 AM Feature #1635: implement MEMPTR/RAW support
- From what I've seen from documentation 4GL memptr memory can be shared with other variable:
For example according to...
01/23/2013
- 03:01 PM Feature #1957 (Closed): develop a set of testcases that utilize all features of the 4GL socket an...
- 02:36 PM Feature #1639: implement socket support
- Updated the bazaar, below the wait-for read-response it was the alternate procedural equivalent so not sure why I put...
- 12:31 PM Feature #1639: implement socket support
- Please remove this:...
- 10:59 AM Feature #1639: implement socket support
- Corrected the wrong name , added two new files which implement the same example from point 3 but with procedural mode...
- 08:21 AM Feature #1639: implement socket support
- ...
- 07:21 AM Feature #1639: implement socket support
- Corrected the name that used underscore and added 3 files with the test case described at points 3-4 using read and w...
- 02:35 PM Feature #1920: implement persistent procedures
- OK, now I have the correct version of 0123e.zip, which does the following:
# ControlFlowOps APIs are re-written to u... - 02:14 PM Feature #1920: implement persistent procedures
- I've deleted 0123e.zip, as it wasn't supposed to get uploaded.
- 02:03 PM Feature #1920: implement persistent procedures
- > Actually, I meant to handle this case but the code I wrote was not correct. I think this form of my example is bet...
- 01:03 PM Feature #1920: implement persistent procedures
- ...
- 12:51 PM Feature #1920: implement persistent procedures
- And another thought about using generics: I would like to leave the non-generic versions of the functions in place, t...
- 12:45 PM Feature #1920: implement persistent procedures
- > [...]
>
> I agree. Please add a history entry providing the suitable details.
Understood.
> 1. What is stil... - 12:26 PM Feature #1920: implement persistent procedures
- Code review feedback: the latest code looks good....
- 11:09 AM Feature #1920: implement persistent procedures
- This version adds support for functions returning int64, rowid and recid. Note that if such functions are used with D...
- 10:47 AM Feature #1920: implement persistent procedures
- Code review feedback:
1. In ExpressionConversionWorker, the history entry needs to be 036. It also should not be ... - 09:44 AM Feature #1920: implement persistent procedures
- > ... it almost passed regression testing in MAJIC (some tests have failed with what looks like a comon cause).
My c... - 09:41 AM Feature #1920: implement persistent procedures
- > Please add recid, rowid and int64.
Note that I will need to add BlockManager.*function APIs for these types too.
... - 08:47 AM Feature #1920: implement persistent procedures
- ...
- 05:43 AM Feature #1920: implement persistent procedures
- Constantin Asofiei wrote:
> 7. @FOR EACH table WHERE my-field = DYNAMIC-FUNCTION("something" IN some-handle)@
> [..... - 03:36 AM Feature #1920: implement persistent procedures
- 1. please check the return types for all functions - currently, only these return types are supported: integer, decim...
- 01:44 AM Feature #1920: implement persistent procedures
- About the review feedback:
1. in functions.rules I need the 4GL function name from the static string passed to the D... - 10:42 AM Feature #1972: provide full-support for DYNAMIC-FUNCTION set to function parameters
- In 4GL, when a parameter of a function call is set as the the returned value of a DYNAMIC-FUNCTION call, as in:
<pre... - 10:35 AM Feature #1972 (Closed): provide full-support for DYNAMIC-FUNCTION set to function parameters
- 10:04 AM Feature #1649: implement Windows environment/registry access
- ...
- 09:29 AM Feature #1649: implement Windows environment/registry access
- Currently there are no significant issues with the statements:
PUT-KEY-VALUE, USE, LOAD, UNLOAD
The small questio...
01/22/2013
- 05:34 PM Feature #1920: implement persistent procedures
- Code review feedback:
1. I'm not sure how important it is, but it may be better to use ExpressionConversionWorker.... - 04:03 PM Feature #1920: implement persistent procedures
- More research and thoughts on dynamic-function() return types:
1. I have been looking at all the call sites for th... - 11:10 AM Feature #1920: implement persistent procedures
- Issues fixed/changed by this update:
# function/internal procedures are searched case-insensitive (both in the conve... - 10:58 AM Feature #1920: implement persistent procedures
- Let's go ahead and finalize your update and get it regression tested and checked in. If we have rework for some of t...
- 10:44 AM Feature #1920: implement persistent procedures
- I ask this because I noticed that some attributes are read-only for some handle types and writable for others (thus w...
- 10:27 AM Feature #1920: implement persistent procedures
- ...
- 06:59 AM Feature #1920: implement persistent procedures
- > Don't forget that function names are matched case-insensitively.
About the case-insensitivity: I see that this app... - 06:21 AM Feature #1920: implement persistent procedures
- Greg: can you ran a report and let me know which attributes/methods are used in the project ? I want to make sure we ...
- 12:44 PM Feature #1639: implement socket support
- I looked at the new testcases. Here is some feedback:
1. Please do not use spaces in filenames. You can use bzr ... - 12:08 PM Feature #1639: implement socket support
- In your opinion, are you done with this work?
- 12:07 PM Feature #1639: implement socket support
- ...
- 12:04 PM Feature #1639: implement socket support
- Submited testcases to bazaar.
- 11:29 AM Feature #1639: implement socket support
- Tried to implement a procedural model according to hints given by documentation using CONNECTED() and GET-BYTES-AVAIL...
- 10:52 AM Feature #1639: implement socket support
- My guess: Progress implements MEMPTRs instances literally as an internal pointer to some memory. This probably means...
- 08:34 AM Feature #1639: implement socket support
- The solution for this would be to use get-bytes-available and use it in get-string, like:...
- 07:31 AM Feature #1639: implement socket support
- It seems there is a problem when reading in the connect procedure.
The problem seems to be with the buffer variable... - 12:13 PM Feature #1963 (WIP): implement conversion support for MEMPTR/RAW
01/21/2013
- 03:04 PM Feature #1639: implement socket support
- ...
- 01:58 PM Feature #1639: implement socket support
- *Notes from 4GL Test results*
- You can get the socket handle for which you set the response procedure by using *S... - 01:58 PM Feature #1639: implement socket support
- 1. Yes
2. Will test more.
3 - 4 built the program , unfortunately it seems to block when testing, I'm working to fi... - 01:33 PM Feature #1920: implement persistent procedures
- Eric, thanks, I've tested it with the class of P2J frame instance and it returns true, so it will work with the class...
- 12:56 PM Feature #1920: implement persistent procedures
- Constantin, as discussed, I have added isProxyClass(Class<?>) to the ProxyFactory class and attached the update here....
- 12:20 PM Feature #1920: implement persistent procedures
- This version does the following:
- a few fixes for issues discovered when using MAJIC
- collect the return types for ... - 11:07 AM Feature #1920: implement persistent procedures
- Yes, I think you are right. We process 1 AST *sequentially* through each rule-set....
- 09:35 AM Feature #1920: implement persistent procedures
- > Annotations is designed such that every rule-set is run against the entire set of source files before the next rule...
- 07:49 AM Bug #1971: emit worker versions for functions to fix source-procedure handle
- To be able to use Java method calls for simple function calls (without IN SUPER or IN handle clauses), we need to emi...
- 07:45 AM Bug #1971 (Closed): emit worker versions for functions to fix source-procedure handle
- 03:36 AM Feature #1970: improve ControlFlowOps method resolution by reflection
- Cache the Method objects obtained by Class.getMethod (and other Class APIs) by class/method name/signature, to improv...
- 03:35 AM Feature #1970 (WIP): improve ControlFlowOps method resolution by reflection
- 03:32 AM Bug #1969: buffer names in get-signature
- In collect_names.rules, when collecting the name of the buffer from a BUFFER FOR <buf-name> parameter, the name must ...
- 03:31 AM Bug #1969 (Closed): buffer names in get-signature
- 03:29 AM Bug #1968 (Closed): implement MAP TO actual-name IN handle clause for function definitions
01/20/2013
- 11:06 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Ovidiu: I am going to make the final modifications on the latest code you have posted. I know you are busy with othe...
01/19/2013
- 03:55 PM Feature #1963: implement conversion support for MEMPTR/RAW
- For this task, do the conversion support/runtime stubs for all the get-*() functions and for the put-* and set-* stat...
- 03:20 PM Feature #1963: implement conversion support for MEMPTR/RAW
- This task is just to manage time spent. Please put all history entries into the parent task #1635.
- 03:17 PM Feature #1963: implement conversion support for MEMPTR/RAW
- See the parent task for the list of things to support. ONLY create the conversion support (rules changes to emit the...
- 03:15 PM Feature #1963 (Closed): implement conversion support for MEMPTR/RAW
- 03:19 PM Feature #1964: finish runtime support for MEMPTR/RAW
- This is just a placeholder to time entry. Put all history entries into the parent task #1635.
- 03:18 PM Feature #1964 (Closed): finish runtime support for MEMPTR/RAW
- 03:09 PM Feature #1639: implement socket support
- Some feedback:
1. Is the client-socket.p missing a wait-for statement?
2. Do the client and server work reliably?... - 02:49 PM Feature #1920: implement persistent procedures
- ...
- 12:56 PM Feature #1920: implement persistent procedures
- > It may be worth have different variants of invokeFunction that are type specific (invokeLogicalFunction(), invokeIn...
- 12:43 PM Feature #1920: implement persistent procedures
- I'm generally fine with this plan. Some thoughts:...
- 12:22 PM Feature #1920: implement persistent procedures
- The major cost in ControlFlowOps is the reflection done to determine the correct method. If we cache this, we will ha...
- 02:27 AM Feature #1920: implement persistent procedures
- Considering your idea to emit worker methods, to be able to differentiate between simple and dynamic function calls, ...
01/18/2013
- 06:18 PM Feature #1920: implement persistent procedures
- Feedback on the Java implementation:
1. StaticProxy.invoke() is missing the method level description text in javad... - 05:07 PM Feature #1920: implement persistent procedures
- ...
- 04:55 PM Feature #1920: implement persistent procedures
- OK, I understand now what you mean, emit workers in the generated code. About the hints - if a file contains multiple...
- 04:47 PM Feature #1920: implement persistent procedures
- And of course, the BlockManager.*Function() methods would need variants that take the extra parameter.
- 04:46 PM Feature #1920: implement persistent procedures
- I was thinking more along the lines of:...
- 04:41 PM Feature #1920: implement persistent procedures
- When I said the DYNAMIC-FUNCTION return type is static, I mean that if the target is hard coded, then the DYNAMIC-FUN...
- 04:28 PM Feature #1920: implement persistent procedures
- About entry 89 - I need to keep in mind that at least TARGET-PROCEDURE handle might be used in cojunction with the SE...
- 04:18 PM Feature #1920: implement persistent procedures
- I don't think DYNAMIC-FUNCTION's return type is "static"... I think it's something more like the Object type in Java....
- 04:08 PM Feature #1920: implement persistent procedures
- ...
- 03:59 PM Feature #1920: implement persistent procedures
- Here are some results from my searches.
In my latest scan, there are 12690 instances of DYNAMIC-FUNCTION. Of thos... - 03:31 PM Feature #1920: implement persistent procedures
- First, about the DYNAMIC-FUNCTION's case: idea is, 4GL does compile such code (where the type of the operand is evalu...
- 02:39 PM Feature #1920: implement persistent procedures
- ...
- 11:32 AM Feature #1920: implement persistent procedures
- > 1. Did you check on the effect to Majic of removing of the move of the define parameter of a buffer in record_scopi...
- 11:30 AM Feature #1920: implement persistent procedures
- Unfortunately, another issue appears: DYNAMIC-FUNCTION calls can be used in complex expressions (arithmetic, logical,...
- 11:16 AM Feature #1920: implement persistent procedures
- > 1. Did you check on the effect to Majic of removing of the move of the define parameter of a buffer in record_scopi...
- 10:58 AM Feature #1920: implement persistent procedures
- Feedback on the latest rules changes:
1. Did you check on the effect to Majic of removing of the move of the defin... - 10:00 AM Feature #1920: implement persistent procedures
- > Why does the first convert to a BlockManager.doWhile() but the second converts to a Java while() loop? If the dyna...
- 09:55 AM Feature #1920: implement persistent procedures
- ...
- 09:01 AM Feature #1920: implement persistent procedures
- Another idea for the @IF <func-name>()@ case would be: why not emit directly something like @if (((logical)ControlFlo...
- 08:37 AM Feature #1920: implement persistent procedures
- Attached update has the following new fixes:
* javadoc fixes
* merged with latest bazaar files
* fixed conversion of ... - 03:16 AM Feature #1920: implement persistent procedures
- > 1. The read_only_attribute function in common-progress.rules seems like it will be painful to maintain over time, s...
- 07:43 PM Feature #1920: implement persistent procedures
- Feedback:
0. First: WOW! Really good work.
1. The read_only_attribute function in common-progress.rules seems ... - 02:10 PM Feature #1639: implement socket support
- Commited to bazaar an initial set of testcases #1957: Use cases for the socket and server-socket attributes and metho...
- 12:17 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- I added @SESSION:YEAR-OFFSET@, @DATETIME@ fields in a temp-table and support arrays (@EXTEND@) of @int64@ and @DATETI...
- 08:43 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Code review 20130117a:
* Nice functional addition! A bit more to go for Milestone 4 (e.g., defining DATETIME in a... - 09:34 AM Feature #1962: modify parser to add a readOnly boolean annotation to all attributes and change po...
- 1. Change the SymbolResolver.addAttributeOrMethod() to take a 3rd parameter: boolean readOnly. It should store this i...
- 09:31 AM Feature #1962 (New): modify parser to add a readOnly boolean annotation to all attributes and cha...
01/17/2013
- 06:44 PM Feature #1649: implement Windows environment/registry access
- ...
- 06:27 PM Feature #1649: implement Windows environment/registry access
- Greg,
I have followed with the conversion process and found the language keywords are already supported in progres... - 05:30 PM Feature #1626: implement OS-DIR support as an INPUT stream
- Two more additions to the feedback:
7. DirStream should use com.goldencode.util.PlatformHelper.isUnderWindowsFamil... - 05:13 PM Feature #1626: implement OS-DIR support as an INPUT stream
- You don't need separate history entries for #1613 and #1626. Just merge the text into a single entry and use the sam...
- 05:00 PM Feature #1626: implement OS-DIR support as an INPUT stream
- Feedback on cs_upd20130117a.zip:
1. The FileSystemDaemon changes are definitely wrong. For example, it is valid f... - 11:35 AM Feature #1626: implement OS-DIR support as an INPUT stream
- added cs_upd20130116b
- 11:03 AM Feature #1626: implement OS-DIR support as an INPUT stream
- The regression testing for cs_upd20130116a.zip has passed, but to clear testing we had to roll back the StreamWrapper...
- 05:40 AM Feature #1626: implement OS-DIR support as an INPUT stream
- Solved the pipe problem by opening the file in non-blocking mode, which is good that worked since there is no other w...
- 05:09 PM Feature #1613: finish FILE-INFO system handle support
- See the code feedback notes in #1626. As noted there, DO NO FURTHER WORK ON THIS UNTIL AFTER THE MILESTONE 4 DELIVER...
- 11:27 AM Feature #1613: finish FILE-INFO system handle support
- Added proposed update with described changes (also contains FileChecker and filesys.c hopefully it will not collide w...
- 11:03 AM Feature #1613: finish FILE-INFO system handle support
- Finished the update, however modification to search(String[] paths, boolean caseSens, String filename) from FileSy...
- 06:49 AM Feature #1920: implement persistent procedures
- Some other notes related to functions/procedures which have buffer parameters. For these cases, the actual parameter ...
- 06:39 AM Feature #1920: implement persistent procedures
- This update adds:
- a first phase of SEARCH-TARGET mode for super calls
- support for parameter mode validation for... - 04:48 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- The update pack includes a sample testcase with an expected output sample (as obtained from windev01). It contains th...
01/16/2013
- 06:08 PM Feature #1626: implement OS-DIR support as an INPUT stream
- You can't open a pipe like a regular file. It is a very special fake filename that is implemented by code in the kern...
- 12:42 PM Feature #1626: implement OS-DIR support as an INPUT stream
- Finished the logic for unix/windows adding another bitfield to the result that will point if unix or windows logic wi...
- 07:03 AM Feature #1626: implement OS-DIR support as an INPUT stream
- OK, I will apply the update to staging so we can retest. If it passes we will check it in, even though there are dev...
- 05:37 AM Feature #1626: implement OS-DIR support as an INPUT stream
- Tested the behavior for UNIX 4GL and noticed notable differences than the Windows 4GL:
- The current dir "." is no... - 03:19 AM Feature #1626: implement OS-DIR support as an INPUT stream
- Added proposed update which changes in: StreamWrapper.assign(Stream s) on how the inOk and outOk are assigned to avoi...
- 06:04 PM Feature #1920: implement persistent procedures
- I think the issue is caused by this code:...
- 10:37 AM Feature #1920: implement persistent procedures
- Constantin Asofiei wrote:
> The parameter mode for function calls (DYNAMIC-FUNCTION or simple function call) is remo... - 10:23 AM Feature #1920: implement persistent procedures
- The parameter mode for function calls (DYNAMIC-FUNCTION or simple function call) is removed by some code I guess in p...
- 09:35 AM Feature #1920: implement persistent procedures
- I like it.
- 09:32 AM Feature #1920: implement persistent procedures
- Ok, I think I understand now. What you are suggesting is to condense the parameter modes into a string and emit it as...
- 09:13 AM Feature #1920: implement persistent procedures
- ...
- 08:47 AM Feature #1920: implement persistent procedures
- Yes, you understood correctly, we need the parameter modes set to the RUN or function call statement.
> I prefer to ... - 08:24 AM Feature #1920: implement persistent procedures
- If I understand properly, the problem is that the calling side does not supply the missing signature information (ess...
- 04:20 AM Feature #1920: implement persistent procedures
- Another issues which we need to decide if we support it or not is the attribute's mode set when the function/procedur...
- 09:24 AM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
- Updated archive uploaded.
- 09:05 AM Feature #1634: implement full native library (.so or DLL) support
- OK, so the only remaining questions:
1. What do we do with the PROCEDURE EXTERNAL calls for their purpose of *regi... - 04:25 AM Feature #1634: implement full native library (.so or DLL) support
- All native procedure calls convert the same way as internal (or external) procedures. The fact that the target is a n...
- 07:22 AM Feature #1613: finish FILE-INFO system handle support
- ...
- 05:21 AM Feature #1613: finish FILE-INFO system handle support
- Tested on Unix 4GL:
It seems that FILE-INFO:FILE-CREATE-* doesn't actually return any value on Unix.
File types for... - 03:22 AM Feature #1613: finish FILE-INFO system handle support
- 2. The problem with searchPath is that it only returns the value, if the target is a file, otherwise it returns null,...
- 06:46 AM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
- ...
01/15/2013
- 06:32 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
- Looks like we now already have properly conversion for DOS statement. The following line
dos dir /w > dir.log.
conv... - 02:50 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
- Option 2 is certainly how we want to do it. Yes, it is up to the application to only try to run child processes that ...
- 02:32 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
- At this time I have not found any other statements except DOS to add the conversion support. As far as I understood t...
- 10:56 AM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
- Please provide a summary of your findings so far.
I know that the DOS statement needs conversion support. I would... - 04:28 PM Feature #1649: implement Windows environment/registry access
- For now, we need to add conversion support (for all features mentioned above) and the minimum runtime stubs to make t...
- 04:26 PM Feature #1961: implement runtime backing for Windows environment/registry access
- This task is only for tracking time. Do NOT put any history entries here. Put all history entries in the parent task...
- 04:26 PM Feature #1961 (Closed): implement runtime backing for Windows environment/registry access
- 04:25 PM Feature #1960: conversion support for Windows environment/registry access
- This task is just for tracking spent time. Do NOT put any history entries here. Put all history into the parent tas...
- 04:24 PM Feature #1960 (Closed): conversion support for Windows environment/registry access
- 02:43 PM Feature #1613: finish FILE-INFO system handle support
- Feedback:
1. The build.xml and makefile are not changed in your update. Remove them unless you have real changes.... - 12:43 PM Feature #1613: finish FILE-INFO system handle support
- Added proposed update , will test on Unix 4GL for matching behavior.
- 12:19 PM Feature #1613: finish FILE-INFO system handle support
- Yes, do build the changes on top of the files from #1626 as this is in test and should pass soon. We can always make...
- 12:11 PM Feature #1613: finish FILE-INFO system handle support
- On Unix the only date the system keeps regarding files is the last access date which is probably what Progress on Uni...
- 01:28 PM Feature #1607: implement full named events support
- Yes. As THIS-PROCEDURE needs to return the external procedure handle to which the current statement belongs, I've imp...
- 12:51 PM Feature #1607: implement full named events support
- The ProcedureManager will have enough information to know the immediate caller (in the converted code) and associate ...
- 12:41 PM Feature #1607: implement full named events support
- I don't see any valid reason to emit an explicit ProcedureManager.thisProcedure() call in these cases. The runtime sh...
- 12:02 PM Feature #1607: implement full named events support
- The 4GL documentation suggests that the following are implicit uses of THIS-PROCEDURE:
PUBLISH without a FROM clau... - 11:58 AM Feature #1607: implement full named events support
- Named events also support the PUBLISHED-EVENTS attribute, which the documentation suggests is a string created at com...
- 12:02 PM Feature #1920: implement persistent procedures
- Summary for more tested issues:
* merged files with latest bzr versions
* proper error messages for read-only assig... - 08:17 AM Feature #1920: implement persistent procedures
- Yes, your approach makes perfect sense. The 4GL "feature" is absurd.
- 07:11 AM Feature #1920: implement persistent procedures
- In 4GL, code with read-only attributes on the right-side of an expression gets compiled, as in:...
- 10:07 AM Feature #1958: implement the runtime support for sockets
- This task is only meant to capture time spent on the runtime portion of the parent task. Do NOT put any history entr...
- 10:03 AM Feature #1958 (Closed): implement the runtime support for sockets
- 10:06 AM Feature #1959: implement JNI runtime support for native libraries
- This task is only meant to capture time spent on the conversion portion of task #1634. Do NOT put any history entrie...
- 10:06 AM Feature #1959 (Closed): implement JNI runtime support for native libraries
- 10:01 AM Feature #1957: develop a set of testcases that utilize all features of the 4GL socket and server ...
- This task is only meant to capture time spent on the testcase creation portion of task #1639. Do NOT put any history...
- 09:59 AM Feature #1957 (Closed): develop a set of testcases that utilize all features of the 4GL socket an...
- 09:58 AM Feature #1956: implement conversion support for sockets
- This task is only meant to capture time spent on the conversion portion of task #1639. Do NOT put any history entrie...
- 09:54 AM Feature #1956 (Closed): implement conversion support for sockets
- 09:51 AM Feature #1639: implement socket support
- Other 4GL socket features:
CREATE SERVER-SOCKET statement
DELETE OBJECT for socket handles and for server socket ...
01/14/2013
- 06:36 PM Feature #1624: add support for PUT CONTROL
- This is already supported. Someone should generate some representative testcases and prove that there are no issues,...
- 06:30 PM Feature #1630: implement support for UNBUFFERED in I/O statements
- Conversion is already supported. But the runtime probably needs changes to support this option. Testcases will have...
- 05:40 PM Feature #1634: implement full native library (.so or DLL) support
- The following need to be supported:
PROCEDURE procname EXTERNAL "dllname":
DEFINE <type> PARAMETER ...
END PR... - 05:21 PM Feature #1950: conversion support for native library (.so or .DLL) access
- This task is for tracking purposes, but all discussions should take place in the parent task #1634. The runtime chang...
- 05:20 PM Feature #1950 (Closed): conversion support for native library (.so or .DLL) access
- 04:29 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
- Status update: My recent update completely passed the harness cycle with the last testing in separate directory.
- 03:44 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
- I just finished rebuilding with all updates applied. Eric will be handling the reconversion in 20 minutes. He has t...
- 03:41 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
- Greg,
Please start the P2J rebuild and reconversion now. After this is finished I'll start the DB restore and new ... - 03:24 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
- > I can apply your change and rebuild if it is ready.
I have applied my update.
...
-rw-r--r-- 1 evl gc 113230 ... - 03:16 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
- Yes, we will wait 30 minutes for your previous harness results. Let me know. I can apply your change and rebuild if...
- 03:07 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
- Another question. What about customer_libs subdirectory? Do we need to clean it up before testing?
- 03:02 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
- > Are you sure you want to test this separate from other changes? If it has already passed testing, then it should be...
- 02:51 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
- Are you sure you want to test this separate from other changes? If it has already passed testing, then it should be ...
- 02:38 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
- The uploaded file contains the merge with the current p2j bzr status.
- 01:17 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
- > What is the status of your update? Did it pass harness testing?
The CTRL-C tests have been passed. The main part... - 01:10 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
- What is the status of your update? Did it pass harness testing?
You will need to merge it with the latest level o... - 01:17 PM Feature #1626: implement OS-DIR support as an INPUT stream
- I have applied this to staging but it is NOT yet rebuilt. Later today, some other changes will be applied, the code ...
- 11:46 AM Feature #1626: implement OS-DIR support as an INPUT stream
- Conversion test passed.
- 10:20 AM Feature #1626: implement OS-DIR support as an INPUT stream
- Added the proposed update , testcases passed - modified and commited to bzr the testcase for seek position since it c...
- 09:06 AM Feature #1626: implement OS-DIR support as an INPUT stream
- I should also note that using multiple chained .append() method calls is more efficient than using the + string conca...
- 08:47 AM Feature #1626: implement OS-DIR support as an INPUT stream
- You are right. I must have been comparing the wrong StreamWrapper file....
- 08:35 AM Feature #1626: implement OS-DIR support as an INPUT stream
- Found a bug when using relative paths, the path name implemented by File.getAbsolutePath() does not have the same beh...
- 12:44 PM Feature #1613: finish FILE-INFO system handle support
- At this point, I don't think it is a good idea to rely on something only in Java 7. Our current production customer ...
- 12:39 PM Feature #1613: finish FILE-INFO system handle support
- Finished and tested the FILE-INFO:FILE-TYPE logic wit OS-DIR code reuse.
For FILE-INFO:FILE-CREATE-* there might be... - 11:28 AM Feature #1613: finish FILE-INFO system handle support
- OK, great! Put the update together ASAP and upload it.
- 10:44 AM Feature #1613: finish FILE-INFO system handle support
- > I am OK with reusing the native method, so long as the result is 100% compatible. Does the FILE-TYPE attribute actu...
- 10:18 AM Feature #1613: finish FILE-INFO system handle support
- I am OK with reusing the native method, so long as the result is 100% compatible. Does the FILE-TYPE attribute actua...
- 11:02 AM Feature #1920: implement persistent procedures
- Summary for more tested issues:
* fixed the DYNAMIC-FUNCTION's error messages
* testing of RUN SUPER and SUPER cal... - 09:03 AM Feature #1920: implement persistent procedures
- Good work! I'm really excited to see this come together....
01/12/2013
- 12:37 PM Feature #1920: implement persistent procedures
- Summary for more tested issues:
* handle equality tests
* persistent procedure chains (SESSION handle's first-proce... - 09:09 AM Feature #1613: finish FILE-INFO system handle support
- For FILE-INFO:FILE-TYPE we can reuse the native code for OS-DIR as main type and just keep the read/write type logic ...
- 06:38 AM Feature #1626: implement OS-DIR support as an INPUT stream
- The results of the tests are ok, ran the conversion tests and there weren't any differences.
- 04:45 AM Feature #1626: implement OS-DIR support as an INPUT stream
- 1. I checked the StreamWrapper from proposed update against bzr and the changes are on method assignStream(Stream s)
...
01/11/2013
- 05:55 PM Feature #1613 (WIP): finish FILE-INFO system handle support
- Assuming new JNI methods are needed, they can be placed into filesys.c.
The conversion support is in rules/convert... - 05:52 PM Feature #1626: implement OS-DIR support as an INPUT stream
- I have 2 questions:
1. Where is the StreamWrapper change? The one that is included in the update is identical wit... - 01:23 PM Feature #1626: implement OS-DIR support as an INPUT stream
- Added the proposed update.
- 12:48 PM Feature #1626: implement OS-DIR support as an INPUT stream
- ...
- 12:22 PM Feature #1626: implement OS-DIR support as an INPUT stream
- > 6. In FileChecker.getFileType(), there needs to be code to handle the -1 (error case). I stubbed it out in my examp...
- 05:52 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Additional requirements:
* define a DATETIME variable
* define a DATETIME field in a temp-table
* assign a DATET... - 05:11 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- The highest priorities for the DATETIME implementation:
NOW
MTIME
ADD-INTERVAL
DATETIME
SESSION:TIME-SOURCE ... - 01:23 PM Feature #1920: implement persistent procedures
- Summary for what is tested and known to be working:
* FILE-INFO, SESSION, ERROR-STATUS, LAST-KEY, CURRENT-WINDOW hand... - 09:55 AM Feature #1920: implement persistent procedures
- ErrorManager.isError() is what should be used from converted application code, to access ERROR-STATUS:ERROR. If I re...
- 09:50 AM Feature #1920: implement persistent procedures
- Which ErrorManager API maps the ERROR-STATUS:ERROR flag ? isError or isErrorFlag ?
01/10/2013
- 05:59 PM Feature #1626: implement OS-DIR support as an INPUT stream
- Feedback:
1. In input_output.rules, this change seems wrong:... - 12:10 PM Feature #1626: implement OS-DIR support as an INPUT stream
- Added proposed update, hope I didn't miss anything.
- 03:44 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- This plan sounds good.
My only feedback is that it is probably best to encode the time value as a number of mill... - 12:30 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- As @date@ / @datetime@ and @datetime-tz@ all represent some kind of timestamp the following question raise:
Isn't i... - 12:23 PM Feature #1920: implement persistent procedures
- All of your decisions are good ones. I agree with the deferral of the old API name mapping.
- 10:58 AM Feature #1920: implement persistent procedures
- About the invalid API calls (when the invoked API is not valid for the current referent). 4GL shows these kind of mes...
01/09/2013
- 03:10 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
- > You only need to compare the src/aero/timco/majic directories.
The directories are identical. The next step I'm ... - 01:59 PM Feature #1626: implement OS-DIR support as an INPUT stream
- We will handle that in a different task. We will likely use platform specific files with functions that are called f...
- 01:32 PM Feature #1626: implement OS-DIR support as an INPUT stream
- Finished and tested the filesys.c version that handles all the logic inside the c code using bitfield approach for st...
- 09:30 AM Feature #1611 (Closed): implement QUOTER utility
- 08:40 AM Feature #1611: implement QUOTER utility
- Costin: please check in the code to bzr and distribute the update to the team.
I won't be promoting this version o... - 01:34 AM Feature #1611: implement QUOTER utility
- The testing results have been uploaded into shared GCD drive: 20130107_*.zip 20130108_*.zip(4 files). The all tests c...
01/08/2013
- 04:38 PM Feature #1611: implement QUOTER utility
- I have started another harness cycle about a hour ago. We will know today if this issue be repeated.
- 04:24 PM Feature #1611: implement QUOTER utility
- Strange. Can you reproduce the problem manually?
- 03:57 PM Feature #1611: implement QUOTER utility
- The current report(The failing line is second in the figures below):...
- 03:24 PM Feature #1611: implement QUOTER utility
- It is unlikely, but yes, it is possible. Please show the lines of output in the report that are different.
- 02:51 PM Feature #1611: implement QUOTER utility
- Is there inside the update some code that can affect data sorting algirythm inside report generated? I have one issue...
- 04:18 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
- You only need to compare the src/aero/timco/majic directories.
- 04:01 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
- Is it enough to compare just src/aero/timco/majic to make sure the generated java code is identical? Or we need to co...
- 03:21 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
- Yes, good plan. Make sure to compare the converted output from staging with the output from your copied build. It s...
- 02:47 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
- > Let me know if there are any questions.
The plan is:
After current staging passes the regression testing I will... - 12:23 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
- It looks good. Please go ahead with testing. It needs both conversion AND runtime testing. The conversion testing ...
- 12:18 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
- OK. The update has been uploaded.
- 11:49 AM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
- Feedback on the PlatformHelper:
1. Remove the JPRM column from the header. Since there are no JPRM numbers and JPR... - 10:51 AM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
- The new update to review. The method isUnderWindowsFamily() has been move to the separate class com.goldencode.util.P...
- 10:17 AM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
- Yes, that makes sense.
- 10:13 AM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
- > Please create a new class com.goldencode.util.PlatformHelper. Put the static method isWindowsFamily() in there. Cal...
- 09:23 AM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
- Everything looks good except for 1 thing.
We don't want com.goldencode.util to depend upon com.goldencode.p2j.util... - 01:26 PM Feature #1626: implement OS-DIR support as an INPUT stream
- > 1. I don't like that you have made the status codes mutually exclusive..
> 2. I don't see how you can ever get the... - 12:04 PM Feature #1626: implement OS-DIR support as an INPUT stream
- This is a step in the right direction, but it is incomplete or wrong in some ways.
1. I don't like that you have m... - 11:17 AM Feature #1626: implement OS-DIR support as an INPUT stream
- The C implementation "filesys.c" according to Progress documentation...
- 03:12 AM Feature #1626: implement OS-DIR support as an INPUT stream
- > ... they mean that the L, H and P attributes are always IN ADDITION TO the main attribute F, D, S or X
Yes those at... - 08:43 AM Support #1928: update documentation to explain how to convert, develop and run P2J on Windows
- The latest document update uploaded. With small synytax fix and new line behavior description adding.
01/07/2013
- 05:22 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
- The Windows detection code has been moved to separate statis method of the EnvironmentOps class.
Also I made one s... - 04:33 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
- Yes, please make a new method for isUnderWindowsFamily() and use that everywhere necessary. Then upload the latest c...
- 03:47 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
- The new archive has been uploaded here for you to review.
The question: In getLegacyCaseSensitive() I have used "i... - 02:54 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
- Feedback:
1. In ExpressionConversionWorker, instead of this:... - 01:51 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
- The cumulative fix has been uploaded here.
- 01:26 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
- Please upload the complete update zip into this task so that I can do a final code review.
- 02:32 PM Feature #1626: implement OS-DIR support as an INPUT stream
- To be clear, I think that when Progress says "You might also get one or more of the following characters:" they mean ...
- 02:29 PM Feature #1626: implement OS-DIR support as an INPUT stream
- Implement option 2 (create the Linux implementation even though we cannot test the 4GL on Linux today). Please note ...
- 01:50 PM Feature #1626: implement OS-DIR support as an INPUT stream
- The pipes case may be a problem to detect, since files and FIFO pipes are both marked with "F" only nonFIFO pipes w...
- 02:04 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
- Please implement full process launching support for Windows. This means that src/native/process.c will need modifica...
- 11:07 AM Feature #1920: implement persistent procedures
- Yes, you've got the idea.
I think your implementation approach (e.g. CommonProcedure) makes sense.
One note: us... - 08:14 AM Feature #1920: implement persistent procedures
- Ok, now I undestand what you mean: when the resource is of a known type (widget, persistent procedure,etc), unwrap wi...
- 10:15 AM Feature #1611: implement QUOTER utility
- The latest update for this tast is cs_upd20121219a.zip the cs_upd20121231a? is for the other quoter (built-in) #1591....
- 10:09 AM Feature #1611: implement QUOTER utility
- > Did you get a chance to work on it?
Costin,
Have you updates ready to test in lightning? Is it only cs_upd20... - 03:02 AM Feature #1591: implement QUOTER built-in function
- I've applied the update to staging and P2J is rebuilt.
01/04/2013
- 11:31 AM Feature #1626: implement OS-DIR support as an INPUT stream
- For Windows stat() seems to do the job, but in Unix lstat() must be used or link will not be corectly detected.
2-> ... - 11:06 AM Feature #1626: implement OS-DIR support as an INPUT stream
- It is OK to be linux-specific right now. We will have separate tasks to port this to Windows.
Some initial feedba... - 10:32 AM Feature #1626: implement OS-DIR support as an INPUT stream
- Actually , I realize this will have to be tested on a windows system since there might be problems with lstat().
- 10:21 AM Feature #1626: implement OS-DIR support as an INPUT stream
- The code for filesys.c...
- 09:52 AM Feature #1626: implement OS-DIR support as an INPUT stream
- Good. Please post your prototype code for review. Just paste the code into your redmine issue update if it is small...
- 09:42 AM Feature #1626: implement OS-DIR support as an INPUT stream
- This also requires some changes to the ant task "native" ,
otherwise I made the changes and tested for symbolic lin... - 08:10 AM Feature #1626: implement OS-DIR support as an INPUT stream
- Yes, this solution is OK. We already have a libp2j.so (which we will have to also port to Windows as p2j.dll). Righ...
01/03/2013
- 10:21 AM Feature #1626: implement OS-DIR support as an INPUT stream
- Java (at least until Java 7 NIO 2) doesn't seem to have a way of detecting symbolic links( the problem it's likely th...
Also available in: Atom