Project

General

Profile

Activity

From 03/22/2013 to 04/20/2013

04/20/2013

09:35 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
The conversion test failed today because in some places more code needed to be added.
After successive fixes, the con...
Ovidiu Maxiniuc

04/19/2013

02:46 PM Feature #1639: implement socket support
Added end of the day update. Added partially implementation for SET-SOCKET-OPTION. Costin Savin
09:25 AM Feature #1639: implement socket support
Then again, in the GUI project or even in a traditional CHUI client scenario, the client can be (and often is) runnin... Greg Shah
09:14 AM Feature #1639: implement socket support
But the performance improvement by hosting all the socket read/write directly in the server, is a substantial benefit... Greg Shah
06:03 AM Feature #1639: implement socket support
> I am pretty sure that each appserver "agent" and each batch process can have its own server socket opened. That me... Constantin Asofiei
01:42 PM Feature #1613 (Closed): finish FILE-INFO system handle support
Greg Shah
01:22 PM Feature #1613: finish FILE-INFO system handle support
Commited to bzr as revision number 10341.
Costin Savin
12:57 PM Feature #1613: finish FILE-INFO system handle support
Great! Costin: please check it in and distribute it. Greg Shah
12:10 PM Feature #1613: finish FILE-INFO system handle support
Runtime regression testing has passed. Constantin Asofiei
01:40 PM Feature #1626 (Closed): implement OS-DIR support as an INPUT stream
Greg Shah
01:22 PM Feature #1626: implement OS-DIR support as an INPUT stream
Update cs_upd20130418b from #1613 includes this. It has passed conversion and runtime regression testing.
Commited...
Costin Savin
12:56 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
It looks good. Please do both conversion and runtime regression testing on this. Greg Shah
12:07 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
1. I as not not sure about it, I hoped there is a way to obtain the clob data. I removed the code for it.
2. By mi...
Ovidiu Maxiniuc
11:38 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
All the changes are OK except the PropertyMapper. PropertyMapper is used as a helper for the database import process... Greg Shah
10:27 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
1. A line of code vanished probably in the cleanup or CTRL+D instead of CTRL+S? Added it back.
Working on @datetim...
Ovidiu Maxiniuc
08:52 AM Feature #1640: implement DOM XML support
Any current portions of the implementation must be considered incomplete and potentially incorrect. We did not reall... Greg Shah

04/18/2013

07:38 PM Feature #1640: implement DOM XML support
> 1. Method stubs that exist but need an implementation written.
ADD-SCHEMA-LOCATION stub in XCommon
REMOVE-A...
Evgeny Kiselev
05:58 PM Feature #1640: implement DOM XML support
OK, please make a list of the following:
1. Method stubs that exist but need an implementation written.
2. Method...
Greg Shah
04:12 PM Feature #1640: implement DOM XML support
Greg Shah wrote:
> > 2) Also there are 4gl methods that aren't implemented yet:
>
> What do you mean by this? T...
Evgeny Kiselev
10:04 AM Feature #1640: implement DOM XML support
> 2) Also there are 4gl methods that aren't implemented yet:
What do you mean by this? They are stubbed out alre...
Greg Shah
06:37 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
Code Review:
1. The change to RANDOM() processing in ECW:...
Greg Shah
05:07 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
As part of adding support for new data types, please review @com.goldencode.p2j.persist.HQLPreprocessor@ and the @com... Eric Faulhaber
02:55 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
New changes in this update:
* Fixed ArrayAssigner to work with int64 indexes
* Removed special constructor with boo...
Ovidiu Maxiniuc
12:45 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
In a few minutes. I'm working on finalizing the update.
I don't understand the 2 extra updates, probably the browser...
Ovidiu Maxiniuc
12:37 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
When do you expect to have the next update ready for review? I see the same om_upd20130416b.zip posted 3 times, but ... Greg Shah
01:59 PM Feature #1884: add some of the v10 data types and core built-ins
This one is even more obscure than the IN WINDOW clause. The main issues are:
# character/longchar interchangeabilit...
Constantin Asofiei
01:52 PM Feature #1920: implement persistent procedures
The problem occurs only for @OUTPUT@ parameters only. For @INPUT-OUTPUT@ parameters the subroutines works directly on... Ovidiu Maxiniuc
01:38 PM Feature #1920: implement persistent procedures
See note 25 from #1884 for other thoughts:
*GES*
>Normally, we always define parameters as the exact match to the t...
Constantin Asofiei
04:30 AM Feature #1920: implement persistent procedures
> For @OUTPUT@ mode, the current incomplete-coded solution is to pass a special "conversion" constructor, with an ext... Constantin Asofiei
01:21 PM Feature #1639: implement socket support
Added end of the day update, very little change from previous update since design solution is still discussed Costin Savin
12:46 PM Feature #1639: implement socket support
Here is the partial message of StackOverflow... Costin Savin
12:24 PM Feature #1639: implement socket support
> however it does seem to collect connect events and keep them to be executed in a WAIT-FOR, but as well as an input ... Greg Shah
08:49 AM Feature #1639: implement socket support
Accepting connection for ServerSocket doesn't seem to be done async as I previously implemented in the startListening... Costin Savin
12:42 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
Good work! Keep going. Greg Shah
09:06 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
The new drop has been updated after lots of debugging. Windows is a kind of black box. The FileDescriptor Java implem... Eugenie Lyzenko
11:12 AM Feature #1613: finish FILE-INFO system handle support
The 0418b is OK. Please get that regression tested. Greg Shah
10:41 AM Feature #1613: finish FILE-INFO system handle support
I checked the files from the update and indeed there were other differences (in FSD) between 15b and the latest code ... Costin Savin
10:07 AM Feature #1613: finish FILE-INFO system handle support
Please check that the update you posted here has the same versions that you used in testing. Greg Shah
09:55 AM Feature #1613: finish FILE-INFO system handle support
On my machine it was there, so it's possible I corrected it after I created the 15b archive. Costin Savin
09:48 AM Feature #1613: finish FILE-INFO system handle support
How did that update pass standalone test and conversion testing if it did not compile? Greg Shah
09:34 AM Feature #1613: finish FILE-INFO system handle support
Added the semicolon back Costin Savin
09:00 AM Feature #1613: finish FILE-INFO system handle support
Costin, about cs_upd20130415b.zip - you are missing a semicolon in filesys.c, line 103. Constantin Asofiei

04/17/2013

01:57 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
The @INT64@ is only needed when running Progress in @-noint64@ mode to make the literal integer-type. In absence of t... Ovidiu Maxiniuc
01:19 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
Interesting finding.
If we make this change:...
Greg Shah
12:11 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
What do you say about this 4GL code:... Ovidiu Maxiniuc
11:40 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
>> Why is this needed? The BDT.duplicate() method is meant for this exact case.
>
> I will remove the old code. Th...
Greg Shah
06:03 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
Greg Shah wrote:
> Code Review:
> 1. The modulo solution is still too simplistic. The 4GL has some behavior that d...
Ovidiu Maxiniuc
01:15 PM Feature #1920: implement persistent procedures
Some more remarks about parameter passing in subroutines (procedures and functions).
I investigated how arguments ca...
Ovidiu Maxiniuc
12:50 PM Feature #1639: implement socket support
Added end of the day update, ran tests on the p2j code and fixed the bugs I found. There is a problem in calling Cont... Costin Savin

04/16/2013

03:58 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
Code Review:
1. The modulo solution is still too simplistic. The 4GL has some behavior that doesn't exist in Java...
Greg Shah
01:57 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
I found today that there are some problems when working with large numbers (9223372036854775808 and up). Some numbers... Ovidiu Maxiniuc
03:09 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
Sorry, my mistake in the sample above, it should be multiplication, not addition:... Ovidiu Maxiniuc
03:03 PM Feature #1639: implement socket support
Added end of the day update re-tested the behavior on 4GL and adjusted the code.
> 1. getByteRange/setByteRange: h...
Costin Savin
10:09 AM Feature #1786 (Closed): implement server-side support for non-UI client features (file system mgm...
This task is no longer needed.
The initial idea was that server-side applications (batch programs, appserver, webs...
Greg Shah
09:24 AM Feature #1634: implement full native library (.so or DLL) support
In thinking about this, I have come to the conclusion that the only correct way to implement this is on the client-si... Greg Shah
09:09 AM Feature #1964 (WIP): finish runtime support for MEMPTR/RAW
Greg Shah
09:08 AM Feature #1635 (WIP): implement MEMPTR/RAW support
Something to highlight about this implementation: it must be implemented in the client. The real memory backed MEMPT... Greg Shah

04/15/2013

07:58 PM Feature #1640: implement DOM XML support
I have found next TODOs/issues list:
1) Next methods are not implemented(only stubs):
* com.goldencode.p2j.xml.XEntit...
Evgeny Kiselev
07:04 PM Feature #1639: implement socket support
Code Review:
1. getByteRange/setByteRange: have you tested these? I don't think they can work properly. For exam...
Greg Shah
03:07 PM Feature #1639: implement socket support
Added end of the day update.
6. 7. I realize these are just bad implementations, I'll stop including code I finish t...
Costin Savin
02:36 PM Feature #1613: finish FILE-INFO system handle support
Great! Work with Constantin to get it runtime regression tested. Greg Shah
02:34 PM Feature #1613: finish FILE-INFO system handle support
Ran conversion, no differences compared to latest from bzr, re-ran file-info and search tests, the results look good. Costin Savin
12:51 PM Feature #1613: finish FILE-INFO system handle support
It is OK. Get this tested.
Please also retest all the related testcases to prove that the solution is still valid...
Greg Shah
12:27 PM Feature #1613: finish FILE-INFO system handle support
Added update. I'll start the conversion test if there isn't anything else.
Costin Savin
12:15 PM Feature #1613: finish FILE-INFO system handle support
Code Review:
1. You have chosen the wrong place to put isPathRelativeToCurrentDir(). FileSystemOps runs on the SE...
Greg Shah
11:02 AM Feature #1613: finish FILE-INFO system handle support
Added proposed update: moved the isPathRelativeToCurrentDir() method from FileChecker to FileSystemOps, added check t... Costin Savin
10:20 AM Feature #1613: finish FILE-INFO system handle support
Editing mistake:
Since I couldn't copy/paste the text from the windows 4GL test I had to just write it down and pro...
Costin Savin
10:12 AM Feature #1613: finish FILE-INFO system handle support
Why was it broken? Greg Shah
09:45 AM Feature #1613: finish FILE-INFO system handle support
The correct version is:
@SEARCH(".\file.txt"): ?@ Edited it
Costin Savin
09:37 AM Feature #1613: finish FILE-INFO system handle support
Something is not right in the output you have posted. You posted this:... Greg Shah
07:59 AM Feature #1613: finish FILE-INFO system handle support
The testcases for using the wrong File separator:... Costin Savin
02:29 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
> Perhaps I did not document that well. It's about using ? raw literal. Consider the following code:
OK, go with i...
Greg Shah
01:48 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
Greg,
today I have investigated another point-of view. You mentioned the @DisplayFormat@, and starting to double ch...
Ovidiu Maxiniuc
12:51 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
Greg Shah wrote:
> More Code Review:
>
> 10. This MathOps method has a typo:
> [...]
Thanks, because of the ran...
Ovidiu Maxiniuc
12:16 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
Greg Shah wrote:
> Code Review:
>
> 1. The update is missing your BlockManager change.
> 2. DisplayFormat.instan...
Ovidiu Maxiniuc
12:05 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
More Code Review:
12. What is this code in int64?...
Greg Shah
10:52 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
More Code Review:
9. CompareOps is fine.
10. This MathOps method has a typo:...
Greg Shah
08:26 AM Feature #1632 (Closed): implement _MSG() undocumented built-in function
Greg Shah
08:23 AM Feature #2012 (Closed): runtime support for _MSG() built-in
Greg Shah

04/14/2013

06:48 PM Feature #2012 (Review): runtime support for _MSG() built-in
Evgeny Kiselev
09:11 PM Feature #2012 (WIP): runtime support for _MSG() built-in
Evgeny Kiselev
05:33 PM Feature #1632: implement _MSG() undocumented built-in function
committed evk_upd20130413a.zip in revision 10339 Evgeny Kiselev
10:39 AM Feature #1632: implement _MSG() undocumented built-in function
It looks good. You can check it in and distribute it. Greg Shah
09:03 PM Feature #1632: implement _MSG() undocumented built-in function
Corrected javadoc according to №18 comment. Evgeny Kiselev
12:57 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
> From my research, the -noint64 parameter does not affect in any way the current implementation.
I think you are ...
Greg Shah
10:48 AM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
It looks good. Keep going. Greg Shah
09:12 PM Feature #1980 (WIP): runtime support for DOM XML processing
Evgeny Kiselev

04/13/2013

05:58 PM Feature #1980: runtime support for DOM XML processing
Please put all history entries into the parent task #1640. Greg Shah
05:57 PM Feature #1632: implement _MSG() undocumented built-in function
I am fine with the proposed changes.
I do think we need to improve the javadoc. We should explain that the getE...
Greg Shah
08:07 PM Feature #1632: implement _MSG() undocumented built-in function
Attached update evk_upd20130412c.zip with testcase. Evgeny Kiselev

04/12/2013

07:05 PM Feature #1632: implement _MSG() undocumented built-in function
fixed error with int64 Evgeny Kiselev
06:12 PM Feature #1632: implement _MSG() undocumented built-in function
Attached update evk_upd20130412a.zip. Implemented getErrorNumberAtIndex method.
Also will provide testcase soon.
Evgeny Kiselev
07:02 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
> ... Eugenie Lyzenko
03:18 PM Feature #1613: finish FILE-INFO system handle support
>> - Unix P2J and 4GL will not find anything when given the path with the opposite separator,
>> - On Windows 4GL yo...
Greg Shah
02:37 PM Feature #1613: finish FILE-INFO system handle support
> I don't think this is right. For example, why are you appending the \ to ./ in this code: pathName.startsWith("./" ... Costin Savin
01:54 PM Feature #1613: finish FILE-INFO system handle support
> - Unix P2J and 4GL will not find anything when given the path with the opposite separator,
> - On Windows 4GL you ...
Greg Shah
12:41 PM Feature #1613: finish FILE-INFO system handle support
Tested with the file separator changed to opposite of what the OS uses,
The results are:
- Unix P2J and 4GL will no...
Costin Savin
09:05 AM Feature #1613: finish FILE-INFO system handle support
> The resulting code in the FSD.search() method has some blank lines removed where they previously existed. Please pu... Greg Shah
04:58 AM Feature #1613: finish FILE-INFO system handle support
Added proposed update. Costin Savin
02:59 PM Feature #1639: implement socket support
Code Feedback:
1. Some of the error messages are still wrong (the host is hard coded to "localhost" but it should ...
Greg Shah
02:06 PM Feature #1639: implement socket support
End of the day update. Costin Savin
07:04 AM Feature #1792: implement widget-pool support
Should the runtime task include working on the resources which can be added in a pool or add just the pooling support... Constantin Asofiei
06:02 AM Feature #1984: make methods to act as "read-only" attributes
From #1920 (note 76):
*GES*
1. The read_only_attribute function in common-progress.rules seems like it will be pain...
Constantin Asofiei
05:45 AM Feature #1921: implement super-procedures
A resume on what else needs to be done regarding super-procedure chains:
* make the SEARCH-TARGET and SEARCH-SELF em...
Constantin Asofiei
05:32 AM Bug #1971: emit worker versions for functions to fix source-procedure handle
This has two parts:
# the conversion part, where the worker method is added
# the runtime part, which involves the ...
Constantin Asofiei
05:28 AM Feature #2123: map the converted method/attribute names to their legacy name
Note 54 from #1920:
About the invalid API calls (when the invoked API is not valid for the current referent). 4GL ...
Constantin Asofiei
05:21 AM Feature #2123 (New): map the converted method/attribute names to their legacy name
Constantin Asofiei
05:10 AM Feature #2013: implement the SELF system handle
About the runtime implementation of SELF handles: I don't want to do this in a separate task; instead, each case whic... Constantin Asofiei
04:51 AM Bug #1968: implement MAP TO actual-name IN handle clause for function definitions
This clause should be easy to integrate in the ControlFlowOps invocation mechanism, as we only need to add a "hook" f... Constantin Asofiei
04:46 AM Bug #1969: buffer names in get-signature
The unknown part at this time is how the schema can be interogated to get the original buffer name. I expect we alrea... Constantin Asofiei
04:33 AM Feature #1972: provide full-support for DYNAMIC-FUNCTION set to function parameters
This is a _POLY case which should be solved by #2068 changes for _POLY cases. Estimate 1h to confirm. Constantin Asofiei

04/11/2013

05:08 PM Feature #1639: implement socket support
Code Review:
1. Messages that embed the local host's port number must be built dynamically at runtime with the cor...
Greg Shah
03:12 PM Feature #1639: implement socket support
Added "end of the day" update, this doesn't contain fix for all the issues from review (valid() I must see behavior). Costin Savin
02:18 PM Feature #1639: implement socket support
> I solved them by using complete name of java.net.Socket
That is fine for now.
Greg Shah
02:17 PM Feature #1639: implement socket support
More feedback:
This code in SocketListenerImpl.startListening() is wrong:...
Greg Shah
02:12 PM Feature #1639: implement socket support
The list of things to be done at the moment:
On SOCKET side:
- I modified the read methods because the GET-BYTES-AV...
Costin Savin
02:10 PM Feature #1639: implement socket support
Code Review for
1. Remember that we do NOT put individual import statements in code unless we are needing to over...
Greg Shah
01:20 PM Feature #1639: implement socket support
> what is left to be done
I am still waiting to see a detailed list of what is left to be implemented OR investiga...
Greg Shah
04:20 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
> I would suggest to replace this call with:
> ...
> sb.append(pkgroot.replaceAll("\\.", StringHelper.fixupRegex(fi...
Greg Shah
03:48 PM Feature #1613: finish FILE-INFO system handle support
Code Review of cs_upd20130410a.zip:
Generally I am fine with this update.
The resulting code in the FSD.searc...
Greg Shah
02:48 PM Feature #1613: finish FILE-INFO system handle support
> Were any of your changes applied at the time?
Yes the allowDir additional check only but that should not affect an...
Costin Savin
02:42 PM Feature #1613: finish FILE-INFO system handle support
Which bzr revision of P2J did you use to get the results of note 42?
Were any of your changes applied at the time?...
Greg Shah
01:25 PM Feature #1613: finish FILE-INFO system handle support
Considering we have the following directory structure:... Costin Savin
03:00 PM Feature #1634: implement full native library (.so or DLL) support
About the parameter validation: as the native side has no idea of the routine's signature (thanks for the details, it... Constantin Asofiei
12:11 PM Feature #1634: implement full native library (.so or DLL) support
> How will the native code know to convert a value from "ABL data type" to "ABL DLL type" (better said, if signature ... Greg Shah
11:08 AM Feature #1634: implement full native library (.so or DLL) support
> I was referring to NativeInvoker.invoke(). I'd like you to take that part. I will handle NativeInvoker.invokeRout... Constantin Asofiei
10:34 AM Feature #1634: implement full native library (.so or DLL) support
> Looks like I skipped the "native" modifier for the NativeInvoker.invokeRoutine() signature. Idea is this is a nativ... Greg Shah
05:34 AM Feature #1634: implement full native library (.so or DLL) support
Greg Shah wrote:
> I was planning to build the part of the solution from the NativeInvoker.invokeRoutine() on down t...
Constantin Asofiei
12:16 PM Feature #2121: implement Java runtime support for native libraries
This is just for time tracking. Place all history in parent task #1634. Greg Shah
12:15 PM Feature #2121 (Closed): implement Java runtime support for native libraries
Greg Shah

04/10/2013

05:56 PM Feature #1634: implement full native library (.so or DLL) support
I was planning to build the part of the solution from the NativeInvoker.invokeRoutine() on down to the OS. It is not... Greg Shah
07:04 AM Feature #1634: implement full native library (.so or DLL) support
Some ideas on how the code for native proc call should work and what needs to be done:
* determine how the argument v...
Constantin Asofiei
03:03 PM Feature #1635: implement MEMPTR/RAW support
The error behavior of all the BinaryData.get/set*() methods will need to be researched before implementation. If all... Greg Shah
02:39 PM Feature #1635: implement MEMPTR/RAW support
A more detailed look at NIO ByteBuffer makes it clear that it is not a suitable solution for our problem. In particu... Greg Shah
12:28 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
The issues(related or partially) to discuss so far:
1. The source file com/goldencode/p2j/util/SourceNameMapper.ja...
Eugenie Lyzenko
11:24 AM Feature #1613: finish FILE-INFO system handle support
After some tests I found some more problems in the search algorithm for example the file.isAbsolute() check should a... Costin Savin
08:09 AM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
OK, after you are finished with #1650, you can fix the propath assignment behavior. When that is done we will close ... Greg Shah

04/09/2013

07:09 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
> Is this done?
I have clarified this point. Both Windows and Linux 4GL systems shows the same behavior:...
Eugenie Lyzenko
04:46 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
The final work with this task was checked in as bzr revision 10152 on January 17, 2013. As far as I know this task m... Greg Shah
05:05 PM Feature #1634: implement full native library (.so or DLL) support
Constantin: can you define the native API you will need in order to finish the ControlFlowOps support for native proc... Greg Shah
04:56 PM Feature #1613: finish FILE-INFO system handle support
While you are working on the final fixes to FSD.search(), I would like to get a safe version of all the other changes... Greg Shah
02:03 PM Feature #1613: finish FILE-INFO system handle support
These investigations are all going in the right direction. Continue your analysis and make a list of the problems in... Greg Shah
12:37 PM Feature #1613: finish FILE-INFO system handle support
This part of the previous code ... Costin Savin
09:48 AM Feature #1613: finish FILE-INFO system handle support
After I retested to see what I've missed (both Unix and Windows) I realized that the behavior of search for files and... Costin Savin
01:28 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
> Reworked file names to simplify. Unfortunately for now process.h has compilation issue in Windows. So the file is:... Greg Shah
08:30 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
The next drop includes:
1. Restored missing code for linux process file to handle SIGCHLD
2. Reworked file names to...
Eugenie Lyzenko

04/08/2013

07:16 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
> 2. Please use the "simple" process.h and filesys.h instead of the longer *_helper.h versions.
I had the same ide...
Eugenie Lyzenko
06:59 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
Code Feedback:
1. Please remove the following from future updates:...
Greg Shah
01:48 PM Feature #1639: implement socket support
As mentioned in note 58, please document the list of things that still need to be completed, fixed or investigated. ... Greg Shah
01:15 PM Feature #1639: implement socket support
Added an intermediate update, this is just initial form, there are still many things to implement and bring to a clea... Costin Savin
12:26 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
I will be reviewing the 0406 updates shortly.
I assume you are now working on the datetime/datetime_tz changes. P...
Greg Shah
11:40 AM Feature #2108: event model rationalization
The 4GL event model is inherently "client" oriented. It's primary usage is built around the user-interface and the i... Greg Shah
11:07 AM Feature #2108 (Closed): event model rationalization
Greg Shah

04/07/2013

01:33 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
The next drop changes:
1. P2J build.xml file has been changed to pass OS architecture to the makefile for Windows com...
Eugenie Lyzenko

04/06/2013

12:37 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
I have found that the @int64@ variables (including @extent@) were not correctly initialized to 0. I fixed this.
I ad...
Ovidiu Maxiniuc

04/05/2013

02:15 PM Feature #1639: implement socket support
So far I've completed the connect (including ssl) on socket part and tested it, and also added code for read and wri... Costin Savin
07:44 AM Feature #1639: implement socket support
Costin: please put details here about what you are doing with the implementation, what is completed and what is left ... Greg Shah
01:44 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
I checked today and adjusted the code for the function calls (direct calls specially) and database access.
The imple...
Ovidiu Maxiniuc
08:56 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
> 5 and 6 work fine, I double checked. If pos + len is 33/65 means that the bits involved are the last len bits from ... Greg Shah
08:48 AM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
I like it. Keep going in this direction. Greg Shah
08:23 AM Feature #1626: implement OS-DIR support as an INPUT stream
OK, that is fine. Please put comments into that code to explain this, so that future readers will not accidentally c... Greg Shah
08:11 AM Feature #1626: implement OS-DIR support as an INPUT stream
Sorry I forgot to mention about that. The reason is when we have a link, getting the canonicalPath of the link file w... Costin Savin
08:01 AM Feature #1626: implement OS-DIR support as an INPUT stream
Please describe the reasons behind the DirStream.getPathName() change in cs_upd20130404a.zip. Greg Shah
08:21 AM Feature #1613: finish FILE-INFO system handle support
Code Feedback:
1. See note 52 in #1626.
2. The FSD.search() change to use file.getPath().startsWith(".") is not...
Greg Shah
04:58 AM Feature #1920: implement persistent procedures
You can go ahead and commit/release om_upd20130405a.zip
LE: just runtime changes, no conversion regression testing n...
Constantin Asofiei
04:56 AM Feature #1920: implement persistent procedures
Comment type changed to single-line. Ovidiu Maxiniuc
04:47 AM Feature #1920: implement persistent procedures
Review of om_upd20130404a.zip - do not use @/*@ for adding comments, always use @//@ single-line comments. Please mak... Constantin Asofiei

04/04/2013

01:14 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
I went on with integer-type parameter passing and implemented the same mechanism for @integer@/@int64@ as it was for ... Ovidiu Maxiniuc
01:00 PM Feature #1920: implement persistent procedures
This update fixes:
* @unknown@ parameter in function/procedure calls. The unknown values for some data types (@date@...
Ovidiu Maxiniuc
07:35 AM Feature #1613: finish FILE-INFO system handle support
> If the PROPATH is /path1/,/path2/,/path3/,. then a search for relative/path/to/file.txt would find /path1/relative/... Costin Savin

04/03/2013

06:40 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
Today drop has been uploaded. Includes:
1. Rework for build.xml to separate common native tasks. Adding required com...
Eugenie Lyzenko
09:25 AM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
I am generally fine with the build.xml approach. The only thing I see is this:... Greg Shah
08:11 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
OK. This drop contains only changes in build.xml project build file to review. Plus one small change for filesys.c fo... Eugenie Lyzenko
02:29 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
Greg,
I have integrated your feedback into the code for notes 1, 2, 3 and 4.
5 and 6 work fine, I double checked. ...
Ovidiu Maxiniuc
12:55 PM Feature #1613: finish FILE-INFO system handle support
Tested by having this structure @/workcs/file.txt@ in the current folder(@/home/costins@)
and setting propath varia...
Costin Savin
09:03 AM Feature #1613: finish FILE-INFO system handle support
> I removed the check for current directory because I considered it is already checked in the begining with file.exis... Greg Shah
06:08 AM Bug #2106: Missing runtime error messages in P2J
Moved from #2080, note 74
Example:...
Vadim Nebogatov

04/02/2013

04:11 PM Bug #2106: Missing runtime error messages in P2J
Moved from #2080, note 74
Example:...
Vadim Nebogatov
01:22 PM Bug #2106: Missing runtime error messages in P2J
Moved from #2080, note 78
Example:...
Vadim Nebogatov
01:21 PM Bug #2106: Missing runtime error messages in P2J
Moved from #2080, note 77
Example:...
Vadim Nebogatov
01:19 PM Bug #2106 (New): Missing runtime error messages in P2J
Vadim Nebogatov
01:29 PM Feature #1613: finish FILE-INFO system handle support
> 2.
> You are right, the case insensitive path is now broken with your changes. Please fix it.
I'm not sure it's...
Costin Savin
10:37 AM Feature #1613: finish FILE-INFO system handle support
> 3. This code looks wrong and it definitely breaks behavior that we rely upon today:
>
> // if the path length is...
Costin Savin
07:49 AM Feature #1613: finish FILE-INFO system handle support
Also, please note that your update zip filename is not matching our standard naming conventions. You don't need to c... Greg Shah
06:58 AM Feature #1613: finish FILE-INFO system handle support
Code Feedback:
1. This code in filesys.c still needs to close the file descriptor before returning:...
Greg Shah
06:24 AM Feature #1613: finish FILE-INFO system handle support
> The 4GL bug which sees .. directory as hidden for os dir is described in DirStream class (it happpends because the ... Greg Shah
06:09 AM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
Feedback:
It is OK so far. Make sure you merge with the latest version of P2J (for example the build.xml that you...
Greg Shah
05:47 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
Code Feedback:
1. The instantiateUnknownRaw() method should be positioned after the constructors in the raw.java.
...
Greg Shah

04/01/2013

11:22 AM Feature #1920: implement persistent procedures
Note 80 from #2080 shows a missing error for function invocation:... Constantin Asofiei
10:53 AM Feature #1613: finish FILE-INFO system handle support
Added proposed update, with the modified search function, eliminated the change in EnvironmentOps since it wasn't nec... Costin Savin
09:29 AM Feature #1613: finish FILE-INFO system handle support
> In the Javadoc of EnvironmentOps.searchPath() there is this saying:
I think you mean EnvironmentOps.getSearchPat...
Greg Shah

03/29/2013

07:06 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
This is update just for review to see the approach. It compiles native DLL in Windows 32-bit using mingw32-gcc. Plann... Eugenie Lyzenko
01:41 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
This update adds implementation for all TODOs from @int64@ and, since the implementation is mostly the same for the @... Ovidiu Maxiniuc
09:19 AM Bug #2105: BlockManager does not return some datatypes correctly
A first attempt to fix would be to have only one @returnNormal@ static function with a BDT parameter and the value wr... Ovidiu Maxiniuc
09:04 AM Bug #2105: BlockManager does not return some datatypes correctly
Consider the following 4GL code:... Ovidiu Maxiniuc
08:55 AM Bug #2105 (New): BlockManager does not return some datatypes correctly
Ovidiu Maxiniuc

03/28/2013

01:26 PM Feature #1613: finish FILE-INFO system handle support
I retested the cases from UAST which contained search function or Propath and there weren't any difference,
However ...
Costin Savin
08:53 AM Feature #1613: finish FILE-INFO system handle support
In the Javadoc of EnvironmentOps.searchPath() there is this saying:... Costin Savin
08:48 AM Feature #1613: finish FILE-INFO system handle support
I don't understand why the comma is included in the default path. We already have protection against the path being ... Greg Shah
08:37 AM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
You are allowed to use Windows in KVM on the same Ubuntu system. It will be allowed in the standards. Thanks for as... Greg Shah

03/27/2013

04:21 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
The question. I have idea to install The Windows inside the KVM Virtual Machine on my new Ubuntu box. Will it also co... Eugenie Lyzenko
02:58 PM Feature #1613: finish FILE-INFO system handle support
There seems to be an error in the search() logic of FileSystemDaemon.
If the given paths Array is non null it will s...
Costin Savin

03/26/2013

11:13 AM Feature #1613: finish FILE-INFO system handle support
Code Feedback:
1. StreamWrapper has no real changes other than the copyright date and the history entry. Does it ...
Greg Shah

03/25/2013

04:14 PM Feature #1626: implement OS-DIR support as an INPUT stream
Added proposed update.The update is for both #1613 and #1626 Costin Savin
04:13 PM Feature #1613: finish FILE-INFO system handle support
Added proposed update.The update is for both #1613 and #1626 Costin Savin
08:40 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
Ovidiu: your next priority should be completing the runtime work on this task. The first priority is to get the int6... Greg Shah

03/23/2013

03:18 PM Bug #2070: BlockManager Action disambiguation
Converting the extent_params_proc.p test on windows fails with this:... Constantin Asofiei

03/22/2013

09:37 AM Feature #1920: implement persistent procedures
Merged with latest bzr version, contains both CA 0322a.zip and CA 0322f.zip changes. committed to bzr revision 10313. Constantin Asofiei
08:24 AM Feature #1920: implement persistent procedures
The code is OK. It can be committed and distributed when it passes testing. Greg Shah
07:54 AM Feature #1920: implement persistent procedures
Fixes the case when a method param has subscript:... Constantin Asofiei
06:04 AM Feature #1920: implement persistent procedures
The code is OK. If it passes conversion testing you can check it in and distribute it. Greg Shah
05:31 AM Feature #1920: implement persistent procedures
Fixed conversion support for HANDLE attribute, when used with system handles:... Constantin Asofiei
06:59 AM Feature #1608: implement full appserver support (from 4GL clients only)
Checked in to bzr as revision 10310. Costin Savin
05:26 AM Feature #1608: implement full appserver support (from 4GL clients only)
Conversion testing passed. Check it in and distribute it. Greg Shah
 

Also available in: Atom