Activity
From 05/26/2013 to 06/24/2013
06/24/2013
- 07:59 PM Feature #1649: implement Windows environment/registry access
- More INI files interesting findings:
GET_KEY_VALUE for missing entry gives empty string, not error or NULL string.
...
06/21/2013
- 05:20 PM Feature #1649: implement Windows environment/registry access
- Possible situations with registry load/get/put:
1. Registry already has the key, using LOAD env. - Environment can b... - 01:57 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Changes in this update:
* where_clause.rules: cleanup;
* ImportWorker: put the fall-back mechanism back, improved P... - 12:17 PM Feature #1608: implement full appserver support (from 4GL clients only)
- Constantin Asofiei wrote:
> ... And something else about using @java.sql.ResultSet@ - to access the metadata, the on...
06/20/2013
- 05:09 PM Feature #1608: implement full appserver support (from 4GL clients only)
- This update:
# forces the PropertyDefinition.type to be a hibernate UserType subclass; it allows the user to specify... - 08:00 AM Feature #1608: implement full appserver support (from 4GL clients only)
- For tables used in OUTPUT and INPUT-OUTPUT mode, do we need to allow the user to access the new data via a @java.sql....
- 03:30 PM Feature #1649: implement Windows environment/registry access
- > > So looks like 4GL in Windows consider whitespaces at the end as meaningfull.
>
> This seems to be true for the... - 02:56 PM Feature #1649: implement Windows environment/registry access
- > So looks like 4GL in Windows consider whitespaces at the end as meaningfull.
This seems to be true for the LOAD ... - 02:05 PM Feature #1649: implement Windows environment/registry access
- > 1. Please check if whitespace at the end of strings is ignored for environment names. In the 4GL the string compari...
06/19/2013
- 06:19 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Code review 20130618a (no DB content in 20130619a):
I was just looking over the DB-related stuff. Overall very go... - 02:39 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- I am fine with the 0619a changes. Eric still needs to finish his review of the DB parts.
How is the conversion te... - 02:23 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Sorry, I zipped the wrong files.
Reuploaded. - 02:18 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- There are no differences in the files zipped into 0619a.
- 01:52 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Fixed _datetime-tz vs datetimetz_ issue.
My choice was to use java class name for TRPL processing and at the end swi... - 03:36 PM Feature #1649: implement Windows environment/registry access
- > 1. Please check if whitespace at the end of strings is ignored for environment names. In the 4GL the string compari...
- 01:58 PM Feature #1649: implement Windows environment/registry access
- > > LOAD and USE does not really touch the registry for creation keys with given environments.
>
> Can you explain... - 01:49 PM Feature #1649: implement Windows environment/registry access
- > LOAD and USE does not really touch the registry for creation keys with given environments.
Can you explain what ... - 01:48 PM Feature #1649: implement Windows environment/registry access
- Code Review (0618a)
1. Please check if whitespace at the end of strings is ignored for environment names. In the ... - 09:33 AM Feature #1608: implement full appserver support (from 4GL clients only)
- Thoughts on memptr:
I don't want to make any changes to memptr.java itself. As far as I understand it, the Open J... - 09:03 AM Feature #1608: implement full appserver support (from 4GL clients only)
- To use memptr from java code, I suggest the following:
# in memptr.java file, we directly use a MemoryDaemon instanc...
06/18/2013
- 07:27 PM Feature #1649: implement Windows environment/registry access
- Ini file findings:
LOAD creates the new empty INI file.
Registry findings:
LOAD and USE does not really touc... - 04:48 PM Feature #1608: implement full appserver support (from 4GL clients only)
- >>>hasPrevSibling (and hasNextSibling) will return true only if the resource supports the PREV-SIBLING (and the NEXT-...
- 02:44 PM Feature #1608: implement full appserver support (from 4GL clients only)
- > Also, don't we need to provide a basic subclass of TableResultSet for use on the remote side? For example, if we t...
- 12:20 PM Feature #1608: implement full appserver support (from 4GL clients only)
- I am fine with the resulting code. Thoughts:
>> 4. Do I understand correctly that the TableResultSet and TempTabl... - 11:21 AM Feature #1608: implement full appserver support (from 4GL clients only)
- [[> 1. The file Protocol.java has no changes compared to the one in bzr.
Had some whitespace added by mistake, I've ... - 04:41 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Code Review
I am good with all the non-database stuff. Eric will have to review the DB parts.
My only remaining... - 01:46 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Added new update file with the changes from reviews.
- 12:43 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- > * There is an @exc.printStackTrace()@ debug call left behind at line 1800 in Persistence. Was this triggered by the...
- 11:52 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- 20130606a/20130607a review (cont.):
* There is an @exc.printStackTrace()@ debug call left behind at line 1800 in Per... - 11:29 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Ah, good point, I didn't read carefully enough, but the comments are misleading. Since this is the only change (and i...
- 04:44 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- It was an attempt to implement the @datetime-tz@ operators. The initial idea was to handle (only) the two column @dat...
06/17/2013
- 04:37 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- I am reviewing the database changes in 20130606a. Although I'm not finished, I see one change so far that is likely ...
- 02:30 PM Feature #1608: implement full appserver support (from 4GL clients only)
- Code Review (0617b)
Wow! This is very, very good work. And it is massive too. I took me most of the day to revi... - 12:24 PM Feature #1608: implement full appserver support (from 4GL clients only)
- Merged with revision 10359.
- 08:54 AM Feature #1608: implement full appserver support (from 4GL clients only)
- - secured the connection IDs (only authorized sessions can access them)
- some other fixes related to using appserve...
06/14/2013
- 03:04 PM Feature #1649: implement Windows environment/registry access
- INI files findings:
1. LOAD is case insensitive, we can use evl_env for eVl_eNV.ini file, or eVl_eNV for evl_env.i... - 01:22 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- 3. All @date@ and @datetime@ in 4GL are not localized. Or perhaps, as I found somewhere written, they are localtime. ...
06/13/2013
- 06:58 PM Feature #1649: implement Windows environment/registry access
- Code Review
1. The use of EnvironmentDaemon.envMap should probably have keys lowercased. The change is needed in ... - 06:39 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Code Review (0606a and 0607a)
Eric will have to look carefully at the database related parts. Overall, it is very... - 12:37 PM Feature #1608: implement full appserver support (from 4GL clients only)
- Some later edits:
4. the AppServerFactory class was renamed to ServerFactory, as a SERVER object handle can connect ... - 10:05 AM Feature #1608: implement full appserver support (from 4GL clients only)
- This update is a good version for review; major remaining TODOs:
1. implement context-local reset (for State-reset m...
06/12/2013
- 03:56 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Ovidiu Maxiniuc wrote:
> While testing queries that use pl/java functions I observed that in 4GL, eventual errors ar...
06/11/2013
- 01:46 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- While testing queries that use pl/java functions I observed that in 4GL, eventual errors are silently discarded, for ...
06/10/2013
- 05:27 PM Feature #1649: implement Windows environment/registry access
- The new drop includes:
1. Some rework for Java implementation of base logic.
2. The ThinClient starts the Environme...
06/07/2013
- 01:32 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- This update fixes the import of date / datetime / datetime-tz fields.
The *.d files are parsed for PSC header / foot...
06/06/2013
- 12:33 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Some test cases I used for int64 / date / datetime / datetime-tz.
They are a little messy but I tried to comment eac... - 12:28 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Greg Shah wrote:
> I would also like to see the list of all open/remaining todos/issues.
Added update for datetime/...
06/05/2013
- 05:43 PM Feature #1649: implement Windows environment/registry access
- The overall design looks good.
Some thoughts:
1. Please create some non-trivial samples that use a complete ran... - 04:46 PM Feature #1649: implement Windows environment/registry access
- The first high level design upload for you to review. The offered implementation:
1. The class EnvironmentOps calls ... - 02:48 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Please post your current code, even if not yet complete. I want to start the code review process, since it may take ...
- 11:22 AM Feature #1608: implement full appserver support (from 4GL clients only)
- Greg Shah wrote:
> > the requester can use it, but on the requester side the resource to which will end up being mapp... - 11:17 AM Feature #1608: implement full appserver support (from 4GL clients only)
- > the requester can use it, but on the requester side the resource to which will end up being mapped is somehow rando...
06/04/2013
- 05:28 PM Feature #1608: implement full appserver support (from 4GL clients only)
- > Plan to support the same types that the 4GL supports. For example: do they support handle from Java code to/from a...
- 05:15 PM Feature #1608: implement full appserver support (from 4GL clients only)
- Let's go ahead and use the P2J wrapper types all the way out to the custom Java code. This way, we can duplicate the...
- 02:18 PM Feature #1608: implement full appserver support (from 4GL clients only)
- For OUTPUT and INPUT-OUTPUT parameters from Java code, I was thinking to use the P2J data wrappers + the string repre...
- 12:19 PM Feature #1608: implement full appserver support (from 4GL clients only)
- > I don't understand exactly what you mean by this part. Perhaps you can provide more detail/an example?
Lets say a... - 11:29 AM Feature #1608: implement full appserver support (from 4GL clients only)
- > then this can be used to communicate with the appserver, and acts as a channel for receiveing request from the remo...
- 08:39 AM Feature #1608: implement full appserver support (from 4GL clients only)
- Something else about the appserver agents: in cases when a direct connection is established from Java code and this c...
- 08:19 AM Feature #1608: implement full appserver support (from 4GL clients only)
- OK, then just do the following:
1. As part of the appserver agent startup, set the session:batch-mode to true.
2.... - 05:15 AM Feature #1608: implement full appserver support (from 4GL clients only)
- > The key question: what is the minimum you can do to get through this task?
This does not hurt at all the appserver... - 11:29 AM Bug #2130: fix propath assignment
- > It is OK. I think we can avoid testing this one. Check it in and distribute it.
OK, agreed. Moreover this change... - 11:06 AM Bug #2130: fix propath assignment
- It is OK. I think we can avoid testing this one. Check it in and distribute it.
- 11:02 AM Bug #2130: fix propath assignment
- The updated file has been uploaded for you to review.
- 10:34 AM Bug #2130: fix propath assignment
- No, you are right. That code is missing:...
- 09:19 AM Bug #2130: fix propath assignment
- Greg, is it me or SourceNameMapper.java is missing the H019 changes, from 20130412?
06/03/2013
- 01:58 PM Bug #2130 (Closed): fix propath assignment
- 01:11 PM Bug #2130: fix propath assignment
- The update evl_upd20130530b.zip has passed the regression testing and committed in bzr as revision 10357.
- 11:55 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Since this is becoming quite complicated, let's take a step back to see if we really need this right now.
The date... - 10:44 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- I added some small patched to have my @CompositeCustomType@ written as named parameters. Simple equality queries exec...
- 08:04 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- When processing multicolumn values there are a few keypoints of interest:...
- 10:22 AM Feature #1608: implement full appserver support (from 4GL clients only)
- I believe this is the equivalent of batch mode (see #1787). This is expected. I was planning to work on it after I ...
05/31/2013
- 05:00 PM Feature #1608: implement full appserver support (from 4GL clients only)
- I'm trying to make the agents unaware of UI code (to behave as if all output is redirected to /dev/null), but the "he...
- 09:49 AM Feature #2132 (Closed): implement any missing filesys.c features for Windows
- 08:37 AM Feature #1650 (Closed): process launching support for Windows (JNI library changes and any associ...
- Distributed and committed to bzr as rev 10356.
05/30/2013
- 06:51 PM Bug #2130: fix propath assignment
- > OK, this is ready for testing. When the #1650 changes pass testing, this will be next. It will need both conversion...
- 01:56 PM Bug #2130: fix propath assignment
- OK, this is ready for testing. When the #1650 changes pass testing, this will be next. It will need both conversion...
- 01:51 PM Bug #2130: fix propath assignment
- > The only thing missing is that the resolveJavaClass() method should be removed from NameMappingWorker, since it is ...
- 01:41 PM Bug #2130: fix propath assignment
- It looks good. The only thing missing is that the resolveJavaClass() method should be removed from NameMappingWorker...
- 01:12 PM Bug #2130: fix propath assignment
- The new PROPATH fix has been uploaded:
> 1. Please change the name of the "propathDefault" data member to "propath... - 12:54 PM Bug #2130: fix propath assignment
- OK. Eugenie, please go forward as described.
- 12:42 PM Bug #2130: fix propath assignment
- > SourceNameMapper.convertJavaProg() is called from NameMappingWorker.classNameExists() method which is still in use....
- 12:37 PM Bug #2130: fix propath assignment
- >> But there still seems to be 1 remaining dependency.
>
> What dependency do you refer too?
SourceNameMapper.co... - 11:44 AM Bug #2130: fix propath assignment
- The NameMappingWorker should have no use of the propath, during conversion. Even if NameMappingWorker.resolveJavaClas...
- 11:33 AM Bug #2130: fix propath assignment
- The SourceNameMapper.convertJavaProg() is called from NameMappingWorker.classNameExists() method which is still in us...
- 11:18 AM Bug #2130: fix propath assignment
- > The propath field removing from SourceNameMapper works fine. But the file p2j/convert/NameMappingWorker.java need t...
- 10:31 AM Bug #2130: fix propath assignment
- > The problem I think is the SourceNameMapper.propath field, which gets initialized by the SourceNameMapper.initMappi...
- 07:00 AM Bug #2130: fix propath assignment
- Code Review (0529a)
1. Please change the name of the "propathDefault" data member to "propathFixed".
2. For the... - 02:58 AM Bug #2130: fix propath assignment
- The problem I think is the @SourceNameMapper.propath@ field, which gets initialized by the @SourceNameMapper.initMapp...
- 06:28 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
- Replaced the file with correct name - evl_upd20130530c.zip. Sorry for this mess.
- 06:04 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
- > that stuff MUST be removed. No debugging output should remain. If that is only in the windows code, then you don't ...
- 05:31 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
- I should have caught that. No, that stuff MUST be removed. No debugging output should remain. If that is only in t...
- 05:11 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
- > Please check it in and distribute it via email.
OK. One more question. There are the console logging code(printf... - 05:00 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
- Great! Please check it in and distribute it via email.
- 04:32 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
- > Then you can run regression testing in staging, directly.
The testing completed. There are no regressions, resul... - 05:19 PM Feature #1640: implement DOM XML support
- The basic idea here:...
- 05:03 PM Feature #1640: implement DOM XML support
- Greg Shah wrote:
> Code Review (0527a)
>
>
> 11. The XmlFactory.createXNodeReference() implementation (both version... - 03:03 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- After a full day of debugging and small changes:
Converted code:... - 07:57 AM Feature #1608: implement full appserver support (from 4GL clients only)
- Understood. Good.
- 07:56 AM Feature #1608: implement full appserver support (from 4GL clients only)
- > I believe this is also how Progress does it in the Open Java Client.
Yes, this is similar to how the progress docu... - 07:04 AM Feature #1608: implement full appserver support (from 4GL clients only)
- Yes, I think your approach with result-sets is correct. Pure Java code (like BPM) does not want to be dealing with l...
- 03:59 AM Feature #1608: implement full appserver support (from 4GL clients only)
- > 11. Yes, parameters passed via RemoteObject proxies are immutable. So we must invent something to implement:
> ...
...
05/29/2013
- 06:51 PM Bug #2130: fix propath assignment
- New approach update has been uploaded. The changes:
1. New member for WorkArea in EnvironmentOps.java to separate fu... - 06:19 AM Bug #2130: fix propath assignment
- Please see #1608 note 73 for two example testcases (test1.p and test2.p) which should run properly when you have fixe...
- 04:33 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Ovidiu Maxiniuc wrote:
> However, I cannot see why I get the error message when running
> @new FindQuery(tt1, "tt1.... - 02:10 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- With this table:...
- 07:09 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- It looks good.
- 06:03 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Greg Shah wrote:
> I am fine with the update except for one question: why not use writeShort() and readShort() in th... - 03:36 PM Feature #1640: implement DOM XML support
- Evgeny Kiselev wrote:
> I still have a problem with delete statement. Aast generate java code:
> @HandleOps.delete(... - 03:07 PM Feature #1640: implement DOM XML support
- Code Review (0527a)
1. Almost all of the files are missing a history entry describing your changes.
2. handle.j... - 07:16 AM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
- > Please get this runtime regression tested. I have applied the pending changes to staging and I am running conversio...
- 06:53 AM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
- It looks good. Please get this runtime regression tested. I have applied the pending changes to staging and I am ru...
- 09:20 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
- Merged update has been uploaded.
- 05:02 AM Feature #1608: implement full appserver support (from 4GL clients only)
- > I will have Eugenie add the SourceNameMapper propath changes in. Can you suggest some simple testcases that he can...
05/28/2013
- 07:47 PM Feature #1649: implement Windows environment/registry access
- OK. Then you will need to generate the same errors when running on systems other than Windows.
- 07:42 PM Feature #1649: implement Windows environment/registry access
- > I don't understand what you mean here. Please show an example.
>
> And a question: can the INI files be used on ... - 07:24 PM Feature #1649 (WIP): implement Windows environment/registry access
- > This in not very optimized approach especially for INI file due to open->write->close cycle we have to do for every...
- 07:46 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
- > As far as I can see MSVCRT.DLL is a standard package at least from XP. Why do we need to distribute it?
Are you ... - 07:33 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
- > 1. The approach is fine. Please remove all the logging code from the DllEntryPoint function. In addition, put comme...
- 07:06 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
- Code Review
1. The approach is fine. Please remove all the logging code from the DllEntryPoint function. In addi... - 07:35 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Code Review (for 0527b)
I am fine with the update except for one question: why not use writeShort() and readShort() ... - 04:15 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Constantin Asofiei wrote:
> The server project failed compilation:
> [...]
> We need the SpaceField(integer), Skip... - 05:29 PM Bug #2130: fix propath assignment
- Code Review:
> The implementation idea is to store variable part in WorkArea with initial value as "." - current d... - 04:48 PM Feature #1608: implement full appserver support (from 4GL clients only)
- >> 10. Yes, we need to fix the SourceNameMapper to use the effective propath. Eugenie is also working on a fix for pr...
- 04:39 PM Feature #1608: implement full appserver support (from 4GL clients only)
- Some info about agent's context management: I've tested all modes, by creating a global shared var in the connect pro...
- 03:43 PM Feature #1608: implement full appserver support (from 4GL clients only)
- > 1. Is there any need for this information (e.g. the legacy port number)?
OK, I'll leave out of the directory any... - 01:25 PM Feature #1608: implement full appserver support (from 4GL clients only)
- ...
- 01:21 PM Feature #1608: implement full appserver support (from 4GL clients only)
- I have reviewed the design in detail. It looks very good.
Here are my questions/comments:
1. Is there any ne... - 11:04 AM Feature #1608: implement full appserver support (from 4GL clients only)
- More findings on remote procedure invocations: 4GL allows to *Pass INPUT, OUTPUT, and INPUT-OUTPUT variable or TEMP-T...
- 09:18 AM Feature #2135: implement COPY-LOB language statement
- An early form of COPY-LOB support was created in #1635. It is only useful for testing purposes and it is not complet...
- 09:18 AM Feature #1635 (Closed): implement MEMPTR/RAW support
- This is a complete re-write of the memptr and raw data types. Since most of the implementation of these types is sha...
05/27/2013
- 06:43 PM Feature #1640: implement DOM XML support
- upload test
- 06:43 PM Feature #1640: implement DOM XML support
- upload new version with bugfixes
- 04:55 AM Feature #1640: implement DOM XML support
- I still have a problem with delete statement. Aast generate java code:
@HandleOps.delete(hDoc);@
But inside delete me... - 03:38 PM Feature #1649: implement Windows environment/registry access
- > More importantly, does the 4GL immediately persist any changes to the backing registry/INI file? Or are those chang...
- 02:22 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- > Please provide or point me to your new @DatetimeTzUserType@ implementation (and supporting code). I didn't see it ...
- 12:31 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Ovidiu Maxiniuc wrote:
> * completely rewrote the @DatetimeTzUserType@ as implements @CompositeUserType@. It declare... - 10:08 AM Feature #1608: implement full appserver support (from 4GL clients only)
- # In 4GL, if the @PROPATH@ function is used at runtime and to set the propath to i.e. @.@, then all RUN statements wi...
Also available in: Atom