FWD » Core Development » Base Language

06/28/2013

06:46 PM Feature #1649: implement Windows environment/registry access

The investigation results:
> 1. Please do consider if it is possible to shift the EnvironmentAccessor to use String ... Eugenie Lyzenko

11:38 AM Feature #1608: implement full appserver support (from 4GL clients only)

I think I understand your point now. These changes don't affect the cleanup that happens during normal termination p... Greg Shah

10:16 AM Feature #1608: implement full appserver support (from 4GL clients only)

> 1. SecurityManager.resetContext() should probably be only callable from selected portions of the P2J runtime (using... Constantin Asofiei

10:04 AM Feature #1608: implement full appserver support (from 4GL clients only)

Code Review 0628a
Overall it looks very good. A couple of things:
1. SecurityManager.resetContext() should pro... Greg Shah

08:19 AM Feature #1608: implement full appserver support (from 4GL clients only)

Adds State-reset support plus a @TableResultSet.asResultSet@ API which returns a @java.sql.ResultSet@ proxy for the d... Constantin Asofiei

06/27/2013

06:22 PM Feature #1608: implement full appserver support (from 4GL clients only)

The SharedVariableManager's ContextContainer instances will get cleaned up (i.e. removed) too during reset. What I wa... Constantin Asofiei

06:08 PM Feature #1608: implement full appserver support (from 4GL clients only)

I don't have a problem with this, but how does the app-created stuff (e.g. shared vars) get cleaned up if we complete... Greg Shah

05:48 PM Feature #1608: implement full appserver support (from 4GL clients only)

About State-reset: the good news is that 4GL doesn't save any state created by the connect or startup procedures, for... Constantin Asofiei

10:56 AM Feature #1608: implement full appserver support (from 4GL clients only)

Greg Shah wrote:
> Great! Please distribute the changes and check it in.
Committed to bzr revision 10361. Constantin Asofiei

10:17 AM Feature #1608: implement full appserver support (from 4GL clients only)

> see the javadoc for AppServerTest.java class for details about connecting to the appserver from Java code. Please l... Greg Shah

10:04 AM Feature #1608: implement full appserver support (from 4GL clients only)

Great! Please distribute the changes and check it in. Greg Shah

05:08 AM Feature #1608: implement full appserver support (from 4GL clients only)

0626a.zip has passed regression testing. Constantin Asofiei

10:15 AM Bug #2130: fix propath assignment

Fixed in appended update. Committed in bzr as 10360. Eugenie Lyzenko

09:13 AM Bug #2130: fix propath assignment

You can go ahead and fix the javadoc issue in that one file. Do NOT add a history entry for that change. Then you m... Greg Shah

08:00 PM Bug #2130: fix propath assignment

There is one javadoc issue found here which does not touch the functionality and does not require re-testing. The pro... Eugenie Lyzenko

10:01 AM Feature #1649: implement Windows environment/registry access

The code looks good. Some thoughts:
1. Please do consider if it is possible to shift the EnvironmentAccessor to u... Greg Shah

06/26/2013

07:52 PM Feature #1649: implement Windows environment/registry access

> Please note that the StanzaIni constructors need javadoc.
The new update uploaded. The javadoc missing entries w... Eugenie Lyzenko

07:21 PM Feature #1649: implement Windows environment/registry access

> How much more effort do you expect is needed to complete your testcases and the implementation?
This is the seri... Eugenie Lyzenko

05:08 PM Feature #1649: implement Windows environment/registry access

Code Review 0626a
I am fine with the code and approach in general. Please note that the StanzaIni constructors ne... Greg Shah

02:49 PM Feature #1649: implement Windows environment/registry access

> Please make sure to test cases where "" (empty string) is passed for various parameters AND where unknown value is ... Eugenie Lyzenko

05:09 PM Feature #1608: implement full appserver support (from 4GL clients only)

Greg Shah wrote:
> > 1. implement context-local reset (for State-reset mode). This is a little tricky, as I think we... Constantin Asofiei

10:27 AM Feature #1608: implement full appserver support (from 4GL clients only)

Code Review 0625b
I am fine with the proposed code. There a a couple of minor coding standard issues (explicit im... Greg Shah

10:06 AM Feature #1608: implement full appserver support (from 4GL clients only)

> 1. implement context-local reset (for State-reset mode). This is a little tricky, as I think we need to take a snap... Greg Shah

06/25/2013

06:26 PM Feature #1608: implement full appserver support (from 4GL clients only)

This adds MemoryBuffer support: instances of this class must be used by the Java client code, when performing appserv... Constantin Asofiei

04:46 PM Feature #1608: implement full appserver support (from 4GL clients only)

I've found the Memptr.java javadoc on windev01 -devsrv01- and it states that "Represents the PROGRESS 4GL MEMPTR data... Constantin Asofiei

04:32 PM Feature #1608: implement full appserver support (from 4GL clients only)

> BTW, any news on memptr about the "is it safe to store it on the Java heap" issue?
I thought my comments in note... Greg Shah

04:19 PM Feature #1608: implement full appserver support (from 4GL clients only)

Eh, I was thinking if the user wanted to provide its own implementation of a ResultSet, but this is unlikely. My real... Constantin Asofiei

04:15 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

One minor issue exists in the generated code. Here is an example:... Greg Shah

01:31 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

I am putting this code through conversion and runtime regression testing right now. I had to modify the datetime cla... Greg Shah

10:10 AM Feature #1649: implement Windows environment/registry access

The code in 0621a is good. The findings are also interesting. Please make sure to test cases where "" (empty string... Greg Shah

06/24/2013

07:59 PM Feature #1649: implement Windows environment/registry access

More INI files interesting findings:
GET_KEY_VALUE for missing entry gives empty string, not error or NULL string.
... Eugenie Lyzenko

06/21/2013

05:20 PM Feature #1649: implement Windows environment/registry access

Possible situations with registry load/get/put:
1. Registry already has the key, using LOAD env. - Environment can b... Eugenie Lyzenko

01:57 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Changes in this update:
* where_clause.rules: cleanup;
* ImportWorker: put the fall-back mechanism back, improved P... Ovidiu Maxiniuc

12:17 PM Feature #1608: implement full appserver support (from 4GL clients only)

Constantin Asofiei wrote:
> ... And something else about using @java.sql.ResultSet@ - to access the metadata, the on... Eric Faulhaber

06/20/2013

05:09 PM Feature #1608: implement full appserver support (from 4GL clients only)

This update:
# forces the PropertyDefinition.type to be a hibernate UserType subclass; it allows the user to specify... Constantin Asofiei

08:00 AM Feature #1608: implement full appserver support (from 4GL clients only)

For tables used in OUTPUT and INPUT-OUTPUT mode, do we need to allow the user to access the new data via a @java.sql.... Constantin Asofiei

03:30 PM Feature #1649: implement Windows environment/registry access

> > So looks like 4GL in Windows consider whitespaces at the end as meaningfull.
>
> This seems to be true for the... Eugenie Lyzenko

02:56 PM Feature #1649: implement Windows environment/registry access

> So looks like 4GL in Windows consider whitespaces at the end as meaningfull.
This seems to be true for the LOAD ... Greg Shah

02:05 PM Feature #1649: implement Windows environment/registry access

> 1. Please check if whitespace at the end of strings is ignored for environment names. In the 4GL the string compari... Eugenie Lyzenko

06/19/2013

06:19 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Code review 20130618a (no DB content in 20130619a):
I was just looking over the DB-related stuff. Overall very go... Eric Faulhaber

02:39 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

I am fine with the 0619a changes. Eric still needs to finish his review of the DB parts.
How is the conversion te... Greg Shah

02:23 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Sorry, I zipped the wrong files.
Reuploaded. Ovidiu Maxiniuc

02:18 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

There are no differences in the files zipped into 0619a. Greg Shah

01:52 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Fixed _datetime-tz vs datetimetz_ issue.
My choice was to use java class name for TRPL processing and at the end swi... Ovidiu Maxiniuc

03:36 PM Feature #1649: implement Windows environment/registry access

> 1. Please check if whitespace at the end of strings is ignored for environment names. In the 4GL the string compari... Eugenie Lyzenko

01:58 PM Feature #1649: implement Windows environment/registry access

> > LOAD and USE does not really touch the registry for creation keys with given environments.
>
> Can you explain... Eugenie Lyzenko

01:49 PM Feature #1649: implement Windows environment/registry access

> LOAD and USE does not really touch the registry for creation keys with given environments.
Can you explain what ... Greg Shah

01:48 PM Feature #1649: implement Windows environment/registry access

Code Review (0618a)
1. Please check if whitespace at the end of strings is ignored for environment names. In the ... Greg Shah

09:33 AM Feature #1608: implement full appserver support (from 4GL clients only)

Thoughts on memptr:
I don't want to make any changes to memptr.java itself. As far as I understand it, the Open J... Greg Shah

09:03 AM Feature #1608: implement full appserver support (from 4GL clients only)

To use memptr from java code, I suggest the following:
# in memptr.java file, we directly use a MemoryDaemon instanc... Constantin Asofiei

06/18/2013

07:27 PM Feature #1649: implement Windows environment/registry access

Ini file findings:
LOAD creates the new empty INI file.
Registry findings:
LOAD and USE does not really touc... Eugenie Lyzenko

04:48 PM Feature #1608: implement full appserver support (from 4GL clients only)

>>>hasPrevSibling (and hasNextSibling) will return true only if the resource supports the PREV-SIBLING (and the NEXT-... Greg Shah

02:44 PM Feature #1608: implement full appserver support (from 4GL clients only)

> Also, don't we need to provide a basic subclass of TableResultSet for use on the remote side? For example, if we t... Constantin Asofiei

12:20 PM Feature #1608: implement full appserver support (from 4GL clients only)

I am fine with the resulting code. Thoughts:
>> 4. Do I understand correctly that the TableResultSet and TempTabl... Greg Shah

11:21 AM Feature #1608: implement full appserver support (from 4GL clients only)

[[> 1. The file Protocol.java has no changes compared to the one in bzr.
Had some whitespace added by mistake, I've ... Constantin Asofiei

04:41 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Code Review
I am good with all the non-database stuff. Eric will have to review the DB parts.
My only remaining... Greg Shah

01:46 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Added new update file with the changes from reviews. Ovidiu Maxiniuc

12:43 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

> * There is an @exc.printStackTrace()@ debug call left behind at line 1800 in Persistence. Was this triggered by the... Ovidiu Maxiniuc

11:52 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

20130606a/20130607a review (cont.):
* There is an @exc.printStackTrace()@ debug call left behind at line 1800 in Per... Eric Faulhaber

11:29 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Ah, good point, I didn't read carefully enough, but the comments are misleading. Since this is the only change (and i... Eric Faulhaber

04:44 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

It was an attempt to implement the @datetime-tz@ operators. The initial idea was to handle (only) the two column @dat... Ovidiu Maxiniuc

06/17/2013

04:37 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

I am reviewing the database changes in 20130606a. Although I'm not finished, I see one change so far that is likely ... Eric Faulhaber

02:30 PM Feature #1608: implement full appserver support (from 4GL clients only)

Code Review (0617b)
Wow! This is very, very good work. And it is massive too. I took me most of the day to revi... Greg Shah

12:24 PM Feature #1608: implement full appserver support (from 4GL clients only)

Merged with revision 10359. Constantin Asofiei

08:54 AM Feature #1608: implement full appserver support (from 4GL clients only)

- secured the connection IDs (only authorized sessions can access them)
- some other fixes related to using appserve... Constantin Asofiei

06/14/2013

03:04 PM Feature #1649: implement Windows environment/registry access

INI files findings:
1. LOAD is case insensitive, we can use evl_env for eVl_eNV.ini file, or eVl_eNV for evl_env.i... Eugenie Lyzenko

01:22 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

3. All @date@ and @datetime@ in 4GL are not localized. Or perhaps, as I found somewhere written, they are localtime. ... Ovidiu Maxiniuc

06/13/2013

06:58 PM Feature #1649: implement Windows environment/registry access

Code Review
1. The use of EnvironmentDaemon.envMap should probably have keys lowercased. The change is needed in ... Greg Shah

06:39 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Code Review (0606a and 0607a)
Eric will have to look carefully at the database related parts. Overall, it is very... Greg Shah

12:37 PM Feature #1608: implement full appserver support (from 4GL clients only)

Some later edits:
4. the AppServerFactory class was renamed to ServerFactory, as a SERVER object handle can connect ... Constantin Asofiei

10:05 AM Feature #1608: implement full appserver support (from 4GL clients only)

This update is a good version for review; major remaining TODOs:
1. implement context-local reset (for State-reset m... Constantin Asofiei

06/12/2013

03:56 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Ovidiu Maxiniuc wrote:
> While testing queries that use pl/java functions I observed that in 4GL, eventual errors ar... Eric Faulhaber

06/11/2013

01:46 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

While testing queries that use pl/java functions I observed that in 4GL, eventual errors are silently discarded, for ... Ovidiu Maxiniuc

06/10/2013

05:27 PM Feature #1649: implement Windows environment/registry access

The new drop includes:
1. Some rework for Java implementation of base logic.
2. The ThinClient starts the Environme... Eugenie Lyzenko

06/07/2013

01:32 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

This update fixes the import of date / datetime / datetime-tz fields.
The *.d files are parsed for PSC header / foot... Ovidiu Maxiniuc

06/06/2013

12:33 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Some test cases I used for int64 / date / datetime / datetime-tz.
They are a little messy but I tried to comment eac... Ovidiu Maxiniuc

12:28 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Greg Shah wrote:
> I would also like to see the list of all open/remaining todos/issues.
Added update for datetime/... Ovidiu Maxiniuc

06/05/2013

05:43 PM Feature #1649: implement Windows environment/registry access

The overall design looks good.
Some thoughts:
1. Please create some non-trivial samples that use a complete ran... Greg Shah

04:46 PM Feature #1649: implement Windows environment/registry access

The first high level design upload for you to review. The offered implementation:
1. The class EnvironmentOps calls ... Eugenie Lyzenko

02:48 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Please post your current code, even if not yet complete. I want to start the code review process, since it may take ... Greg Shah

11:22 AM Feature #1608: implement full appserver support (from 4GL clients only)

Greg Shah wrote:
> > the requester can use it, but on the requester side the resource to which will end up being mapp... Constantin Asofiei

11:17 AM Feature #1608: implement full appserver support (from 4GL clients only)

> the requester can use it, but on the requester side the resource to which will end up being mapped is somehow rando... Greg Shah

06/04/2013

05:28 PM Feature #1608: implement full appserver support (from 4GL clients only)

> Plan to support the same types that the 4GL supports. For example: do they support handle from Java code to/from a... Constantin Asofiei

05:15 PM Feature #1608: implement full appserver support (from 4GL clients only)

Let's go ahead and use the P2J wrapper types all the way out to the custom Java code. This way, we can duplicate the... Greg Shah

02:18 PM Feature #1608: implement full appserver support (from 4GL clients only)

For OUTPUT and INPUT-OUTPUT parameters from Java code, I was thinking to use the P2J data wrappers + the string repre... Constantin Asofiei

12:19 PM Feature #1608: implement full appserver support (from 4GL clients only)

> I don't understand exactly what you mean by this part. Perhaps you can provide more detail/an example?
Lets say a... Constantin Asofiei

11:29 AM Feature #1608: implement full appserver support (from 4GL clients only)

> then this can be used to communicate with the appserver, and acts as a channel for receiveing request from the remo... Greg Shah

08:39 AM Feature #1608: implement full appserver support (from 4GL clients only)

Something else about the appserver agents: in cases when a direct connection is established from Java code and this c... Constantin Asofiei

08:19 AM Feature #1608: implement full appserver support (from 4GL clients only)

OK, then just do the following:
1. As part of the appserver agent startup, set the session:batch-mode to true.
2.... Greg Shah

05:15 AM Feature #1608: implement full appserver support (from 4GL clients only)

> The key question: what is the minimum you can do to get through this task?
This does not hurt at all the appserver... Constantin Asofiei

11:29 AM Bug #2130: fix propath assignment

> It is OK. I think we can avoid testing this one. Check it in and distribute it.
OK, agreed. Moreover this change... Eugenie Lyzenko

11:06 AM Bug #2130: fix propath assignment

It is OK. I think we can avoid testing this one. Check it in and distribute it. Greg Shah

11:02 AM Bug #2130: fix propath assignment

The updated file has been uploaded for you to review. Eugenie Lyzenko

10:34 AM Bug #2130: fix propath assignment

No, you are right. That code is missing:... Greg Shah

09:19 AM Bug #2130: fix propath assignment

Greg, is it me or SourceNameMapper.java is missing the H019 changes, from 20130412? Constantin Asofiei

06/03/2013

01:58 PM Bug #2130 (Closed): fix propath assignment

Greg Shah

01:11 PM Bug #2130: fix propath assignment

The update evl_upd20130530b.zip has passed the regression testing and committed in bzr as revision 10357. Eugenie Lyzenko

11:55 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Since this is becoming quite complicated, let's take a step back to see if we really need this right now.
The date... Eric Faulhaber

10:44 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

I added some small patched to have my @CompositeCustomType@ written as named parameters. Simple equality queries exec... Ovidiu Maxiniuc

08:04 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

When processing multicolumn values there are a few keypoints of interest:... Ovidiu Maxiniuc

10:22 AM Feature #1608: implement full appserver support (from 4GL clients only)

I believe this is the equivalent of batch mode (see #1787). This is expected. I was planning to work on it after I ... Greg Shah

05/31/2013

05:00 PM Feature #1608: implement full appserver support (from 4GL clients only)

I'm trying to make the agents unaware of UI code (to behave as if all output is redirected to /dev/null), but the "he... Constantin Asofiei

09:49 AM Feature #2132 (Closed): implement any missing filesys.c features for Windows

Greg Shah

08:37 AM Feature #1650 (Closed): process launching support for Windows (JNI library changes and any associ...

Distributed and committed to bzr as rev 10356. Greg Shah

05/30/2013

06:51 PM Bug #2130: fix propath assignment

> OK, this is ready for testing. When the #1650 changes pass testing, this will be next. It will need both conversion... Eugenie Lyzenko

01:56 PM Bug #2130: fix propath assignment

OK, this is ready for testing. When the #1650 changes pass testing, this will be next. It will need both conversion... Greg Shah

01:51 PM Bug #2130: fix propath assignment

> The only thing missing is that the resolveJavaClass() method should be removed from NameMappingWorker, since it is ... Eugenie Lyzenko

01:41 PM Bug #2130: fix propath assignment

It looks good. The only thing missing is that the resolveJavaClass() method should be removed from NameMappingWorker... Greg Shah

01:12 PM Bug #2130: fix propath assignment

The new PROPATH fix has been uploaded:
> 1. Please change the name of the "propathDefault" data member to "propath... Eugenie Lyzenko

12:54 PM Bug #2130: fix propath assignment

OK. Eugenie, please go forward as described. Greg Shah

12:42 PM Bug #2130: fix propath assignment

> SourceNameMapper.convertJavaProg() is called from NameMappingWorker.classNameExists() method which is still in use.... Constantin Asofiei

12:37 PM Bug #2130: fix propath assignment

>> But there still seems to be 1 remaining dependency.
>
> What dependency do you refer too?
SourceNameMapper.co... Greg Shah

11:44 AM Bug #2130: fix propath assignment

The NameMappingWorker should have no use of the propath, during conversion. Even if NameMappingWorker.resolveJavaClas... Constantin Asofiei

11:33 AM Bug #2130: fix propath assignment

The SourceNameMapper.convertJavaProg() is called from NameMappingWorker.classNameExists() method which is still in us... Greg Shah

11:18 AM Bug #2130: fix propath assignment

> The propath field removing from SourceNameMapper works fine. But the file p2j/convert/NameMappingWorker.java need t... Constantin Asofiei

10:31 AM Bug #2130: fix propath assignment

> The problem I think is the SourceNameMapper.propath field, which gets initialized by the SourceNameMapper.initMappi... Eugenie Lyzenko

07:00 AM Bug #2130: fix propath assignment

Code Review (0529a)
1. Please change the name of the "propathDefault" data member to "propathFixed".
2. For the... Greg Shah

02:58 AM Bug #2130: fix propath assignment

The problem I think is the @SourceNameMapper.propath@ field, which gets initialized by the @SourceNameMapper.initMapp... Constantin Asofiei

06:28 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...

Replaced the file with correct name - evl_upd20130530c.zip. Sorry for this mess. Eugenie Lyzenko

06:04 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...

> that stuff MUST be removed. No debugging output should remain. If that is only in the windows code, then you don't ... Eugenie Lyzenko

05:31 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...

I should have caught that. No, that stuff MUST be removed. No debugging output should remain. If that is only in t... Greg Shah

05:11 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...

> Please check it in and distribute it via email.
OK. One more question. There are the console logging code(printf... Eugenie Lyzenko

05:00 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...

Great! Please check it in and distribute it via email. Greg Shah

04:32 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...

> Then you can run regression testing in staging, directly.
The testing completed. There are no regressions, resul... Eugenie Lyzenko

05:19 PM Feature #1640: implement DOM XML support

The basic idea here:... Greg Shah

05:03 PM Feature #1640: implement DOM XML support

Greg Shah wrote:
> Code Review (0527a)
>
>
> 11. The XmlFactory.createXNodeReference() implementation (both version... Evgeny Kiselev

03:03 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

After a full day of debugging and small changes:
Converted code:... Ovidiu Maxiniuc

07:57 AM Feature #1608: implement full appserver support (from 4GL clients only)

Understood. Good. Greg Shah

07:56 AM Feature #1608: implement full appserver support (from 4GL clients only)

> I believe this is also how Progress does it in the Open Java Client.
Yes, this is similar to how the progress docu... Constantin Asofiei

07:04 AM Feature #1608: implement full appserver support (from 4GL clients only)

Yes, I think your approach with result-sets is correct. Pure Java code (like BPM) does not want to be dealing with l... Greg Shah

03:59 AM Feature #1608: implement full appserver support (from 4GL clients only)

> 11. Yes, parameters passed via RemoteObject proxies are immutable. So we must invent something to implement:
> ...
... Constantin Asofiei