Activity
From 06/22/2013 to 07/21/2013
07/20/2013
- 03:31 PM Feature #1649: implement Windows environment/registry access
- Finally the update has passed all regression testing in devsrv01 except known TC-JOB-002(including CTRL-C 3-way tests...
- 10:20 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- The om_upd20130716a.zip has been committed as bzr revision 10365.
The om_upd20130716b.zip has been committed as bz...
07/19/2013
- 02:04 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- > I believe that it is best to check in now the changes as this is another big update and delaying this will need add...
- 01:58 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Strange enough, my tc_job_002.txt has 58K and looks like a weekly table starting with current DoW (each of my previou...
- 01:27 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- The tc_job_002 failure is at the expected step (report comparison). I think the unix2dos is only part of the problem...
- 01:16 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- > tc_job_clock_002: failure in step 20: 'timeout before the specific screen buffer became available (Mismatched data ...
- 12:34 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- I ran the update against revision 10364 . The result changed a bit:
* tc_job_002: @failure in step 40: 'Unexpected E... - 08:33 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- I just heard from Eric. He is getting on a plane right now and doesn't have the full answer on my question. But we ...
- 08:25 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- My recommendation was spurred by Ovidiu's deprecation of @Functions.getMTime()@ because the database server could pro...
- 07:42 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- > The no-argument variant of the mtime() function in a where clause should not convert to a server-side function, but...
- 04:14 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Code review 20130716a/b:
The database content of this update generally looks good, with a few issues:
* Use of ... - 07:53 AM Feature #1640: implement DOM XML support
- 2 thoughts:
1. Your test code needs a slight change. Unfortunately, when I pointed you to my memptr test code as e...
07/18/2013
- 07:00 PM Feature #1640: implement DOM XML support
- Greg Shah wrote:
> I don't understand. We don't yet have a GUI in P2J, do you mean the ChUI (character UI) in our S... - 02:37 PM Feature #1640: implement DOM XML support
- > Because in my test hDoc:name="asd" no-error. and I used handle.readOnlyError and I expected do not see error in GUI...
- 01:30 PM Feature #1649: implement Windows environment/registry access
- Code Review 0718a
It looks good. Get it runtime regression tested on devsrv01. - 01:14 PM Feature #1649: implement Windows environment/registry access
- OK. The changes for points 1-4 has been uploaded for review. NO-ERROR mode is also working for ErrorManager change.
- 11:20 AM Feature #1649: implement Windows environment/registry access
- Code Review 0717a
Each code review I look deeper in some areas and catch some things I didn't see before. We are ... - 08:16 PM Feature #1649: implement Windows environment/registry access
- The update with removed TODO comments for implemented code. The testcases also refreshed.
The testcase env_test34....
07/17/2013
- 07:56 PM Feature #1640: implement DOM XML support
- May I change in method @handle.readOnlyError@ last line:
@ErrorManager.displayError(4052, err, false);@
to
@ErrorM... - 06:07 PM Feature #1649: implement Windows environment/registry access
- > If your testing proves that the implementation is correct and complete, then please remove the TODOs. If something ...
- 05:57 PM Feature #1649: implement Windows environment/registry access
- > I've left them for possible changes reflecting to your notes. Do I need to remove them?
If your testing proves t... - 05:44 PM Feature #1649: implement Windows environment/registry access
- > 1. Do LOAD/UNLOAD/USE really generate a STOP condition (like a CTRL-C) on non-Windows?
Yes, when error is enable... - 05:24 PM Feature #1649: implement Windows environment/registry access
- Code Review 0712c
1. Do LOAD/UNLOAD/USE really generate a STOP condition (like a CTRL-C) on non-Windows?
2. Nor... - 04:39 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Code Review 0716b
I am fine with the changes, but Eric needs to review them since many affect the persistence laye... - 04:30 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Code Review 0716a
I am OK with this code being checked in.
> tc_job_002: failure in step 40: 'Unexpected EOF ... - 01:24 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- This second update adds all new stuff about date/datetime/datetime-tz: class hierarchy, literals, new date API, pl, e...
07/16/2013
- 01:43 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- My previous update was too big to be manageable so I split it in two chuncks. The first one (attached) does not conta...
- 09:50 AM Feature #1640: implement DOM XML support
- What I mean by "compile time" is that it can only be fixed by changing the code and re-compiling.
Yes, this manife... - 09:04 AM Feature #1640: implement DOM XML support
- Greg Shah wrote:
> > I don't like to add empty stub and just specify @readOnlyError@.
>
> The idea is that writi... - 08:44 AM Feature #1640: implement DOM XML support
- > I don't like to add empty stub and just specify @readOnlyError@.
The idea is that writing to such an attribute ... - 03:42 AM Feature #1640: implement DOM XML support
- Evgeny, what rules have you tried and it didn't work? In 10364 rev, adding this rule to @methods_attributes.rules@ (u...
07/15/2013
- 07:08 PM Feature #1640: implement DOM XML support
- How I can make attribute readonly via rules. I have @kw_chld_num@ attribute, I have tried to find something in common...
07/12/2013
- 07:24 PM Feature #1649: implement Windows environment/registry access
- This is the StanzaIni.java Javadoc adding for more descriptions and little syntax fix for Javadoc in Registry.java.
- 05:36 PM Feature #1649: implement Windows environment/registry access
- This is the final changes for registry access for you to review. Changes comparing to previous update:
1. The native ... - 11:56 AM Feature #1649: implement Windows environment/registry access
- The drop includes:
1. Disabling environment related calls and daemon starting for non-Windows environment.
2. Addin...
07/11/2013
- 07:39 PM Feature #1649: implement Windows environment/registry access
- The second drop for today includes Java doc additions for Registry class. Please let me know if this level of details...
- 01:33 PM Feature #1649: implement Windows environment/registry access
- OK.
- 12:02 PM Feature #1649: implement Windows environment/registry access
- Finding news for handling registry in Windows 4GL in PUT/GET KEY-VALUE calls.
1. The CHUI and GUI interfaces works t... - 08:55 AM Feature #1649: implement Windows environment/registry access
- > 1, 2.
OK, agreed, we need more descriptions here. I'll add detailed javadocs in recent today drop.
> 3.
Th... - 06:58 AM Feature #1649: implement Windows environment/registry access
- Code Review 0710a
1. The Registry.java class javadoc needs significant enhancements. The native methods have only... - 08:51 PM Feature #1649: implement Windows environment/registry access
- This drop includes JNI implementation for Windows registry access functions and minor change for JNI signature. Debug...
- 07:14 PM Feature #1640: implement DOM XML support
- Greg Shah wrote:
> > The error comes from method com.goldencode.p2j.util.BinaryData.setMethodSetup() there is a line... - 06:00 AM Feature #1640: implement DOM XML support
- > The error comes from method com.goldencode.p2j.util.BinaryData.setMethodSetup() there is a line that check if (isAu...
- 02:40 AM Feature #1640: implement DOM XML support
- Evgeny
> But I have next issue. I have a test:
> @
> set-size(m1) = 10001.
> set-size(m2) = 101.
> d... - 02:37 AM Feature #1640: implement DOM XML support
- Evgeny Kiselev wrote:
> I have one more issue: in the generated code I have: @unwrap(hRoot).readOnlyError("namespace...
07/10/2013
- 07:11 PM Feature #1640: implement DOM XML support
- Greg Shah wrote:
> > It works fine in the 4GL, but in p2j I have next error: ** Can't PUT past the end of the MEMPTR... - 06:58 PM Feature #1640: implement DOM XML support
- I have one more issue: in the generated code I have: @unwrap(hRoot).readOnlyError("namespace-prefix");@
but I'm expe... - 04:57 PM Feature #1640: implement DOM XML support
- > It works fine in the 4GL, but in p2j I have next error: ** Can't PUT past the end of the MEMPTR. (4791)
Do you g... - 03:31 PM Feature #1640: implement DOM XML support
- Thanks, it was issue from my side.
But I have next issue. I have a test:
@
set-size(m1) = 10001.
set-siz... - 02:30 PM Feature #1640: implement DOM XML support
- > IS it issue with my environment ?
Possibly. The code being called is native (JNI) in src/native/memory.c:
JN... - 02:13 PM Feature #1640: implement DOM XML support
- I have found next issue with memptr:
@Caused by: java.lang.NullPointerException
at com.sun.proxy.$Proxy3.is... - 04:15 AM Feature #1608: implement full appserver support (from 4GL clients only)
- 0708b is committed to bzr revision 10363.
- 09:28 PM Feature #1649: implement Windows environment/registry access
- The special empty parameters cases:
GET-KEY-VALUE
section == "", key != "" -> getting the value for given value n...
07/09/2013
- 06:53 PM Feature #1649: implement Windows environment/registry access
- This is the fix for issue in EnvironmentOps code for unwrapping character unknown variable. It is possible the code:
... - 06:26 PM Feature #1649: implement Windows environment/registry access
- Code Review 0708b
I am fine with the changes. One thing I see is that Javadoc which states @If the parameter is n... - 06:30 PM Feature #1608: implement full appserver support (from 4GL clients only)
- I am fine with the 0708b. You can check it in and distribute it.
- 05:56 AM Feature #1608: implement full appserver support (from 4GL clients only)
- There was a NPE at server startup fixed in this update. Runtime regression has passed, results are copied in the shar...
- 01:45 PM Feature #2108: event model rationalization
- > 1. What types of handle can be used there?
I found only these handles to be accepted by WAIT-FOR:
* active-window...
07/08/2013
- 06:55 PM Feature #1649: implement Windows environment/registry access
- This drop adds simulation for 4GL CHUI behavior for empty parameters handling. If the value is empty, the key=value p...
- 04:20 PM Feature #1649: implement Windows environment/registry access
- The drop includes a bug fix for section remove code and testcases to check. I had to simulate windowing interface whi...
- 06:32 PM Feature #2108: event model rationalization
- > when using the aforementioned events, the @<handle>@ in the @WAIT-FOR ... OF <handle>@. statement needs to be in a ...
- 04:23 PM Feature #2108 (WIP): event model rationalization
- I've been looking for common points between the various non-UI events and my findings are these:
# events like @PROC... - 06:31 PM Feature #1640: implement DOM XML support
- 1) all methods and attributes are supported now.
2) It's not final version. There is some TODOs and not final versi... - 04:56 AM Feature #1608: implement full appserver support (from 4GL clients only)
- Address the problems at note 127. I have one ControlFlowOps fix here too (related to passing byte[] instances for me...
07/05/2013
- 06:36 PM Feature #1649: implement Windows environment/registry access
- The next drop implements the empty or unknown values as parameters for USE, GET-KEY-VALUE and PUT-KEY-VALUE for you t...
- 06:11 PM Feature #1608: implement full appserver support (from 4GL clients only)
- > Generally, the use of this success "flag" is a bit confusing. Even after reading your comment, it is not clear why...
- 04:32 PM Feature #1608: implement full appserver support (from 4GL clients only)
- Code Review 0705b
Generally, I like the improvements and the approach. It seems a bit cleaner than the previous c... - 03:23 PM Feature #1608: implement full appserver support (from 4GL clients only)
- Redesign of the appserver launching. This can be done in several modes:
# via "-p appserver" argument specified at P...
07/04/2013
- 05:46 PM Feature #1649: implement Windows environment/registry access
- More testcases have been added.
- 03:43 PM Feature #1649: implement Windows environment/registry access
- Another interesting finding. Consider the situation when there are two keys with same name and different values in on...
- 08:06 PM Feature #1649: implement Windows environment/registry access
- The next drop supports the section duplication. Also I have noted one thing. 4GL adds the new key in section after la...
- 10:08 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- The problem is isolated to a sql like @select toInt(current_date);@. The root cause is related to the changes in @da...
- 07:50 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Ovidiu seems to have some LOCALE-related problems too, but they look different than Vadim's. All failed tests log an ...
07/03/2013
- 05:09 PM Feature #1649: implement Windows environment/registry access
- > I'm planning to handle this case as set of the ignored lines not belonging to any sections like comment in the head...
- 05:07 PM Feature #1649: implement Windows environment/registry access
- > I think that loadIniFile() will need changes to process this properly.
>
> You may need to check if the duplicat... - 02:38 PM Feature #1649: implement Windows environment/registry access
- > 2. Have you checked to see what happens if the same key appears more than once in a single section?
>>
>> In this... - 01:24 PM Feature #1649: implement Windows environment/registry access
- > 1. Please put a TODO into StanzaIni to implement the PrintWriter creation the using proper charset (not always just...
- 12:54 PM Feature #1649: implement Windows environment/registry access
- Code Review 0702a
The code looks good. Some comments:
1. Please put a TODO into StanzaIni to implement the Pri... - 08:01 PM Feature #1649: implement Windows environment/registry access
- Additional findings for same section name in one file. Even we have the following:...
- 03:24 PM Feature #1608: implement full appserver support (from 4GL clients only)
- How I'm planning to launch appservers:
# in automatic mode, at server startup, it will pick up all appservers config... - 02:01 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Conversion was fine, there are a lot of changes but they were expected.
The runtime test has hung-up for unknown rea... - 01:08 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- I am fine with the 0702a changes. How is testing going?
07/02/2013
- 07:30 PM Feature #1649: implement Windows environment/registry access
- > 4. What happens if the same section name appears more than once (2, 3 or more times) in the same stanza INI file?
... - 05:45 PM Feature #1649: implement Windows environment/registry access
- The new drop contains reworked approach for storing key-value pair and ignored lines separately in the data section. ...
- 10:57 AM Feature #1649: implement Windows environment/registry access
- Yes.
- 10:56 AM Feature #1649: implement Windows environment/registry access
- > 2. The algorithm for StanzaIni.getContent() is more complicated and slower than needed. Please add a HashMap<String...
- 10:09 AM Feature #1649: implement Windows environment/registry access
- Code Review 0701a
1. I would like some changes made to the Content class and its subsclasses.
* Do not store "n... - 04:00 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Changes in this update:
- merged with latest (today) brz sources
- extra-generated constructor removed
- except... - 08:35 PM Feature #1640: implement DOM XML support
- 1) It's not final version. There is some TODOs and not final version for save/load, i'm working on it now.
2) Also re...
07/01/2013
- 07:02 PM Feature #1649: implement Windows environment/registry access
- > ...That means we implement all the undocumented and crazy behavior.
OK. Understood.
The new drop has been upl... - 09:04 AM Feature #1608: implement full appserver support (from 4GL clients only)
- Greg Shah wrote:
> I am fine with the 0701a code. Please check it in and distribute it.
Committed to revision 10362. - 08:30 AM Feature #1608: implement full appserver support (from 4GL clients only)
- I am fine with the 0701a code. Please check it in and distribute it.
- 08:17 AM Feature #1608: implement full appserver support (from 4GL clients only)
- This is built on top of 28a.zip and fixes issue 1 in note 119 and two other problems (some state needs to be re-appli...
06/30/2013
- 11:40 AM Feature #1649: implement Windows environment/registry access
- Please implement this exactly like the 4GL actually works. It doesn't matter what the documentation says. We have t...
06/28/2013
- 06:46 PM Feature #1649: implement Windows environment/registry access
- The investigation results:
> 1. Please do consider if it is possible to shift the EnvironmentAccessor to use String ... - 11:38 AM Feature #1608: implement full appserver support (from 4GL clients only)
- I think I understand your point now. These changes don't affect the cleanup that happens during normal termination p...
- 10:16 AM Feature #1608: implement full appserver support (from 4GL clients only)
- > 1. SecurityManager.resetContext() should probably be only callable from selected portions of the P2J runtime (using...
- 10:04 AM Feature #1608: implement full appserver support (from 4GL clients only)
- Code Review 0628a
Overall it looks very good. A couple of things:
1. SecurityManager.resetContext() should pro... - 08:19 AM Feature #1608: implement full appserver support (from 4GL clients only)
- Adds State-reset support plus a @TableResultSet.asResultSet@ API which returns a @java.sql.ResultSet@ proxy for the d...
06/27/2013
- 06:22 PM Feature #1608: implement full appserver support (from 4GL clients only)
- The SharedVariableManager's ContextContainer instances will get cleaned up (i.e. removed) too during reset. What I wa...
- 06:08 PM Feature #1608: implement full appserver support (from 4GL clients only)
- I don't have a problem with this, but how does the app-created stuff (e.g. shared vars) get cleaned up if we complete...
- 05:48 PM Feature #1608: implement full appserver support (from 4GL clients only)
- About State-reset: the good news is that 4GL doesn't save any state created by the connect or startup procedures, for...
- 10:56 AM Feature #1608: implement full appserver support (from 4GL clients only)
- Greg Shah wrote:
> Great! Please distribute the changes and check it in.
Committed to bzr revision 10361. - 10:17 AM Feature #1608: implement full appserver support (from 4GL clients only)
- > see the javadoc for AppServerTest.java class for details about connecting to the appserver from Java code. Please l...
- 10:04 AM Feature #1608: implement full appserver support (from 4GL clients only)
- Great! Please distribute the changes and check it in.
- 05:08 AM Feature #1608: implement full appserver support (from 4GL clients only)
- 0626a.zip has passed regression testing.
- 10:15 AM Bug #2130: fix propath assignment
- Fixed in appended update. Committed in bzr as 10360.
- 09:13 AM Bug #2130: fix propath assignment
- You can go ahead and fix the javadoc issue in that one file. Do NOT add a history entry for that change. Then you m...
- 08:00 PM Bug #2130: fix propath assignment
- There is one javadoc issue found here which does not touch the functionality and does not require re-testing. The pro...
- 10:01 AM Feature #1649: implement Windows environment/registry access
- The code looks good. Some thoughts:
1. Please do consider if it is possible to shift the EnvironmentAccessor to u...
06/26/2013
- 07:52 PM Feature #1649: implement Windows environment/registry access
- > Please note that the StanzaIni constructors need javadoc.
The new update uploaded. The javadoc missing entries w... - 07:21 PM Feature #1649: implement Windows environment/registry access
- > How much more effort do you expect is needed to complete your testcases and the implementation?
This is the seri... - 05:08 PM Feature #1649: implement Windows environment/registry access
- Code Review 0626a
I am fine with the code and approach in general. Please note that the StanzaIni constructors ne... - 02:49 PM Feature #1649: implement Windows environment/registry access
- > Please make sure to test cases where "" (empty string) is passed for various parameters AND where unknown value is ...
- 05:09 PM Feature #1608: implement full appserver support (from 4GL clients only)
- Greg Shah wrote:
> > 1. implement context-local reset (for State-reset mode). This is a little tricky, as I think we... - 10:27 AM Feature #1608: implement full appserver support (from 4GL clients only)
- Code Review 0625b
I am fine with the proposed code. There a a couple of minor coding standard issues (explicit im... - 10:06 AM Feature #1608: implement full appserver support (from 4GL clients only)
- > 1. implement context-local reset (for State-reset mode). This is a little tricky, as I think we need to take a snap...
06/25/2013
- 06:26 PM Feature #1608: implement full appserver support (from 4GL clients only)
- This adds MemoryBuffer support: instances of this class must be used by the Java client code, when performing appserv...
- 04:46 PM Feature #1608: implement full appserver support (from 4GL clients only)
- I've found the Memptr.java javadoc on windev01 -devsrv01- and it states that "Represents the PROGRESS 4GL MEMPTR data...
- 04:32 PM Feature #1608: implement full appserver support (from 4GL clients only)
- > BTW, any news on memptr about the "is it safe to store it on the Java heap" issue?
I thought my comments in note... - 04:19 PM Feature #1608: implement full appserver support (from 4GL clients only)
- Eh, I was thinking if the user wanted to provide its own implementation of a ResultSet, but this is unlikely. My real...
- 04:15 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- One minor issue exists in the generated code. Here is an example:...
- 01:31 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- I am putting this code through conversion and runtime regression testing right now. I had to modify the datetime cla...
- 10:10 AM Feature #1649: implement Windows environment/registry access
- The code in 0621a is good. The findings are also interesting. Please make sure to test cases where "" (empty string...
06/24/2013
- 07:59 PM Feature #1649: implement Windows environment/registry access
- More INI files interesting findings:
GET_KEY_VALUE for missing entry gives empty string, not error or NULL string.
...
Also available in: Atom