FWD » Core Development » Base Language

09/26/2013

04:29 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

> I did it. It don't change the ERROR-STATUS:ERROR handle. It remains false. However it add the error number 12119. I... Greg Shah

04:04 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

Greg Shah wrote:
> I assume the error is occurring in the decode function but it is important to confirm that. Just... Vadim Gindin

01:22 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

I assume the error is occurring in the decode function but it is important to confirm that. Just put a "pause." into... Greg Shah

01:05 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

Question 2. I converted and ran test 2. Recalling, that it is the same test as 1 but with wrong "base64" string "abra... Vadim Gindin

12:21 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

The null check is just for safety purposes. It should never get used by converted code that was automatically genera... Greg Shah

12:13 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

I have a question. Lets see at the method com.goldencode.p2j.util.SecurityOps.base64Encode(BinaryData). There is a nu... Vadim Gindin

10:46 AM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

I'm not exactly sure what you mean by this question. But I suggest you try this code to see how multiple message stm... Greg Shah

10:43 AM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

Thank you, but will the MESSAGE command override it's previous output? Vadim Gindin

10:41 AM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

OK, good. One thing to change: don't use DISPLAY for just printing a line of text. It creates an entire frame which... Greg Shah

10:35 AM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

You're right. My mistake.
Here is updated error test.... Vadim Gindin

02:08 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Just noticed that Constantin has committed some changes in the same file, in a very close area (consecutive line numb... Ovidiu Maxiniuc

12:42 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Good. You can check it in and distribute it. Greg Shah

12:38 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

The attached update passed the conversion test (no differences detected for both src and ddl). There is no need for r... Ovidiu Maxiniuc

01:37 PM Feature #1612: finish SESSION system handle support

OK, I'm fine with your approach to all of this. Make some notes in #1779 (FOCUS) and also #2015 (SELF), so that we d... Greg Shah

01:25 PM Feature #1612: finish SESSION system handle support

> > But, there are widgets implementations (like ControlTextWidget and BrowseColumnWidget classes) which can represen... Constantin Asofiei

12:18 PM Feature #1612: finish SESSION system handle support

> for widgets, the resource type can't be set at the interface, because they all grow from CommonWidget. In this case... Greg Shah

11:50 AM Feature #1612: finish SESSION system handle support

There are some more issues:
# for widgets, the resource type can't be set at the interface, because they all grow fr... Constantin Asofiei

10:09 AM Feature #1612: finish SESSION system handle support

I like it. Two things:
1.
> system handle implementations (like SessionUtils.getResourceType()) still need to ... Greg Shah

10:02 AM Feature #1612: finish SESSION system handle support

> Can we change the getResourceType() implementation to use the LegacyResource annotation as its source of TYPE info?... Constantin Asofiei

09:50 AM Feature #1612: finish SESSION system handle support

> To solve this, we could have a LegacyResource annotation to annotate the interface associated with the resource def... Greg Shah

09:43 AM Feature #1612: finish SESSION system handle support

I've been looking at the FIRST-QUERY attribute, and I think we need to change something in the FIRST/LAST-resource im... Constantin Asofiei

08:23 AM Feature #1612: finish SESSION system handle support

For now, just implement it in the runtime section of the directory. Use the Directory interface with ID_RELATIVE whi... Greg Shah

06:46 AM Feature #1612: finish SESSION system handle support

Greg, how do you suggest to implement the @PARAMETER@ attribute? The @SESSION:PARAMETER@ attribute holds the value of... Constantin Asofiei

05:46 AM Feature #1612: finish SESSION system handle support

Following attributes will be added first
* client-type
* parameter
* first-buffer Constantin Asofiei

01:31 PM Feature #1607: implement full named events support

The runtime testing seems OK, but I want to do another run, to clean some failures. Constantin Asofiei

09:47 AM Feature #1607: implement full named events support

Attached version contains the comment changes at note 29. Runtime testing is still in progress - conversion testing h... Constantin Asofiei

08:31 AM Feature #1607: implement full named events support

Code Review 0926b
I'm fine with the code. Before checking in, please make these comment changes:
1. This comm... Greg Shah

04:47 AM Feature #1607: implement full named events support

Attached update is going through regression testing now.
Beside other fixes, I've renamed PersistentProc to Proce... Constantin Asofiei

04:48 AM Feature #1977 (Review): implement the runtime support for named events

Constantin Asofiei

04:03 AM Feature #2004 (WIP): runtime support for SESSION handle

Constantin Asofiei

09/25/2013

07:12 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

> returns empty file
Instead of using copy-lob in these cases, it is cleaner to just check if the length/size of ... Greg Shah

04:53 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

Greg Shah wrote:
> Also: please add a testcase showing how these functions respond to the following:
>
> # unknow... Vadim Gindin

02:23 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

> Should I only check and probably test them?
You can check them, but I can guarantee that they don't properly imp... Greg Shah

02:15 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

Here is additional testing.
6. Empty input.... Vadim Gindin

09:52 AM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

To be clear: memptr and raw are BaseDataTypes that can be compared for equality, inequality, less than... Greg Shah

09:51 AM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

See BinaryData.compareTo() and CompareOps.equals(BDT, BDT). Greg Shah

09:48 AM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

Greg Shah wrote:
> ..
> Create a test like number 1 above, but first do the encode on a text string and then decode... Vadim Gindin

11:48 AM Feature #1607: implement full named events support

> In ProcedureManager, all procedures are saved in the ppMap and deleted, via WorkArea's Scopeable implementation. If... Greg Shah

11:15 AM Feature #1607: implement full named events support

> 1. Why are only persistent procedures checked for subscriptions? The ProcedureManager code uses PersistentProc and... Constantin Asofiei

11:09 AM Feature #1607: implement full named events support

Code Review 0925a
1. Why are only persistent procedures checked for subscriptions? The ProcedureManager code uses... Greg Shah

10:46 AM Feature #1607: implement full named events support

Greg Shah wrote:
> > When the procedure code is executed, the NO-ERROR clause doesn't look like is in effect any mor... Constantin Asofiei

10:44 AM Feature #1607: implement full named events support

> When the procedure code is executed, the NO-ERROR clause doesn't look like is in effect any more, as the ERROR cond... Greg Shah

10:36 AM Feature #1607: implement full named events support

A first version of the runtime for named events. I've also added support for the PUBLISHED-EVENTS attribute for proce... Constantin Asofiei

09:08 AM Feature #1607: implement full named events support

It seems that every new feature, even straightforward ones, will always have some significant divergence from the Pro... Greg Shah

08:19 AM Feature #1607: implement full named events support

The publish/subscribe/unsubscribe rules from the documentation are simple, but practice proves to be more complex.
... Constantin Asofiei

09:25 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

My intention was to identify nodes of this type: @(E)@, ie. an expression formed by another one (@E@) between unneede... Ovidiu Maxiniuc

09:13 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

I'm fine with the change. My only question: what is the purpose of the @nodeRef.numImmediateChildren == 1@ test as p... Greg Shah

08:55 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Fixed issue by moving 'chp_wrapper' annotation to first operator in if it is enclosed into one or more superfluous pa... Ovidiu Maxiniuc

07:56 AM Feature #1640: implement DOM XML support

I want to clarify something. Phase 2 (build) and 3 (runtime-regression) of your list above are needed. Phase 4 (ful... Greg Shah

01:41 AM Feature #1640: implement DOM XML support

> How long is "normal" time for regression test running ?
Depending on which task you are running, the times are the... Constantin Asofiei

09:33 PM Feature #1640: implement DOM XML support

Constantin Asofiei wrote:
> Next step is to run regression testing; let me know if you encounter any problems.
I'... Evgeny Kiselev

09/24/2013

04:43 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

> Can't read data from source file and shows error: "Error -26 in file to longchar". Strange error. It looks like a b... Greg Shah

04:08 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

base64-decode(expr) - where expr - character or longchar. Resulting MEMPTR contains binary data
base64-encode(expr) ... Vadim Gindin

04:37 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

It looks good. Thanks! Greg Shah

04:23 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Sure, I understand an importance of such rules. I just wanted to make a final step to remember goals of that rules. I... Vadim Gindin

11:08 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

OK, this is fine.
> In addition, please apply the same cleanup items I mentioned in note 67 above to the PrinterSt... Greg Shah

08:58 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

I corrected progress.g and PrinterStream Vadim Gindin

02:36 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed

Greg Shah wrote:
> It looks like we have a PRIVATE-DATA implementation in both BaseEntity and QueryWrapper that need... Constantin Asofiei

02:06 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed

It looks like we have a PRIVATE-DATA implementation in both BaseEntity and QueryWrapper that needs to be deleted. Bo... Greg Shah

01:22 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed

Implemented by some resources:
- local-name: x-noderef (pending to be released), soap-header-entryref
- namespace-u... Constantin Asofiei

11:44 AM Feature #2041: implement runtime support for "shared" attributes that are just stubbed

Constantin: I have looked at #2002 to see the runtime implementation status of these attributes. It is not clear fro... Greg Shah

01:11 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Seems like the wrapping annotation is put on the wrong node that is later removed.
I will dig into this tomorrow in ... Ovidiu Maxiniuc

12:50 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Ovidiu, name_map.xml was removed before the build. Anyway, I've isolate the problem to calls like:... Constantin Asofiei

12:40 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Constantin,
please remove the xml that caches the functions signature.
You probably had an f1 function with int64 ... Ovidiu Maxiniuc

12:32 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Greg/Ovidiu,
With revision 10385, there is a case which doesn't convert properly. It looks something like this:
<... Constantin Asofiei

08:19 AM Feature #1977 (WIP): implement the runtime support for named events

Constantin Asofiei

09/23/2013

05:38 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Oops. I spoke too soon. Your P2J build is not clean:
antlr_progress:
[antlr] ANTLR Parser Generator Versi... Greg Shah

05:13 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

OK, this is ready for testing. Greg Shah

04:38 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

I made described corrections Vadim Gindin

03:37 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Code Review 0923b
OK. Functionally the code is good. The last issues are about the code formatting/naming...
... Greg Shah

01:26 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

corrected archive Vadim Gindin

12:24 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Then just do the call to SD.store() from inside PrinterStream.createPrinterStream(). Hiding the printer-specific stu... Greg Shah

12:18 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Greg Shah wrote:
> Code Review 0923a
>
> 1. There is no PrinterStream class in this update. I think you accident... Vadim Gindin

11:15 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Code Review 0923a
1. There is no PrinterStream class in this update. I think you accidentally included ProcessStr... Greg Shah

09:22 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Next update Vadim Gindin

02:27 AM Feature #1640: implement DOM XML support

Evgeny: the attached version contains just some format related changes, plus I've removed the @XEntity[Impl].getHandl... Constantin Asofiei

11:05 PM Feature #1640: implement DOM XML support

last update for regression testing. merged with 10385 revision Evgeny Kiselev

09/20/2013

05:12 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Code Review 0918b
1. The name of this update should have been vig_upd20130920a.zip since you completed your change... Greg Shah

04:21 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

I'm uploading next update. I made described corrections.
About slashes, it seems that Progress removes it itself. I ... Vadim Gindin

01:22 PM Feature #1621 (Closed): implement dynamic/unspecified EXTENT support

Greg Shah

01:02 PM Feature #1621: implement dynamic/unspecified EXTENT support

Yes, it can be closed. Constantin Asofiei

09:50 AM Feature #1621: implement dynamic/unspecified EXTENT support

This can be closed, right? Greg Shah

09:53 AM Feature #1640: implement DOM XML support

Evgeny: please merge your code with latest revision 10385. This is the version that needs final review and full regr... Greg Shah

08:53 AM Feature #1640: implement DOM XML support

> The changes are good. The changes are probably safe enough to avoid separate regression testing. What do you thin... Constantin Asofiei

08:22 AM Feature #1640: implement DOM XML support

Code Review ca_upd20130920b.zip
The changes are good. The changes are probably safe enough to avoid separate regr... Greg Shah

05:14 AM Feature #1640: implement DOM XML support

This update solves the ErrorManager.recordOrShowError, when the "isError" flag is false and the NO-ERROR clause is pr... Constantin Asofiei

09:18 AM Feature #1792 (Closed): implement widget-pool support

Greg Shah

09:16 AM Feature #1792: implement widget-pool support

ca_upd20130920c.zip was committed to bzr revision 10385.
Final Notes:
1. A bug was fixed for CREATE BUFFER ... IN... Constantin Asofiei

08:53 AM Feature #1792: implement widget-pool support

The changes are really good. The class javadoc improvements are excellent!
> The exception is thrown because this... Greg Shah

04:32 AM Feature #1792: implement widget-pool support

> 1. Why throw IllegalStateException in WidgetPool.addResource()?
The exception is thrown because this method must a... Constantin Asofiei

09:17 AM Feature #1983 (Closed): runtime support for widget pools

Greg Shah

04:33 AM Feature #1983 (Review): runtime support for widget pools

Constantin Asofiei

09/19/2013

02:55 PM Feature #1792: implement widget-pool support

Code Review 0919a
Overall, it looks very good.
1. Why throw IllegalStateException in WidgetPool.addResource()?
... Greg Shah

12:53 PM Feature #1792: implement widget-pool support

The attached update adds runtime support for widget pools. Still need to perform regression testing on it. Constantin Asofiei

09:34 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

The changes look good. When you get back, you can merge up with the latest code, implement the DOM/SAX attributes/me... Greg Shah

08:00 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

This update with new 6 getters in CommonSession class. The static classes SessionUtils, NumberType, ProcedureManager ... Eugenie Lyzenko

09:09 AM Feature #1638 (Closed): implement Java access to converted appserver code (must be a simple repla...

Greg Shah

07:53 AM Feature #1638: implement Java access to converted appserver code (must be a simple replacement fo...

At this time, no. Constantin Asofiei

02:03 AM Feature #1640: implement DOM XML support

Evgeny, please merge your @handle.java@ file, discard the @ErrorManager@ changes you made and put the update through ... Constantin Asofiei

09/18/2013

07:09 PM Feature #1781 (WIP): add missing support for the WIDGET-HANDLE builtin function

Hynek Cihlar

07:05 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

OK, I think I understand now. If we have the backing implementations for the missing attributes, please do add the 6... Greg Shah

07:01 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

> Are they defined in some other interface?
The following attributes are not defined at all:
FIRST-SERVER r
LAST... Eugenie Lyzenko

06:51 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

Are they defined in some other interface? Greg Shah

06:50 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

> I assume you still have these attributes annotated in their CommonSession interface?
No, there are no such attri... Eugenie Lyzenko

06:40 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

I assume you still have these attributes annotated in their CommonSession interface? Greg Shah

06:35 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

> These 3 classes are statically implementing the proxy defined by the CommonSession interface - so you are correct, ... Eugenie Lyzenko

04:24 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

Eugenie Lyzenko wrote:
> > NumberType shouldn't have been annotated. The proper interface for the SESSION resource i... Constantin Asofiei

04:05 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

> NumberType shouldn't have been annotated. The proper interface for the SESSION resource is the CommonSession interf... Eugenie Lyzenko

03:46 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

> 1. Since NumberType isn't a WrappedResource, it won't ever be referenced via a handle. Instead, we use static meth... Constantin Asofiei

03:34 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

> 2. You have some major merging to do with the recent sockets code.
Done.
> And there are massive changes to t... Eugenie Lyzenko

03:10 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

Code Review 0917b
Generally it looks really good. Some feedback:
1. Since NumberType isn't a WrappedResource, ... Greg Shah

09:28 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

Added missing ERROR related attributes and methods. It is found the setter for READ-ONLY attribute is not found. Eugenie Lyzenko

06:49 PM Feature #1640: implement DOM XML support

1) fixed issues in note 123 - 130
2) in @XmlFactory@ class methods @createXNodeReference@ now set new node into reso... Evgeny Kiselev

02:49 PM Feature #1640: implement DOM XML support

Can you get your update ready for review today? If not, when can it be ready? Greg Shah

12:14 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Code Review 0918a
This is pretty good work. Some changes to make:
1. The name of the update should be vig_upd2... Greg Shah

09:43 AM Bug #2183: fix resource save/restoration when used with string/handle functions

Work this along with the work in #1781. They are closely related. Greg Shah

09:30 AM Feature #1608 (Closed): implement full appserver support (from 4GL clients only)

Greg Shah

09:30 AM Feature #1991 (Closed): runtime support for appserver

Greg Shah

09:29 AM Feature #2184 (Closed): create and populate the temp-table on the remote side, based on the recei...

Greg Shah

08:49 AM Feature #1606 (Closed): implement persistent procedures/super procedures

Greg Shah

08:46 AM Feature #1884 (Closed): add some of the v10 data types and core built-ins

Greg Shah

08:38 AM Feature #1964 (Closed): finish runtime support for MEMPTR/RAW

Greg Shah

08:33 AM Feature #1638: implement Java access to converted appserver code (must be a simple replacement fo...

Is there anything left to do on this or can we close the task? Greg Shah

08:27 AM Feature #1958 (Closed): implement the runtime support for sockets

Greg Shah

08:26 AM Feature #2129 (Closed): final runtime work on sockets

Greg Shah

08:26 AM Feature #1639 (Closed): implement socket support

Greg Shah

03:10 AM Feature #1639: implement socket support

>I assume all the socket testcases (other than SSL) are working now?
yes.
This version was committed to rev 10382... Constantin Asofiei

09/17/2013

06:54 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Here is an archive with my changes. Please review. What to do further? Vadim Gindin

12:21 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

> The rule uses a parentid variable as a parent node pointer(as other IO_OPTIONS do) and this var is correctly set as... Greg Shah

03:45 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

At this moment these statements can correctly be converted:
output to printer
output to printer printerName
outp... Vadim Gindin

01:40 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

This is the first candidate for implementation. While you are reviewing I'll check for possible missed annotations be... Eugenie Lyzenko

08:20 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

>> Moving to the static calls(SessionUtils, ProcedureManager, etc.)
>
> For these too, you will need to annotate t... Eugenie Lyzenko

07:47 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

Eugenie Lyzenko wrote:
> Moving to the static calls(SessionUtils, ProcedureManager, etc.)
For these too, you will ... Constantin Asofiei

08:54 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

Moving to the static calls(SessionUtils, ProcedureManager, etc.) The new notes found for CommonWidget:
The attribute... Eugenie Lyzenko

12:53 PM Feature #1640: implement DOM XML support

Constantin's ErrorManager change will be checked in before your changes. So you don't have to include this file in y... Greg Shah

12:28 PM Feature #1640: implement DOM XML support

Evgeny, please use the attached ErrorManager class. You will need to call @recordOrShowError(code, msg, false, false,... Constantin Asofiei

10:29 AM Feature #1640: implement DOM XML support

> we need to add yet another parameter isError, to the ErrorManager.recordOrShowError, so that the pending flag will ... Greg Shah

07:30 AM Feature #1640: implement DOM XML support

About @HANDLE@ attribute: please add this code in @methods_attributes.rules@:... Constantin Asofiei

09:41 PM Feature #1640: implement DOM XML support

Constantin Asofiei wrote:
> > You are right. I'll try to look how I can manage it inside rules.
> Please provide th... Evgeny Kiselev

12:51 PM Feature #1639: implement socket support

I'm OK with the changes. I assume all the socket testcases (other than SSL) are working now?
If all the socket te... Greg Shah

12:25 PM Feature #1639: implement socket support

> Please increase this size to at least 4096.
I've set it to 4096 for now. I wonder if it should not be set to SO_RC... Constantin Asofiei

10:54 AM Feature #1639: implement socket support

> - for read, I chose an arbitrary chunk size of 512 bytes (although I think a larger size would work too).
Please... Greg Shah

06:56 AM Feature #1639: implement socket support

> 1. We should not be using Apache Commons logging. Eric's use of it was unsanctioned and should not be extended. We ... Constantin Asofiei

12:24 PM Bug #2183: fix resource save/restoration when used with string/handle functions

Notes from #1639:
[GES]
> 3. Is it safe to use the hash code for the ID to resource mapping in handle? It seems lik... Constantin Asofiei

12:22 PM Bug #2183 (Closed): fix resource save/restoration when used with string/handle functions

Constantin Asofiei

07:47 AM Feature #1983 (WIP): runtime support for widget pools

Constantin Asofiei

07:33 AM Bug #2182: HANDLE attribute doesn't convert properly in "h:handle:<attr/method>" cases

There is a problem in converting @h:handle:attribute@ or @h:handle:method()@ chain calls, as the inner @HANDLE@ attri... Constantin Asofiei

07:32 AM Bug #2182 (New): HANDLE attribute doesn't convert properly in "h:handle:<attr/method>" cases

Constantin Asofiei

09/16/2013

06:30 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

> Greg, any idea why we have both KEEP-Z-ORDER and KEEP-FRAME-Z-ORDER? IMO, only KEEP-FRAME-Z-ORDER is correct, as th... Greg Shah

04:04 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

> I see. The problem is we have the methods for both:
> KEEP-Z-ORDER:
> isKeepZOrder();
> setKeepZOrder(logical lo... Constantin Asofiei

02:28 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

> > The attribute PERSISTENT has described in Progress docs as readable/writable. But in P2J conversion we have only ... Eugenie Lyzenko

06:26 PM Feature #1639: implement socket support

Code Review 0916c
General: very good work. The multithreaded read part is especially hard to get one's mind aroun... Greg Shah

04:12 PM Feature #1639: implement socket support

I'm regression testing this update now (conersion passed, runtime is in progress); please review. The only issue is a... Constantin Asofiei

04:17 PM Feature #1638 (WIP): implement Java access to converted appserver code (must be a simple replacem...

Constantin Asofiei

12:31 PM Feature #2129 (WIP): final runtime work on sockets

Constantin Asofiei

12:30 PM Feature #1640: implement DOM XML support

> You are right. I'll try to look how I can manage it inside rules.
Please provide the test you which uses the gener... Constantin Asofiei

12:18 PM Feature #1640: implement DOM XML support

Constantin Asofiei wrote:
> methods_attributes.rules:
> - getHandle - please explain why you still need to convert ... Evgeny Kiselev

06:56 AM Feature #1640: implement DOM XML support

Evgeny, a lot better, only a few issues left:
methods_attributes.rules:
- getHandle - please explain why you stil... Constantin Asofiei

10:16 PM Feature #1640: implement DOM XML support

1) now all assignments works inside WrapperResource and check type of handle.
2) load/save now works properly
3) merg... Evgeny Kiselev

12:20 PM Feature #2181: implement SSL support for sockets

@LowLevelSocketImpl.connectSSL@ is not yet implemented. Following are some findings/implementation notes:
* nosessio... Constantin Asofiei

12:16 PM Feature #2181 (Closed): implement SSL support for sockets

Constantin Asofiei

09/14/2013

07:20 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

> The attribute PERSISTENT has described in Progress docs as readable/writable. But in P2J conversion we have only ge... Constantin Asofiei

09/13/2013

07:01 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

The additional notes at this time:
NUM-BUFFERS r P2JQuery - (Changed javadoc, bacause it is attribute, not a metho... Eugenie Lyzenko

03:08 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

Another question.
The attribute PERSISTENT has described in Progress docs as readable/writable. But in P2J convers... Eugenie Lyzenko

03:33 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

Eugenie Lyzenko wrote:
> Another point:
> [...]
>
> The Buffer.java does not have @defaultBufferHandle@ method. ... Constantin Asofiei

01:45 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

OK, there are multiple things to discuss here.
1. First, the code you have posted is nested inside this "top level... Greg Shah

01:26 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Here is the rule, that creates openPrinterStream()... Vadim Gindin

11:48 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

> Here is my rule for the FILENAME type:
Actually, I don't think this code is needed. The FILENAME node should co... Greg Shah

10:24 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Greg Shah wrote:
> > Don't see at the type FILENAME here.
>
> What do you mean by this? The FILENAME node is the... Vadim Gindin

10:14 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

> Don't see at the type FILENAME here.
What do you mean by this? The FILENAME node is there.
> After I'll fix ... Greg Shah

10:03 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Here is 4GL tree part corresponding to that statement:... Vadim Gindin

09:44 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

You are on the right track by looking at the tree itself to understand what is generated. But the problem here is li... Greg Shah

09:09 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

I'll explain.
Let's assume, that we are converting the statement OUTPUT TO PRINTER "printerName". At this moment re... Vadim Gindin

08:28 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Your question is too broad. Are you asking for information on how to code TRPL programs? Do you have some specific ... Greg Shah

08:26 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Could you tell me please how to specify the rules to convert OUTPUT TO PRINTER printerName statement to correct Java ... Vadim Gindin

09/12/2013

05:51 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

Another point:... Eugenie Lyzenko

04:48 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

> No, please don't change the @hwrap@ values in methods attributes. To identify the interface defining the attribute/... Eugenie Lyzenko

03:48 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

Eugenie Lyzenko wrote:
> Need another clarification. Consider the following rule:
> [...]
> There are no BufferFie... Constantin Asofiei

05:28 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

OK, interesting results. The progress.g will need to be fixed and most everything else from a conversion perspective... Greg Shah

04:56 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

> Finally, note this comment from the 4GL docs: @On UNIX, the printer spooling facilities (lp or lpr) are used automa... Vadim Gindin

04:34 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

It seems I really missed this circumstance. See the results of my testing below.
> Some questions:
>
> # Does t... Vadim Gindin

02:56 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

> OUTPUT TO PRINTER "somePrinter"
Interesting. Please note that the Progress 4GL Language reference states this:... Greg Shah

02:29 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

During the testing step I faced with a problem. When a printer name is specified in the progress OUTPUT TO PRINTER st... Vadim Gindin

09/11/2013

07:51 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

Need another clarification. Consider the following rule:... Eugenie Lyzenko

06:15 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

Yes, except the javadoc should read like this:... Greg Shah

06:13 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

And the annotation for method should be:... Eugenie Lyzenko

06:08 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

> 1. I would leave resource() field untouched. This will contain additional info we probably will able to use to sepa... Greg Shah

06:00 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

And one more question:
For example consider the following attribute:... Eugenie Lyzenko

02:30 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

Some additional thoughts about annotation:
1. I would leave resource() field untouched. This will contain addition... Eugenie Lyzenko

12:02 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

Greg Shah wrote:
> Constantin: are you suggesting putting all the annotations on interface method definitions instea... Constantin Asofiei

11:57 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

Constantin: are you suggesting putting all the annotations on interface method definitions instead of on the implemen... Greg Shah

11:57 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

Thoughts:
1. The code @Method[] methods = h.get().getClass().getMethods();@ is not safe to chain this way. h.get(... Greg Shah

11:31 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

While I'm modifying the attribute related classes you can review canQuery/canSet implementation proposal(HandleOps.ja... Eugenie Lyzenko

11:18 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

> Do you mean that we should remove the "resource" field of LegacyAttribute/LegacyMethod?
Yes, as it will only confu... Constantin Asofiei

11:16 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

OK, so we don't need to add the writable flag to the annotation.
> And I keep forgetting but fortunately I reminde... Greg Shah

11:06 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

How the @LegacyAttribute@ annotation should look:... Constantin Asofiei

10:46 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

Please document the change you propose (show the LegacyAttribute annotation definition and examples of use). Greg Shah

10:44 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

Greg Shah wrote:
> Constantin: If I understand correctly, no changes are needed to the annotations design to support... Constantin Asofiei

10:38 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

Constantin: If I understand correctly, no changes are needed to the annotations design to support these other use cas... Greg Shah

10:36 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

Greg Shah wrote:
> > For each attribute/method we will specify its interface too, beside the associated method name ... Constantin Asofiei

10:31 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

> For each attribute/method we will specify its interface too, beside the associated method name (sometimes the hwrap... Greg Shah

10:21 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

> Constantin: is this design sufficient to support the needs of #2123 and the LIST-QUERY-ATTRS/LIST-SET-ATTRS?
Yes... Constantin Asofiei

10:03 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

Please implement the annotations for all currently supported methods and attributes. This way, it will just be a sta... Greg Shah

09:51 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

OK understood. Do we have the list of attributes we need to implement this way for now? Only "FRAME" and "FILE-TYPE" ... Eugenie Lyzenko

02:10 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

The ProcessDaemon actually already has a reference to StreamDaemon. When we instantiate both in ThinClient, we alrea... Greg Shah

01:47 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

As I understand StreamDaemon and ProcessDaemon are executed on the Client (on the same node). How can I obtain Proces... Vadim Gindin

11:49 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

I don't want to mix Linux PRINTER output device support in with generic process launching. In addition, Windows PRIN... Greg Shah

11:33 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

I didn't find the reason to write a separate stream class such PrinterStream, but I find the other way. We can add ne... Vadim Gindin

09/10/2013

07:20 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

> The question I have is what will be the cost of this solution in term of application performance?
Yes, it is slo... Greg Shah

06:29 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

OK. This is very clean approach and we can implement incrementally only what we currently need. The question I have i... Eugenie Lyzenko

10:09 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

After some additional thought, I have come up with a 3rd option that I think is even better. Consider these annotati... Greg Shah

05:49 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

Suggestion at this time.
Yes the approach #2 above looks preferable. However I see the discussion points here. The... Eugenie Lyzenko

09:48 PM Feature #1640: implement DOM XML support

Constantin Asofiei wrote:
> Evgeny, please provide the list of methods which, like @get-attribute-node@, require a v... Evgeny Kiselev

09/09/2013

03:38 PM Feature #1640: implement DOM XML support

Evgeny, please provide the list of methods which, like @get-attribute-node@, require a valid x-noderef resource and c... Constantin Asofiei

01:45 PM Feature #1640: implement DOM XML support

> I did not remove @XComonImpl.readOnlyError@ because I'm waiting @ErrorManager.displayAndAddError@ method.
I missed... Constantin Asofiei

11:48 PM Feature #1640: implement DOM XML support

issues from note 114:
1) I need @getHandle()@ for code like this @hRoot:handle:subtype@. Is it possible for @someHan... Evgeny Kiselev

03:16 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

> I've made a rule which converts OUTPUT TO PRINTER to this code:
>
>> UnnamedStreams.assingOut(StreamFactory.creat... Greg Shah

02:49 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

I need some help.
1. Rules.
I've made a rule which converts OUTPUT TO PRINTER to this code:
... Vadim Gindin

12:43 PM Feature #1639: implement socket support

> about SSL connections:
For Milestone 7, we don't need SSL support ("-ssl" never appears in any CONNECT() string ... Greg Shah

10:52 AM Feature #2074 (WIP): add CAN-QUERY() and CAN-SET() support

Greg Shah

09/08/2013

04:03 PM Feature #1639: implement socket support

A few issues to discuss/mention:
# about SSL connections:
a. OpenEdge keeps the private keys in a global store. Als... Constantin Asofiei

07:51 AM Feature #1640: implement DOM XML support

Evgeny, I missed something from your tests; your cases are mostly something like this:... Constantin Asofiei

09/06/2013

02:39 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Your plan is almost exactly right.
> add new method for the StreamFactory called openPrinterStream
Yes.
> im... Greg Shah

01:16 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

I reviewed the input-output rules and the code in classes /goldencode/p2j/util/Stream*.java
I'm going to do the fol... Vadim Gindin

12:35 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

The UI layout manager will do this when the columns won't fit into the width available. It is actually quite a compl... Greg Shah

12:27 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Here is the resulting file for surprising test. Vadim Gindin

11:45 AM Feature #1631 (WIP): implement support for LANDSCAPE/PORTRAIT in I/O statements

> I expected that the result pdf will content one line. But the actual result really surprised me (see output_to_prin... Greg Shah

11:08 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

I ran all tests on windev01 and made additional test. The common results are:
# LANDSCAPE/PORTRAIT options are not a... Vadim Gindin

07:24 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Interesting. OK, this means that on Linux the options are silently ignored. Our runtime implementation will have to... Greg Shah

07:16 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Greg Shah wrote:
> The key questions here are:
>
> # What are the parameters passed to lp by Progress for these d... Vadim Gindin

07:28 AM Feature #1625 (WIP): implement OUTPUT TO PRINTER on Windows

Please see #1631 for details on how the PRINTER option works for Linux/UNIX. When used on Linux, the PRINTER destina... Greg Shah

09/05/2013

04:53 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

> The Progress documentation says that landscape/portrait options should be supported by printer driver, i.e. real be... Greg Shah

03:36 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

The next script is:... Vadim Gindin

10:37 AM Feature #1640: implement DOM XML support

> Greg: there are some common attributes (like INSTANTIATING-PROCEDURE and UNIQUE-ID) for which the implementation ca... Greg Shah

10:20 AM Feature #1640: implement DOM XML support

> Widget Pool is not implemented in @com.goldencode.p2j.xml.XmlFactory.createSaxAttributes()@ because I didn't find a... Constantin Asofiei

10:19 AM Feature #1640: implement DOM XML support

As a side-note, in some files there are lots of whitespace changes. Please change the settings to your editor so that... Constantin Asofiei

10:14 PM Feature #1640: implement DOM XML support

from note 107:
1-11 is done.
from note 109:
1. done
2. done
3. in the update it's implemented incorrect. Because need... Evgeny Kiselev

09/04/2013

04:56 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

> 1. Greg, you wroted in the task 1631: "You will have to test with wider than 132 and narrower than 132 terminals to... Greg Shah

04:53 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

> 4. Attributes paged and page-size. Default page-size is 56. LANDSCAPE, PORTRAIT options do not affect page size - d... Greg Shah

04:32 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

1. While starting progress in terminal width = 60. Message: "Unable to use your terminal. Check your PROTERMCAP file.... Vadim Gindin

09/03/2013

04:41 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

> It creates 3 identical files with textwidth=132 symbols. So in this case our options also do not affect the page wi... Greg Shah

04:25 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

The first test is for default terminal wich is xterm (80x24) on lindev01:... Vadim Gindin

10:48 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Questions/Answers:
1. Why are you using the STREAM-IO in your tests? Unless it is needed, you generally should el... Greg Shah

12:11 PM Feature #2108 (Closed): event model rationalization

Greg Shah

12:10 PM Feature #2108: event model rationalization

Attached update is committed to bzr revision 10378. Constantin Asofiei

09/02/2013

05:21 PM Feature #2108: event model rationalization

Code Review 0829a
Everything looks good.
1. Please add javadoc to explain the details in note 14 answers 1, 3, ... Greg Shah

10:07 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

I've made a script for testing conditions about width of text in the outut file. Here it is:... Vadim Gindin

08/30/2013

05:57 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

> 1. lindev01. I ran different test. See below.
Please try both test programs on both lindev01 and windev01. In p... Greg Shah

04:31 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

I tried to run simple test with these options on lindev01 and windev01.
1. lindev01. I ran different test. See belo... Vadim Gindin

09:46 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

The work above was all done to support the proper conversion of these options. But the runtime behavior has not yet ... Greg Shah

01:40 PM Feature #2108: event model rationalization

ca_upd20130829a.zip has passed regression testing. Constantin Asofiei

04:31 AM Feature #1640: implement DOM XML support

Evgeny Kiselev wrote:
> in *1* instance is created. In my case I'm understand this state as unknown, but there is so... Constantin Asofiei

08/29/2013

06:32 PM Feature #1640: implement DOM XML support

Constantin Asofiei wrote:
> 3. @XEntityImpl.invalidNodeError@
> - I don't like how the @XEntityImpl.invalidNodeErro... Evgeny Kiselev

09:13 AM Feature #2108: event model rationalization

The attached fix solved some bugs found during regression testing and addresses the issues in the review.
# I coul... Constantin Asofiei

08/28/2013

05:59 PM Feature #2108: event model rationalization

OK, I have completed my code review (to the 0827a level). Overall: it is really good! The code is now also insanely... Greg Shah

04:41 PM Feature #2108: event model rationalization

More questions:
4. In regard to your assumption in note 9:
> From my testing, I think is reasonbly to think a d... Greg Shah

04:33 PM Feature #2108: event model rationalization

I am in the middle of the code review. So far I have finished the ui and net package code. I have these initial que... Greg Shah