Project

General

Profile

Activity

From 04/06/2014 to 05/05/2014

05/06/2014

09:49 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Greg Shah wrote:
> Code Review 0502a
>
> 1. Is the @GenericFrame@ change intentionally meant to only modify the c...
Evgeny Kiselev

05/05/2014

01:22 PM Bug #2294: In Progress the variable initializer ignores the declared decimal precision
Please see the attached changes and provide feedback.
The solution seems to be functionally correct, however it i...
Hynek Cihlar
12:54 PM Bug #2133: fix precision for decimal, dynamic-extent variables
Attached are the fixed formatting issues. Also, the related testcases are committed in the file @testcases/uast/exten... Hynek Cihlar
11:47 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Code Review 0502a
1. Is the @GenericFrame@ change intentionally meant to only modify the case where @DISPLAY@ is u...
Greg Shah

05/02/2014

07:47 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
This is pre review update, without doc headers.
1) @DirStream.java@ there is unnecessary new line. I'm not sure if t...
Evgeny Kiselev
03:21 AM Bug #2133: fix precision for decimal, dynamic-extent variables
Hynek, the logic looks good, but there are some formatting issues:
* assignments.rules:
- line 229 is too long
* d...
Constantin Asofiei

05/01/2014

01:16 AM Bug #2294 (WIP): In Progress the variable initializer ignores the declared decimal precision
Hynek Cihlar

04/30/2014

12:15 PM Bug #2133 (Review): fix precision for decimal, dynamic-extent variables
The attached code fixes decimal precision for extent variables and extent-to-extent assignment when rvalue is a param... Hynek Cihlar

04/29/2014

11:00 AM Bug #2133: fix precision for decimal, dynamic-extent variables
I created a new issue #2294 for the initializer ignoring declared decimal precision - it is related not only to exten... Hynek Cihlar
10:58 AM Bug #2294: In Progress the variable initializer ignores the declared decimal precision
In Progress the variable initializer doesn't care much about the declared decimal precision, see below.... Hynek Cihlar
10:57 AM Bug #2294 (Closed): In Progress the variable initializer ignores the declared decimal precision
Hynek Cihlar

04/28/2014

09:27 AM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...
@double@ literals in Java can encode values in source code which cannot be properly represented by the actual @double... Greg Shah
02:52 AM Bug #2250: Conversion error when decimal precision defined on dynamic extent variable
The change looks good, assuming it fixes the cases at note 1. Constantin Asofiei

04/26/2014

05:25 PM Bug #2250 (Feedback): Conversion error when decimal precision defined on dynamic extent variable
Hynek Cihlar
05:23 PM Bug #2250: Conversion error when decimal precision defined on dynamic extent variable
Please review. Hynek Cihlar
12:13 PM Bug #2133: fix precision for decimal, dynamic-extent variables
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > In Progress the variable initializer doesn't care much about th...
Hynek Cihlar
12:02 PM Bug #2133: fix precision for decimal, dynamic-extent variables
Hynek Cihlar wrote:
> In Progress the variable initializer doesn't care much about the declared decimal precision, s...
Constantin Asofiei
02:35 AM Bug #2133: fix precision for decimal, dynamic-extent variables
In Progress the variable initializer doesn't care much about the declared decimal precision, see below.... Hynek Cihlar

04/25/2014

05:54 PM Bug #2293 (WIP): Fixing an unfixed extent output parameter causes an error
Hynek Cihlar
05:49 PM Bug #2293: Fixing an unfixed extent output parameter causes an error
Constantin Asofiei wrote:
> Hynek, this one is a little tricky: with output parameters, I think 4GL assumes nothing ...
Hynek Cihlar
01:50 PM Bug #2293: Fixing an unfixed extent output parameter causes an error
Hynek, this one is a little tricky: with output parameters, I think 4GL assumes nothing is received from the original... Constantin Asofiei
01:44 PM Bug #2293: Fixing an unfixed extent output parameter causes an error
The code sample in note 1 is missing parameter qualifier. Below is the corrected version.... Hynek Cihlar
03:40 AM Bug #2293: Fixing an unfixed extent output parameter causes an error
Please post how the converted code for the program on note 1. Constantin Asofiei
03:09 PM Bug #2291 (Closed): Could not resolve closest legacy method for function returning an extent
Greg Shah
01:12 PM Bug #2291: Could not resolve closest legacy method for function returning an extent
Attached is the final change with the fixed code formatting. Committed into bzr revision 10516. No regression test run. Hynek Cihlar
03:39 AM Bug #2291: Could not resolve closest legacy method for function returning an extent
The change is OK, no regression testing is required. But before releasing it, make sure the code respects the 98-char... Constantin Asofiei
03:25 AM Bug #2292: Fix error handling when unfixed extent passed to fixed extent input parameter
Some notes here:
# the @/home/hc/p34141_Untitled8.ped@ is the actual program name, not some special string (i.e. if ...
Constantin Asofiei

04/24/2014

05:29 PM Bug #2293: Fixing an unfixed extent output parameter causes an error
The following code causes the error _Indeterminate extent is already fixed to a dimension of 2_ in P2J but works with... Hynek Cihlar
05:21 PM Bug #2293 (Closed): Fixing an unfixed extent output parameter causes an error
Hynek Cihlar
05:09 PM Bug #2133: fix precision for decimal, dynamic-extent variables
I created new issue for the error handling of input fixed extent parameters (as of the note 23), the issue number is ... Hynek Cihlar
11:37 AM Bug #2133: fix precision for decimal, dynamic-extent variables
Yes, there is. I have an implementation in place, but because of the few secondary issues I found (which some of them... Hynek Cihlar
11:00 AM Bug #2133: fix precision for decimal, dynamic-extent variables
Is there anything left to do on this task? Greg Shah
05:00 PM Bug #2291 (Feedback): Could not resolve closest legacy method for function returning an extent
Hynek Cihlar
03:02 PM Bug #2291: Could not resolve closest legacy method for function returning an extent
Please review. Hynek Cihlar
02:25 PM Bug #2291: Could not resolve closest legacy method for function returning an extent
Hynek Cihlar wrote:
> I am attaching a fix which seems to work ok.
OK, leave only the function related change, the ...
Constantin Asofiei
02:22 PM Bug #2291: Could not resolve closest legacy method for function returning an extent
Calling a function of extent return type is causing the error "Could not resolve closest legacy method for class XYZ"... Hynek Cihlar
02:10 PM Bug #2291 (Closed): Could not resolve closest legacy method for function returning an extent
Hynek Cihlar
04:59 PM Bug #2292: Fix error handling when unfixed extent passed to fixed extent input parameter
The following code sample causes the error message _Calling procedure /home/hc/p34141_Untitled8.ped cannot input an i... Hynek Cihlar
04:54 PM Bug #2292 (Closed): Fix error handling when unfixed extent passed to fixed extent input parameter
Hynek Cihlar
01:32 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Interesting.
It seems to me that all 4 DISPLAY statements are being output in the same "default" (unnamed) frame...
Greg Shah
11:11 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Greg Shah wrote:
> > 3) but if try to display after stream is closed, then all data will shown. I think it's redraw ...
Evgeny Kiselev
08:36 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
> 3) but if try to display after stream is closed, then all data will shown. I think it's redraw (refresh) all data i... Greg Shah
10:56 AM Bug #2284 (Closed): Fix parameter initialization
Greg Shah
10:44 AM Bug #2284 (Review): Fix parameter initialization
Hynek Cihlar
10:42 AM Bug #2284: Fix parameter initialization
0417a passed regression testing and was committed to bzr revision 10513. Hynek Cihlar

04/23/2014

07:14 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
After investigation about problem in @display@ while stream is opened, I've found next problem:
1) if output stream ...
Evgeny Kiselev

04/22/2014

11:53 AM Bug #2288: incorrect conversion and results for unknown value comparisons
The 0421a update has passed conversion regression testing. Now performing runtime testing. Eric Faulhaber
10:06 PM Bug #2288: incorrect conversion and results for unknown value comparisons
Regression testing again showed an unwanted change with the 0420a update. Previously,... Eric Faulhaber

04/21/2014

01:31 PM Bug #2288: incorrect conversion and results for unknown value comparisons
It probably makes sense to note the status of this task in #18 and to move that task into the Database project. It ma... Greg Shah
01:13 PM Bug #2288: incorrect conversion and results for unknown value comparisons
Greg Shah wrote:
> Not that you were asking, but I am fine with the changes.
OK, the feedback is helpful, particula...
Eric Faulhaber
12:49 PM Bug #2288: incorrect conversion and results for unknown value comparisons
Code Review 0420a
Not that you were asking, but I am fine with the changes.
Are the remaining portions of #18 o...
Greg Shah
11:20 AM Bug #2288: incorrect conversion and results for unknown value comparisons
Regression testing indicated that this change had the useful side effect of fixing some queries that were selecting t... Eric Faulhaber

04/19/2014

10:27 PM Bug #2288: incorrect conversion and results for unknown value comparisons
The attached update, based on some of Vadim's findings documented in #18 (note 9), resolves the issue. Eric Faulhaber

04/18/2014

02:28 PM Bug #2288: incorrect conversion and results for unknown value comparisons
Seems it started off that way, though in the history, #18 only describes the inequality comparisons with true/false, ... Eric Faulhaber
02:10 PM Bug #2288: incorrect conversion and results for unknown value comparisons
Is this the same as #18? Greg Shah
12:57 AM Bug #2288: incorrect conversion and results for unknown value comparisons
Consider the following 4GL test (testcases/uast/unknown-comparison2.p):... Eric Faulhaber
12:30 AM Bug #2288 (Closed): incorrect conversion and results for unknown value comparisons
Eric Faulhaber
03:06 AM Bug #2284: Fix parameter initialization
Hynek Cihlar wrote:
> Attached is the fix for the above two initialization issues, *please review*. Regression test ...
Constantin Asofiei

04/17/2014

04:05 PM Bug #2284: Fix parameter initialization
It turns out I was running the P2J conversion without the proper version defined, i.e. with the default 9.0C as Const... Hynek Cihlar
10:15 AM Support #2234 (Closed): test and fix native API support on Windows
Greg Shah
08:48 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
There are polymorphic functions (FUNC_POLY), attributes (ATTR_POLY) and methods (METH_POLY) in the 4GL. These are bu... Greg Shah

04/16/2014

06:59 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method
Several data type wrapper implementations have TODOs in @assign(BaseDataType value, boolean force)@, as in the follow... Eric Faulhaber
06:47 PM Feature #2287 (Closed): implement missing type conversion for POLY cases in data type wrapper ass...
Eric Faulhaber

04/15/2014

09:36 AM Feature #2184: create and populate the temp-table on the remote side, based on the received metad...
Update for review. Stanislav Lomany

04/14/2014

03:15 PM Bug #2284: Fix parameter initialization
The original source suggests that Progress 9.0C version behaves differently in respect to the parameter initializatio... Hynek Cihlar
01:41 AM Bug #2284: Fix parameter initialization
Hynek Cihlar wrote:
> Note that the file @variable_definitions.rules@ contained logic of Progress V9.0C. I removed t...
Constantin Asofiei
05:12 AM Feature #2184: create and populate the temp-table on the remote side, based on the received metad...
Stanislav Lomany wrote:
> Constantin, is there a simple way do determine that the specific context is run using an a...
Constantin Asofiei
04:59 AM Feature #2184: create and populate the temp-table on the remote side, based on the received metad...
Constantin, is there a simple way do determine that the specific context is run using an agent? Stanislav Lomany
02:20 AM Bug #2283: Appserver persistence-related abend on subsequent connect
Stanislav, if you look into the @TM.resettables@ list, there are two @BufferManager@ instances, when it should have b... Constantin Asofiei

04/13/2014

05:35 PM Bug #2284: Fix parameter initialization
Attached is the fix resolving the found parameter initialization issues.
Note that the file @variable_definitions...
Hynek Cihlar
04:23 PM Bug #2284 (WIP): Fix parameter initialization
Hynek Cihlar
04:04 PM Bug #2284: Fix parameter initialization
The following are the cases where the variable initialization fails.
* Components of an indeterminate unfixed extent...
Hynek Cihlar
03:29 PM Bug #2284 (Closed): Fix parameter initialization
Hynek Cihlar
04:21 PM Bug #2133: fix precision for decimal, dynamic-extent variables
Because the problem of parameter initialization goes beyond the extents, I created a separate issue for it. See #2284. Hynek Cihlar

04/12/2014

04:44 AM Bug #2283: Appserver persistence-related abend on subsequent connect
Testcase (@called.p@):... Stanislav Lomany
04:38 AM Bug #2283 (Closed): Appserver persistence-related abend on subsequent connect
Stanislav Lomany

04/10/2014

03:18 PM Feature #2184: create and populate the temp-table on the remote side, based on the received metad...
Stanislav Lomany wrote:
> Where should we "keep" the values - in the global scopes (should we add them?) of scoped d...
Constantin Asofiei
12:49 PM Feature #2184: create and populate the temp-table on the remote side, based on the received metad...
> I think the problem is here. When an appserver procedure is ran persistent and its topmost scope is finished, I thi... Stanislav Lomany
09:44 AM Feature #2184: create and populate the temp-table on the remote side, based on the received metad...
Stanislav Lomany wrote:
> Note that topmost scope for the external procedure is also deleted.
I think the problem i...
Constantin Asofiei
08:39 AM Feature #2184: create and populate the temp-table on the remote side, based on the received metad...
Guys, consider an external persistent procedure and a buffer scoped to that procedure. When we call an internal proce... Stanislav Lomany
01:31 PM Feature #1634: implement full native library (.so or DLL) support
The @evl_upd20140403b.zip@ has been committed into bzr as 10509. Eugenie Lyzenko
01:00 PM Feature #1634: implement full native library (.so or DLL) support
Today I have got completely passed CTRL-C session tests(2-way and 3-way in single passed run). So I have started the ... Eugenie Lyzenko

04/09/2014

05:30 PM Feature #1634: implement full native library (.so or DLL) support
I have finished regression testing. The results have been uploaded to share. So I can start uploading changes:
1. ...
Eugenie Lyzenko
11:32 AM Feature #1634: implement full native library (.so or DLL) support
Eugenie Lyzenko wrote:
> 1. I have to commit the @majic@ changes first, into the @staging@ branch, correct?
Yes, ...
Constantin Asofiei
11:09 AM Feature #1634: implement full native library (.so or DLL) support
Looks like I'm finishing with regression testing. Wait for finished CTRL-C results to arrive. And before committing P... Eugenie Lyzenko

04/08/2014

07:16 PM Feature #1634: implement full native library (.so or DLL) support
The main part of the runtime testing has passed without any regression. One time cycle, clean run(except known tc-job... Eugenie Lyzenko
01:57 PM Feature #1634: implement full native library (.so or DLL) support
> Eugenie, have you added the ACL I mentioned at note 209?
For unknown reasons I have not got the e-mail with this...
Eugenie Lyzenko
01:31 PM Feature #1634: implement full native library (.so or DLL) support
Eugenie, have you added the ACL I mentioned at note 209? Because after adding this ACL, your update worked fine for m... Constantin Asofiei
01:24 PM Feature #1634: implement full native library (.so or DLL) support
Greg, Constantin,
After a lot of debugging(including remote session to @devbox01@ P2J server and client) I need on...
Eugenie Lyzenko

04/07/2014

03:30 AM Feature #2184: create and populate the temp-table on the remote side, based on the received metad...
Stanislav, you are correct: the @loadedBuffers.size() > 0@ check is needed in @scopeDeleted()@. The problem here is ... Constantin Asofiei
 

Also available in: Atom