FWD » Core Development » Base Language

06/06/2014

01:29 PM Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server

In wrapped mode, the request and the response are both treated as a string with the serialized XML contents of the SO... Constantin Asofiei

12:50 PM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...

Vadim, regarding Q2 in note 4: as Greg mentioned, we can't clean the list too early and the right place to me looks l... Constantin Asofiei

12:28 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

I would really like to avoid such a flag. The reason is simple: I want the wrapper classes (BDT subclasses) to limit... Greg Shah

11:21 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

regarding "dynamic" flag I think that is better to set on this call ControlFlowOps.invokeDynamicFunctionImpl Marius Gligor

11:20 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Marius Gligor wrote:
> In order to know if a BDT is the result of a DYNAMIC-FUNCTION call I have an idea.
Your idea... Constantin Asofiei

11:00 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Here are the latest changes that I did so far for other BDT's like handle, longchar, raw, memptr, date, raw etc.
I... Marius Gligor

06/04/2014

10:02 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Excellent point/question.
Marius: please do implement the missing functionality in the util/DynamicOps class as ... Greg Shah

09:56 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Greg: will the DynamicOps APIs be implemented with this task or another? Constantin Asofiei

06/03/2014

02:41 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Code Review 0603b
The changes look good. Greg Shah

12:34 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

The archive contains the implementation of decimal wrapper type conversion for POLY cases. Marius Gligor

11:29 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Until to fix the conversion issue I found a temporary solution to test the behaviour on P2J by swap the _isEqual oper... Marius Gligor

10:05 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Code Review 0603a
The changes look good. I'm glad you were able to fix the problem without extra conversion-time ... Greg Shah

09:55 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

I haven't reviewed your changes yet. But while you were editing the code, I wrote this:
> When this expression: _is... Greg Shah

09:30 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

I added new BDT types for conversion to a logical value.
I found and implemented the conversion rules for date and h... Marius Gligor

09:09 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

I added the line in my configuration file and now works properly.
Thanks Marius Gligor

08:09 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Marius Gligor wrote:
> I have no such line in my p2j.cfg.xml.
> My configuration file is for <!-- Majic-specific P2... Constantin Asofiei

08:05 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

I have no such line in my p2j.cfg.xml.
My configuration file is for <!-- Majic-specific P2J main configuration -->
Marius Gligor

07:23 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Marius Gligor wrote:
> 2. Another problem that I found is related to initial values for P4G primitives.
I think thi... Constantin Asofiei

07:17 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

1. Working to add more BDT types for conversion inside the logical class and I found a blocked issue.
I have the fo... Marius Gligor

05:04 AM Feature #1630 (Closed): implement support for UNBUFFERED in I/O statements

Greg Shah

08:12 PM Feature #1630: implement support for UNBUFFERED in I/O statements

Committed to bzr rev. 10542. Evgeny Kiselev

06/02/2014

02:11 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Code Review 0602b
The changes look good. I assume you are working on the same changes for the other BDT types. Greg Shah

12:20 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

1. I've started to work on this issue by executing the provided test case on P4G environment and I found the followin... Marius Gligor

02:01 AM Feature #2287 (WIP): implement missing type conversion for POLY cases in data type wrapper assign...

Marius Gligor

12:10 PM Bug #2288 (Closed): incorrect conversion and results for unknown value comparisons

Update 0421a passed runtime regression testing and was committed to bzr rev. 10523 (although in the commit message I ... Eric Faulhaber

08:36 AM Feature #2311 (Closed): rewrite parsing of handle chains and other misc parser changes

Greg Shah

06:40 AM Feature #2311 (Review): rewrite parsing of handle chains and other misc parser changes

Greg Shah wrote:
> Excellent! Please check it in and distribute it.
Committed to bzr rev 10539. The task can be clo... Constantin Asofiei

06:24 AM Feature #2311: rewrite parsing of handle chains and other misc parser changes

Excellent! Please check it in and distribute it. Greg Shah

06:34 AM Feature #1630: implement support for UNBUFFERED in I/O statements

Great! Please do commit it and distribute it. Greg Shah

08:08 PM Feature #1630: implement support for UNBUFFERED in I/O statements

Update @evk_upd20140528a.zip@ has passed regression testing and ready to commit. Evgeny Kiselev

06/01/2014

08:41 AM Feature #2311: rewrite parsing of handle chains and other misc parser changes

0531b.passed conversion testing - MAJIC has 1 case and the server project has 2 cases where RecordBuffer.start/EndBat... Constantin Asofiei

05/31/2014

03:31 PM Feature #2311: rewrite parsing of handle chains and other misc parser changes

Greg Shah wrote:
> What do you suggest for the assignment stmts issue?
The fix in the end was pretty simple - I jus... Constantin Asofiei

09:09 PM Feature #1630: implement support for UNBUFFERED in I/O statements

Greg Shah wrote:
> Code Review 0528a
>
> The code looks good.
>
> Have you finished testing all of your testca... Evgeny Kiselev

05/30/2014

07:39 PM Feature #2311: rewrite parsing of handle chains and other misc parser changes

What do you suggest for the assignment stmts issue? We can defer it, but we may just hit it in future code. If that... Greg Shah

05:56 PM Feature #2311: rewrite parsing of handle chains and other misc parser changes

Greg Shah wrote:
> OK, then go ahead, check in and distribute it.
Committed to bzr rev 10538.
As a reminder, the... Constantin Asofiei

05:40 PM Feature #2311: rewrite parsing of handle chains and other misc parser changes

OK, then go ahead, check in and distribute it. Greg Shah

05:38 PM Feature #2311: rewrite parsing of handle chains and other misc parser changes

Greg Shah wrote:
> You're confident that the handle unwrapping changes are safe?
MAJIC uses only @unwrapWidget@, an... Constantin Asofiei

05:01 PM Feature #2311: rewrite parsing of handle chains and other misc parser changes

You're confident that the handle unwrapping changes are safe? Greg Shah

04:52 PM Feature #2311: rewrite parsing of handle chains and other misc parser changes

Greg Shah wrote:
> I am fine with the changes. At this point, is there anything left to do?
Conversion testing pas... Constantin Asofiei

04:41 PM Feature #2311: rewrite parsing of handle chains and other misc parser changes

Code Review 0530b
I am fine with the changes. At this point, is there anything left to do? Greg Shah

04:25 PM Feature #2311: rewrite parsing of handle chains and other misc parser changes

OK, the attached version contains this:
# @progress.g@ history fixed
# @methods_attributes.rules@ - was added a not... Constantin Asofiei

04:05 PM Feature #2311: rewrite parsing of handle chains and other misc parser changes

> Thus, is there anything else I should do at this point? Because I doubt the COM_INVOCATION/COM_METHOD/COM_PARAMETER... Greg Shah

03:29 PM Feature #2311: rewrite parsing of handle chains and other misc parser changes

Constantin Asofiei wrote:
> What I think ECW needs is just some simplifications of the cases when COLON nodes are in... Constantin Asofiei

03:01 PM Feature #2311: rewrite parsing of handle chains and other misc parser changes

Constantin Asofiei wrote:
> > 1. The com_invocation/com_method processing in methods_attributes.rules is removed. I... Constantin Asofiei

02:17 PM Feature #2311: rewrite parsing of handle chains and other misc parser changes

> BTW, are there other POLY tests, beside the ones at #2050?
Yes, dynamic_function_context_analysis.p is useful to... Greg Shah

01:46 PM Feature #2311: rewrite parsing of handle chains and other misc parser changes

Greg Shah wrote:
> Code Review 0526f
>
> Generally, I am happy with the changes. The methods_attributes.rules is ... Constantin Asofiei

08:11 AM Feature #1630: implement support for UNBUFFERED in I/O statements

Code Review 0528a
The code looks good.
Have you finished testing all of your testcases? If it is fully working... Greg Shah

08:10 PM Feature #1630: implement support for UNBUFFERED in I/O statements

>1. Please merge the code up to the latest P2J level in bzr (Stream.java is missing changes).
>2. In both classes, p... Evgeny Kiselev

05/29/2014

05:26 PM Feature #2311: rewrite parsing of handle chains and other misc parser changes

Code Review 0526f
Generally, I am happy with the changes. The methods_attributes.rules is so much simpler now. Ni... Greg Shah

05:38 AM Feature #2311: rewrite parsing of handle chains and other misc parser changes

A remainder issue is an investigation of the @annotations/assignment_style_stmt_rewriting.rules@ file: this will spli... Constantin Asofiei

05/28/2014

02:38 PM Bug #2293: Fixing an unfixed extent output parameter causes an error

Constantin Asofiei wrote:
> OK, this is a conversion problem, if the fix is not trivial leave it for another time.
... Hynek Cihlar

12:43 PM Bug #2293: Fixing an unfixed extent output parameter causes an error

Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Not sure if you are aware, table fields can not be set as dynam... Constantin Asofiei

12:35 PM Bug #2293: Fixing an unfixed extent output parameter causes an error

Constantin Asofiei wrote:
> Not sure if you are aware, table fields can not be set as dynamic extent in 4GL. How doe... Hynek Cihlar

11:52 AM Bug #2293: Fixing an unfixed extent output parameter causes an error

Hynek Cihlar wrote:
> Is the conversion of output extent fields supposed to work? When converting a temp-table field... Constantin Asofiei

11:45 AM Bug #2293: Fixing an unfixed extent output parameter causes an error

Is the conversion of output extent fields supposed to work? When converting a temp-table field passed as output param... Hynek Cihlar

10:36 AM Bug #2293: Fixing an unfixed extent output parameter causes an error

By the way, we can remove the need to call @setParameter@ from the converted code completely. For example, when @exte... Hynek Cihlar

01:45 PM Feature #1630: implement support for UNBUFFERED in I/O statements

Code Review 0523a
The changes look good. I have some minor comments and questions:
1. Please merge the code up to ... Greg Shah

12:24 PM Feature #2311: rewrite parsing of handle chains and other misc parser changes

The ges_upd20140428a.zip (amongs other changes) rewrites the AST tree for a chaining in a handle, com-handle or objec... Constantin Asofiei

12:09 PM Feature #2311 (Closed): rewrite parsing of handle chains and other misc parser changes

Constantin Asofiei

05/27/2014

01:59 PM Bug #2293: Fixing an unfixed extent output parameter causes an error

Constantin Asofiei wrote:
> Hynek,
>
> The approach loosk good, just a question about how the converted code looks: ... Hynek Cihlar

11:59 AM Bug #2293: Fixing an unfixed extent output parameter causes an error

Hynek,
The approach loosk good, just a question about how the converted code looks: if we have @integer[] p = extp... Constantin Asofiei

05/26/2014

08:50 PM Feature #1630: implement support for UNBUFFERED in I/O statements

>>Also, please add a test for OUTPUT TO "somefile.txt" UNBUFFERED (redirects the unnamed stream from the terminal to ... Evgeny Kiselev

05/23/2014

02:37 PM Bug #2293: Fixing an unfixed extent output parameter causes an error

Constantin Asofiei wrote:
> How do you expect the converted code will look?
There are not many changes in the con... Hynek Cihlar

01:50 AM Bug #2293: Fixing an unfixed extent output parameter causes an error

Hynek Cihlar wrote:
> In terms of implementation, I don't have a better idea than storing the variable pair consisti... Constantin Asofiei

05/22/2014

04:58 PM Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions

As far as I know, only the issue in note 24 remains open for this task.
I believe that most of the problem in this... Greg Shah

01:20 PM Bug #2293: Fixing an unfixed extent output parameter causes an error

The implementation should be straightforward with one exception - fixing the indeterminate extent argument. When the ... Hynek Cihlar

11:39 AM Bug #2293: Fixing an unfixed extent output parameter causes an error

Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > When error is raised during function or procedure execution, th... Hynek Cihlar

01:41 AM Bug #2293: Fixing an unfixed extent output parameter causes an error

Hynek Cihlar wrote:
> When error is raised during function or procedure execution, the variable passed in the block ... Constantin Asofiei

05/21/2014

06:02 PM Bug #2293: Fixing an unfixed extent output parameter causes an error

Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > The above covers functions only. I will also test procedure out... Hynek Cihlar

01:30 PM Bug #2293: Fixing an unfixed extent output parameter causes an error

Hynek Cihlar wrote:
> The above covers functions only. I will also test procedure output parameters to see how it be... Constantin Asofiei

11:16 AM Bug #2293: Fixing an unfixed extent output parameter causes an error

Constantin Asofiei wrote:
> Hynek, something else to test: what happens with an extent var passed as an OUTPUT argum... Hynek Cihlar

08:42 AM Feature #1596 (Closed): complete big decimal implementation

Greg Shah

08:41 AM Feature #1600 (Closed): provide a conversion option to emit decimal literals using a string liter...

Greg Shah

05/20/2014

05:07 PM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Regression tests passed. Code changes committed to bzr revision 10535. Hynek Cihlar

11:56 AM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...

> Why there are possible of more than one error?! - It's for cases where could be more than one error during executio... Greg Shah

10:36 AM Feature #1630: implement support for UNBUFFERED in I/O statements

It is expected that P2J is not working. The runtime support for UNBUFFERED is not yet implemented. Your testcases l... Greg Shah

08:50 PM Feature #1630: implement support for UNBUFFERED in I/O statements

@UNBUFFERED@ statement is not working properly in p2j. This keyword is properly converted, but worked different.
One... Evgeny Kiselev

05:27 AM Bug #2293: Fixing an unfixed extent output parameter causes an error

Hynek, something else to test: what happens with an extent var passed as an OUTPUT argument, if the function/proc doe... Constantin Asofiei

05/19/2014

04:38 PM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Greg Shah wrote:
> Code Review 0519a
>
> It looks good. Sorry that I didn't think about this approach before now... Hynek Cihlar

03:18 PM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Code Review 0519a
It looks good. Sorry that I didn't think about this approach before now. It was your good idea... Greg Shah

02:29 PM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Attached is the change set with the removed check for decimal literals being effectively mathematical integers. Now t... Hynek Cihlar

02:10 PM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Greg Shah wrote:
> > Or are you saying that we should not care about the literal being effectively an integer (and d... Hynek Cihlar

02:05 PM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

> Or are you saying that we should not care about the literal being effectively an integer (and do not check for this... Greg Shah

11:46 AM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Greg Shah wrote:
> Code Review 0518a
>
> The changes look good. I really like your approach of using the Java @d... Hynek Cihlar

09:31 AM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Code Review 0518a
The changes look good. I really like your approach of using the Java @double@ and @BigDecimal@ ... Greg Shah

04:31 PM Feature #2184 (Closed): create and populate the temp-table on the remote side, based on the recei...

Eric Faulhaber

07:34 AM Feature #2184 (Review): create and populate the temp-table on the remote side, based on the recei...

Stanislav Lomany

07:33 AM Feature #2184 (WIP): create and populate the temp-table on the remote side, based on the received...

Merged update. Stanislav Lomany

02:02 PM Bug #2250 (Closed): Conversion error when decimal precision defined on dynamic extent variable

Greg Shah

01:39 PM Bug #2250: Conversion error when decimal precision defined on dynamic extent variable

I accidentally fixed this issue in the issue #2294. This can be closed now. Hynek Cihlar

05/18/2014

06:32 PM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Attached is the implementation with the special handling of mathematical integers. Now the decimal literal is emitted... Hynek Cihlar

05/16/2014

11:45 AM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Good points. OK, go ahead with your approach. Please do put in the code to detect the 17 digit issue at conversion ... Greg Shah

10:26 AM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Greg Shah wrote:
> We very much like to avoid wrapping when unnecessary. Your idea about whole numbers is a good on... Hynek Cihlar

09:37 AM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

We very much like to avoid wrapping when unnecessary. Your idea about whole numbers is a good one. It does have to ... Greg Shah

08:47 AM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

I am wondering, whether we should emit the wrapper even for (effectively) whole numbers? Ex. instead of @.assign(new ... Hynek Cihlar

05/15/2014

04:22 PM Bug #2294 (Closed): In Progress the variable initializer ignores the declared decimal precision

Greg Shah

12:55 PM Bug #2294: In Progress the variable initializer ignores the declared decimal precision

Committed to bzr revision 10532. Hynek Cihlar

11:31 AM Bug #2294: In Progress the variable initializer ignores the declared decimal precision

Good! Check in and distribute the changes. Greg Shah

11:26 AM Bug #2294: In Progress the variable initializer ignores the declared decimal precision

The regression test (after several attempts) passed. Hynek Cihlar

05/13/2014

08:03 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

The client code will have to be looked at closely in regard to flushing. There are other times when flushing occurs ... Greg Shah

05/12/2014

06:21 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Everything is correct, except one:
>C: this line outputs the default (unnamed) frame to the unnamed stream which is ... Evgeny Kiselev

02:58 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

> Behaviour of display and stream functionality is more complicated than I thought before.
Yes, it is very tricky.... Greg Shah

03:53 PM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Code Review 0512b
Looks good. Get it regression tested. Both conversion and runtime testing are necessary. The ... Greg Shah

03:33 PM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Greg Shah wrote:
> Code Review 0512a
>
> The code looks fine. My only question is about this:
>
> [...]
>
... Hynek Cihlar

02:14 PM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Code Review 0512a
The code looks fine. My only question is about this:... Greg Shah

12:52 PM Feature #1600 (Review): provide a conversion option to emit decimal literals using a string liter...

Hynek Cihlar

12:46 PM Feature #1600: provide a conversion option to emit decimal literals using a string literal instea...

Please review the attached changes. The related test cases are committed as uast/decimal_literal_precision.p.
Hynek Cihlar

09:34 PM Feature #1600 (WIP): provide a conversion option to emit decimal literals using a string literal ...

Hynek Cihlar

02:16 PM Feature #1630: implement support for UNBUFFERED in I/O statements

Check all uses (not just OUTPUT). I would hope that it just means that we flush with every write (synchronously). Greg Shah

11:52 AM Bug #2133 (Closed): fix precision for decimal, dynamic-extent variables

Greg Shah

11:14 AM Bug #2294: In Progress the variable initializer ignores the declared decimal precision

Hynek, the changes on 0511a.zip look good. How was the regression testing? Constantin Asofiei

05/11/2014

05:02 PM Bug #2294 (Review): In Progress the variable initializer ignores the declared decimal precision

Hynek Cihlar

04:41 PM Bug #2294: In Progress the variable initializer ignores the declared decimal precision

Please review the attached change set. It passes the companion uast/testcases which include cases for @setTempPrecisi... Hynek Cihlar