FWD » Core Development » Base Language

08/26/2014

05:52 PM Bug #2367: re-connecting an appserver agent after a hard client termination

Code Review 0806b
Wow! That is tricky code with lots of subtlety. You documented it well and the approach makes ... Greg Shah

04:47 PM Bug #2367 (WIP): re-connecting an appserver agent after a hard client termination

This one was tricky to duplicate and even trickier to solve. The cause is this: if the appserver client terminates t... Constantin Asofiei

02:52 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

> In out code, we add extra new line only for MODE_EXPORT, but in this situation we need to add extra line only when ... Greg Shah

02:04 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

I know, that 4gl documentation is not always correct, but there is next paragraph in @put@ statement:
>UNFORMATTED
... Evgeny Kiselev

01:32 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Greg Shah wrote:
> I still don't know the answer to this question from note 87.
>
> And I would like to know your... Evgeny Kiselev

10:34 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Code Review 0820a
I am fine with the changes.
> However, I think the problems 10/11 in #1629 note 17 will NOT b... Greg Shah

09:45 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Evgeny Kiselev wrote:
> Before merge this update have been passed regression testing, but now it not compile because... Constantin Asofiei

08:35 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

fix problem described in note 86
fix issues from note 87
merged with latest revision
Before merge this update ha... Evgeny Kiselev

08/25/2014

10:48 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

OK, that makes more sense now. What do you suggest? Greg Shah

10:00 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Here is my stacktrace:... Evgeny Kiselev

09:24 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

> problem with @put unformatted "~n ".@:
> ...
> and in method com.goldencode.p2j.util.Stream#generateFormattedText... Greg Shah

08/22/2014

09:32 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

problem described in note 86 divide into 2 problems:
1) incorrect position for message method with redirected stream ... Evgeny Kiselev

08/15/2014

03:05 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Code Review 0812a
The proposed code can be accepted with only some minor changes (listed below).
However, I t... Greg Shah

04:50 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

update:
1) rollback isTerm() method
2) rollback ThinClient(described below)
3) I've added in StreamFactory next co... Evgeny Kiselev

08/13/2014

06:17 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Evgeny Kiselev wrote:
> Also When we removed isTerm() method, there are next possible issues:
> @RemoteStream@ had ... Constantin Asofiei

06:07 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Also When we removed isTerm() method, there are next possible issues:
@RemoteStream@ had constructor @RemoteStream(in... Evgeny Kiselev

06:02 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Evgeny Kiselev wrote:
> > CTRL-C part:
> > ctrlc_11_session1 step 18-28
> > ctrlc_11_session3 step 9-23, 25
> > c... Constantin Asofiei

05:55 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

> CTRL-C part:
> ctrlc_11_session1 step 18-28
> ctrlc_11_session3 step 9-23, 25
> ctrlc_11_session4 step 1-26, 28
... Evgeny Kiselev

04:47 AM Bug #2375: fix the memptr initialization (in extent) and memptr parameter processing

Attached update is a first pass at fixing the problems noted in #1635 note 29,30,31,32. Testcases which cover memptr... Constantin Asofiei

04:32 AM Bug #2375 (Closed): fix the memptr initialization (in extent) and memptr parameter processing

Constantin Asofiei

08/12/2014

04:21 PM Bug #2338: fix _MSG function

Vadim Gindin wrote:
> Constantin Asofiei wrote:
> ..
> > * QUIT/STOP/ENDKEY conditions
>
> I didn't find a way ... Constantin Asofiei

04:07 PM Bug #2338: fix _MSG function

Constantin Asofiei wrote:
..
> * QUIT/STOP/ENDKEY conditions
I didn't find a way to test QUIT and ENDKEY conditi... Vadim Gindin

09:08 AM Feature #1635: implement MEMPTR/RAW support

I'm fine with the proposed approach. My only concern is that I don't want us to spend too much time fixing this, as ... Greg Shah

05:03 AM Feature #1635: implement MEMPTR/RAW support

Greg Shah wrote:
> Code Review 0811a
>
> The changes look good. When it passes testing, please check it in and d... Constantin Asofiei

08/11/2014

04:26 PM Feature #1635: implement MEMPTR/RAW support

Greg Shah wrote:
> Thoughts on how to accommodate this?
Looks like this special state is preserved until the memptr... Constantin Asofiei

01:34 PM Feature #1635: implement MEMPTR/RAW support

> when memptr is set to unknown, the unknown equality test is computed different: it's like Schrodinger's cat, the me... Greg Shah

01:17 PM Feature #1635: implement MEMPTR/RAW support

Code Review 0811a
The changes look good. When it passes testing, please check it in and distribute it. Greg Shah

12:38 PM Feature #1635: implement MEMPTR/RAW support

I have some weird unknown equality test using memptr... See this test:... Constantin Asofiei

10:28 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

> tc_job_002
> tc_job_clock_002
Are these the known failures as described in our documentation?
The other prob... Greg Shah

09:51 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Greg Shah wrote:
> We need to get this through testing. Are there any tests which are always failing?
CTRL-C part:... Evgeny Kiselev

09:48 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

OK, then we need to leave the code as:... Greg Shah

09:39 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

In @StreamWrapper@ with next code: ... Evgeny Kiselev

08/08/2014

02:00 PM Feature #1635: implement MEMPTR/RAW support

> Or raw/memptr values with no data are considered not-unknown?
raw/memptr has a concept of "uninitialized". For ... Greg Shah

11:51 AM Feature #1635: implement MEMPTR/RAW support

There is a bug in the BinaryData.assign code; if a raw/memptr value is set to unknown and then assigned to something ... Constantin Asofiei

01:49 PM Bug #2367: re-connecting an appserver agent after a hard client termination

Eric: yes, both set to 1:... Ovidiu Maxiniuc

01:08 PM Bug #2367: re-connecting an appserver agent after a hard client termination

Ovidiu: this was achieved with @min_agents@ and @max_agents@ both set to 1, correct? Eric Faulhaber

01:03 PM Bug #2367: re-connecting an appserver agent after a hard client termination

Ovidiu, please try to duplicate again, and capture the server thread dump (use @jstack@ for this). I'm curious where... Constantin Asofiei

01:01 PM Bug #2367: re-connecting an appserver agent after a hard client termination

When a client abruptly terminate (killed or otherwise disconnected because of network failure) the appserver enters a... Ovidiu Maxiniuc

12:43 PM Bug #2367 (Closed): re-connecting an appserver agent after a hard client termination

Ovidiu Maxiniuc

10:26 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

I edited the previous note to fix the logic I had broken... Greg Shah

10:24 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Code Review 0805a
I agree that an alternate approach in StreamWrapper seems more correct.
> StreamWrapper line 404:... Greg Shah

05:51 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

ctrc part passed
main part failed, but problem was in testsuit, now tests are running again.
different from previ... Evgeny Kiselev

08/04/2014

07:15 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

merged with latest revision (ThinClient class)
Regression testing failed with 10 tests in main part and 3 tests in c... Evgeny Kiselev

08/01/2014

12:49 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Evgeny Kiselev wrote:
> Do I need to specify in @com.goldencode.p2j.util.StreamDaemon#openTerminalStream@ page size ... Constantin Asofiei

12:32 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Constantin Asofiei wrote:
> Evgeny, about 0731a.zip: the @StreamFactory.openTerminalStream(boolean, int, boolean)@ n... Evgeny Kiselev

03:54 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Evgeny, about 0731a.zip: the @StreamFactory.openTerminalStream(boolean, int, boolean)@ needs to return NULL only if t... Constantin Asofiei

07/31/2014

06:10 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

final version with properly conversion
merged with latest bzr revision Evgeny Kiselev

09:16 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Evgeny: please merge 0728a.zip with the latest bzr revision - #2352 has changes which need to be merged. Constantin Asofiei

07/29/2014

01:55 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Code Review 0728a
I am fine with the changes. Greg Shah

01:11 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Fixed everything from note 63 except conversion rules.
Evgeny Kiselev

09:28 AM Bug #2348 (Closed): unable to find internal procedure from database session trigger

Greg Shah

09:01 AM Bug #2348 (Review): unable to find internal procedure from database session trigger

0729a.zip was committed to bzr rev 10584. This can be closed. Constantin Asofiei

08:54 AM Bug #2348: unable to find internal procedure from database session trigger

Great! Please go ahead and release this as is. Thanks for the quick turnaround. Eric Faulhaber

03:43 AM Bug #2348 (WIP): unable to find internal procedure from database session trigger

This should fix your case. The problem was that the DB trigger invocation code was not pushing the trigger's externa... Constantin Asofiei