Project

General

Profile

Activity

From 04/26/2015 to 05/25/2015

05/22/2015

02:01 PM Bug #2578: incorrect promotion of local defined variables
Please ignore my om_upd20150522a.zip. It brings nothing new, I zipped the wrong files. Sorry. Ovidiu Maxiniuc
11:28 AM Bug #2578: incorrect promotion of local defined variables
I moved the @HandleExprN@ instance variable definitions to same scope as their class. The Majic conversion testing pa... Ovidiu Maxiniuc
11:48 PM Bug #2578: incorrect promotion of local defined variables
I tested @om_upd20150521a.zip@ with the current project. After conversion, there were a number of compile errors (act... Eric Faulhaber

05/21/2015

01:02 PM Bug #2578: incorrect promotion of local defined variables
Code review 0521a:
Looks good to me in terms of the persistence-related changes, though I did notice a typo in the...
Eric Faulhaber
11:32 AM Bug #2578: incorrect promotion of local defined variables
I have tested this update with majic conversion and it looks fine to me.
There are a lot of changes in the code: asi...
Ovidiu Maxiniuc

05/20/2015

01:25 PM Bug #2578: incorrect promotion of local defined variables
Eric Faulhaber wrote:
> See @get_top_level_section_anchor@ in @common-progress.rules@. I use this as a substitute fo...
Ovidiu Maxiniuc
12:52 PM Bug #2578: incorrect promotion of local defined variables
See @get_top_level_section_anchor@ in @common-progress.rules@. I use this as a substitute for @getSectionAnchor@. Eric Faulhaber
12:49 PM Bug #2578: incorrect promotion of local defined variables
That's exactly what I should do in this regard, too: to move the embedded assignment expressions to a more specific s... Ovidiu Maxiniuc
12:29 PM Bug #2578: incorrect promotion of local defined variables
Ovidiu Maxiniuc wrote:
> I think that is the correct location/scope of the inner @EmbeddedAssignmentExpr0@ class (li...
Eric Faulhaber
09:24 AM Bug #2578: incorrect promotion of local defined variables
After some local tests with proposed fix I did a first conversion on Majic. There are indeed a lot of changes, 10% th... Ovidiu Maxiniuc

05/19/2015

04:32 PM Bug #2578: incorrect promotion of local defined variables
I think here we are over-generalizing for a specific case handled at line 619 of @where_clause_post.rules@, where we ... Eric Faulhaber
03:23 PM Bug #2578: incorrect promotion of local defined variables
Eric,
As I expected, the variables are generally promoted if they are found to be referenced in a query substitution...
Ovidiu Maxiniuc
12:27 PM Bug #2578: incorrect promotion of local defined variables
Ovidiu Maxiniuc wrote:
> The reason why the variable is promoted is related to the fact that it takes part into the ...
Eric Faulhaber
12:02 PM Bug #2578: incorrect promotion of local defined variables
Please check the @uast/scoping/local-variable-in-query.p@. Ovidiu Maxiniuc
11:30 AM Bug #2578: incorrect promotion of local defined variables
Please check this 4GL code into the testcases project and post the name here. Eric Faulhaber
10:29 AM Bug #2578: incorrect promotion of local defined variables
When running some testcases for a customer I encountered cases when they were passing at a first run, then re-running... Ovidiu Maxiniuc
10:03 AM Bug #2578 (Closed): incorrect promotion of local defined variables
Ovidiu Maxiniuc

05/08/2015

11:11 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Good, this sounds promising. Please do implement the changes so that they are nicely separated (e.g. no ChUI/GUI-spe... Greg Shah

05/07/2015

03:36 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
All other issues are resolved. All tests has been passed if I exclude changes from Window and ThinClient classes (exc... Evgeny Kiselev

05/06/2015

02:26 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Code Review evk_upd20150504a.zip
1. @import org.apache.commons.logging.*;@ should not be added to @Stream.java@.
...
Greg Shah
12:16 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Thx, I've fixed it. now it's working fine for if I worked from p2j.jar instead of using code. Evgeny Kiselev
02:26 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Evgeny Kiselev wrote:
> merged with latest revision
> moved cursorInvalid to the BasePrimitives
> But I couldn't t...
Constantin Asofiei

05/05/2015

09:33 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
merged with latest revision
moved cursorInvalid to the BasePrimitives
But I couldn't test it now (after merged 29.0...
Evgeny Kiselev
 

Also available in: Atom