Activity

From 05/08/2015 to 06/06/2015

12:21 PM Bug #2578: incorrect promotion of local defined variables: Update 0605a did well with the full group of search unit tests. Eric Faulhaber

01:10 PM Bug #2578: incorrect promotion of local defined variables: Code Review om_upd20150605a.zip
I'm good with this approach. You can check it in if it passes testing. Greg Shah
12:21 PM Bug #2578 (WIP): incorrect promotion of local defined variables: Thanks, Greg, this is exactly my idea. I was sure the @ui_statements@ is not the right place - it is also called too ... Ovidiu Maxiniuc

03:16 PM Bug #2578: incorrect promotion of local defined variables: OK, I've dug into this code more deeply. I think I understand better what you are trying to do.
I still believe t... Greg Shah

05:00 AM Bug #2578: incorrect promotion of local defined variables: Greg Shah wrote:
> Code Review om_upd20150528a.zip
> 1. Are the form header changes are necessary to fix this bug? I... Ovidiu Maxiniuc

03:45 PM Bug #2578: incorrect promotion of local defined variables: Code Review om_upd20150528a.zip
1. Are the form header changes are necessary to fix this bug? If I understand cor... Greg Shah
02:08 PM Bug #2578: incorrect promotion of local defined variables: Eric Faulhaber wrote:
> The changes look correct to me, but I am not expert in this area of the code. Greg will be r... Ovidiu Maxiniuc
01:08 PM Bug #2578: incorrect promotion of local defined variables: Code review 0527b:
The changes look correct to me, but I am not expert in this area of the code. Greg will be revi... Eric Faulhaber

03:27 PM Bug #2578: incorrect promotion of local defined variables: This update is not the ideal solution I wanted but it fixes both last issues.
It passed my testcases, as well as the... Ovidiu Maxiniuc
10:55 AM Bug #2578: incorrect promotion of local defined variables: My candidate has the following flaw I am trying to fix: when a @FORM HEADER@ is defined locally in an internal proced... Ovidiu Maxiniuc

01:10 PM Bug #2578: incorrect promotion of local defined variables: Do you have a new version that I should use for the code review? Greg Shah

02:01 PM Bug #2578: incorrect promotion of local defined variables: Please ignore my om_upd20150522a.zip. It brings nothing new, I zipped the wrong files. Sorry. Ovidiu Maxiniuc
11:28 AM Bug #2578: incorrect promotion of local defined variables: I moved the @HandleExprN@ instance variable definitions to same scope as their class. The Majic conversion testing pa... Ovidiu Maxiniuc
11:48 PM Bug #2578: incorrect promotion of local defined variables: I tested @om_upd20150521a.zip@ with the current project. After conversion, there were a number of compile errors (act... Eric Faulhaber

01:02 PM Bug #2578: incorrect promotion of local defined variables: Code review 0521a:
Looks good to me in terms of the persistence-related changes, though I did notice a typo in the... Eric Faulhaber
11:32 AM Bug #2578: incorrect promotion of local defined variables: I have tested this update with majic conversion and it looks fine to me.
There are a lot of changes in the code: asi... Ovidiu Maxiniuc

01:25 PM Bug #2578: incorrect promotion of local defined variables: Eric Faulhaber wrote:
> See @get_top_level_section_anchor@ in @common-progress.rules@. I use this as a substitute fo... Ovidiu Maxiniuc
12:52 PM Bug #2578: incorrect promotion of local defined variables: See @get_top_level_section_anchor@ in @common-progress.rules@. I use this as a substitute for @getSectionAnchor@. Eric Faulhaber
12:49 PM Bug #2578: incorrect promotion of local defined variables: That's exactly what I should do in this regard, too: to move the embedded assignment expressions to a more specific s... Ovidiu Maxiniuc
12:29 PM Bug #2578: incorrect promotion of local defined variables: Ovidiu Maxiniuc wrote:
> I think that is the correct location/scope of the inner @EmbeddedAssignmentExpr0@ class (li... Eric Faulhaber
09:24 AM Bug #2578: incorrect promotion of local defined variables: After some local tests with proposed fix I did a first conversion on Majic. There are indeed a lot of changes, 10% th... Ovidiu Maxiniuc

04:32 PM Bug #2578: incorrect promotion of local defined variables: I think here we are over-generalizing for a specific case handled at line 619 of @where_clause_post.rules@, where we ... Eric Faulhaber
03:23 PM Bug #2578: incorrect promotion of local defined variables: Eric,
As I expected, the variables are generally promoted if they are found to be referenced in a query substitution... Ovidiu Maxiniuc
12:27 PM Bug #2578: incorrect promotion of local defined variables: Ovidiu Maxiniuc wrote:
> The reason why the variable is promoted is related to the fact that it takes part into the ... Eric Faulhaber
12:02 PM Bug #2578: incorrect promotion of local defined variables: Please check the @uast/scoping/local-variable-in-query.p@. Ovidiu Maxiniuc
11:30 AM Bug #2578: incorrect promotion of local defined variables: Please check this 4GL code into the testcases project and post the name here. Eric Faulhaber
10:29 AM Bug #2578: incorrect promotion of local defined variables: When running some testcases for a customer I encountered cases when they were passing at a first run, then re-running... Ovidiu Maxiniuc
10:03 AM Bug #2578 (Closed): incorrect promotion of local defined variables: Ovidiu Maxiniuc

11:11 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support: Good, this sounds promising. Please do implement the changes so that they are nicely separated (e.g. no ChUI/GUI-spe... Greg Shah

Also available in: Atom

FWD » Core Development » Base Language