Project

General

Profile

Activity

From 05/21/2015 to 06/19/2015

06/19/2015

03:41 PM Bug #2592: improve support for implicit type conversions
I continued by digging into procedure call mechanism. In @ControlFlowOps@, there is @InternalEntryCaller.validate()@ ... Ovidiu Maxiniuc
03:39 PM Bug #2592: improve support for implicit type conversions
On 06/19/2015 10:04 PM, Constantin Asofiei wrote:
> Eric/Ovidiu,
>
> This is a new discovery. And it looks like i...
Ovidiu Maxiniuc
03:38 PM Bug #2592: improve support for implicit type conversions
I found the following external procedure @caller.p@:... Ovidiu Maxiniuc
03:36 PM Bug #2592 (Closed): improve support for implicit type conversions
Ovidiu Maxiniuc

06/08/2015

10:53 AM Bug #2578 (Closed): incorrect promotion of local defined variables
Nice work, Ovidiu. Eric Faulhaber
10:48 AM Bug #2578: incorrect promotion of local defined variables
The update passed the regression testing, was committed to bzr as revno 10874 and it was distributed by mail. Ovidiu Maxiniuc

06/06/2015

12:21 PM Bug #2578: incorrect promotion of local defined variables
Update 0605a did well with the full group of search unit tests. Eric Faulhaber

06/05/2015

01:10 PM Bug #2578: incorrect promotion of local defined variables
Code Review om_upd20150605a.zip
I'm good with this approach. You can check it in if it passes testing.
Greg Shah
12:21 PM Bug #2578 (WIP): incorrect promotion of local defined variables
Thanks, Greg, this is exactly my idea. I was sure the @ui_statements@ is not the right place - it is also called too ... Ovidiu Maxiniuc

06/04/2015

03:16 PM Bug #2578: incorrect promotion of local defined variables
OK, I've dug into this code more deeply. I think I understand better what you are trying to do.
I still believe t...
Greg Shah

05/29/2015

05:00 AM Bug #2578: incorrect promotion of local defined variables
Greg Shah wrote:
> Code Review om_upd20150528a.zip
> 1. Are the form header changes are necessary to fix this bug? I...
Ovidiu Maxiniuc

05/28/2015

03:45 PM Bug #2578: incorrect promotion of local defined variables
Code Review om_upd20150528a.zip
1. Are the form header changes are necessary to fix this bug? If I understand cor...
Greg Shah
02:08 PM Bug #2578: incorrect promotion of local defined variables
Eric Faulhaber wrote:
> The changes look correct to me, but I am not expert in this area of the code. Greg will be r...
Ovidiu Maxiniuc
01:08 PM Bug #2578: incorrect promotion of local defined variables
Code review 0527b:
The changes look correct to me, but I am not expert in this area of the code. Greg will be revi...
Eric Faulhaber

05/27/2015

03:27 PM Bug #2578: incorrect promotion of local defined variables
This update is not the ideal solution I wanted but it fixes both last issues.
It passed my testcases, as well as the...
Ovidiu Maxiniuc
10:55 AM Bug #2578: incorrect promotion of local defined variables
My candidate has the following flaw I am trying to fix: when a @FORM HEADER@ is defined locally in an internal proced... Ovidiu Maxiniuc

05/26/2015

01:10 PM Bug #2578: incorrect promotion of local defined variables
Do you have a new version that I should use for the code review? Greg Shah

05/22/2015

02:01 PM Bug #2578: incorrect promotion of local defined variables
Please ignore my om_upd20150522a.zip. It brings nothing new, I zipped the wrong files. Sorry. Ovidiu Maxiniuc
11:28 AM Bug #2578: incorrect promotion of local defined variables
I moved the @HandleExprN@ instance variable definitions to same scope as their class. The Majic conversion testing pa... Ovidiu Maxiniuc
11:48 PM Bug #2578: incorrect promotion of local defined variables
I tested @om_upd20150521a.zip@ with the current project. After conversion, there were a number of compile errors (act... Eric Faulhaber

05/21/2015

01:02 PM Bug #2578: incorrect promotion of local defined variables
Code review 0521a:
Looks good to me in terms of the persistence-related changes, though I did notice a typo in the...
Eric Faulhaber
11:32 AM Bug #2578: incorrect promotion of local defined variables
I have tested this update with majic conversion and it looks fine to me.
There are a lot of changes in the code: asi...
Ovidiu Maxiniuc
 

Also available in: Atom