Project

General

Profile

Activity

From 05/31/2015 to 06/29/2015

06/29/2015

04:24 PM Bug #2592: improve support for implicit type conversions
The issue for Hynek's earlier work is #2293. Eric Faulhaber
04:18 PM Bug #2592: improve support for implicit type conversions
As I was reviewing this code, I was wondering why @VariableAssigner@ and @OutputParameterAssigner@ were not in the @c... Eric Faulhaber
02:48 PM Bug #2592: improve support for implicit type conversions
After running the testcase procedure against P4GL, I was able to detect the cases where the automatic/implicit conver... Ovidiu Maxiniuc

06/26/2015

04:03 PM Bug #2592: improve support for implicit type conversions
The testcases project was updated with @uast/procedures/conversion-params.p@. It contains the matrix for conversion p... Ovidiu Maxiniuc
12:53 PM Bug #2592: improve support for implicit type conversions
The branch 2592 has been updated and rebased (main trunk revision 10887). It is not at revision 10892.
It passed my ...
Ovidiu Maxiniuc

06/25/2015

12:25 PM Bug #2592: improve support for implicit type conversions
Very good plan and design. Greg Shah
11:50 AM Bug #2592: improve support for implicit type conversions
Support for variables.
I am thinking of the following changes in code:
* an abstract class @Assigner@ with @BaseDat...
Ovidiu Maxiniuc
11:31 AM Bug #2592: improve support for implicit type conversions
These are very good points (the complete matrix and the support for variables). I think both of these issues need to... Greg Shah
10:10 AM Bug #2592 (WIP): improve support for implicit type conversions
I updated the code according your reviews. The new revno is 10890.
Constantin: your 2nd question is very good. I n...
Ovidiu Maxiniuc
04:26 AM Bug #2592: improve support for implicit type conversions
Greg Shah wrote:
> Constantin: as the owner of @ControlFlowOps@, do you have any concerns with the update?
The logi...
Constantin Asofiei

06/24/2015

05:04 PM Bug #2592 (New): improve support for implicit type conversions
Code Review Task Branch 2592 Revision 10889
The core functionality seems good.
1. In @FieldAssigner.assign()@ y...
Greg Shah
03:53 PM Bug #2592: improve support for implicit type conversions
10889 looks good, thanks, but I still want Greg or Constantin's stamp of approval, particularly on the @ControlFlowOp... Eric Faulhaber
03:48 PM Bug #2592 (WIP): improve support for implicit type conversions
New changes committed to revision 10889. Ovidiu Maxiniuc
03:29 PM Bug #2592: improve support for implicit type conversions
Code review 10888:
This looks good to me, with 2 very minor points:
* Please rename @FieldAssigner$Scope.list@ to...
Eric Faulhaber
03:01 PM Bug #2592: improve support for implicit type conversions
The branch has been updated to revision 10888. I already tested with ETF and it passed all +JULIAN_DATE tests that we... Ovidiu Maxiniuc
01:32 PM Bug #2592: improve support for implicit type conversions
Ovidiu Maxiniuc wrote:
> Looks like my idea from note 7 can be easier implemented thanks to the @List<FieldAssigner>...
Eric Faulhaber
12:40 PM Bug #2592: improve support for implicit type conversions
> Sorry for these incremental status updates.
You have done exactly the right thing in posting these different ide...
Greg Shah
12:30 PM Bug #2592: improve support for implicit type conversions
Looks like my idea from note 7 can be easier implemented thanks to the @List<FieldAssigner>@ from @FieldAssigner@ con... Ovidiu Maxiniuc
11:55 AM Bug #2592: improve support for implicit type conversions
After further thinking:
what if we allow the internal variable from @FieldAssigner@ to be updated. For example, if t...
Ovidiu Maxiniuc
10:47 AM Bug #2592: improve support for implicit type conversions
I have created branch 2592 from the main trunk (revno 10886). I committed the intermediary changes in @ControlFlowOps... Ovidiu Maxiniuc
10:06 AM Bug #2592: improve support for implicit type conversions
I started the implementation for the optional conversions in message passing parameters. The forward checking is done... Ovidiu Maxiniuc

06/19/2015

03:41 PM Bug #2592: improve support for implicit type conversions
I continued by digging into procedure call mechanism. In @ControlFlowOps@, there is @InternalEntryCaller.validate()@ ... Ovidiu Maxiniuc
03:39 PM Bug #2592: improve support for implicit type conversions
On 06/19/2015 10:04 PM, Constantin Asofiei wrote:
> Eric/Ovidiu,
>
> This is a new discovery. And it looks like i...
Ovidiu Maxiniuc
03:38 PM Bug #2592: improve support for implicit type conversions
I found the following external procedure @caller.p@:... Ovidiu Maxiniuc
03:36 PM Bug #2592 (Closed): improve support for implicit type conversions
Ovidiu Maxiniuc

06/08/2015

10:53 AM Bug #2578 (Closed): incorrect promotion of local defined variables
Nice work, Ovidiu. Eric Faulhaber
10:48 AM Bug #2578: incorrect promotion of local defined variables
The update passed the regression testing, was committed to bzr as revno 10874 and it was distributed by mail. Ovidiu Maxiniuc

06/06/2015

12:21 PM Bug #2578: incorrect promotion of local defined variables
Update 0605a did well with the full group of search unit tests. Eric Faulhaber

06/05/2015

01:10 PM Bug #2578: incorrect promotion of local defined variables
Code Review om_upd20150605a.zip
I'm good with this approach. You can check it in if it passes testing.
Greg Shah
12:21 PM Bug #2578 (WIP): incorrect promotion of local defined variables
Thanks, Greg, this is exactly my idea. I was sure the @ui_statements@ is not the right place - it is also called too ... Ovidiu Maxiniuc

06/04/2015

03:16 PM Bug #2578: incorrect promotion of local defined variables
OK, I've dug into this code more deeply. I think I understand better what you are trying to do.
I still believe t...
Greg Shah
 

Also available in: Atom