FWD » Core Development » Base Language

07/14/2015

02:44 PM Bug #2592: improve support for implicit type conversions

Ovidiu Maxiniuc wrote:
> There is another reason for my question: once those classed are moved to new package the co... Eric Faulhaber

02:18 PM Bug #2592: improve support for implicit type conversions

Eric Faulhaber wrote:
> Ovidiu Maxiniuc wrote:
> > ... To be honest, I am not completely pleased with the class hie... Ovidiu Maxiniuc

02:07 PM Bug #2592: improve support for implicit type conversions

Ovidiu Maxiniuc wrote:
> The new part is in @ else if (AEP.isAssignableFrom(expectedType) && AEP.isAssignableFrom(ar... Eric Faulhaber

01:56 PM Bug #2592: improve support for implicit type conversions

Eric Faulhaber wrote:
> Code review 2592/10908
>
> I only looked at the diffs from 10907 to 10908.
>
> The con... Ovidiu Maxiniuc

12:16 PM Bug #2592: improve support for implicit type conversions

Ovidiu Maxiniuc wrote:
> ... To be honest, I am not completely pleased with the class hierarchy I merged because it ... Eric Faulhaber

12:12 PM Bug #2592: improve support for implicit type conversions

Code review 2592/10908
I only looked at the diffs from 10907 to 10908.
The conversion change in @control_flow.r... Eric Faulhaber

07/13/2015

02:56 PM Bug #2592: improve support for implicit type conversions

I have found a new issue when calling a procedure with a single EXTENT parameter. Consider a procedure... Ovidiu Maxiniuc

07:15 AM Bug #2592: improve support for implicit type conversions

Eric Faulhaber wrote:
> Ovidiu, I did a quick review of 2592/10907 (though you have not asked for it yet). It looks ... Ovidiu Maxiniuc

12:16 AM Bug #2592: improve support for implicit type conversions

Ovidiu, I did a quick review of 2592/10907 (though you have not asked for it yet). It looks as though you're nearly f... Eric Faulhaber

01:55 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

All changes except Stream class is passed regression testing.
Changes in Stream class is not fully correct. gso_103 ... Evgeny Kiselev

07/10/2015

02:08 PM Bug #2592: improve support for implicit type conversions

Sorry I didn't make this connection sooner. OK, so we've never implemented a solution. Ovidiu, please move forward wi... Eric Faulhaber

02:03 PM Bug #2592: improve support for implicit type conversions

Sorry I didn't realize this earlier, the output parameter precision for fields is covered by #2295. Hynek Cihlar

02:00 PM Bug #2592: improve support for implicit type conversions

Ovidiu Maxiniuc wrote:
> It seems like this case was somehow overlooked, with revno 10895 of main trunk it displays:... Eric Faulhaber

01:49 PM Bug #2592: improve support for implicit type conversions

Ovidiu Maxiniuc wrote:
> The problem is that we need to temporarily overwrite the precision of the database field un... Eric Faulhaber

01:25 PM Bug #2592: improve support for implicit type conversions

It seems like this case was somehow overlooked, with revno 10895 of main trunk it displays:... Ovidiu Maxiniuc

12:42 PM Bug #2592: improve support for implicit type conversions

Eric Faulhaber wrote:
> Ovidiu, please try this testcase without your changes applied and track back to where it bro... Ovidiu Maxiniuc

12:40 PM Bug #2592: improve support for implicit type conversions

Ovidiu, please try this testcase without your changes applied and track back to where it broke (which may be part of ... Eric Faulhaber

12:33 PM Bug #2592: improve support for implicit type conversions

Ovidiu,
it's been a while since I was playing with extents.
The case you refer to shows that 4GL doesn't propag... Hynek Cihlar

12:32 PM Bug #2592: improve support for implicit type conversions

Hynek,
I found in one of your testcase files the following test:... Ovidiu Maxiniuc

09:35 AM Bug #2592: improve support for implicit type conversions

The 2592 branch was rebased with 10895 main trunk and now it is at revno 10906. Ovidiu Maxiniuc

07/09/2015

11:37 AM Bug #2592: improve support for implicit type conversions

Ovidiu Maxiniuc wrote:
> ...
> Since the @rv@ is really the same object as in first call, the fields will be overwr... Eric Faulhaber

10:15 AM Bug #2592: improve support for implicit type conversions

It looks to me that line 4551 in 2592/10903 will only check for types errors: both argument and formal parameter to b... Ovidiu Maxiniuc

07/08/2015

02:18 PM Bug #2592: improve support for implicit type conversions

Ovidiu Maxiniuc wrote:
> I guess that if the size is handles in @ControlFlowOps@, there is no need for the additiona... Eric Faulhaber

01:07 PM Bug #2592: improve support for implicit type conversions

Eric Faulhaber wrote:
> I read through @ControlFlowOps@ a bit more, and I must be misunderstanding your second point... Ovidiu Maxiniuc

11:16 AM Bug #2592: improve support for implicit type conversions

I read through @ControlFlowOps@ a bit more, and I must be misunderstanding your second point above, because it appear... Eric Faulhaber

11:07 AM Bug #2592: improve support for implicit type conversions

Ovidiu wrote (in email):
> There are two main issues I would like to discuss and I would appreciate additional help:... Eric Faulhaber

06/29/2015

04:24 PM Bug #2592: improve support for implicit type conversions

The issue for Hynek's earlier work is #2293. Eric Faulhaber

04:18 PM Bug #2592: improve support for implicit type conversions

As I was reviewing this code, I was wondering why @VariableAssigner@ and @OutputParameterAssigner@ were not in the @c... Eric Faulhaber

02:48 PM Bug #2592: improve support for implicit type conversions

After running the testcase procedure against P4GL, I was able to detect the cases where the automatic/implicit conver... Ovidiu Maxiniuc

06/26/2015

04:03 PM Bug #2592: improve support for implicit type conversions

The testcases project was updated with @uast/procedures/conversion-params.p@. It contains the matrix for conversion p... Ovidiu Maxiniuc

12:53 PM Bug #2592: improve support for implicit type conversions

The branch 2592 has been updated and rebased (main trunk revision 10887). It is not at revision 10892.
It passed my ... Ovidiu Maxiniuc

06/25/2015

12:25 PM Bug #2592: improve support for implicit type conversions

Very good plan and design. Greg Shah

11:50 AM Bug #2592: improve support for implicit type conversions

Support for variables.
I am thinking of the following changes in code:
* an abstract class @Assigner@ with @BaseDat... Ovidiu Maxiniuc

11:31 AM Bug #2592: improve support for implicit type conversions

These are very good points (the complete matrix and the support for variables). I think both of these issues need to... Greg Shah

10:10 AM Bug #2592 (WIP): improve support for implicit type conversions

I updated the code according your reviews. The new revno is 10890.
Constantin: your 2nd question is very good. I n... Ovidiu Maxiniuc

04:26 AM Bug #2592: improve support for implicit type conversions

Greg Shah wrote:
> Constantin: as the owner of @ControlFlowOps@, do you have any concerns with the update?
The logi... Constantin Asofiei

06/24/2015

05:04 PM Bug #2592 (New): improve support for implicit type conversions

Code Review Task Branch 2592 Revision 10889
The core functionality seems good.
1. In @FieldAssigner.assign()@ y... Greg Shah

03:53 PM Bug #2592: improve support for implicit type conversions

10889 looks good, thanks, but I still want Greg or Constantin's stamp of approval, particularly on the @ControlFlowOp... Eric Faulhaber

03:48 PM Bug #2592 (WIP): improve support for implicit type conversions

New changes committed to revision 10889. Ovidiu Maxiniuc

03:29 PM Bug #2592: improve support for implicit type conversions

Code review 10888:
This looks good to me, with 2 very minor points:
* Please rename @FieldAssigner$Scope.list@ to... Eric Faulhaber

03:01 PM Bug #2592: improve support for implicit type conversions

The branch has been updated to revision 10888. I already tested with ETF and it passed all +JULIAN_DATE tests that we... Ovidiu Maxiniuc

01:32 PM Bug #2592: improve support for implicit type conversions

Ovidiu Maxiniuc wrote:
> Looks like my idea from note 7 can be easier implemented thanks to the @List<FieldAssigner>... Eric Faulhaber

12:40 PM Bug #2592: improve support for implicit type conversions

> Sorry for these incremental status updates.
You have done exactly the right thing in posting these different ide... Greg Shah

12:30 PM Bug #2592: improve support for implicit type conversions

Looks like my idea from note 7 can be easier implemented thanks to the @List<FieldAssigner>@ from @FieldAssigner@ con... Ovidiu Maxiniuc

11:55 AM Bug #2592: improve support for implicit type conversions

After further thinking:
what if we allow the internal variable from @FieldAssigner@ to be updated. For example, if t... Ovidiu Maxiniuc

10:47 AM Bug #2592: improve support for implicit type conversions

I have created branch 2592 from the main trunk (revno 10886). I committed the intermediary changes in @ControlFlowOps... Ovidiu Maxiniuc

10:06 AM Bug #2592: improve support for implicit type conversions

I started the implementation for the optional conversions in message passing parameters. The forward checking is done... Ovidiu Maxiniuc

06/19/2015

03:41 PM Bug #2592: improve support for implicit type conversions

I continued by digging into procedure call mechanism. In @ControlFlowOps@, there is @InternalEntryCaller.validate()@ ... Ovidiu Maxiniuc

03:39 PM Bug #2592: improve support for implicit type conversions

On 06/19/2015 10:04 PM, Constantin Asofiei wrote:
> Eric/Ovidiu,
>
> This is a new discovery. And it looks like i... Ovidiu Maxiniuc

03:38 PM Bug #2592: improve support for implicit type conversions

I found the following external procedure @caller.p@:... Ovidiu Maxiniuc

03:36 PM Bug #2592 (Closed): improve support for implicit type conversions

Ovidiu Maxiniuc