FWD » Core Development » Base Language

07/24/2015

12:27 PM Bug #2592: improve support for implicit type conversions

The 2592a/10900 passed the regression testing. The harness results were saved as /opt/secure/clients/timco/majic_test... Ovidiu Maxiniuc

07/23/2015

06:04 PM Bug #2592: improve support for implicit type conversions

Code review 2592a/10900.
The changes look good. Please regression test and merge into trunk as soon as possible. Eric Faulhaber

04:17 PM Bug #2592: improve support for implicit type conversions

I did a quick test and the warning is gone with the small change. I committed the update on 2592 as revno 10900. Ovidiu Maxiniuc

03:21 PM Bug #2592: improve support for implicit type conversions

Greg,
I will add the requested notes in javadocs.
Eric,
2592a it is, I mistyped.
Thanks. I am replacing the @H... Ovidiu Maxiniuc

03:10 PM Bug #2592: improve support for implicit type conversions

Ovidiu Maxiniuc wrote:
> The BDT has the @equals()@ method overridden so two different java objects (an @integer@ an... Eric Faulhaber

03:08 PM Bug #2592: improve support for implicit type conversions

> I used a Map having BaseDataType as keys. This is a very bad option! We should never use BDT for keying/fast looku... Greg Shah

02:41 PM Bug #2592: improve support for implicit type conversions

Eric,
I found out why the server log is filled with @Two AbstractOutputParameterAssigner configured with same wrap... Ovidiu Maxiniuc

07/21/2015

03:26 PM Bug #2592: improve support for implicit type conversions

The 2582 branch advanced to revno 10916 after it was rebased with trunk revno 10897. There were no conflicts.
Then i... Ovidiu Maxiniuc

02:26 PM Bug #2592: improve support for implicit type conversions

Please go ahead and rebase. If there are no conflicts as expected, go ahead and merge into the trunk. Eric Faulhaber

01:43 PM Bug #2592: improve support for implicit type conversions

Eric Faulhaber wrote:
> Code review 2592/10915:
>
> The items from the previous code review appear to have been a... Ovidiu Maxiniuc

01:10 PM Bug #2592: improve support for implicit type conversions

Code review 2592/10915:
The items from the previous code review appear to have been addressed.
Ovidiu, what is ... Eric Faulhaber

07/20/2015

10:08 AM Bug #2592: improve support for implicit type conversions

> Using the BaseDataType could be a solution, but we need to store somewhere the compatibility matrix. I guess this w... Greg Shah

07/17/2015

04:00 PM Bug #2592: improve support for implicit type conversions

Constantin Asofiei wrote:
> Ovidiu, about revision 10912:
> * SourceNameMapper.getParameter:941 - you should check ... Ovidiu Maxiniuc

02:22 PM Bug #2592: improve support for implicit type conversions

Greg Shah wrote:
> Aren't all implicit cases using the BaseDataType constructor?
At this point, no. The @ControlF... Ovidiu Maxiniuc

02:07 PM Bug #2592: improve support for implicit type conversions

Aren't all implicit cases using the BaseDataType constructor? Greg Shah

01:57 PM Bug #2592: improve support for implicit type conversions

I was going further and investigating some other failed tests from #1868. I noticed that in P2J some query was failin... Ovidiu Maxiniuc

06:05 AM Bug #2592: improve support for implicit type conversions

Ovidiu, about revision 10912:
* SourceNameMapper.getParameter:941 - you should check for @param >= ie.getParameterLi... Constantin Asofiei

05:36 AM Bug #2592: improve support for implicit type conversions

Paul Eames wrote:
> I see this is marked as blocking #1868.
>
> Can you give me a couple of examples of where we ... Ovidiu Maxiniuc

05:06 AM Bug #2592: improve support for implicit type conversions

I see this is marked as blocking #1868.
Can you give me a couple of examples of where we are relying on this impli... Paul E

07/16/2015

11:11 PM Bug #2592: improve support for implicit type conversions

Ovidiu Maxiniuc wrote:
> * if a procedure was called then that is a serious error and the condition will stop execut... Eric Faulhaber

07/15/2015

04:05 PM Bug #2592: improve support for implicit type conversions

I updated the branch. What is new in revno 10910:
* moved @FieldAssigner@, @OutputExtentField@ and @InputOutputExten... Ovidiu Maxiniuc

05:31 AM Bug #2592: improve support for implicit type conversions

The revno 10909/2592 test ended with some failures:
* 3 tests in CTRL+C (known to fail in most runs)
* gso_269/48 i... Ovidiu Maxiniuc

07/14/2015

02:44 PM Bug #2592: improve support for implicit type conversions

Ovidiu Maxiniuc wrote:
> There is another reason for my question: once those classed are moved to new package the co... Eric Faulhaber

02:18 PM Bug #2592: improve support for implicit type conversions

Eric Faulhaber wrote:
> Ovidiu Maxiniuc wrote:
> > ... To be honest, I am not completely pleased with the class hie... Ovidiu Maxiniuc

02:07 PM Bug #2592: improve support for implicit type conversions

Ovidiu Maxiniuc wrote:
> The new part is in @ else if (AEP.isAssignableFrom(expectedType) && AEP.isAssignableFrom(ar... Eric Faulhaber

01:56 PM Bug #2592: improve support for implicit type conversions

Eric Faulhaber wrote:
> Code review 2592/10908
>
> I only looked at the diffs from 10907 to 10908.
>
> The con... Ovidiu Maxiniuc

12:16 PM Bug #2592: improve support for implicit type conversions

Ovidiu Maxiniuc wrote:
> ... To be honest, I am not completely pleased with the class hierarchy I merged because it ... Eric Faulhaber

12:12 PM Bug #2592: improve support for implicit type conversions

Code review 2592/10908
I only looked at the diffs from 10907 to 10908.
The conversion change in @control_flow.r... Eric Faulhaber

07/13/2015

02:56 PM Bug #2592: improve support for implicit type conversions

I have found a new issue when calling a procedure with a single EXTENT parameter. Consider a procedure... Ovidiu Maxiniuc

07:15 AM Bug #2592: improve support for implicit type conversions

Eric Faulhaber wrote:
> Ovidiu, I did a quick review of 2592/10907 (though you have not asked for it yet). It looks ... Ovidiu Maxiniuc

12:16 AM Bug #2592: improve support for implicit type conversions

Ovidiu, I did a quick review of 2592/10907 (though you have not asked for it yet). It looks as though you're nearly f... Eric Faulhaber

01:55 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

All changes except Stream class is passed regression testing.
Changes in Stream class is not fully correct. gso_103 ... Evgeny Kiselev

07/10/2015

02:08 PM Bug #2592: improve support for implicit type conversions

Sorry I didn't make this connection sooner. OK, so we've never implemented a solution. Ovidiu, please move forward wi... Eric Faulhaber

02:03 PM Bug #2592: improve support for implicit type conversions

Sorry I didn't realize this earlier, the output parameter precision for fields is covered by #2295. Hynek Cihlar

02:00 PM Bug #2592: improve support for implicit type conversions

Ovidiu Maxiniuc wrote:
> It seems like this case was somehow overlooked, with revno 10895 of main trunk it displays:... Eric Faulhaber

01:49 PM Bug #2592: improve support for implicit type conversions

Ovidiu Maxiniuc wrote:
> The problem is that we need to temporarily overwrite the precision of the database field un... Eric Faulhaber

01:25 PM Bug #2592: improve support for implicit type conversions

It seems like this case was somehow overlooked, with revno 10895 of main trunk it displays:... Ovidiu Maxiniuc

12:42 PM Bug #2592: improve support for implicit type conversions

Eric Faulhaber wrote:
> Ovidiu, please try this testcase without your changes applied and track back to where it bro... Ovidiu Maxiniuc

12:40 PM Bug #2592: improve support for implicit type conversions

Ovidiu, please try this testcase without your changes applied and track back to where it broke (which may be part of ... Eric Faulhaber

12:33 PM Bug #2592: improve support for implicit type conversions

Ovidiu,
it's been a while since I was playing with extents.
The case you refer to shows that 4GL doesn't propag... Hynek Cihlar

12:32 PM Bug #2592: improve support for implicit type conversions

Hynek,
I found in one of your testcase files the following test:... Ovidiu Maxiniuc

09:35 AM Bug #2592: improve support for implicit type conversions

The 2592 branch was rebased with 10895 main trunk and now it is at revno 10906. Ovidiu Maxiniuc

07/09/2015

11:37 AM Bug #2592: improve support for implicit type conversions

Ovidiu Maxiniuc wrote:
> ...
> Since the @rv@ is really the same object as in first call, the fields will be overwr... Eric Faulhaber

10:15 AM Bug #2592: improve support for implicit type conversions

It looks to me that line 4551 in 2592/10903 will only check for types errors: both argument and formal parameter to b... Ovidiu Maxiniuc

07/08/2015

02:18 PM Bug #2592: improve support for implicit type conversions

Ovidiu Maxiniuc wrote:
> I guess that if the size is handles in @ControlFlowOps@, there is no need for the additiona... Eric Faulhaber

01:07 PM Bug #2592: improve support for implicit type conversions

Eric Faulhaber wrote:
> I read through @ControlFlowOps@ a bit more, and I must be misunderstanding your second point... Ovidiu Maxiniuc

11:16 AM Bug #2592: improve support for implicit type conversions

I read through @ControlFlowOps@ a bit more, and I must be misunderstanding your second point above, because it appear... Eric Faulhaber

11:07 AM Bug #2592: improve support for implicit type conversions

Ovidiu wrote (in email):
> There are two main issues I would like to discuss and I would appreciate additional help:... Eric Faulhaber

06/29/2015

04:24 PM Bug #2592: improve support for implicit type conversions

The issue for Hynek's earlier work is #2293. Eric Faulhaber

04:18 PM Bug #2592: improve support for implicit type conversions

As I was reviewing this code, I was wondering why @VariableAssigner@ and @OutputParameterAssigner@ were not in the @c... Eric Faulhaber

02:48 PM Bug #2592: improve support for implicit type conversions

After running the testcase procedure against P4GL, I was able to detect the cases where the automatic/implicit conver... Ovidiu Maxiniuc

06/26/2015

04:03 PM Bug #2592: improve support for implicit type conversions

The testcases project was updated with @uast/procedures/conversion-params.p@. It contains the matrix for conversion p... Ovidiu Maxiniuc

12:53 PM Bug #2592: improve support for implicit type conversions

The branch 2592 has been updated and rebased (main trunk revision 10887). It is not at revision 10892.
It passed my ... Ovidiu Maxiniuc

06/25/2015

12:25 PM Bug #2592: improve support for implicit type conversions

Very good plan and design. Greg Shah

11:50 AM Bug #2592: improve support for implicit type conversions

Support for variables.
I am thinking of the following changes in code:
* an abstract class @Assigner@ with @BaseDat... Ovidiu Maxiniuc

11:31 AM Bug #2592: improve support for implicit type conversions

These are very good points (the complete matrix and the support for variables). I think both of these issues need to... Greg Shah

10:10 AM Bug #2592 (WIP): improve support for implicit type conversions

I updated the code according your reviews. The new revno is 10890.
Constantin: your 2nd question is very good. I n... Ovidiu Maxiniuc

04:26 AM Bug #2592: improve support for implicit type conversions

Greg Shah wrote:
> Constantin: as the owner of @ControlFlowOps@, do you have any concerns with the update?
The logi... Constantin Asofiei