Activity
From 03/18/2016 to 04/16/2016
04/16/2016
- 01:30 PM Bug #2657: appserver agent context reset does not deallocate currently allocated memptr buffers
- Re-assigning this so we can address the remaining concerns in note 4.
04/07/2016
- 09:02 AM Feature #1612: finish SESSION system handle support
- I'm pushing trunk revision 10996 your way now, which will get you this fix. Sorry for the delay.
- 08:17 AM Feature #1612: finish SESSION system handle support
- p.s. alternatively if a fix can't be pushed our way soon then can you let me know and we'll reconvert with an older P...
- 07:09 AM Feature #1612: finish SESSION system handle support
- Not really sure which issue to put this comment on, or whether to raise a new issue.
We've not been running our te...
04/06/2016
- 10:17 AM Feature #2181 (Closed): implement SSL support for sockets
- 10:12 AM Feature #2181: implement SSL support for sockets
- The final update for task branch 2181a was committed to trunk as revision 10995.
The test results were saved and bra... - 09:40 AM Feature #2181: implement SSL support for sockets
- Please merge to trunk.
- 08:30 AM Feature #2181: implement SSL support for sockets
- The regression test passed. There were a few failed testcases, but they are known to fail occasionally.
- 10:14 AM Bug #2685 (Closed): web services networking needs to be moved from the P2J server to the client
- 10:13 AM Bug #2685: web services networking needs to be moved from the P2J server to the client
- The final update for this task was committed to trunk with task branch 2181a as revision 10995.
Task can be closed. - 10:14 AM Feature #2687 (Closed): add SSL support for the 4GL web services implementation
- 10:13 AM Feature #2687: add SSL support for the 4GL web services implementation
- The final update for this task was committed to trunk with task branch 2181a as revision 10995.
Task can be closed. - 10:13 AM Bug #2684 (Closed): XML file processing needs to be implemented on the client side instead of on ...
- 10:13 AM Bug #2684: XML file processing needs to be implemented on the client side instead of on the P2J s...
- The final update for this task was committed to trunk with task branch 2181a as revision 10995.
Task can be closed.
04/05/2016
- 03:45 PM Feature #2181: implement SSL support for sockets
- Great! Please post your regression testing results here as soon as you have them. Branch 1811t is waiting for your ...
- 03:25 PM Feature #2181: implement SSL support for sockets
- Task branch 2181a was rebased and pushed up to revision 11010.
- 01:52 PM Feature #2181: implement SSL support for sockets
- > If you think otherwise, I will move it back (or copy it for emphasis).
No, don't worry about it. - 01:47 PM Feature #2181: implement SSL support for sockets
- Yes, the information is correct.
The comment was not completly removed, I moved the 4 lines up to method javadoc. I ... - 01:29 PM Feature #2181: implement SSL support for sockets
- Code Review Task Branch 2181a Revision 11006
The changes are good. Resolve the following 2 issues and then put th... - 12:58 PM Feature #2181: implement SSL support for sockets
- Greg Shah wrote:
> Code Review Task Branch 2181a Revision 11005
>
> The changes are fine.
>
> Please resolve t...
04/04/2016
- 04:48 PM Feature #2181: implement SSL support for sockets
- Code Review Task Branch 2181a Revision 11005
The changes are fine.
Please resolve the case-insensitive lookup i... - 04:37 PM Bug #2684: XML file processing needs to be implemented on the client side instead of on the P2J s...
- Greg Shah wrote:
> Great!
>
> Is there anything left to do on this task?
I have committed the last changes rel... - 10:55 AM Feature #1612: finish SESSION system handle support
- The fix for regression in note 212 was moved from branch 2181a to branch 3012a rev 10996.
04/02/2016
- 08:03 AM Feature #2181: implement SSL support for sockets
- Code Review Task Branch 2181a Revision 11004
The changes look very good.
1. In the future, "simple container" class... - 07:36 AM Bug #2684: XML file processing needs to be implemented on the client side instead of on the P2J s...
- Great!
Is there anything left to do on this task? - 07:16 AM Bug #2684: XML file processing needs to be implemented on the client side instead of on the P2J s...
- Greg Shah wrote:
> To be clear, I think the LOAD and SAVE implementations should be possible using @InputStreamWrapp...
04/01/2016
- 04:36 PM Feature #2181: implement SSL support for sockets
- >> LowLevelSocketImpl.enableSSLConnections - I think we might need to provide case-insensitive search of store files,...
- 04:15 PM Feature #2181: implement SSL support for sockets
- Constantin Asofiei wrote:
> Ovidiu, about 2181a rev 10998:
> 1. @LowLevelSocketImpl.createSslSocket@ - it can retur... - 04:14 PM Feature #1612: finish SESSION system handle support
- Greg Shah wrote:
> Ovidiu: please put this into 2181a.
Done. Revision is 11004. - 03:50 PM Feature #1612: finish SESSION system handle support
- The idea is reasonable.
Ovidiu: please put this into 2181a. - 11:58 AM Feature #1612: finish SESSION system handle support
- Constantin Asofiei wrote:
> The @LogicalTerminal@ versions need to be renamed to something else (maybe append an @_@... - 11:58 AM Feature #1612: finish SESSION system handle support
- Ovidiu reports a regression when building a @SESSION@ as a handle via @SessionUtils.asHandle()@ - @isDataEntryReturn@...
- 07:07 AM Bug #2872: IOException in Windows
- The exception is thrown in @com\goldencode\p2j\util\Utils.java@. Here is an example of a complete exception stack:
<...
03/31/2016
- 08:44 AM Feature #2504 (Closed): real environment access for OS-GETENV
- The change to add this feature was put into branch 1896c which was merged to trunk as revision 10990.
- 08:42 AM Feature #1612 (Closed): finish SESSION system handle support
- 07:10 AM Feature #2181: implement SSL support for sockets
- Ovidiu, about 2181a rev 10998:
# @LowLevelSocketImpl.createSslSocket@ - it can return @null@ if host name can't be v...
03/30/2016
- 04:08 PM Bug #2684: XML file processing needs to be implemented on the client side instead of on the P2J s...
- To be clear, I think the LOAD and SAVE implementations should be possible using @InputStreamWrapper@ and @OutputStrea...
- 12:47 PM Feature #1612: finish SESSION system handle support
- Thanks, those are useful clarifications.
- 12:28 PM Feature #1612: finish SESSION system handle support
- Greg Shah wrote:
> In our gap analysis rules, I was planning to set the following:
>
> [...]
>
> Is this corre... - 12:23 PM Feature #1612: finish SESSION system handle support
- In our gap analysis rules, I was planning to set the following:...
- 09:57 AM Feature #1612: finish SESSION system handle support
- The task branch merged to the trunk revision 10988 and archived.
- 08:50 AM Feature #1612: finish SESSION system handle support
- Great! Please merge 1612b to trunk.
- 06:53 AM Feature #1612: finish SESSION system handle support
- ctrl-c-3way tests passed.
- 03:25 AM Feature #1612: finish SESSION system handle support
- All regression tests except @gso_ctrlc_3way_tests@ and @tc_job_002@ passed.
- 07:56 AM Bug #2872: IOException in Windows
- Ovidiu: please post details of the IOException and how to recreate the problem.
The native console init will be wo... - 05:08 AM Feature #2181: implement SSL support for sockets
- Greg Shah wrote:
> Code Review Task Branch 2181a Revision 10995
>
> 1. @LowLevelSocketImpl.initClientSideSSL()@ h...
03/29/2016
- 05:20 PM Feature #2181: implement SSL support for sockets
- Constantin: please review this.
- 05:19 PM Feature #2181: implement SSL support for sockets
- Code Review Task Branch 2181a Revision 10995
This is really good work.
1. @LowLevelSocketImpl.initClientSideSSL... - 01:39 PM Feature #1612: finish SESSION system handle support
- Rebased task branch 1612b from P2J trunk rev 10987. The latest revision is now 10997.
Starting regression testing. - 01:34 PM Feature #1612: finish SESSION system handle support
- It looks good. Please rebase to the latest trunk level. After that you can regression test.
- 01:32 PM Feature #1612: finish SESSION system handle support
- Greg Shah wrote:
> Code Review Task Branch 1612b Revision 10995
>
> Everything looks good except you forgot about... - 01:29 PM Feature #1612: finish SESSION system handle support
- Code Review Task Branch 1612b Revision 10995
Everything looks good except you forgot about this one:... - 01:26 PM Feature #1612: finish SESSION system handle support
- Greg Shah wrote:
> Code Review Task Branch 1612b Revision 10993
Fixed.
Committed to the task branch 1612b revi... - 01:15 PM Feature #1612: finish SESSION system handle support
- Code Review Task Branch 1612b Revision 10993
1. @ClientCore@ should not import @com.goldencode.p2j.ui.client.gui.*... - 01:01 PM Feature #1612: finish SESSION system handle support
- Client command line parameters' processing refactored.
Committed to the task branch 1612b revision 10993. - 12:27 PM Feature #1612: finish SESSION system handle support
- Greg Shah wrote:
> No. Just remove the @ClientParameters@ instance from @standardEntry()@. I don't ever see a rea... - 12:26 PM Feature #1612: finish SESSION system handle support
- > My concern is this opens the door for submitting two (possibly different) versions of ClientParameters to the serve...
- 12:24 PM Feature #1612: finish SESSION system handle support
- Greg Shah wrote:
> We don't want to expose the directory configuration for @SessionUtils@ to the client. The direct... - 12:19 PM Feature #1612: finish SESSION system handle support
- We don't want to expose the directory configuration for @SessionUtils@ to the client. The directory node that is che...
- 11:22 AM Feature #1612: finish SESSION system handle support
- Greg Shah wrote:
> You're right. Propose an alternative that does not call @WorkArea.get()@ before the @ClientParam... - 11:13 AM Feature #1612: finish SESSION system handle support
- Greg Shah wrote:
> Later we are going to have to split this out anyway, so it might as well be done now. That also ... - 11:08 AM Feature #1612: finish SESSION system handle support
- > My initial version was exactly like you suggested but I've changed it as there are no places (so far) where we need...
- 11:06 AM Feature #1612: finish SESSION system handle support
- Greg Shah wrote:
> Code Review Task Branch 1612b Revision 10992
>
> Generally the changes are OK.
>
> However,... - 11:02 AM Feature #1612: finish SESSION system handle support
- Code Review Task Branch 1612b Revision 10992
Generally the changes are OK.
However, I think this code in @Error... - 10:29 AM Feature #1612: finish SESSION system handle support
- Constantin Asofiei wrote:
> Greg Shah wrote:
> > 1. In @ErrorManager.recordOrShowError()@, I think the direct use o... - 10:15 AM Feature #1612: finish SESSION system handle support
- > As I can see the ThinClient.initializePost() is called even before ThinClient.loadEnvironment()
You're right. P... - 09:47 AM Feature #1612: finish SESSION system handle support
- Greg Shah wrote:
> 5. Move the @ThinClient.loadEnvironment()@ call to @getSessionTooltips()@ to the @ThinClient.in... - 09:21 AM Feature #1612: finish SESSION system handle support
- Greg Shah wrote:
> 1. In @ErrorManager.recordOrShowError()@, I think the direct use of the @ProcedureManager@ will b... - 09:09 AM Feature #1612: finish SESSION system handle support
- > To make the change as local as possible I decided to change SessionUtils.getSessionTooltips() only. This approach i...
- 05:21 AM Feature #1612: finish SESSION system handle support
- Greg Shah wrote:
> Good find. Please do fix it.
Done.
Committed to the task branch 1612b revision 10991.
To ... - 01:20 PM Feature #1623 (Closed): refine I/O support to resolve incompatibilities or missing features
- 01:20 PM Feature #1628 (Closed): fix any incompatibilities or missing features of NO-ECHO support
- 01:16 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Branch 1628a passed runtime testing and was merged to trunk rev 10987 and archived.
- 05:23 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- 1628a rev 10989 fixes two more issues (format for unknown date variables and a NL emitted before the page headers).
03/28/2016
- 06:44 PM Feature #1612: finish SESSION system handle support
- > This happens because of the @ToolTip.setSessionTooltips(tc.server.getSessionTooltips())@ call at the end of the @Th...
- 06:44 PM Feature #1612: finish SESSION system handle support
- Code Review Task Branch 1612a Revision 10990
History number @802@ in @ErrorWriterServer@ should be @002@. - 04:13 PM Feature #1612: finish SESSION system handle support
- This happens because of the @ToolTip.setSessionTooltips(tc.server.getSessionTooltips())@ call at the end of the @Thin...
- 04:03 PM Feature #1612: finish SESSION system handle support
- Greg Shah wrote:
> Strange. If this call occurs after the @StandardServer.standardEntry()@ is called, then how can ... - 03:47 PM Feature #1612: finish SESSION system handle support
- Greg Shah wrote:
> Strange. If this call occurs after the @StandardServer.standardEntry()@ is called, then how can ... - 03:46 PM Feature #1612: finish SESSION system handle support
- Strange. If this call occurs after the @StandardServer.standardEntry()@ is called, then how can the @ClientParameter...
- 03:22 PM Feature #1612: finish SESSION system handle support
- Greg Shah wrote:
> > The problem is that sometimes the @StandardServer.getClientParameters()@ returns @null@ when ca... - 03:11 PM Feature #1612: finish SESSION system handle support
- > > You should never be able to call @get()@ without @initialValue()@ having been executed. This is a pre-existing b...
- 03:10 PM Feature #1612: finish SESSION system handle support
- Code Review Task Branch 1612b Revision 10989
1. In @ErrorManager.recordOrShowError()@, I think the direct use of t... - 02:12 PM Feature #1612: finish SESSION system handle support
- The issues mentioned in the code review have been fixed.
Committed to the task branch 1612b revision 10989. - 02:02 PM Feature #1612: finish SESSION system handle support
- Greg Shah wrote:
> You should never be able to call @get()@ without @initialValue()@ having been executed. This i... - 01:59 PM Feature #1612: finish SESSION system handle support
- >> 3. I don't understand why SessionUtils.init() is being called from isDebugAlert() and isClientlog(). Shouldn't the...
- 01:56 PM Feature #1612: finish SESSION system handle support
- Greg Shah wrote:
> Code Review Task Branch 1612b Revision 10988
>
> 1. My primary concern is that you are re-intr... - 01:45 PM Feature #1612: finish SESSION system handle support
- Code Review Task Branch 1612b Revision 10988
1. My primary concern is that you are re-introducing a direct UI depe... - 12:13 PM Feature #1612: finish SESSION system handle support
- Finished client logging.
Committed to the task branch 1612b revision 10988.
Ready for the code review. - 08:47 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Code Review Task Branch 1628a Revision 10988
Both the merge of the evk_upd20150713a.zip into 1628a and the changes... - 07:45 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Rebased trunk rev from 1628a rev 10986.
1628a rev 10988 fixes a PUT issues (do not emit NL before PUT if cursor is...
03/26/2016
- 08:50 AM Feature #1612: finish SESSION system handle support
- Created task branch 1612b
- 08:45 AM Feature #1612: finish SESSION system handle support
- Merged to the trunk revision 10986.
The task branch 1612a was archived. - 08:29 AM Feature #1612: finish SESSION system handle support
- Please merge 1612a to trunk.
- 02:31 AM Feature #1612: finish SESSION system handle support
- All CTRL-C test passed.
The branch 1612a is ready for merge.
03/25/2016
- 06:26 PM Feature #1612: finish SESSION system handle support
- tc_job_clock_002 test passed.
Starting CTRL-C tests. - 02:56 PM Feature #1612: finish SESSION system handle support
- After a second run only the following tests from main-regression failed in both runs:
tc_job_002
tc_job_clock_002
... - 11:22 AM Feature #1612: finish SESSION system handle support
- Igor Skornyakov wrote:
> Constantin Asofiei wrote:
>
> > I've used this test:
> > [...]
> > and after running i... - 11:16 AM Feature #1612: finish SESSION system handle support
- Greg Shah wrote:
> Yes. Do not spend time on @LOG-MANAGER@.
OK, thank you.
- 11:15 AM Feature #1612: finish SESSION system handle support
- > do you agree with this approach?
Yes. Do not spend time on @LOG-MANAGER@. - 11:10 AM Feature #1612: finish SESSION system handle support
- Constantin Asofiei wrote:
> I've used this test:
> [...]
> and after running it like this: @pro -p aa.p -clientl... - 11:05 AM Feature #1612: finish SESSION system handle support
- Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > In note 59 you state that stack trace is written also for @M... - 11:04 AM Feature #1612: finish SESSION system handle support
- After the fix the following test failed in the main-regression:
tc_codes_employees_021
tc_codes_employees_024
tc_d... - 10:57 AM Feature #1612: finish SESSION system handle support
- Constantin Asofiei wrote:
> In note 59 you state that stack trace is written also for @MESSAGE statements shown as A... - 10:44 AM Feature #1612: finish SESSION system handle support
- Igor Skornyakov wrote:
> The goal is to write Progress stack trace when @DEBUG-ALERT@ is on and the @-clientlog@ is... - 10:32 AM Feature #1612: finish SESSION system handle support
- Constantin Asofiei wrote:
> For appserver agents (and also batch processes configured in the directory and started v... - 10:14 AM Feature #1612: finish SESSION system handle support
- Greg Shah wrote:
> Constantin: can you please provide some guidance on how to best write to the log?
For appserver ... - 09:56 AM Feature #1612: finish SESSION system handle support
- OK, but the @DSLOG-MANAGER@ system handle is not in use in the customer application. We don't need to worry about it...
- 09:51 AM Feature #1612: finish SESSION system handle support
- Greg Shah wrote:
> > If I understand the progress documentation correctly the parameters of the server log are the a... - 09:46 AM Feature #1612: finish SESSION system handle support
- > If I understand the progress documentation correctly the parameters of the server log are the attributes of the DSL...
- 09:36 AM Feature #1612: finish SESSION system handle support
- I have a question regrading logging. I understand that I'm supposed to implement stack trace logging for the applicat...
- 06:27 AM Feature #1612: finish SESSION system handle support
- It appears that the clause @The AVM ignores this attribute if there is a default button on the frame@ means that in t...
- 04:29 AM Feature #1612: finish SESSION system handle support
- Well in fact the template screen is...
- 04:14 AM Feature #1612: finish SESSION system handle support
- Multiple tests failed on the same (or similar) screen:...
- 12:41 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Created task branch 1628a from trunk rev 10985.
Rev 10986 contains the merged evk_upd20150713a.zip (there are still ...
03/24/2016
- 10:25 AM Feature #1612: finish SESSION system handle support
- Greg Shah wrote:
> My question about the estimate is in regards to the @-debugalert@ command line support and the ad... - 10:00 AM Feature #1612: finish SESSION system handle support
- My question about the estimate is in regards to the @-debugalert@ command line support and the addition of the needed...
- 09:50 AM Feature #1612: finish SESSION system handle support
- Greg Shah wrote:
> No, we will do them here but in a new branch 1612b. I want to get the current changes merged t... - 09:31 AM Feature #1612: finish SESSION system handle support
- Code Review Task Branch 1612a Revision 10995
This review checks every change in this branch from trunk 10985. I h... - 09:20 AM Feature #1612: finish SESSION system handle support
- > Please note that the support for the -debugalert startup parameter and the logging is not implemented as well. Shou...
- 06:55 AM Feature #1612: finish SESSION system handle support
- Greg Shah wrote:
> It isn't necessary right now. Please open a separate task in the UI project for that. Make it a... - 05:31 AM Feature #1612: finish SESSION system handle support
- Fixed the issues mentioned in the code review.
Rebased task branch 1612a from P2J trunk rev 10985. The latest revi...
03/23/2016
- 07:15 PM Feature #1612: finish SESSION system handle support
- Code Review Task Branch 1612a Revision 10991
1. There are 2 history entries in @ButtonConfig@ which have wrong num... - 07:06 PM Feature #1612: finish SESSION system handle support
- > I made some progress with ChUI stack trace dialog but it is still not working properly.
It isn't necessary right... - 06:54 PM Feature #1612: finish SESSION system handle support
- Greg Shah wrote:
> 2. Direct users of @ThinClient.messageBox()@ all have comments like @TODO: is it always correct... - 08:29 AM Feature #1612: finish SESSION system handle support
- Greg Shah wrote:
> Code Review Task Branch 1612a Revision 10990
>
> The overall approach is very good. My commen... - 08:20 AM Feature #1612: finish SESSION system handle support
- Code Review Task Branch 1612a Revision 10990
The overall approach is very good. My comments are mostly about codi... - 02:42 PM Feature #1615 (Rejected): implement RCODE-INFO system handle
- This usage was removed from the application.
03/22/2016
- 05:20 PM Feature #1612: finish SESSION system handle support
- Hynek Cihlar wrote:
> Looks ok to me.
Great! Thank you very much indeed!
- 05:20 PM Feature #1612: finish SESSION system handle support
- Igor Skornyakov wrote:
> Hynek, can you please take a look at the @AlertBoxCommons.showStackTrace()@ method? Are the... - 01:02 PM Feature #1612: finish SESSION system handle support
- The dialog for the Progress stack trace is essentially finished for the Swing GUI
Committed to the task branch 161... - 07:30 AM Feature #1612: finish SESSION system handle support
- Greg Shah wrote:
> In #3033, you are trying to use extra widgets to get your layout to look right. Does the 4GL use... - 07:27 AM Feature #1612: finish SESSION system handle support
- In #3033, you are trying to use extra widgets to get your layout to look right. Does the 4GL use a fixed location fo...
- 07:26 AM Feature #1612: finish SESSION system handle support
- Greg Shah wrote:
> If you have some partially working code, please check it in and get help. We have to close this ... - 07:23 AM Feature #1612: finish SESSION system handle support
- If you have some partially working code, please check it in and get help. We have to close this down as quickly as p...
03/21/2016
- 05:45 PM Feature #1612: finish SESSION system handle support
- Hynek Cihlar wrote:
> Good idea, but I am afraid that 4GL internally uses two different layouts for ChUI and GUI a... - 05:41 PM Feature #1612: finish SESSION system handle support
- Igor Skornyakov wrote:
> Hynek Cihlar wrote:
> > Igor Skornyakov wrote:
> > > Hynek,
> > > I'm working now on the... - 05:12 PM Feature #1612: finish SESSION system handle support
- Hynek Cihlar wrote:
> Igor Skornyakov wrote:
> > Hynek,
> > I'm working now on the dialog for the stack trace foll... - 04:59 PM Feature #1612: finish SESSION system handle support
- Igor Skornyakov wrote:
> Hynek,
> I'm working now on the dialog for the stack trace following the approach you sugg... - 03:03 PM Feature #1612: finish SESSION system handle support
- Hynek,
I'm working now on the dialog for the stack trace following the approach you suggested. The dialog should con...
Also available in: Atom