FWD » Core Development » Base Language

12/17/2017

05:13 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

Unfortunately, the ChUI app regression testing fails with the same core regressions that have been happening earlier ... Greg Shah

10:38 AM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

ETF batch tests passed. If it passes regular regression testing, I think this revision can be merged to trunk. Eric Faulhaber

02:16 AM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

Greg, 3406a/11222 has passed ETF search and dev tests (2 clean runs of the latter). I am testing batch next, but plea... Eric Faulhaber

12/16/2017

09:02 AM Feature #3262: implement COM/OLE Automation support

Task branch @3262b@ has been rebased with recent trunk @11210@, new version is @11250@. Eugenie Lyzenko

12/12/2017

11:35 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

Investigation so far shows that the 4GL's where clause processing and error handling is a bit different than ours. An... Eric Faulhaber

12/09/2017

05:01 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

The root cause of the first failing test is that the new code in @AbstractQuery.preprocessSubstitutionArguments@ does... Eric Faulhaber

04:08 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

The errors I've looked at so far seem to be cases of @P2JQuery.Parameter@ lambda expressions being passed too far alo... Eric Faulhaber

03:16 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

ETF testing failed immediately because the DMO ASM code used the old BDT @assign@ signatures. Once I fixed this (comm... Eric Faulhaber

12/05/2017

01:00 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

I need to investigate more thoroughly, but my initial thoughts:
@RecordBuffer$Handler.invoke@: should be safe to r... Eric Faulhaber

12:45 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

I will post more details of the problem and the proposed solution shortly. But for now, I have a question.
The pe... Greg Shah

11:16 AM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow

Created task branch 3406a. The changes for this task are going to be in a sensitive area and will affect many files. Greg Shah

12/04/2017

08:38 AM Bug #3406 (Closed): implement silent error mode as a lambda to allow aborting the control flow

Greg Shah

12/03/2017

09:13 AM Bug #3400: shared variables context for RUN int-proc IN ext-proc-handle is not properly pushed

Greg Shah wrote:
> Code Review Task Branch 3394a Revision 11225
>
> 1. In @ProcedureManager.searchInStack()@, why... Constantin Asofiei

12:56 AM Bug #3400: shared variables context for RUN int-proc IN ext-proc-handle is not properly pushed

Code Review Task Branch 3394a Revision 11225
1. In @ProcedureManager.searchInStack()@, why use a map as @searched@... Greg Shah

12/02/2017

02:38 PM Bug #3400: shared variables context for RUN int-proc IN ext-proc-handle is not properly pushed

The fixes are in 3394a rev 11225
In the end, the problem was that the lookup for shared vars must be performed on ... Constantin Asofiei

12/01/2017

10:47 AM Feature #3262: implement COM/OLE Automation support

Task branch @3262b@ has been updated for review to revision @11248@.
Adding protection for null characters passed ... Eugenie Lyzenko

10:45 PM Feature #3262: implement COM/OLE Automation support

During testing COM feature with big application found new issues:
1. The file resources to be taken from application... Eugenie Lyzenko

10:11 PM Feature #3262: implement COM/OLE Automation support

> Is it OK to leave this feature postponed?
Yes, you can match the support level of the Java code. Greg Shah

09:50 PM Feature #3262: implement COM/OLE Automation support

Task branch @3262b@ has been updated for review to revision @11247@.
OK. This update returns native code to the st... Eugenie Lyzenko

07:14 PM Feature #3262: implement COM/OLE Automation support

Constantin Asofiei wrote:
> > So for now you offer to have nothing extent array support.
> Yes, because the correct... Eugenie Lyzenko

08:21 AM Bug #3400: shared variables context for RUN int-proc IN ext-proc-handle is not properly pushed

The main problems I identified are:
# a shared-var leak for persistent procedures (they are not being removed when t... Constantin Asofiei

08:19 AM Bug #3400 (Closed): shared variables context for RUN int-proc IN ext-proc-handle is not properly ...

Constantin Asofiei

11/30/2017

05:53 PM Feature #3396: shift searchpath and other pathing lists in the directory to use the platform neut...

I almost completely forgot about #3225. I took a quick look over it. The 3225b contains only a single altered file: @... Ovidiu Maxiniuc

04:51 PM Feature #3396: shift searchpath and other pathing lists in the directory to use the platform neut...

The @searchpath@ is the @directory.xml@ value that is used by the FWD runtime to represent the @PROPATH@. Since FWD ... Greg Shah

05:14 PM Feature #3262: implement COM/OLE Automation support

Guys,
More complex approach can be to introduce new class for results coming from native side to Java, say @ComRet... Eugenie Lyzenko

04:55 PM Feature #3262: implement COM/OLE Automation support

Eugenie Lyzenko wrote:
> Another word as I can see you removed (undone) all recent changes prepared to handle extent... Constantin Asofiei

04:50 PM Feature #3262: implement COM/OLE Automation support

Constantin Asofiei wrote:
> Eugenie, please see 3262b rev 11246. Note that you will need to have some changes in th... Eugenie Lyzenko

04:15 PM Feature #3262: implement COM/OLE Automation support

Eugenie, please see 3262b rev 11246. Note that you will need to have some changes in the FWD native COM part, becaus... Constantin Asofiei

01:01 PM Feature #3262: implement COM/OLE Automation support

Yes. I didn't start yet to fix the branch, I'll try tonight or tomorrow the latest. Constantin Asofiei

12:57 PM Feature #3262: implement COM/OLE Automation support

Yes, we have signature match issue. Like this when @FWD@ expects @comhandle.call()@ returning @BDT@ while our @comhan... Eugenie Lyzenko

11:53 AM Feature #3262: implement COM/OLE Automation support

Greg Shah wrote:
> Code Review Task Branch 3262b Revision 11244
>
> I've checked in some changes as 11245. I'm g... Eugenie Lyzenko

11:00 AM Feature #3262: implement COM/OLE Automation support

Code Review Task Branch 3262b Revision 11244
I've checked in some changes as 11245. I'm good with that version. ... Greg Shah

09:28 AM Feature #3262: implement COM/OLE Automation support

Task branch @3262b@ has been updated for review to revision @11244@.
The notes resolution changes. Optional @NO-CO... Eugenie Lyzenko

08:47 AM Feature #3262: implement COM/OLE Automation support

Greg Shah wrote:
> Code Review Task Branch 3262b Revision 11243
>
> 1. Please make the 4th parameter to @launch()... Eugenie Lyzenko

06:07 AM Feature #3262: implement COM/OLE Automation support

Code Review Task Branch 3262b Revision 11243
1. Please make the 4th parameter to @launch()@ optional. This means ... Greg Shah

10:42 PM Feature #3262: implement COM/OLE Automation support

Task branch @3262b@ has been updated for review to revision @11243@.
This is minor javadoc fixes for my recent cha... Eugenie Lyzenko

09:47 PM Feature #3262: implement COM/OLE Automation support

Task branch @3262b@ has been rebased with recent trunk @11208@, new version is @11242@. Eugenie Lyzenko

09:27 PM Feature #3262: implement COM/OLE Automation support

Task branch @3262b@ has been updated for review to revision @11241@.
This update fixes the handling of the @NO-WAI... Eugenie Lyzenko

11/29/2017

05:15 PM Feature #3262: implement COM/OLE Automation support

> Is this OK?
Yes.
> Observing the rule file for process launch I see we do not have any support for NO-CONSOLE... Greg Shah

02:58 PM Feature #3262: implement COM/OLE Automation support

For Windows @SILENT@ option I suggest to change the @ProcessDaemon@ class to take into account the same reaction for ... Eugenie Lyzenko

11:19 AM Feature #3262: implement COM/OLE Automation support

> For example notepad.exe and regedit.exe cause the 4GL application to finish external app to continue after os-comm... Greg Shah

11:15 AM Feature #3262: implement COM/OLE Automation support

Constantin Asofiei wrote:
> Eugenie, I've tried this simple program, with @pro@, @prowin@ and from procedure editor,... Eugenie Lyzenko

11:12 AM Feature #3262: implement COM/OLE Automation support

Yes, @notepad.exe@, @regedit.exe@, also @write.exe@ can be started with @no-console@ option. However the behavior is ... Eugenie Lyzenko

11:05 AM Feature #3262: implement COM/OLE Automation support

Greg Shah wrote:
> Are you testing with OpenEdge 11.6?
@11.6.3@. Eugenie Lyzenko

10:28 AM Feature #3262: implement COM/OLE Automation support

Eugenie, I've tried this simple program, with @pro@, @prowin@ and from procedure editor, and it opens the @notepad.ex... Constantin Asofiei

10:27 AM Feature #3262: implement COM/OLE Automation support

Greg Shah wrote:
> Try running a program that has no GUI and which also can be made to run without STDIN/STDOUT/STDE... Hynek Cihlar

08:59 AM Feature #3262: implement COM/OLE Automation support

Try running a program that has no GUI and which also can be made to run without STDIN/STDOUT/STDERR. In other words,... Greg Shah

08:24 AM Feature #3262: implement COM/OLE Automation support

Are you testing with OpenEdge 11.6? Greg Shah

08:11 AM Feature #3262: implement COM/OLE Automation support

Greg Shah wrote:
> @dir@ is an internal feature of the @cmd.exe@ shell. It won't work without the shell. But launc... Eugenie Lyzenko

07:43 AM Feature #3262: implement COM/OLE Automation support

@dir@ is an internal feature of the @cmd.exe@ shell. It won't work without the shell. But launching a @.exe@ progra... Greg Shah

07:39 AM Feature #3262: implement COM/OLE Automation support

Greg Shah wrote:
> I will review the changes shortly.
>
> > NO-CONSOLE - does not start any child process in GUI.... Eugenie Lyzenko

06:02 AM Feature #3262: implement COM/OLE Automation support

I will review the changes shortly.
> NO-CONSOLE - does not start any child process in GUI.
I don't understand w... Greg Shah

09:22 PM Feature #3262: implement COM/OLE Automation support

Task branch @3262b@ has been updated for review to revision @11240@.
The change adds initial step to turn the chil... Eugenie Lyzenko

11/28/2017

06:51 PM Feature #3262: implement COM/OLE Automation support

The testcases repo has been updated to revision @1705@.
The child process starting testcases added for @GUI@ mode ... Eugenie Lyzenko

05:59 PM Feature #3262: implement COM/OLE Automation support

Greg Shah wrote:
>
> Please check the @NO-WAIT@, @SILENT@ and @NO-CONSOLE@ options. I suspect the @NO-WAIT@ is pr... Eugenie Lyzenko

03:56 PM Feature #3262: implement COM/OLE Automation support

Task branch @3262b@ has been rebased with trunk @11207@, new revision is @11239@. Eugenie Lyzenko

03:47 PM Feature #3262: implement COM/OLE Automation support

Starting the rebase. Eugenie Lyzenko

03:45 PM Feature #3262: implement COM/OLE Automation support

Constantin Asofiei wrote:
> Greg/Eugenie: I plan to make the Java code in 3262b generic enough so that we will be ab... Greg Shah

03:44 PM Feature #3262: implement COM/OLE Automation support

> >Eugenie: Would you please run some testcases to see how the interactive child process launching works under GUI? I... Greg Shah

03:42 PM Feature #3262: implement COM/OLE Automation support

Greg/Eugenie: I plan to make the Java code in 3262b generic enough so that we will be able to add the missing extent ... Constantin Asofiei

03:32 PM Feature #3262: implement COM/OLE Automation support

Planning to rebase the branch with the recent trunk in a 10 min. if nobody objects. Eugenie Lyzenko

03:27 PM Feature #3262: implement COM/OLE Automation support

Greg Shah wrote:
>Eugenie: Would you please run some testcases to see how the interactive child process launching wo... Eugenie Lyzenko

03:19 PM Feature #3262: implement COM/OLE Automation support

Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> > Eugenie Lyzenko wrote:
> > > Constantin Asofiei wrote:
> >... Constantin Asofiei

03:17 PM Feature #3262: implement COM/OLE Automation support

Constantin Asofiei wrote:
> Eugenie Lyzenko wrote:
> > Constantin Asofiei wrote:
> > >Eugenie: the large GUI app w... Eugenie Lyzenko

03:06 PM Feature #3262: implement COM/OLE Automation support

Greg Shah wrote:
> Code Review Task Branch 3262b Revision 11234
> ...
>4. The changes in comauto_win.c are so exte... Eugenie Lyzenko

02:42 PM Feature #3262: implement COM/OLE Automation support

Task branch @3262b@ has been updated for review to revision @11238@.
Undo the @EnvironmentOps@ change that fixes t... Eugenie Lyzenko

02:29 PM Feature #3262: implement COM/OLE Automation support

Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> >Eugenie: the large GUI app we are using has constructs like S... Constantin Asofiei

02:27 PM Feature #3262: implement COM/OLE Automation support

Constantin Asofiei wrote:
>Eugenie: the large GUI app we are using has constructs like STRING(com-var:property) - th... Eugenie Lyzenko

02:25 PM Feature #3262: implement COM/OLE Automation support

Constantin Asofiei wrote:
> Greg Shah wrote:
> > It seems we should just continue the work in this branch to finish... Greg Shah

02:24 PM Feature #3262: implement COM/OLE Automation support

> The FWD executes ProcessDaemon.launch() for START EXCEL.EXE some_file.csv. This causes the ChildProcessFactory.getC... Greg Shah

02:16 PM Feature #3262: implement COM/OLE Automation support

Eugenie Lyzenko wrote:
> Greg Shah wrote:
> > Code Review Task Branch 3262b Revision 11234
> >
> >1. In assignme... Constantin Asofiei

02:15 PM Feature #3262: implement COM/OLE Automation support

Greg Shah wrote:
> It seems we should just continue the work in this branch to finish the extent support, rather tha... Constantin Asofiei

02:14 PM Feature #3262: implement COM/OLE Automation support

Greg Shah wrote:
> Code Review Task Branch 3262b Revision 11234
>
>1. In assignments.rules, the newly added code ... Eugenie Lyzenko

02:13 PM Feature #3262: implement COM/OLE Automation support

It seems we should just continue the work in this branch to finish the extent support, rather than reverting it all. Greg Shah

02:00 PM Feature #3262: implement COM/OLE Automation support

Greg Shah wrote:
> Constantin: Do you have any concerns about the changes in this branch?
I've fixed some cases (re... Constantin Asofiei

01:58 PM Feature #3262: implement COM/OLE Automation support

Greg Shah wrote:
> Code Review Task Branch 3262b Revision 11234
>
> 3. The @EnvironmentOps@ change is not correct... Eugenie Lyzenko

01:56 PM Feature #3262: implement COM/OLE Automation support

Greg Shah wrote:
> > found the cases that use COM prefixed with starting EXCEL.EXE as subprocess which is currently ... Eugenie Lyzenko

12:26 PM Feature #3262: implement COM/OLE Automation support

Constantin: Do you have any concerns about the changes in this branch? Greg Shah

12:25 PM Feature #3262: implement COM/OLE Automation support

> found the cases that use COM prefixed with starting EXCEL.EXE as subprocess which is currently not supported in FWD... Greg Shah

12:23 PM Feature #3262: implement COM/OLE Automation support

Code Review Task Branch 3262b Revision 11234
1. In @assignments.rules@, the newly added code is disabled because o... Greg Shah

12:13 PM Feature #3396 (WIP): shift searchpath and other pathing lists in the directory to use the platfor...

Greg Shah

11/27/2017

06:15 PM Feature #3262: implement COM/OLE Automation support

Task branch @3262b@ has been updated for review to revision @11233@, rebased with recent trunk, new version is @11234... Eugenie Lyzenko

11/26/2017

04:54 PM Feature #3262: implement COM/OLE Automation support

Task branch @3262b@ has been updated for review to revision @11232@.
Added fix for @propath@ variation. Allows hav... Eugenie Lyzenko

08:09 PM Feature #3262: implement COM/OLE Automation support

Task branch @3262b@ has been updated for review to revision @11231@.
Fix for regression caused by shifting from si... Eugenie Lyzenko

11/25/2017

05:06 PM Feature #3262: implement COM/OLE Automation support

Task branch @3262b@ has been rebased with trunk @11205@, new revision is @11230@. Eugenie Lyzenko

11/24/2017

03:39 PM Feature #3262: implement COM/OLE Automation support

Task branch @3262b@ has been rebased with trunk @11204@, new revision is @11229@. Eugenie Lyzenko

02:20 PM Feature #3262: implement COM/OLE Automation support

Task branch @3262b@ has been updated for review to revision @11226@, @11227@.
This update implements improved obje... Eugenie Lyzenko

06:45 AM Feature #3262: implement COM/OLE Automation support

> Looks like we also need to change gap report processing rules to reflect the added implementation, this is one more... Greg Shah

10:45 PM Feature #3262: implement COM/OLE Automation support

OK. Looks like the @4GL@ @COM@ garbage collector approach has been clarified. The internal object taken from given @C... Eugenie Lyzenko

09:11 PM Feature #3262: implement COM/OLE Automation support

Greg Shah wrote:
> > The COM objects has no actual parent-child relationships. The same object can be obtained for r... Eugenie Lyzenko

07:05 PM Feature #3262: implement COM/OLE Automation support

Greg,
Looks like we also need to change gap report processing rules to reflect the added implementation, this is o... Eugenie Lyzenko

11/23/2017

06:42 PM Feature #3262: implement COM/OLE Automation support

Task branch @3262b@ has been updated for review to revision @11225@.
This update adds extent array support for pro... Eugenie Lyzenko

06:25 AM Feature #3262: implement COM/OLE Automation support

> The COM objects has no actual parent-child relationships. The same object can be obtained for re-use from different... Greg Shah

09:42 PM Feature #3262: implement COM/OLE Automation support

Task branch @3262b@ has been updated for review to revision @11224@.
This is minor cleanup update. I have designed... Eugenie Lyzenko

11/22/2017

04:36 PM Feature #3262: implement COM/OLE Automation support

Greg Shah wrote:
>Eugenie: Can you write the Java-side array changes that are needed? Constantin is busy with anothe... Eugenie Lyzenko

03:50 PM Feature #3262: implement COM/OLE Automation support

Eugenie: Can you write the Java-side array changes that are needed? Constantin is busy with another task.
What el... Greg Shah

02:17 PM Feature #3262: implement COM/OLE Automation support

Task branch @3262b@ has been rebased with trunk @11202@, new revision is @11223@. Eugenie Lyzenko

02:00 PM Feature #3262: implement COM/OLE Automation support

Task branch @3262b@ has been updated for review to revision @11222@.
This is code partial cleanup and adding inter... Eugenie Lyzenko

08:05 AM Feature #3262: implement COM/OLE Automation support

Greg Shah wrote:
> If I understand correctly, they are stating that the user is responsible for releasing all of the... Eugenie Lyzenko

06:05 AM Feature #3262: implement COM/OLE Automation support

> The intermediate COM handles created with lines like comObject:prop1:prop2:(prop|method()) is not explicitly releas... Greg Shah

11/21/2017

06:33 PM Feature #3262: implement COM/OLE Automation support

Task branch @3262b@ has been updated for review to revision @11221@.
This updates has changes to make chain calls ... Eugenie Lyzenko

06:07 PM Feature #3262: implement COM/OLE Automation support

Constantin Asofiei wrote:
> Eugenie Lyzenko wrote:
> > Honestly I do not understand why we need attributes support ... Eugenie Lyzenko

05:37 PM Feature #3262: implement COM/OLE Automation support

Eugenie Lyzenko wrote:
> Honestly I do not understand why we need attributes support for @COM-HANDLE@. @COM-HANDLE@ ... Constantin Asofiei

05:32 PM Feature #3262: implement COM/OLE Automation support

I would suggest to change @com_access.rules@ to:... Eugenie Lyzenko

04:56 PM Feature #3262: implement COM/OLE Automation support

Constantin Asofiei wrote:
> Eugenie Lyzenko wrote:
> > The @NAME@ is a reserved keyword? What makes @NAME@ property... Eugenie Lyzenko

02:57 PM Feature #3262: implement COM/OLE Automation support

Eugenie Lyzenko wrote:
> The @NAME@ is a reserved keyword? What makes @NAME@ property to process differently?
Is a ... Constantin Asofiei

02:55 PM Feature #3262: implement COM/OLE Automation support

Constantin Asofiei wrote:
> Eugenie Lyzenko wrote:
> > 2. Consider the following @4GL@ code:
> > [...]
> >
> > ... Eugenie Lyzenko

02:13 PM Feature #3262: implement COM/OLE Automation support

Eugenie Lyzenko wrote:
> This is correct conversion and we have property getter and method call. Both of them return... Constantin Asofiei

01:54 PM Feature #3262: implement COM/OLE Automation support

Constantin Asofiei wrote:
> Eugenie Lyzenko wrote:
> > Guys,
> >
> > I have two notes at this time for Java side... Eugenie Lyzenko

01:20 PM Feature #3262: implement COM/OLE Automation support

Eugenie Lyzenko wrote:
> Guys,
>
> I have two notes at this time for Java side with real @Excel@ application:
> ... Constantin Asofiei

01:16 PM Feature #3262: implement COM/OLE Automation support

Guys,
I have two notes at this time for Java side with real @Excel@ application:
1. The @NativeComObject@ must ... Eugenie Lyzenko

09:56 PM Feature #3262: implement COM/OLE Automation support

The testcases repo has been updated to revision @1700@.
The real @MS Office@ testcases have been added. The curren... Eugenie Lyzenko

11/18/2017

06:20 PM Feature #3262: implement COM/OLE Automation support

Constantin Asofiei wrote:
> Eugenie, see 11220 - it should work, I'm sending null value for empty parameters.
Yes... Eugenie Lyzenko

05:47 PM Feature #3262: implement COM/OLE Automation support

Eugenie, see 11220 - it should work, I'm sending null value for empty parameters. Constantin Asofiei

04:39 PM Feature #3262: implement COM/OLE Automation support

Constantin Asofiei wrote:
> Yes, I missed this part - how do you want it to work? Just set that value to @null@, and... Eugenie Lyzenko

04:29 PM Feature #3262: implement COM/OLE Automation support

Eugenie Lyzenko wrote:
> Constantin,
>
> The current Java side support for optional parameters is incomplete. The... Constantin Asofiei

12:01 PM Feature #3262: implement COM/OLE Automation support

Constantin,
The current Java side support for optional parameters is incomplete. The using @comhandle.EMPTY(new Ob... Eugenie Lyzenko

06:44 AM Feature #3262: implement COM/OLE Automation support

Task branch @3262b@ has been updated for review to revision @11219@.
The update adds native support for optional p... Eugenie Lyzenko