Activity
From 11/26/2017 to 12/25/2017
12/25/2017
- 07:46 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- Greg, I've left changes for browse TODOs in 3406b rev 11214.
12/23/2017
- 03:36 AM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- Created task branch 3406b from trunk rev 11213.
12/22/2017
- 06:35 PM Feature #3262: implement COM/OLE Automation support
- The revision @11308@ gives the same converted code for @COM@ sample testcases I have used in @COM@ native implementat...
- 05:22 PM Feature #3262: implement COM/OLE Automation support
- There is an issue with how we convert LOAD-CONTROLS. We've decide to treat every COM access as a generic call (witho...
- 09:12 AM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- Greg Shah wrote:
> > in ControlFlowOps - is the H061 still needed?
>
> No, not after trunk rev 11213.
Backed ou... - 09:05 AM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- > in ControlFlowOps - is the H061 still needed?
No, not after trunk rev 11213. - 08:31 AM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- Greg, in @ControlFlowOps@ - is the H061 still needed?...
- 12:54 AM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- 3406a/11232 has passed ETF search, dev, and batch testing, main regression testing, and ctrl+c testing. The branch wa...
- 08:25 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- Follow-up: I tested with trunk; same error.
However, it's fixed in 3394a (tested with 11299), so... never mind. - 08:01 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- Is this a known Hotel GUI issue? I hit this while trying to check in a guest on the "Available" screen first thing af...
12/21/2017
- 05:21 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- I have manually tested Hotel GUI (Swing, Virtual Desktop and Embedded Modes) in both 3406a (11232) and trunk (11212)....
- 11:25 AM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- Task branch 3406a has been rebased to p2j trunk revision 11212.
- 01:25 AM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- 3406a/11226 has passed dev, search, and batch ETF testing. Two runs of main runtime regression testing show a handful...
- 06:03 AM Feature #3262: implement COM/OLE Automation support
- Branch @3262b@ was merged to trunk as revno @11212@ then it was archived.
- 05:57 AM Feature #3262: implement COM/OLE Automation support
- Greg Shah wrote:
> Please merge 3262b to trunk.
OK. Starting. - 04:56 AM Feature #3262: implement COM/OLE Automation support
- Please merge 3262b to trunk.
- 09:39 PM Feature #3262: implement COM/OLE Automation support
- Testing completed. No regressions have been found. The results: @3262b_11251_a5eeab0_20171220_evl.zip@.
So the bra... - 08:07 PM Feature #3262: implement COM/OLE Automation support
- The main cycle completed. No regression. Running @CTRL-C@ part.
Can I merge into trunk if no regressions for @CTRL...
12/20/2017
- 05:54 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- It's not the case.
- 05:53 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- OK, then please hold off on updating this branch, unless you believe these changes are necessary to making the new er...
- 05:39 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- > OK, please put it in and I'll restart testing.
That may require some time because is not yet ready. - 05:16 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- OK, please put it in and I'll restart testing.
- 05:09 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- No, its not risky, just minor fix which IIRC doesn't affect regression testing.
- 05:03 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- Stanislav Lomany wrote:
> I wanted to fix TODOs and error in processing in one place, but can do that in another bra... - 04:54 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- I wanted to fix TODOs and error in processing in one place, but can do that in another branch.
- 04:35 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- So, are we expecting any more code changes at this point, or is revision 11226 what we're testing? Actually, I alread...
- 04:27 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- The TODOs in 3406a rev 11226:
# @SharedVariableManager.errorHelper@ - this is used when there is a problem resolving... - 03:21 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- > @ErrorManager.recordOrShowError@ or @ErrorManager.recordOrThrowError@?
@ErrorManager.recordOrShowError@ - 03:01 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- Greg Shah wrote:
> I've also added TODO and ECF_TODO comments in other locations that need review.
>
> Eric: Plea... - 02:56 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- Stanislav Lomany wrote:
> > Stanislav: Please look at @Browse@ and @BrowseWidget@ for the TODOs I've added.
>
> T... - 02:52 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- Our original approach to silent error mode was to bracket each NO-ERROR statement (or assignment or standalone expres...
- 02:33 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- > Stanislav: Please look at @Browse@ and @BrowseWidget@ for the TODOs I've added.
These exceptions serve the purpo... - 12:30 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- Per our offline discussion, revision 11225 enables the re-throw of the error condition inside the silent worker's cat...
- 04:11 AM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- Revision 3406a/11224 almost resolves the deferred validation issue, except instead of the pause and "Press space bar ...
- 03:28 AM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- The issue for at least two of the tests (a concurrent pair) is that the harness is expecting a validation failure (un...
- 11:29 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- 3406a/11223 passed ETF developer testing, but failed regular regression testing twice with 4 of the same tests failin...
- 04:44 PM Feature #3262: implement COM/OLE Automation support
- Conversion testing has been passed, code trees are identical. Continue with runtime testing.
- 11:19 AM Feature #3262: implement COM/OLE Automation support
- Task branch @3262b@ has been rebased with recent trunk @11211@, new version is @11251@.
- 10:53 AM Feature #3262: implement COM/OLE Automation support
- Greg Shah wrote:
> > There is an issues with getting the file resources (Excel files templates) from application *.j... - 10:41 AM Feature #3262: implement COM/OLE Automation support
- Greg Shah wrote:
> > The rules were changed, so conversion test is required I guess. Also safe harness run is desira... - 10:39 AM Feature #3262: implement COM/OLE Automation support
- > The rules were changed, so conversion test is required I guess. Also safe harness run is desirable to make sure we ...
- 10:33 AM Feature #3262: implement COM/OLE Automation support
- Greg Shah wrote:
> > I think we can test and merge 3262b into trunk and defer other work to 3262c.
>
> What testi... - 10:26 AM Feature #3262: implement COM/OLE Automation support
- > There is an issues with getting the file resources (Excel files templates) from application *.jar files.
Are the... - 10:09 AM Feature #3262: implement COM/OLE Automation support
- Greg Shah wrote:
>How safe is the 3262b branch at this point? Is it suitable for merge to trunk or is there known wo... - 09:45 AM Feature #3262: implement COM/OLE Automation support
- How safe is the 3262b branch at this point? Is it suitable for merge to trunk or is there known work needed?
I kn...
12/17/2017
- 05:13 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- Unfortunately, the ChUI app regression testing fails with the same core regressions that have been happening earlier ...
- 10:38 AM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- ETF batch tests passed. If it passes regular regression testing, I think this revision can be merged to trunk.
- 02:16 AM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- Greg, 3406a/11222 has passed ETF search and dev tests (2 clean runs of the latter). I am testing batch next, but plea...
12/16/2017
- 09:02 AM Feature #3262: implement COM/OLE Automation support
- Task branch @3262b@ has been rebased with recent trunk @11210@, new version is @11250@.
12/12/2017
- 11:35 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- Investigation so far shows that the 4GL's where clause processing and error handling is a bit different than ours. An...
12/09/2017
- 05:01 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- The root cause of the first failing test is that the new code in @AbstractQuery.preprocessSubstitutionArguments@ does...
- 04:08 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- The errors I've looked at so far seem to be cases of @P2JQuery.Parameter@ lambda expressions being passed too far alo...
- 03:16 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- ETF testing failed immediately because the DMO ASM code used the old BDT @assign@ signatures. Once I fixed this (comm...
12/05/2017
- 01:00 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- I need to investigate more thoroughly, but my initial thoughts:
@RecordBuffer$Handler.invoke@: should be safe to r... - 12:45 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- I will post more details of the problem and the proposed solution shortly. But for now, I have a question.
The pe... - 11:16 AM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow
- Created task branch 3406a. The changes for this task are going to be in a sensitive area and will affect many files.
12/04/2017
- 08:38 AM Bug #3406 (Closed): implement silent error mode as a lambda to allow aborting the control flow
12/03/2017
- 09:13 AM Bug #3400: shared variables context for RUN int-proc IN ext-proc-handle is not properly pushed
- Greg Shah wrote:
> Code Review Task Branch 3394a Revision 11225
>
> 1. In @ProcedureManager.searchInStack()@, why... - 12:56 AM Bug #3400: shared variables context for RUN int-proc IN ext-proc-handle is not properly pushed
- Code Review Task Branch 3394a Revision 11225
1. In @ProcedureManager.searchInStack()@, why use a map as @searched@...
12/02/2017
- 02:38 PM Bug #3400: shared variables context for RUN int-proc IN ext-proc-handle is not properly pushed
- The fixes are in 3394a rev 11225
In the end, the problem was that the lookup for shared vars must be performed on ...
12/01/2017
- 10:47 AM Feature #3262: implement COM/OLE Automation support
- Task branch @3262b@ has been updated for review to revision @11248@.
Adding protection for null characters passed ... - 10:45 PM Feature #3262: implement COM/OLE Automation support
- During testing COM feature with big application found new issues:
1. The file resources to be taken from application... - 10:11 PM Feature #3262: implement COM/OLE Automation support
- > Is it OK to leave this feature postponed?
Yes, you can match the support level of the Java code. - 09:50 PM Feature #3262: implement COM/OLE Automation support
- Task branch @3262b@ has been updated for review to revision @11247@.
OK. This update returns native code to the st... - 07:14 PM Feature #3262: implement COM/OLE Automation support
- Constantin Asofiei wrote:
> > So for now you offer to have nothing extent array support.
> Yes, because the correct... - 08:21 AM Bug #3400: shared variables context for RUN int-proc IN ext-proc-handle is not properly pushed
- The main problems I identified are:
# a shared-var leak for persistent procedures (they are not being removed when t... - 08:19 AM Bug #3400 (Closed): shared variables context for RUN int-proc IN ext-proc-handle is not properly ...
11/30/2017
- 05:53 PM Feature #3396: shift searchpath and other pathing lists in the directory to use the platform neut...
- I almost completely forgot about #3225. I took a quick look over it. The 3225b contains only a single altered file: @...
- 04:51 PM Feature #3396: shift searchpath and other pathing lists in the directory to use the platform neut...
- The @searchpath@ is the @directory.xml@ value that is used by the FWD runtime to represent the @PROPATH@. Since FWD ...
- 05:14 PM Feature #3262: implement COM/OLE Automation support
- Guys,
More complex approach can be to introduce new class for results coming from native side to Java, say @ComRet... - 04:55 PM Feature #3262: implement COM/OLE Automation support
- Eugenie Lyzenko wrote:
> Another word as I can see you removed (undone) all recent changes prepared to handle extent... - 04:50 PM Feature #3262: implement COM/OLE Automation support
- Constantin Asofiei wrote:
> Eugenie, please see 3262b rev 11246. Note that you will need to have some changes in th... - 04:15 PM Feature #3262: implement COM/OLE Automation support
- Eugenie, please see 3262b rev 11246. Note that you will need to have some changes in the FWD native COM part, becaus...
- 01:01 PM Feature #3262: implement COM/OLE Automation support
- Yes. I didn't start yet to fix the branch, I'll try tonight or tomorrow the latest.
- 12:57 PM Feature #3262: implement COM/OLE Automation support
- Yes, we have signature match issue. Like this when @FWD@ expects @comhandle.call()@ returning @BDT@ while our @comhan...
- 11:53 AM Feature #3262: implement COM/OLE Automation support
- Greg Shah wrote:
> Code Review Task Branch 3262b Revision 11244
>
> I've checked in some changes as 11245. I'm g... - 11:00 AM Feature #3262: implement COM/OLE Automation support
- Code Review Task Branch 3262b Revision 11244
I've checked in some changes as 11245. I'm good with that version. ... - 09:28 AM Feature #3262: implement COM/OLE Automation support
- Task branch @3262b@ has been updated for review to revision @11244@.
The notes resolution changes. Optional @NO-CO... - 08:47 AM Feature #3262: implement COM/OLE Automation support
- Greg Shah wrote:
> Code Review Task Branch 3262b Revision 11243
>
> 1. Please make the 4th parameter to @launch()... - 06:07 AM Feature #3262: implement COM/OLE Automation support
- Code Review Task Branch 3262b Revision 11243
1. Please make the 4th parameter to @launch()@ optional. This means ... - 10:42 PM Feature #3262: implement COM/OLE Automation support
- Task branch @3262b@ has been updated for review to revision @11243@.
This is minor javadoc fixes for my recent cha... - 09:47 PM Feature #3262: implement COM/OLE Automation support
- Task branch @3262b@ has been rebased with recent trunk @11208@, new version is @11242@.
- 09:27 PM Feature #3262: implement COM/OLE Automation support
- Task branch @3262b@ has been updated for review to revision @11241@.
This update fixes the handling of the @NO-WAI...
11/29/2017
- 05:15 PM Feature #3262: implement COM/OLE Automation support
- > Is this OK?
Yes.
> Observing the rule file for process launch I see we do not have any support for NO-CONSOLE... - 02:58 PM Feature #3262: implement COM/OLE Automation support
- For Windows @SILENT@ option I suggest to change the @ProcessDaemon@ class to take into account the same reaction for ...
- 11:19 AM Feature #3262: implement COM/OLE Automation support
- > For example notepad.exe and regedit.exe cause the 4GL application to finish external app to continue after os-comm...
- 11:15 AM Feature #3262: implement COM/OLE Automation support
- Constantin Asofiei wrote:
> Eugenie, I've tried this simple program, with @pro@, @prowin@ and from procedure editor,... - 11:12 AM Feature #3262: implement COM/OLE Automation support
- Yes, @notepad.exe@, @regedit.exe@, also @write.exe@ can be started with @no-console@ option. However the behavior is ...
- 11:05 AM Feature #3262: implement COM/OLE Automation support
- Greg Shah wrote:
> Are you testing with OpenEdge 11.6?
@11.6.3@. - 10:28 AM Feature #3262: implement COM/OLE Automation support
- Eugenie, I've tried this simple program, with @pro@, @prowin@ and from procedure editor, and it opens the @notepad.ex...
- 10:27 AM Feature #3262: implement COM/OLE Automation support
- Greg Shah wrote:
> Try running a program that has no GUI and which also can be made to run without STDIN/STDOUT/STDE... - 08:59 AM Feature #3262: implement COM/OLE Automation support
- Try running a program that has no GUI and which also can be made to run without STDIN/STDOUT/STDERR. In other words,...
- 08:24 AM Feature #3262: implement COM/OLE Automation support
- Are you testing with OpenEdge 11.6?
- 08:11 AM Feature #3262: implement COM/OLE Automation support
- Greg Shah wrote:
> @dir@ is an internal feature of the @cmd.exe@ shell. It won't work without the shell. But launc... - 07:43 AM Feature #3262: implement COM/OLE Automation support
- @dir@ is an internal feature of the @cmd.exe@ shell. It won't work without the shell. But launching a @.exe@ progra...
- 07:39 AM Feature #3262: implement COM/OLE Automation support
- Greg Shah wrote:
> I will review the changes shortly.
>
> > NO-CONSOLE - does not start any child process in GUI.... - 06:02 AM Feature #3262: implement COM/OLE Automation support
- I will review the changes shortly.
> NO-CONSOLE - does not start any child process in GUI.
I don't understand w... - 09:22 PM Feature #3262: implement COM/OLE Automation support
- Task branch @3262b@ has been updated for review to revision @11240@.
The change adds initial step to turn the chil...
11/28/2017
- 06:51 PM Feature #3262: implement COM/OLE Automation support
- The testcases repo has been updated to revision @1705@.
The child process starting testcases added for @GUI@ mode ... - 05:59 PM Feature #3262: implement COM/OLE Automation support
- Greg Shah wrote:
>
> Please check the @NO-WAIT@, @SILENT@ and @NO-CONSOLE@ options. I suspect the @NO-WAIT@ is pr... - 03:56 PM Feature #3262: implement COM/OLE Automation support
- Task branch @3262b@ has been rebased with trunk @11207@, new revision is @11239@.
- 03:47 PM Feature #3262: implement COM/OLE Automation support
- Starting the rebase.
- 03:45 PM Feature #3262: implement COM/OLE Automation support
- Constantin Asofiei wrote:
> Greg/Eugenie: I plan to make the Java code in 3262b generic enough so that we will be ab... - 03:44 PM Feature #3262: implement COM/OLE Automation support
- > >Eugenie: Would you please run some testcases to see how the interactive child process launching works under GUI? I...
- 03:42 PM Feature #3262: implement COM/OLE Automation support
- Greg/Eugenie: I plan to make the Java code in 3262b generic enough so that we will be able to add the missing extent ...
- 03:32 PM Feature #3262: implement COM/OLE Automation support
- Planning to rebase the branch with the recent trunk in a 10 min. if nobody objects.
- 03:27 PM Feature #3262: implement COM/OLE Automation support
- Greg Shah wrote:
>Eugenie: Would you please run some testcases to see how the interactive child process launching wo... - 03:19 PM Feature #3262: implement COM/OLE Automation support
- Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> > Eugenie Lyzenko wrote:
> > > Constantin Asofiei wrote:
> >... - 03:17 PM Feature #3262: implement COM/OLE Automation support
- Constantin Asofiei wrote:
> Eugenie Lyzenko wrote:
> > Constantin Asofiei wrote:
> > >Eugenie: the large GUI app w... - 03:06 PM Feature #3262: implement COM/OLE Automation support
- Greg Shah wrote:
> Code Review Task Branch 3262b Revision 11234
> ...
>4. The changes in comauto_win.c are so exte... - 02:42 PM Feature #3262: implement COM/OLE Automation support
- Task branch @3262b@ has been updated for review to revision @11238@.
Undo the @EnvironmentOps@ change that fixes t... - 02:29 PM Feature #3262: implement COM/OLE Automation support
- Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> >Eugenie: the large GUI app we are using has constructs like S... - 02:27 PM Feature #3262: implement COM/OLE Automation support
- Constantin Asofiei wrote:
>Eugenie: the large GUI app we are using has constructs like STRING(com-var:property) - th... - 02:25 PM Feature #3262: implement COM/OLE Automation support
- Constantin Asofiei wrote:
> Greg Shah wrote:
> > It seems we should just continue the work in this branch to finish... - 02:24 PM Feature #3262: implement COM/OLE Automation support
- > The FWD executes ProcessDaemon.launch() for START EXCEL.EXE some_file.csv. This causes the ChildProcessFactory.getC...
- 02:16 PM Feature #3262: implement COM/OLE Automation support
- Eugenie Lyzenko wrote:
> Greg Shah wrote:
> > Code Review Task Branch 3262b Revision 11234
> >
> >1. In assignme... - 02:15 PM Feature #3262: implement COM/OLE Automation support
- Greg Shah wrote:
> It seems we should just continue the work in this branch to finish the extent support, rather tha... - 02:14 PM Feature #3262: implement COM/OLE Automation support
- Greg Shah wrote:
> Code Review Task Branch 3262b Revision 11234
>
>1. In assignments.rules, the newly added code ... - 02:13 PM Feature #3262: implement COM/OLE Automation support
- It seems we should just continue the work in this branch to finish the extent support, rather than reverting it all.
- 02:00 PM Feature #3262: implement COM/OLE Automation support
- Greg Shah wrote:
> Constantin: Do you have any concerns about the changes in this branch?
I've fixed some cases (re... - 01:58 PM Feature #3262: implement COM/OLE Automation support
- Greg Shah wrote:
> Code Review Task Branch 3262b Revision 11234
>
> 3. The @EnvironmentOps@ change is not correct... - 01:56 PM Feature #3262: implement COM/OLE Automation support
- Greg Shah wrote:
> > found the cases that use COM prefixed with starting EXCEL.EXE as subprocess which is currently ... - 12:26 PM Feature #3262: implement COM/OLE Automation support
- Constantin: Do you have any concerns about the changes in this branch?
- 12:25 PM Feature #3262: implement COM/OLE Automation support
- > found the cases that use COM prefixed with starting EXCEL.EXE as subprocess which is currently not supported in FWD...
- 12:23 PM Feature #3262: implement COM/OLE Automation support
- Code Review Task Branch 3262b Revision 11234
1. In @assignments.rules@, the newly added code is disabled because o... - 12:13 PM Feature #3396 (WIP): shift searchpath and other pathing lists in the directory to use the platfor...
11/27/2017
- 06:15 PM Feature #3262: implement COM/OLE Automation support
- Task branch @3262b@ has been updated for review to revision @11233@, rebased with recent trunk, new version is @11234...
11/26/2017
- 04:54 PM Feature #3262: implement COM/OLE Automation support
- Task branch @3262b@ has been updated for review to revision @11232@.
Added fix for @propath@ variation. Allows hav...
Also available in: Atom