Activity

From 11/29/2017 to 12/28/2017

12/22/2017

06:35 PM Feature #3262: implement COM/OLE Automation support: The revision @11308@ gives the same converted code for @COM@ sample testcases I have used in @COM@ native implementat... Eugenie Lyzenko
05:22 PM Feature #3262: implement COM/OLE Automation support: There is an issue with how we convert LOAD-CONTROLS. We've decide to treat every COM access as a generic call (witho... Constantin Asofiei
09:12 AM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: Greg Shah wrote:
> > in ControlFlowOps - is the H061 still needed?
>
> No, not after trunk rev 11213.
Backed ou... Constantin Asofiei
09:05 AM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: > in ControlFlowOps - is the H061 still needed?
No, not after trunk rev 11213. Greg Shah
08:31 AM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: Greg, in @ControlFlowOps@ - is the H061 still needed?... Constantin Asofiei
12:54 AM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: 3406a/11232 has passed ETF search, dev, and batch testing, main regression testing, and ctrl+c testing. The branch wa... Eric Faulhaber
08:25 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: Follow-up: I tested with trunk; same error.
However, it's fixed in 3394a (tested with 11299), so... never mind. Eric Faulhaber
08:01 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: Is this a known Hotel GUI issue? I hit this while trying to check in a guest on the "Available" screen first thing af... Eric Faulhaber

12/21/2017

05:21 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: I have manually tested Hotel GUI (Swing, Virtual Desktop and Embedded Modes) in both 3406a (11232) and trunk (11212).... Greg Shah
11:25 AM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: Task branch 3406a has been rebased to p2j trunk revision 11212. Eric Faulhaber
01:25 AM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: 3406a/11226 has passed dev, search, and batch ETF testing. Two runs of main runtime regression testing show a handful... Eric Faulhaber
06:03 AM Feature #3262: implement COM/OLE Automation support: Branch @3262b@ was merged to trunk as revno @11212@ then it was archived. Eugenie Lyzenko
05:57 AM Feature #3262: implement COM/OLE Automation support: Greg Shah wrote:
> Please merge 3262b to trunk.
OK. Starting. Eugenie Lyzenko
04:56 AM Feature #3262: implement COM/OLE Automation support: Please merge 3262b to trunk. Greg Shah
09:39 PM Feature #3262: implement COM/OLE Automation support: Testing completed. No regressions have been found. The results: @3262b_11251_a5eeab0_20171220_evl.zip@.
So the bra... Eugenie Lyzenko
08:07 PM Feature #3262: implement COM/OLE Automation support: The main cycle completed. No regression. Running @CTRL-C@ part.
Can I merge into trunk if no regressions for @CTRL... Eugenie Lyzenko

12/20/2017

05:54 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: It's not the case. Stanislav Lomany
05:53 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: OK, then please hold off on updating this branch, unless you believe these changes are necessary to making the new er... Eric Faulhaber
05:39 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: > OK, please put it in and I'll restart testing.
That may require some time because is not yet ready. Stanislav Lomany
05:16 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: OK, please put it in and I'll restart testing. Eric Faulhaber
05:09 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: No, its not risky, just minor fix which IIRC doesn't affect regression testing. Stanislav Lomany
05:03 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: Stanislav Lomany wrote:
> I wanted to fix TODOs and error in processing in one place, but can do that in another bra... Eric Faulhaber
04:54 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: I wanted to fix TODOs and error in processing in one place, but can do that in another branch. Stanislav Lomany
04:35 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: So, are we expecting any more code changes at this point, or is revision 11226 what we're testing? Actually, I alread... Eric Faulhaber
04:27 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: The TODOs in 3406a rev 11226:
# @SharedVariableManager.errorHelper@ - this is used when there is a problem resolving... Constantin Asofiei
03:21 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: > @ErrorManager.recordOrShowError@ or @ErrorManager.recordOrThrowError@?
@ErrorManager.recordOrShowError@ Stanislav Lomany
03:01 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: Greg Shah wrote:
> I've also added TODO and ECF_TODO comments in other locations that need review.
>
> Eric: Plea... Eric Faulhaber
02:56 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: Stanislav Lomany wrote:
> > Stanislav: Please look at @Browse@ and @BrowseWidget@ for the TODOs I've added.
>
> T... Greg Shah
02:52 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: Our original approach to silent error mode was to bracket each NO-ERROR statement (or assignment or standalone expres... Greg Shah
02:33 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: > Stanislav: Please look at @Browse@ and @BrowseWidget@ for the TODOs I've added.
These exceptions serve the purpo... Stanislav Lomany
12:30 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: Per our offline discussion, revision 11225 enables the re-throw of the error condition inside the silent worker's cat... Greg Shah
04:11 AM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: Revision 3406a/11224 almost resolves the deferred validation issue, except instead of the pause and "Press space bar ... Eric Faulhaber
03:28 AM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: The issue for at least two of the tests (a concurrent pair) is that the harness is expecting a validation failure (un... Eric Faulhaber
11:29 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: 3406a/11223 passed ETF developer testing, but failed regular regression testing twice with 4 of the same tests failin... Eric Faulhaber
04:44 PM Feature #3262: implement COM/OLE Automation support: Conversion testing has been passed, code trees are identical. Continue with runtime testing. Eugenie Lyzenko
11:19 AM Feature #3262: implement COM/OLE Automation support: Task branch @3262b@ has been rebased with recent trunk @11211@, new version is @11251@. Eugenie Lyzenko
10:53 AM Feature #3262: implement COM/OLE Automation support: Greg Shah wrote:
> > There is an issues with getting the file resources (Excel files templates) from application *.j... Eugenie Lyzenko
10:41 AM Feature #3262: implement COM/OLE Automation support: Greg Shah wrote:
> > The rules were changed, so conversion test is required I guess. Also safe harness run is desira... Eugenie Lyzenko
10:39 AM Feature #3262: implement COM/OLE Automation support: > The rules were changed, so conversion test is required I guess. Also safe harness run is desirable to make sure we ... Greg Shah
10:33 AM Feature #3262: implement COM/OLE Automation support: Greg Shah wrote:
> > I think we can test and merge 3262b into trunk and defer other work to 3262c.
>
> What testi... Eugenie Lyzenko
10:26 AM Feature #3262: implement COM/OLE Automation support: > There is an issues with getting the file resources (Excel files templates) from application *.jar files.
Are the... Greg Shah
10:09 AM Feature #3262: implement COM/OLE Automation support: Greg Shah wrote:
>How safe is the 3262b branch at this point? Is it suitable for merge to trunk or is there known wo... Eugenie Lyzenko
09:45 AM Feature #3262: implement COM/OLE Automation support: How safe is the 3262b branch at this point? Is it suitable for merge to trunk or is there known work needed?
I kn... Greg Shah

12/17/2017

05:13 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: Unfortunately, the ChUI app regression testing fails with the same core regressions that have been happening earlier ... Greg Shah
10:38 AM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: ETF batch tests passed. If it passes regular regression testing, I think this revision can be merged to trunk. Eric Faulhaber
02:16 AM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: Greg, 3406a/11222 has passed ETF search and dev tests (2 clean runs of the latter). I am testing batch next, but plea... Eric Faulhaber

12/16/2017

09:02 AM Feature #3262: implement COM/OLE Automation support: Task branch @3262b@ has been rebased with recent trunk @11210@, new version is @11250@. Eugenie Lyzenko

12/12/2017

11:35 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: Investigation so far shows that the 4GL's where clause processing and error handling is a bit different than ours. An... Eric Faulhaber

12/09/2017

05:01 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: The root cause of the first failing test is that the new code in @AbstractQuery.preprocessSubstitutionArguments@ does... Eric Faulhaber
04:08 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: The errors I've looked at so far seem to be cases of @P2JQuery.Parameter@ lambda expressions being passed too far alo... Eric Faulhaber
03:16 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: ETF testing failed immediately because the DMO ASM code used the old BDT @assign@ signatures. Once I fixed this (comm... Eric Faulhaber

12/05/2017

01:00 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: I need to investigate more thoroughly, but my initial thoughts:
@RecordBuffer$Handler.invoke@: should be safe to r... Eric Faulhaber
12:45 PM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: I will post more details of the problem and the proposed solution shortly. But for now, I have a question.
The pe... Greg Shah
11:16 AM Bug #3406: implement silent error mode as a lambda to allow aborting the control flow: Created task branch 3406a. The changes for this task are going to be in a sensitive area and will affect many files. Greg Shah

12/04/2017

08:38 AM Bug #3406 (Closed): implement silent error mode as a lambda to allow aborting the control flow: Greg Shah

12/03/2017

09:13 AM Bug #3400: shared variables context for RUN int-proc IN ext-proc-handle is not properly pushed: Greg Shah wrote:
> Code Review Task Branch 3394a Revision 11225
>
> 1. In @ProcedureManager.searchInStack()@, why... Constantin Asofiei
12:56 AM Bug #3400: shared variables context for RUN int-proc IN ext-proc-handle is not properly pushed: Code Review Task Branch 3394a Revision 11225
1. In @ProcedureManager.searchInStack()@, why use a map as @searched@... Greg Shah

12/02/2017

02:38 PM Bug #3400: shared variables context for RUN int-proc IN ext-proc-handle is not properly pushed: The fixes are in 3394a rev 11225
In the end, the problem was that the lookup for shared vars must be performed on ... Constantin Asofiei

12/01/2017

10:47 AM Feature #3262: implement COM/OLE Automation support: Task branch @3262b@ has been updated for review to revision @11248@.
Adding protection for null characters passed ... Eugenie Lyzenko
10:45 PM Feature #3262: implement COM/OLE Automation support: During testing COM feature with big application found new issues:
1. The file resources to be taken from application... Eugenie Lyzenko
10:11 PM Feature #3262: implement COM/OLE Automation support: > Is it OK to leave this feature postponed?
Yes, you can match the support level of the Java code. Greg Shah
09:50 PM Feature #3262: implement COM/OLE Automation support: Task branch @3262b@ has been updated for review to revision @11247@.
OK. This update returns native code to the st... Eugenie Lyzenko
07:14 PM Feature #3262: implement COM/OLE Automation support: Constantin Asofiei wrote:
> > So for now you offer to have nothing extent array support.
> Yes, because the correct... Eugenie Lyzenko
08:21 AM Bug #3400: shared variables context for RUN int-proc IN ext-proc-handle is not properly pushed: The main problems I identified are:
# a shared-var leak for persistent procedures (they are not being removed when t... Constantin Asofiei
08:19 AM Bug #3400 (Closed): shared variables context for RUN int-proc IN ext-proc-handle is not properly ...: Constantin Asofiei

11/30/2017

05:53 PM Feature #3396: shift searchpath and other pathing lists in the directory to use the platform neut...: I almost completely forgot about #3225. I took a quick look over it. The 3225b contains only a single altered file: @... Ovidiu Maxiniuc
04:51 PM Feature #3396: shift searchpath and other pathing lists in the directory to use the platform neut...: The @searchpath@ is the @directory.xml@ value that is used by the FWD runtime to represent the @PROPATH@. Since FWD ... Greg Shah
05:14 PM Feature #3262: implement COM/OLE Automation support: Guys,
More complex approach can be to introduce new class for results coming from native side to Java, say @ComRet... Eugenie Lyzenko
04:55 PM Feature #3262: implement COM/OLE Automation support: Eugenie Lyzenko wrote:
> Another word as I can see you removed (undone) all recent changes prepared to handle extent... Constantin Asofiei
04:50 PM Feature #3262: implement COM/OLE Automation support: Constantin Asofiei wrote:
> Eugenie, please see 3262b rev 11246. Note that you will need to have some changes in th... Eugenie Lyzenko
04:15 PM Feature #3262: implement COM/OLE Automation support: Eugenie, please see 3262b rev 11246. Note that you will need to have some changes in the FWD native COM part, becaus... Constantin Asofiei
01:01 PM Feature #3262: implement COM/OLE Automation support: Yes. I didn't start yet to fix the branch, I'll try tonight or tomorrow the latest. Constantin Asofiei
12:57 PM Feature #3262: implement COM/OLE Automation support: Yes, we have signature match issue. Like this when @FWD@ expects @comhandle.call()@ returning @BDT@ while our @comhan... Eugenie Lyzenko
11:53 AM Feature #3262: implement COM/OLE Automation support: Greg Shah wrote:
> Code Review Task Branch 3262b Revision 11244
>
> I've checked in some changes as 11245. I'm g... Eugenie Lyzenko
11:00 AM Feature #3262: implement COM/OLE Automation support: Code Review Task Branch 3262b Revision 11244
I've checked in some changes as 11245. I'm good with that version. ... Greg Shah
09:28 AM Feature #3262: implement COM/OLE Automation support: Task branch @3262b@ has been updated for review to revision @11244@.
The notes resolution changes. Optional @NO-CO... Eugenie Lyzenko
08:47 AM Feature #3262: implement COM/OLE Automation support: Greg Shah wrote:
> Code Review Task Branch 3262b Revision 11243
>
> 1. Please make the 4th parameter to @launch()... Eugenie Lyzenko
06:07 AM Feature #3262: implement COM/OLE Automation support: Code Review Task Branch 3262b Revision 11243
1. Please make the 4th parameter to @launch()@ optional. This means ... Greg Shah
10:42 PM Feature #3262: implement COM/OLE Automation support: Task branch @3262b@ has been updated for review to revision @11243@.
This is minor javadoc fixes for my recent cha... Eugenie Lyzenko
09:47 PM Feature #3262: implement COM/OLE Automation support: Task branch @3262b@ has been rebased with recent trunk @11208@, new version is @11242@. Eugenie Lyzenko
09:27 PM Feature #3262: implement COM/OLE Automation support: Task branch @3262b@ has been updated for review to revision @11241@.
This update fixes the handling of the @NO-WAI... Eugenie Lyzenko

11/29/2017

05:15 PM Feature #3262: implement COM/OLE Automation support: > Is this OK?
Yes.
> Observing the rule file for process launch I see we do not have any support for NO-CONSOLE... Greg Shah
02:58 PM Feature #3262: implement COM/OLE Automation support: For Windows @SILENT@ option I suggest to change the @ProcessDaemon@ class to take into account the same reaction for ... Eugenie Lyzenko
11:19 AM Feature #3262: implement COM/OLE Automation support: > For example notepad.exe and regedit.exe cause the 4GL application to finish external app to continue after os-comm... Greg Shah
11:15 AM Feature #3262: implement COM/OLE Automation support: Constantin Asofiei wrote:
> Eugenie, I've tried this simple program, with @pro@, @prowin@ and from procedure editor,... Eugenie Lyzenko
11:12 AM Feature #3262: implement COM/OLE Automation support: Yes, @notepad.exe@, @regedit.exe@, also @write.exe@ can be started with @no-console@ option. However the behavior is ... Eugenie Lyzenko
11:05 AM Feature #3262: implement COM/OLE Automation support: Greg Shah wrote:
> Are you testing with OpenEdge 11.6?
@11.6.3@. Eugenie Lyzenko
10:28 AM Feature #3262: implement COM/OLE Automation support: Eugenie, I've tried this simple program, with @pro@, @prowin@ and from procedure editor, and it opens the @notepad.ex... Constantin Asofiei
10:27 AM Feature #3262: implement COM/OLE Automation support: Greg Shah wrote:
> Try running a program that has no GUI and which also can be made to run without STDIN/STDOUT/STDE... Hynek Cihlar
08:59 AM Feature #3262: implement COM/OLE Automation support: Try running a program that has no GUI and which also can be made to run without STDIN/STDOUT/STDERR. In other words,... Greg Shah
08:24 AM Feature #3262: implement COM/OLE Automation support: Are you testing with OpenEdge 11.6? Greg Shah
08:11 AM Feature #3262: implement COM/OLE Automation support: Greg Shah wrote:
> @dir@ is an internal feature of the @cmd.exe@ shell. It won't work without the shell. But launc... Eugenie Lyzenko
07:43 AM Feature #3262: implement COM/OLE Automation support: @dir@ is an internal feature of the @cmd.exe@ shell. It won't work without the shell. But launching a @.exe@ progra... Greg Shah
07:39 AM Feature #3262: implement COM/OLE Automation support: Greg Shah wrote:
> I will review the changes shortly.
>
> > NO-CONSOLE - does not start any child process in GUI.... Eugenie Lyzenko
06:02 AM Feature #3262: implement COM/OLE Automation support: I will review the changes shortly.
> NO-CONSOLE - does not start any child process in GUI.
I don't understand w... Greg Shah

« Previous

Also available in: Atom

Project

General

Profile

FWD » Core Development » Base Language

Activity

Activity

12/28/2017

12/25/2017

12/23/2017

12/22/2017

12/21/2017

12/20/2017

12/17/2017

12/16/2017

12/12/2017

12/09/2017

12/05/2017

12/04/2017

12/03/2017

12/02/2017

12/01/2017

11/30/2017

11/29/2017