Activity
From 11/24/2019 to 12/23/2019
12/23/2019
- 11:53 AM Bug #4427: Unable to convert keyword input when used to index into an extent
- What is @dynamicindex@ annotation used for? I'm trying to determine why the LBRACKET subtree is duplicated in @input_...
12/20/2019
- 04:54 PM Bug #4427: Unable to convert keyword input when used to index into an extent
- Roger Borrello wrote:
> I looked at a much simpler case of using @input mynum@ then @input mybuff[mynum]@ instead of... - 04:02 PM Bug #4427: Unable to convert keyword input when used to index into an extent
- I looked at a much simpler case of using @input mynum@ then @input mybuff[mynum]@ instead of the more complicated, ne...
- 02:52 PM Bug #4160: Arrays assigment issue
- Constantin Asofiei wrote:
> Greg Shah wrote:
> > > a bug in ArrayAssigner - when is defined, a dynamic extent var g... - 01:06 PM Bug #4160: Arrays assigment issue
- Roger Borrello wrote:
> Does this mean the testcase is invalid? Or is there a bug? I was using 4207a, not trunk.
I ... - 01:04 PM Bug #4160: Arrays assigment issue
- Constantin Asofiei wrote:
> The above is from trunk: @if false then accum "third" (count).@ is marked as unreachable... - 12:57 PM Bug #4160: Arrays assigment issue
- Greg Shah wrote:
> > a bug in ArrayAssigner - when is defined, a dynamic extent var gets registered with the previou... - 12:07 PM Bug #4160: Arrays assigment issue
- The above is from trunk: @if false then accum "third" (count).@ is marked as unreachable, which is not correct. Any a...
- 11:56 AM Bug #4160: Arrays assigment issue
- Constantin Asofiei wrote:
> Roger Borrello wrote:
> > Roger Borrello wrote:
> > > I think there is a regression. S... - 10:24 AM Bug #4160: Arrays assigment issue
- Roger Borrello wrote:
> Roger Borrello wrote:
> > I think there is a regression. See testcase below. In fact, I jus... - 09:58 AM Bug #4160: Arrays assigment issue
- Roger Borrello wrote:
> I think there is a regression. See testcase below. In fact, I just ran *4207a* against @uast... - 09:56 AM Bug #4160: Arrays assigment issue
- I think there is a regression. See testcase below. In fact, I just ran *4207a* against @uast/accum_scope*.p" and ther...
- 09:36 AM Bug #4160: Arrays assigment issue
- > use a special wrapper (so that we can make even the dynamic extent vars 'mutable', maybe limited to shared cases)
... - 09:33 AM Bug #4160: Arrays assigment issue
- > a bug in ArrayAssigner - when is defined, a dynamic extent var gets registered with the previous scope, and not the...
- 01:09 PM Bug #4484: Accumulator confusion using same field for count and total
- Constantin Asofiei wrote:
> Argh, there was another typo. fixed in 11366
Great... this update worked! We need to ... - 12:45 PM Bug #4484: Accumulator confusion using same field for count and total
- Argh, there was another typo. fixed in 11366
- 12:12 PM Bug #4484: Accumulator confusion using same field for count and total
- Just reporting that there is another scenario which creates a hidden FieldRef. I checked in @uast/accum/accum_count_h...
- 10:02 AM Bug #4484: Accumulator confusion using same field for count and total
- Roger Borrello wrote:
> Constantin Asofiei wrote:
> > Roger, see 4207a rev 11362, it should fix the issue.
>
> I... - 10:00 AM Bug #4484: Accumulator confusion using same field for count and total
- Constantin Asofiei wrote:
> Roger, see 4207a rev 11362, it should fix the issue.
I'll take a look - 09:31 AM Bug #4484: Accumulator confusion using same field for count and total
- Roger, see 4207a rev 11362, it should fix the issue.
- 07:12 PM Bug #4484: Accumulator confusion using same field for count and total
- Found a subsequent error, when multiple accumulators are on the same statement.
Added a new testcase @uast/accum_s... - 12:34 PM Bug #4480: Extent does not become fixed when there is an initial list of values
- Greg Shah wrote:
> > The updated ended up being in Variable.java, so updated to progress.g are unnecessary. However,... - 11:42 AM Bug #4480: Extent does not become fixed when there is an initial list of values
- > The updated ended up being in Variable.java, so updated to progress.g are unnecessary. However, the changes could b...
12/19/2019
- 06:36 PM Bug #4160: Arrays assigment issue
- Constantin Asofiei wrote:
> Ah, and I just realized something - for variables scoped to the external program, we sho... - 03:48 PM Bug #4160: Arrays assigment issue
- The conversion fixes are in 4207a rev 11360. It also moves the @ExtentExpr@ to anon classes, to get rid of the param...
- 02:44 PM Bug #4160: Arrays assigment issue
- I have a conversion fix for the INPUT and normal variable, but I'm working also on getting rid of the promotion of th...
- 12:53 PM Bug #4160: Arrays assigment issue
- And another side-note, in case of OE class properties, we are missing:
* getter which returns the extent var (withou... - 12:46 PM Bug #4160: Arrays assigment issue
- Greg, as a side note: for shared variables, if there is a dynamic extent case, then this solution will not work (as t...
- 12:06 PM Bug #4160: Arrays assigment issue
- Greg Shah wrote:
> OK. Can you please add that change to 4207a?
OK, will do. - 12:04 PM Bug #4160: Arrays assigment issue
- OK. Can you please add that change to 4207a?
- 11:47 AM Bug #4160: Arrays assigment issue
- Greg, the @ref[0]@ approach was added, but only for OUTPUT parameters (I really don't recall why I did it only for th...
- 11:38 AM Bug #4160: Arrays assigment issue
- Indeterminate arrays are profoundly broken in the current FWD trunk. This task and #4123 show two very simple cases ...
- 01:47 PM Bug #4480 (WIP): Extent does not become fixed when there is an initial list of values
- 01:47 PM Bug #4480: Extent does not become fixed when there is an initial list of values
- *Code checked into 4207a-11359.*
- 01:42 PM Bug #4480: Extent does not become fixed when there is an initial list of values
- h2. Testcases Converted and Compiled.
@form_with_extent.p@... - 01:18 PM Bug #4480: Extent does not become fixed when there is an initial list of values
- Roger Borrello wrote:
> Greg Shah wrote:
> > > But: the same might apply to OO properties, table fields and procedu...
12/18/2019
- 04:52 PM Bug #4484 (WIP): Accumulator confusion using same field for count and total
- 04:51 PM Bug #4484: Accumulator confusion using same field for count and total
- Update to @rules/annotations/accumulate.rules@ checked into @4207a-11358@.
- 04:34 PM Bug #4484: Accumulator confusion using same field for count and total
- Constantin Asofiei wrote:
> Roger, please check this patch:
> [...]
>
> The problem was that the check if the ex... - 04:24 PM Bug #4484: Accumulator confusion using same field for count and total
- Roger, please check this patch:...
- 04:08 PM Bug #4484: Accumulator confusion using same field for count and total
- Constantin Asofiei wrote:
> Check the other @KW_ACCUM/EXPRESSION@ nodes. Once COUNT is encountered, any @ STATEMENT... - 03:34 PM Bug #4484: Accumulator confusion using same field for count and total
- Check the other @KW_ACCUM/EXPRESSION@ nodes. Once COUNT is encountered, any @ STATEMENT/KW_ACCUM/EXPRESSION@ will ha...
- 03:25 PM Bug #4484: Accumulator confusion using same field for count and total
- Roger Borrello wrote:
> Constantin Asofiei wrote:
> > Roger, there's another different in the AST: look for the @hi... - 01:53 PM Bug #4484: Accumulator confusion using same field for count and total
- Constantin Asofiei wrote:
> Roger, there's another different in the AST: look for the @hidden@ attribute at the AST ... - 01:47 PM Bug #4484: Accumulator confusion using same field for count and total
- Roger, there's another different in the AST: look for the @hidden@ attribute at the AST node; this depends on the @su...
- 01:37 PM Bug #4484: Accumulator confusion using same field for count and total
- Constantin Asofiei wrote:
> Roger Borrello wrote:
> > I tried that immediately above. It is an issue limited to fie... - 01:34 PM Bug #4484: Accumulator confusion using same field for count and total
- Roger Borrello wrote:
> I tried that immediately above. It is an issue limited to fields. Are we trying to be too _f... - 01:29 PM Bug #4484: Accumulator confusion using same field for count and total
- Constantin Asofiei wrote:
> OK, try this, too:
> [...]
>
> Is normal to declare @i@, as is an explicit var. I'm ... - 01:25 PM Bug #4484: Accumulator confusion using same field for count and total
- OK, try this, too:...
- 01:24 PM Bug #4484: Accumulator confusion using same field for count and total
- Roger Borrello wrote:
> Constantin Asofiei wrote:
> > This works fine in 4GL:
> > [...]
>
> I added count...
>... - 01:20 PM Bug #4484: Accumulator confusion using same field for count and total
- Constantin Asofiei wrote:
> This works fine in 4GL:
> [...]
I added count...... - 01:09 PM Bug #4484: Accumulator confusion using same field for count and total
- This works fine in 4GL:...
- 01:06 PM Bug #4484: Accumulator confusion using same field for count and total
- Constantin Asofiei wrote:
> Roger, is this limited only for fields? Does FWD convert OK if you replace the field wit... - 01:02 PM Bug #4484: Accumulator confusion using same field for count and total
- Roger, is this limited only for fields? Does FWD convert OK if you replace the field with some variable?
- 01:01 PM Bug #4484: Accumulator confusion using same field for count and total
- Roger Borrello wrote:
> Doing some research related to what makes these aggregate functions _order-dependent_.
>
... - 11:04 AM Bug #4484: Accumulator confusion using same field for count and total
- Doing some research related to what makes these aggregate functions _order-dependent_.
+Run 1+...
12/17/2019
- 05:31 PM Bug #4427: Unable to convert keyword input when used to index into an extent
- This still is not fixed, as the java code does not compile. Below is the compilation error of the testcase:...
- 04:58 PM Bug #4484: Accumulator confusion using same field for count and total
- Roger Borrello wrote:
> Roger Borrello wrote:
> > This looks like the culprit...
> >
> > [...]
> >
> > Would ... - 04:26 PM Bug #4484: Accumulator confusion using same field for count and total
- Roger Borrello wrote:
> This looks like the culprit...
>
> [...]
>
> Would it be simple as removing the check ... - 04:09 PM Bug #4484: Accumulator confusion using same field for count and total
- This looks like the culprit......
- 03:59 PM Bug #4484: Accumulator confusion using same field for count and total
- Constantin Asofiei wrote:
> OK, I think this confirms the problem is with COUNT. Look at @process_aggregate@ functi... - 03:46 PM Bug #4484: Accumulator confusion using same field for count and total
- OK, I think this confirms the problem is with COUNT. Look at @process_aggregate@ function in @annotations/accumulate...
- 03:39 PM Bug #4484: Accumulator confusion using same field for count and total
- Constantin Asofiei wrote:
> This might be related to @COUNT@ which doesn't necessarily need the field reference; so,... - 03:32 PM Bug #4484: Accumulator confusion using same field for count and total
- This might be related to @COUNT@ which doesn't necessarily need the field reference; so, please expand your test to r...
- 03:02 PM Bug #4484: Accumulator confusion using same field for count and total
- h1. Testcase
*20191231 Update: Fixed in 4207a-11366*
Checked in: @uast/accum_overlap_count-total.p@... - 02:55 PM Bug #4484 (Closed): Accumulator confusion using same field for count and total
- 03:18 PM Bug #4483 (WIP): Unable to use logical variable check in underline statement
- 03:16 PM Bug #4483: Unable to use logical variable check in underline statement
- Greg Shah wrote:
> The @CONTENT_ARRAY@ is only found in the @MESSAGE@, @ENABLE@, @DISABLE@, @COLOR@ and @UNDERLINE@ ... - 02:59 PM Bug #4483: Unable to use logical variable check in underline statement
- The @CONTENT_ARRAY@ is only found in the @MESSAGE@, @ENABLE@, @DISABLE@, @COLOR@ and @UNDERLINE@ statements, but only...
- 02:06 PM Bug #4483: Unable to use logical variable check in underline statement
- Constantin Asofiei wrote:
> Roger, see the @noUnwrap@ logic - this should decide if @_isEqual@ or @isEqual@ is emitt... - 12:41 PM Bug #4483: Unable to use logical variable check in underline statement
- Roger, see the @noUnwrap@ logic - this should decide if @_isEqual@ or @isEqual@ is emitted, and looks like it depends...
- 11:59 AM Bug #4483: Unable to use logical variable check in underline statement
- Roger Borrello wrote:
> h1. Testcase
>
> Below is the testcase @uast/underline_logic_uses_when.p@:
>
> [...]
... - 11:55 AM Bug #4483: Unable to use logical variable check in underline statement
- h1. Testcase
*20191231 Update: Fixed in 4207a-11357*
Below is the testcase @uast/underline_logic_uses_when.p@:
... - 11:39 AM Bug #4483 (Closed): Unable to use logical variable check in underline statement
- 01:34 PM Bug #4480: Extent does not become fixed when there is an initial list of values
- Greg Shah wrote:
> > But: the same might apply to OO properties, table fields and procedure parameters. So please do... - 10:30 AM Bug #4482: Enable/Disable with empty EXCEPT causes issues
- *Code updates in 4207a-11356.*
@rules/annotations/cleanup.rules@ - 09:27 AM Bug #4482 (WIP): Enable/Disable with empty EXCEPT causes issues
- 09:26 AM Bug #4482: Enable/Disable with empty EXCEPT causes issues
- *20191231 Update: Fixed in 4207a-11356*
There is already a testcase that should have found this: @uast/enable_and_... - 09:23 AM Bug #4482 (Closed): Enable/Disable with empty EXCEPT causes issues
12/16/2019
- 03:50 PM Bug #4480: Extent does not become fixed when there is an initial list of values
- > But: the same might apply to OO properties, table fields and procedure parameters. So please do some tests, and if ...
- 02:26 PM Bug #4480: Extent does not become fixed when there is an initial list of values
- Constantin Asofiei wrote:
> Roger, I agree, I think we need to 'fix' the extent when there is an initializer and no ... - 02:05 PM Bug #4480: Extent does not become fixed when there is an initial list of values
- Roger, I agree, I think we need to 'fix' the extent when there is an initializer and no extent value. For variables,...
- 01:53 PM Bug #4480: Extent does not become fixed when there is an initial list of values
- Roger Borrello wrote:
> h1. Testcase @uast/form_tests/form_with_extent.p@
>
> [...]
>
> The message is *Extent... - 12:45 PM Bug #4480: Extent does not become fixed when there is an initial list of values
- h1. Testcase @uast/form_tests/form_with_extent.p@
*20191231 Update: Checked in 4207a-11365*... - 12:32 PM Bug #4480 (Closed): Extent does not become fixed when there is an initial list of values
- 09:26 AM Bug #4476: Shared frame does not get @ widget method generated
- Roger Borrello wrote:
> h1. Testcase
>
> Added 2 testcases (since it is a shared frame)
>
> [...]
>
> [...]...
12/13/2019
- 05:15 PM Feature #3867: direct java class access from 4GL code
- Greg Shah wrote:
> Constantin: Do you see any flaw in my logic?
No, I can't see any way to jump to the catch block ... - 04:44 PM Feature #3867: direct java class access from 4GL code
- Our current parsing for catch blocks creates an @INNER_BLOCK@ child of the @KW_CATCH@. This results in the following...
- 03:58 PM Bug #4476: Shared frame does not get @ widget method generated
- h1. Testcase
*20200102 Update:* @rules/fixups/inline_format_phrase_var_defs.rules@ checked into *4207a-11369*.
... - 03:40 PM Bug #4476 (Closed): Shared frame does not get @ widget method generated
12/11/2019
- 04:50 PM Bug #4461: DST and add-interval
- My original issue is fixed in 3809e rev 11435, the DateOps change.
- 12:32 PM Bug #4461: DST and add-interval
- I agree that your timestamp approach is probably the right idea for @datetime@/@datetimetz@. We can break the inheri...
- 05:34 AM Bug #4461: DST and add-interval
- This behaviour is somewhat expected. The problem is that we use "convention" time units instead of "physical" axis. O...
- 04:50 PM Bug #4462: NOW with comparison operators
- The fix is in 3809e rev 11435 . The dereference problem (actually any POLY operand) is still postponed.
- 02:56 PM Feature #3854: update appserver support with PASOE features
- Marian, in PASOE, is the format for @server-connection-id@ always @abcdefghijklm_abcdefgh@? (aka 13 chars, underscore...
- 10:10 AM Bug #4455 (WIP): Extent field on unsubscripted next-prompt not converted properly
- 10:01 AM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
- Greg Shah wrote:
> OK, just add a TODO comment in to the array expansion rules to explain that the range case works ... - 09:37 AM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
- OK, just add a TODO comment in to the array expansion rules to explain that the range case works in the 4GL (acts lik...
- 09:33 AM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
- Greg Shah wrote:
> Yes, that is the safe thing to do. Please also report here if the 4GL allows the range case at a... - 09:16 AM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
- Yes, that is the safe thing to do. Please also report here if the 4GL allows the range case at all.
- 09:14 AM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
- Greg Shah wrote:
> Code Review Task Branch 4207a Revisions 11353 - 11354
>
> The changes are good.
>
> The onl... - 09:02 AM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
- Greg Shah wrote:
> Code Review Task Branch 4207a Revisions 11353 - 11354
>
> The changes are good.
>
> The onl...
12/10/2019
- 06:59 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
- Code Review Task Branch 4207a Revisions 11353 - 11354
The changes are good.
The only problem is the range exten... - 06:10 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
- h1. Updated
Below are my updates and findings
h2. rules/annotations/progress_templates.tpl
I have added this... - 05:24 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
- Greg Shah wrote:
> > On line 20, I don't have any subscript. This results in AST generation of:
>
> Are you sayin... - 05:15 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
- > On line 20, I don't have any subscript. This results in AST generation of:
Are you saying that the @input/extent... - 04:28 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
- +*New Testcases*+
I have updated the testcase to not use the @p2j_test.df@, instead using TEMP-TABLE. I also added a... - 03:42 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
- While building up a testcase to use variables instead of fields, I noticed this situation. It may be a red herring, b...
- 01:01 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
- Please remove the @hidden="true"@. Otherwise it won't work.
> Is the @implied_extent_first_element@ name accurat... - 12:58 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
- Greg Shah wrote:
> Constantin Asofiei wrote:
> > I think you need to graft only the LBRACKET portion. As a side no... - 12:14 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
- Constantin Asofiei wrote:
> I think you need to graft only the LBRACKET portion. As a side note, the fix should be ... - 12:13 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
- This:...
- 12:02 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
- I think you need to graft only the LBRACKET portion. As a side note, the fix should be generic for any extent - be i...
- 11:58 AM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
- Greg Shah wrote:
> There is no documentation/task for "templatizing".
>
> I think the annotations can all be left... - 11:40 AM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
- There is no documentation/task for "templatizing".
I think the annotations can all be left out. The line and colu... - 11:28 AM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
- Greg Shah wrote:
> Correct, so long as the child of the @kw_next_pmt@ is the field/var itself. For example, for any... - 10:02 AM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
- Correct, so long as the child of the @kw_next_pmt@ is the field/var itself. For example, for anything with a @form_i...
- 06:49 PM Bug #4462: NOW with comparison operators
- There is a bug in FWD, where a comparison like @dt > NOW@ (where @dt@ is datetime) fails with @Incompatible data type...
- 06:38 PM Bug #4462 (New): NOW with comparison operators
- 06:32 PM Feature #3854: update appserver support with PASOE features
- I was looking for some details on the support of the @server-connection-context@ attribute is. I looked at the code, ...
- 06:29 PM Bug #4461: DST and add-interval
- There's a bug in FWD which is exposed when a DST boundary is reached:...
- 06:17 PM Bug #4461 (New): DST and add-interval
12/09/2019
- 06:14 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
- Greg Shah wrote:
> I'm not suggesting doing it in core conversion. The alternative idea was to add @next-prompt@ to... - 05:46 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
- I'm not suggesting doing it in core conversion. The alternative idea was to add @next-prompt@ to the list of normal ...
- 05:39 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
- At core conversion time may be too late to do this, without having to go and 'hack' the frame generation to exclude t...
- 05:31 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
- The primary issue is that @next-prompt@ is not honored as a statement in which we do array expansion (because we alwa...
- 05:23 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
- > Note that if you remove define shared frame person. the testcase is successful.
This is not the right way to say... - 05:20 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
- Constantin Asofiei wrote:
> Roger, the @ public FillInWidget widgetSchedule();@ line doesn't seem right, to be gen... - 05:00 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
- Roger, the @ public FillInWidget widgetSchedule();@ line doesn't seem right, to be generated. You say that the fir...
- 04:54 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
- Roger Borrello wrote:
> h1. Description
>
> When @next-prompt@ is passed an extent field of a shared frame, but n... - 02:18 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
- h1. Description
When @next-prompt@ is passed an extent field of a shared frame, but no subscript, we generate an u... - 01:00 PM Bug #4455 (Closed): Extent field on unsubscripted next-prompt not converted properly
- 02:48 PM Bug #4427 (WIP): Unable to convert keyword input when used to index into an extent
- 02:43 PM Bug #4423 (WIP): Incorrect buffer scoping when same buffer name used as a parameter to internal p...
12/06/2019
- 05:33 PM Bug #4453: Handling of filename with quotation mark broken in control_flow.rules
- Greg Shah wrote:
> [...]
>
> I disagree with this. If all three are -1 then the @progressToJavaString()@ is NOT ... - 05:16 PM Bug #4453: Handling of filename with quotation mark broken in control_flow.rules
- ...
- 05:01 PM Bug #4453: Handling of filename with quotation mark broken in control_flow.rules
- Constantin Asofiei wrote:
> Rev 10509 was part of #1634 - there's lots of discussion for tilde and quote chars, in p... - 04:37 PM Bug #4453: Handling of filename with quotation mark broken in control_flow.rules
- Rev 10509 was part of #1634 - there's lots of discussion for tilde and quote chars, in paths.
- 04:15 PM Bug #4453: Handling of filename with quotation mark broken in control_flow.rules
- Constantin Asofiei wrote:
> And the implication for my 'garbage suffix' misdirection: if the 4GL code (like @RUN a.p... - 03:35 PM Bug #4453: Handling of filename with quotation mark broken in control_flow.rules
- And the implication for my 'garbage suffix' misdirection: if the 4GL code (like @RUN a.p_garbage@) is tested only wit...
- 03:03 PM Bug #4453: Handling of filename with quotation mark broken in control_flow.rules
- Constantin Asofiei wrote:
> Roger Borrello wrote:
> > When a file name is @runit.p"@ the Java should be @"runit.p\"... - 03:00 PM Bug #4453: Handling of filename with quotation mark broken in control_flow.rules
- Roger Borrello wrote:
> When a file name is @runit.p"@ the Java should be @"runit.p\""@.
Argh, I don't understand, ... - 02:55 PM Bug #4453: Handling of filename with quotation mark broken in control_flow.rules
- Roger Borrello wrote:
> Roger Borrello wrote:
> > h1. Description
> >
> > A filename with a quotation mark (albe... - 02:39 PM Bug #4453: Handling of filename with quotation mark broken in control_flow.rules
- Roger Borrello wrote:
> h1. Description
>
> A filename with a quotation mark (albeit a typo) is not processed pro... - 02:38 PM Bug #4453: Handling of filename with quotation mark broken in control_flow.rules
- h1. Description
A filename with a quotation mark (albeit a typo) is not processed properly.
h2. Testcase
@ru... - 02:33 PM Bug #4453 (WIP): Handling of filename with quotation mark broken in control_flow.rules
12/05/2019
- 02:40 PM Feature #3853: implement LOG-MANAGER runtime
- As part of this task, we should ensure that the default appserver logging that occurs in the 4GL is fully supported i...
12/04/2019
- 07:38 AM Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
- Marian, my questions related to @WebResponseWriter@ are:
* when is the flush happening? What happens if you try to w... - 05:51 AM Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
- Greg Shah wrote:
> From Constantin:
>
> > We need some help in understanding the @WebHandler@ APIs, but not from ... - 02:12 AM Feature #3853: implement LOG-MANAGER runtime
- Greg Shah wrote:
> I have these questions about the content and formatting of the log entries.
>
> * Is @P-999999... - 01:56 AM Feature #3868: customer servlet integration/support
- Constantin Asofiei wrote:
> We need a way to force Jetty @WebAppContext@ to use its own jasper libraries, instead of...
12/03/2019
- 05:16 PM Feature #3868: customer servlet integration/support
- 3809e rev 11414 contains changes to add @GenericWebServer@ APIs to load a WAR file in a standalone Jetty server, in t...
- 05:05 PM Feature #2135: implement COPY-LOB language statement
- The changes are in 3809e rev 11414. There are still some issues not addressed (see the TODOs in the code)m and #2135...
- 01:43 PM Bug #4433: Problem with text concat
- I think it is OK to include this in 3820a.
- 12:15 PM Bug #4433: Problem with text concat
- Greg Shah wrote:
> Good point, don't add the @outer:@ label, just add the @inner:@ label and references.
Is it th... - 10:09 AM Bug #4433: Problem with text concat
- Good point, don't add the @outer:@ label, just add the @inner:@ label and references.
- 10:08 AM Bug #4433: Problem with text concat
- Greg Shah wrote:
> Yes, I think this will work correctly.
>
> Although a careful reading of the code is quite cle... - 08:30 AM Bug #4433: Problem with text concat
- Yes, I think this will work correctly.
Although a careful reading of the code is quite clear about the behavior, I... - 12:38 PM Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
- From Constantin:
> We need some help in understanding the @WebHandler@ APIs, but not from the @WebHandler.cls@, he... - 10:26 AM Feature #3853: implement LOG-MANAGER runtime
- Consider the following log output examples....
- 07:07 PM Bug #4427: Unable to convert keyword input when used to index into an extent
- -*This has been fixed in 4207a-11349*-
12/02/2019
- 04:55 PM Bug #4433: Problem with text concat
- Greg Shah wrote:
> Yes, it would be possible by using @get-string()@ on @memptr@ or @raw@ or with certain forms of s... - 03:41 PM Bug #4433: Problem with text concat
- Yes, it would be possible by using @get-string()@ on @memptr@ or @raw@ or with certain forms of string literals. See...
- 03:25 PM Bug #4433: Problem with text concat
- Greg Shah wrote:
> In that scenario, the value will be a @BaseDataType@ and if it is the first operand, then the pro... - 01:30 PM Bug #4433: Problem with text concat
- In that scenario, the value will be a @BaseDataType@ and if it is the first operand, then the proposed change in the ...
- 01:14 PM Bug #4433: Problem with text concat
- Greg Shah wrote:
> I thought we were discussing the approach from #4433-6 in which the code change was not at conver... - 01:09 PM Bug #4433: Problem with text concat
- I thought we were discussing the approach from #4433-6 in which the code change was not at conversion but only exists...
- 11:55 AM Bug #4433: Problem with text concat
- Greg Shah wrote:
> The first @character@ operand uses @getValue()@ instead of @safeValue()@ in @TextOps.concat()@.
... - 11:11 AM Bug #4433: Problem with text concat
- The first @character@ operand uses @getValue()@ instead of @safeValue()@ in @TextOps.concat()@.
- 11:08 AM Bug #4433: Problem with text concat
- Greg Shah wrote:
> So then the algorithm needs to be slightly different because the leftmost operand is treated diff... - 10:36 AM Bug #4433: Problem with text concat
- So then the algorithm needs to be slightly different because the leftmost operand is treated differently than the sub...
- 10:33 AM Bug #4433: Problem with text concat
- Greg Shah wrote:
> I'm asking about in the 4GL. Can the buffer-value sub-expression appear as the leftmost operand ... - 08:43 AM Bug #4433: Problem with text concat
- I'm asking about in the 4GL. Can the buffer-value sub-expression appear as the leftmost operand of the @+@ concatena...
- 12:02 PM Bug #4427: Unable to convert keyword input when used to index into an extent
- Roger Borrello wrote:
> This same testcase has the issue, so buffers are not the only thing leading to it. It could ... - 09:16 AM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
- Constantin Asofiei wrote:
> This is fixed in 11347. Please test again.
Both testcases (@tablehandle_parameter_wi... - 09:07 AM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
- And another reason why @parmrefid@ was also incorrect: a var can be referenced by multiple parameters, not just one.
- 09:05 AM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
- OK, that works for me.
- 09:05 AM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
- Greg Shah wrote:
> Code Review Task Branch 4207a Revisions 11346-11347
>
> Overall, the changes look good.
>
>... - 09:01 AM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
- Code Review Task Branch 4207a Revisions 11346-11347
Overall, the changes look good.
One question: in @scope_pro... - 08:13 AM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
- This is fixed in 11347. Please test again.
11/30/2019
- 10:07 AM Bug #4433: Problem with text concat
- Greg Shah wrote:
> Can a POLY value ever be passed as the first operand? If not then this is probably the correct a...
11/29/2019
- 06:15 PM Bug #4433: Problem with text concat
- Can a POLY value ever be passed as the first operand? If not then this is probably the correct approach.
- 05:49 PM Bug #4433: Problem with text concat
- Greg Shah wrote:
> I guess we can do that safely, as long as we document this clearly in the javadoc. The only down... - 05:41 PM Bug #4433: Problem with text concat
- I guess we can do that safely, as long as we document this clearly in the javadoc. The only downside is that it can ...
- 05:11 PM Bug #4433: Problem with text concat
- Question: why not do this automatically at runtime? If the argument is not a Java String or a character, then automat...
- 05:08 PM Bug #4433: Problem with text concat
- Consider that the following code is not valid (it does not compile in the 4GL):
@message "text " + 1234567890.@
... - 04:13 PM Bug #4433: Problem with text concat
- From Vladimir:
> I am not sure which is the right way to fix it. According to the Javadocs, the @toString()@ metho... - 12:24 PM Bug #4433: Problem with text concat
- The following code snippet runs smoothly in Progress....
- 12:18 PM Bug #4433 (New): Problem with text concat
- 10:43 AM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
- Roger Borrello wrote:
> I am OOO today, as well, but wanted to take a quick look at this update. I did a full build,... - 10:41 AM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
- Constantin Asofiei wrote:
> Roger Borrello wrote:
> > Sorry for the lack of response. Today was Thanksgiving in the... - 06:09 AM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
- Roger Borrello wrote:
> Sorry for the lack of response. Today was Thanksgiving in the US.
Happy Thanksgiving! :)
... - 10:31 PM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
- Constantin Asofiei wrote:
> Anyway, the changes are in 4207a rev 11346. Greg, please review.
Sorry for the lack ...
11/28/2019
- 05:22 PM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
- Anyway, the changes are in 4207a rev 11346. Greg, please review.
- 05:05 PM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
- Greg, I've fixed this in the conversion rules (it was not a parser problem in the end). But before checking what it ...
- 02:40 PM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
- Sorry, I don't remember anything about that.
- 02:20 PM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
- Stanislav, I see that you've added testcases related to @PARAMETER TABLE-HANDLE [FOR]@ (like @th-for-regular.p@). Wa...
- 01:28 PM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
- I've been trying to understand how @TABLE-HANDLE@ and @TABLE-HANDLE FOR@ behave - looks like they are not equivalent....
11/27/2019
- 01:24 PM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
- Roger Borrello wrote:
> I am trying to dig into #4427 at the same time. Are you able grab 4207a to help? It would be... - 12:17 PM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
- Constantin Asofiei wrote:
> Roger Borrello wrote:
> > Here's what's in the parameter section for the _good_ version... - 12:07 PM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
- Roger Borrello wrote:
> Here's what's in the parameter section for the _good_ version:
The @vardef@ annotation is s... - 12:05 PM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
- Constantin Asofiei wrote:
> Roger Borrello wrote:
> > ... or does @rule.tracing=true@ go someplace else?
> Before ... - 11:50 AM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
- Roger Borrello wrote:
> ... or does @rule.tracing=true@ go someplace else?
Before the main class, like this:
@java... - 11:49 AM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
- Constantin Asofiei wrote:
> Roger, there is no @vardef@ annotation in the case in #4424-13 (the AST is from the full... - 11:39 AM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
- Roger, there is no @vardef@ annotation in the case in #4424-13 (the AST is from the full conversion, right?) Add @-Dr...
- 11:30 AM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
- Constantin Asofiei wrote:
> Roger Borrello wrote:
> > Those 2 lines can be replaced with @define input parameter ta... - 11:27 AM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
- Roger Borrello wrote:
> Those 2 lines can be replaced with @define input parameter table-handle gh.@ and you will ge... - 11:26 AM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
- Constantin Asofiei wrote:
> Roger Borrello wrote:
> > Note that in this testcase, the @gh@ is used in both a @defin... - 11:24 AM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
- Roger Borrello wrote:
> Note that in this testcase, the @gh@ is used in both a @define variable@ and @define input p... - 11:23 AM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
- Roger Borrello wrote:
> Constantin Asofiei wrote:
> > They fix another issue, I thought it was related to this. So... - 11:20 AM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
- Constantin Asofiei wrote:
> They fix another issue, I thought it was related to this. So looks like there's another... - 11:16 AM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
- They fix another issue, I thought it was related to this. So looks like there's another case to fix. Please post the...
- 11:15 AM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
- Constantin Asofiei wrote:
> Roger, take these files from 3809e:
> [...]
>
> They are built from trunk, so is saf... - 10:45 AM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
- Roger, take these files from 3809e:...
- 10:18 AM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
- +*Converted code fails to compile*+...
- 10:11 AM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
- This fix enables the @TABLE-HANDLE FOR <existing_handle_var>@ use case. We already have support in conversion (to se...
- 09:57 AM Bug #4424 (Test): Additional def var needed to receive table handle when keyword FOR included in ...
- The fix for this is in 4207a revision 11344.
- 12:48 PM Bug #4427: Unable to convert keyword input when used to index into an extent
- This same testcase has the issue, so buffers are not the only thing leading to it. It could be 2 separate issues, or ...
- 07:31 PM Bug #4427: Unable to convert keyword input when used to index into an extent
- The regression is fixed in rev 11343. Now this testcase fails again. Success!
- 11:12 AM Bug #4425: Lost frame_id when converting code with missing field names to update
- Greg Shah wrote:
> Sure.
Updated in @4207a-11345@
- 10:47 AM Bug #4425: Lost frame_id when converting code with missing field names to update
- Sure.
- 10:11 AM Bug #4425: Lost frame_id when converting code with missing field names to update
- Greg Shah wrote:
> This change caused a bad regression that dropped all prompt-for/set/update statements. Fixed in ... - 09:58 AM Bug #4425 (Test): Lost frame_id when converting code with missing field names to update
- 07:30 PM Bug #4425: Lost frame_id when converting code with missing field names to update
- This change caused a bad regression that dropped all prompt-for/set/update statements. Fixed in rev 11343.
11/26/2019
- 06:06 PM Bug #4427: Unable to convert keyword input when used to index into an extent
- It is missing all output for this:...
- 06:02 PM Bug #4427: Unable to convert keyword input when used to index into an extent
- Roger Borrello wrote:
> I cannot duplicate the issue using 4207a-11342 using the testcase nor customer code.
Here... - 03:53 PM Bug #4427: Unable to convert keyword input when used to index into an extent
- I cannot duplicate the issue using 4207a-11342 using the testcase nor customer code.
- 05:36 PM Feature #2135: implement COPY-LOB language statement
- Eric Faulhaber wrote:
> First CLOB initialization is sticky, even if followed by a later assignment?
Not the initia... - 05:34 PM Feature #2135: implement COPY-LOB language statement
- First CLOB initialization is sticky, even if followed by a later assignment? Does that hold if the @""@ and @?@ initi...
- 05:07 PM Feature #2135: implement COPY-LOB language statement
- Eric Faulhaber wrote:
> These are all runtime bugs, right? Both the conversion and runtime were meant to handle thes... - 01:25 PM Feature #2135: implement COPY-LOB language statement
- These are all runtime bugs, right? Both the conversion and runtime were meant to handle these permutations, but runti...
- 12:49 PM Feature #2135: implement COPY-LOB language statement
- Eric Faulhaber wrote:
> Well, then again, look at @Text.assign(Text value)@. It stores the @String@ object inside th... - 12:18 PM Feature #2135: implement COPY-LOB language statement
- Well, then again, look at @Text.assign(Text value)@. It stores the @String@ object inside the @Text@ passed to it, no...
- 12:14 PM Feature #2135: implement COPY-LOB language statement
- Hm. That check may have survived from an earlier implementation. I think you are right.
- 01:49 AM Feature #2135: implement COPY-LOB language statement
- The @value == data@ I don't think can ever be true, as when we assign a byte array, we copy it to another instance. ...
- 10:41 AM Bug #4425: Lost frame_id when converting code with missing field names to update
- Greg Shah wrote:
> The fix is in branch 4207a revision 11342.
+*Added additional testcases to demonstrate @prompt... - 10:28 AM Bug #4425: Lost frame_id when converting code with missing field names to update
- The fix is in branch 4207a revision 11342.
- 09:37 AM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
- Note that reversing the lines in the testcase alters the behavior in Progress. ...
11/25/2019
- 04:58 PM Feature #2135: implement COPY-LOB language statement
- This was meant to be a quick exit if there was nothing to do. Note the rest of the block:...
- 04:53 PM Feature #2135: implement COPY-LOB language statement
- Eric Faulhaber wrote:
> I suspect that was meant as an optimization to preempt unnecessary work, but I'm not sure wh... - 04:07 PM Feature #2135: implement COPY-LOB language statement
- Constantin Asofiei wrote:
> I think I understand now - the @overlay@ option (which is 'active' in FWD only if @offse... - 03:38 PM Feature #2135: implement COPY-LOB language statement
- I think I understand now - the @overlay@ option (which is 'active' in FWD only if @offset@ is non-null) is not treate...
- 01:56 PM Feature #2135: implement COPY-LOB language statement
- Eric Faulhaber wrote:
> The idea was that you have an existing @longchar@ instance which has data in it and a COPY-L... - 01:54 PM Feature #2135: implement COPY-LOB language statement
- The idea was that you have an existing @longchar@ instance which has data in it and a COPY-LOB (overlay) operation se...
- 04:10 AM Feature #2135: implement COPY-LOB language statement
- Eric, what is the use case documented like this in @longchar.write@:...
Also available in: Atom