Project

General

Profile

Activity

From 01/02/2020 to 01/31/2020

02/01/2020

07:24 PM Bug #4476: Shared frame does not get @ widget method generated
Made an update to the testcase.... Roger Borrello

01/31/2020

06:21 PM Bug #4476: Shared frame does not get @ widget method generated
While that testcase does not throw the exception in @trunk@, it still reports issues. I added some debug to my trunk ... Roger Borrello
03:14 PM Bug #4476: Shared frame does not get @ widget method generated
Bug found when converting customer code.
Testcase:...
Roger Borrello
01:03 PM Bug #4476: Shared frame does not get @ widget method generated
Greg Shah wrote:
> Code Review Task Branch 4207a Revision 11386
>
> I'm OK with the changes. If it passes regres...
Roger Borrello
01:01 PM Bug #4476: Shared frame does not get @ widget method generated
Code Review Task Branch 4207a Revision 11386
I'm OK with the changes. If it passes regression testing, while stil...
Greg Shah
12:49 PM Bug #4476: Shared frame does not get @ widget method generated
Greg Shah wrote:
> @search_widget@ is used in many places so we must be especially sure that your change is safe. I...
Roger Borrello
12:06 PM Bug #4476: Shared frame does not get @ widget method generated
@search_widget@ is used in many places so we must be especially sure that your change is safe. I can't tell without ... Greg Shah
11:31 AM Bug #4476: Shared frame does not get @ widget method generated
Check my placement of the check:
Currently we call "search_widget":...
Roger Borrello
10:45 AM Bug #4476: Shared frame does not get @ widget method generated
Optimally, we would see the @dumpTree()@ from the ancestor @STATEMENT@ node. Greg Shah
10:00 AM Bug #4476: Shared frame does not get @ widget method generated
Greg Shah wrote:
> > I have changed the message to printfln("## WARNING: %s: Usingframe='%s' from Dictionary for ref...
Roger Borrello
09:56 AM Bug #4476: Shared frame does not get @ widget method generated
> I have changed the message to printfln("## WARNING: %s: Usingframe='%s' from Dictionary for ref='%s', id=%d", file,... Greg Shah
09:54 AM Bug #4476: Shared frame does not get @ widget method generated
I did see a lot of "DANGER WILL ROBINSON!" messages on some regression tests yesterday from the @search_frame_phrase@... Roger Borrello
09:13 AM Bug #4476: Shared frame does not get @ widget method generated
Greg Shah wrote:
> > I have the following, but am trying to determine what type to make the ID, since we wanted to i...
Roger Borrello
01:44 PM Feature #3254: add support for running 4GL on multiple threads in a single session
Greg Shah wrote:
> 1. I think that we should introduce a new 4GL annotation @@ThreadSafe@ which can be used to m...
Constantin Asofiei
01:30 PM Feature #3254: add support for running 4GL on multiple threads in a single session
> We may consider that this related thread shares with the parent and other related threads only its security data, p... Greg Shah
11:12 AM Feature #3254: add support for running 4GL on multiple threads in a single session
Greg Shah wrote:
> My instinct is to disallow this (super-procedures). The new threads are related from the perspec...
Constantin Asofiei
10:39 AM Feature #3254: add support for running 4GL on multiple threads in a single session
>> Should we exclude having super-procedures on the AssociatedThread instances? Lots of old code might require such a... Greg Shah
09:43 AM Feature #3254: add support for running 4GL on multiple threads in a single session
Constantin Asofiei wrote:
> Greg Shah wrote:
> > * Should we exclude having super-procedures on the @AssociatedThre...
Constantin Asofiei
09:38 AM Feature #3254: add support for running 4GL on multiple threads in a single session
Greg Shah wrote:
> * Should we exclude having super-procedures on the @AssociatedThread@ instances? Lots of old cod...
Constantin Asofiei
09:03 AM Feature #3254: add support for running 4GL on multiple threads in a single session
I'm thinking through the @JOIN@ implementation. I agree it is a good idea.
I also am thinking about the following...
Greg Shah
12:21 PM Feature #3868: customer servlet integration/support
Greg Shah wrote:
> Hyenk: We may need to you look at this. I don't want to derail your spreadsheet widget work righ...
Hynek Cihlar
11:44 AM Feature #3868: customer servlet integration/support
My understanding is that what remains open in this task is the conflict with @jasper@ and @castor@. Is that correct?... Greg Shah

01/30/2020

06:20 PM Bug #4476: Shared frame does not get @ widget method generated
> I have the following, but am trying to determine what type to make the ID, since we wanted to initialize it to -1.
...
Greg Shah
06:00 PM Bug #4476: Shared frame does not get @ widget method generated
I have the following, but am trying to determine what type to make the ID, since we wanted to initialize it to @-1@. ... Roger Borrello
04:48 PM Bug #4476: Shared frame does not get @ widget method generated
> What about a ScopedSymbolDictionary, where I add a scope then add symbols in the walk-rules, then delete in the asc... Greg Shah
04:26 PM Bug #4476: Shared frame does not get @ widget method generated
Greg Shah wrote:
> @convert/control_flow.rules@, search for @Dictionary@.
Thanks. That shows adding to the "switc...
Roger Borrello
09:37 AM Feature #2135: implement COPY-LOB language statement
Yes, test cases will be very useful. Thanks!
It seems that the 4GL implements a subset of the "Byte Order Mark":h...
Greg Shah
08:56 AM Feature #2135: implement COPY-LOB language statement
Greg Shah wrote:
> Marian: 2 followup questions:
>
> 1. What is the unicode BOM character that is used?
>
> 2....
Marian Edu

01/29/2020

04:05 PM Bug #4476: Shared frame does not get @ widget method generated
@convert/control_flow.rules@, search for @Dictionary@. Greg Shah
03:51 PM Bug #4476: Shared frame does not get @ widget method generated
Found that since we have reverted code, and the widget list for frame f2 now contains the variable that was before th... Roger Borrello

01/27/2020

01:39 PM Feature #2135: implement COPY-LOB language statement
Marian: 2 followup questions:
1. What is the unicode BOM character that is used?
2. Is it always the same unico...
Greg Shah

01/24/2020

04:47 PM Bug #4476: Shared frame does not get @ widget method generated
It is more correct now. The reason is probably simple: the widget before was being created from a string literal and... Greg Shah
01:45 PM Bug #4476: Shared frame does not get @ widget method generated
Roger Borrello wrote:
> I wanted to check that this is a valid addition to the frame definition for this testcase:
...
Roger Borrello
01:35 PM Bug #4476: Shared frame does not get @ widget method generated
Greg Shah wrote:
> > addrId.setFormat("999999");
>
> This one needs to be there. I'm very surprised it isn't the...
Roger Borrello
12:44 PM Bug #4476: Shared frame does not get @ widget method generated
>> addrId.setAt(true);
>> addrId.setAtFormatLength(6);
I'm not sure about these. You'll have to...
Greg Shah
12:13 PM Bug #4476: Shared frame does not get @ widget method generated
I wanted to check that this is a valid addition to the frame definition for this testcase:... Roger Borrello
09:34 AM Bug #4476: Shared frame does not get @ widget method generated
Greg Shah wrote:
> Did you read the javadoc?
Got it. Thanks for the discussion.
Regarding "junk" before the &#...
Roger Borrello
08:19 AM Bug #4476: Shared frame does not get @ widget method generated
Did you read the javadoc? Greg Shah
07:58 PM Bug #4476: Shared frame does not get @ widget method generated
I have been working with @frame_generator.xml@ and @common-progress.rules@ to correct some regressions. I have a test... Roger Borrello
07:43 PM Bug #4476 (WIP): Shared frame does not get @ widget method generated
Roger Borrello
08:12 AM Feature #4392 (WIP): add -pf support for appserver CONNECT() method
Greg Shah

01/20/2020

06:14 PM Bug #4476: Shared frame does not get @ widget method generated
My annotations are being put into the tree:... Roger Borrello
02:15 PM Bug #4476: Shared frame does not get @ widget method generated
Greg Shah wrote:
> > @ [java] Condition : ref_fmt = ref_fmtp.getImmediateChild(prog.kw_format, null@
>
> Do...
Roger Borrello
01:43 PM Bug #4476: Shared frame does not get @ widget method generated
> @ [java] Condition : ref_fmt = ref_fmtp.getImmediateChild(prog.kw_format, null@
Do you have a missing clos...
Greg Shah
01:42 PM Bug #4476: Shared frame does not get @ widget method generated
Roger Borrello wrote:
> Greg Shah wrote:
> > This is OK.
>
> Good... moving onto adding the annotations in @fram...
Roger Borrello
11:49 AM Bug #4476: Shared frame does not get @ widget method generated
Greg Shah wrote:
> This is OK.
Good... moving onto adding the annotations in @frame_scoping.rules@ to allow @setA...
Roger Borrello
09:45 AM Bug #4476: Shared frame does not get @ widget method generated
This is OK. Greg Shah
08:56 AM Bug #4476: Shared frame does not get @ widget method generated
Greg Shah wrote:
> I suspect that the format in trunk was wrong. I think the conversion of the frame def looks OK h...
Roger Borrello
07:11 AM Bug #4476: Shared frame does not get @ widget method generated
I suspect that the format in trunk was wrong. I think the conversion of the frame def looks OK here in 4207a.
Wha...
Greg Shah
09:57 PM Bug #4476: Shared frame does not get @ widget method generated
Greg Shah wrote:
> I would expect the widget to have @character@ type. But the override specified by the @@@ is goi...
Roger Borrello
07:19 AM Feature #3810: SECURITY-POLICY and other security features
Review for 4335a rev 11346 - I'm OK with the changes. Constantin Asofiei

01/19/2020

05:30 PM Bug #4476: Shared frame does not get @ widget method generated
I would expect the widget to have @character@ type. But the override specified by the @@@ is going to be "temporaril... Greg Shah
05:20 PM Bug #4476: Shared frame does not get @ widget method generated
I have a quiz for the experts... What data type should the @getTmess()@ getter for the widget on @frame1@ return?
...
Roger Borrello

01/17/2020

12:01 PM Bug #4476: Shared frame does not get @ widget method generated
Roger Borrello wrote:
> We are only iterating through wlist once, because we no longer add the don't add @ as a ...
Roger Borrello
11:57 AM Bug #4476: Shared frame does not get @ widget method generated
We are only iterating through wlist once, because we no longer add the don't add @ as a widget, presumably when i... Roger Borrello
11:45 AM Bug #4476: Shared frame does not get @ widget method generated
Given the failed regression testing, I'm revisiting with this testcase:... Roger Borrello

01/16/2020

04:46 PM Feature #3810: SECURITY-POLICY and other security features
Constantin: please review. Greg Shah
04:45 PM Feature #3810: SECURITY-POLICY and other security features
Greg Shah wrote:
> Is this ready for a code review?
I think so.
Igor Skornyakov
04:40 PM Feature #3810: SECURITY-POLICY and other security features
Is this ready for a code review? Greg Shah
05:36 AM Feature #3810: SECURITY-POLICY and other security features
@VALIDATE-SEAL@ is fixed in 4335a revision 11475. Igor Skornyakov
02:50 PM Bug #4484: Accumulator confusion using same field for count and total
Constantin Asofiei wrote:
> Roger Borrello wrote:
> > Hi Constantin... fyi my regression testing was successful wit...
Roger Borrello
01:42 PM Bug #4484: Accumulator confusion using same field for count and total
Roger Borrello wrote:
> Hi Constantin... fyi my regression testing was successful with that code removed. What was t...
Constantin Asofiei
01:17 PM Bug #4160: Arrays assigment issue
Constantin Asofiei wrote:
> The conversion fixes are in 4207a rev 11360. It also moves the @ExtentExpr@ to anon cla...
Roger Borrello
01:00 PM Bug #4123 (Test): conversion generates incorrect java code for Extent statement
This is basically a duplicate of the issue #4160 and the fix is the same. Greg Shah
12:45 PM Bug #4123: conversion generates incorrect java code for Extent statement
Greg Shah wrote:
> In what branch and revision can you recreate this problem (i.e. is this in trunk 11319)?
I jus...
Roger Borrello
09:46 AM Bug #4476: Shared frame does not get @ widget method generated
> Throw a few test samples in here and we can see.
That is your task.
Greg Shah
09:36 AM Bug #4476: Shared frame does not get @ widget method generated
Greg Shah wrote:
> Hmm, this is worse than what we already knew (which was really bad).
>
> Questions:
>
> * D...
Roger Borrello
09:33 AM Bug #4476: Shared frame does not get @ widget method generated
Hmm, this is worse than what we already knew (which was really bad).
Questions:
* Does this happen for any @@@ ...
Greg Shah
09:27 AM Bug #4476: Shared frame does not get @ widget method generated
Constantin Asofiei wrote:
> Roger Borrello wrote:
> > Constantin Asofiei wrote:
> > > Roger, please change @mymess...
Roger Borrello
09:25 AM Bug #4476: Shared frame does not get @ widget method generated
Roger Borrello wrote:
> Constantin Asofiei wrote:
> > Roger, please change @mymess@ to be a decimal and use some si...
Constantin Asofiei
09:24 AM Bug #4476: Shared frame does not get @ widget method generated
Constantin Asofiei wrote:
> Roger, please change @mymess@ to be a decimal and use some similar @Missing value@ - I w...
Roger Borrello
09:19 AM Bug #4476: Shared frame does not get @ widget method generated
Roger, please change @mymess@ to be a decimal and use some similar @Missing value@ - I wonder if @@@ option just form... Constantin Asofiei
09:10 AM Bug #4476: Shared frame does not get @ widget method generated
I just wanted to make a note that the 4GL behavior when including conflicting formatting between the variable definit... Roger Borrello

01/15/2020

05:45 PM Bug #4476: Shared frame does not get @ widget method generated
*Updated convert/frame_generator.xml in 4207a-11378*
We need to look at our parent node for @ base-field, instead ...
Roger Borrello
04:13 PM Bug #4476: Shared frame does not get @ widget method generated
Greg Shah wrote:
> This is an expected consequence of the change. We are now creating the widget from the child of ...
Roger Borrello
03:56 PM Bug #4476: Shared frame does not get @ widget method generated
This is an expected consequence of the change. We are now creating the widget from the child of @AT@ instead of at t... Greg Shah
03:40 PM Bug #4476: Shared frame does not get @ widget method generated
Roger Borrello wrote:
> Roger Borrello wrote:
> > I see a difference in the generated frame definition between trun...
Roger Borrello
01:31 PM Bug #4476: Shared frame does not get @ widget method generated
Roger Borrello wrote:
> I see a difference in the generated frame definition between trunk, and this revision.
>
...
Roger Borrello
11:02 AM Bug #4476: Shared frame does not get @ widget method generated
I see a difference in the generated frame definition between trunk, and this revision.
I modified the testcase @at...
Roger Borrello
05:42 PM Feature #3810: SECURITY-POLICY and other security features
@VALIDATE-SEAL@ is almost fixed, but it appears the @LOAD-DOMAINS@ is broken. Will fix it tomorrow. Igor Skornyakov
01:50 PM Bug #4484: Accumulator confusion using same field for count and total
Roger Borrello wrote:
> Roger Borrello wrote:
> > The code no longer creates a field reference when there is a @[@ ...
Roger Borrello
11:12 AM Feature #3867: direct java class access from 4GL code
Greg Shah wrote:
> I looked into this case. I think you are talking about @ladder-safety-gen.p@ where it references...
Hynek Cihlar
10:13 AM Feature #3867 (Test): direct java class access from 4GL code
Greg Shah
10:12 AM Feature #3867: direct java class access from 4GL code
Hynek Cihlar wrote:
> Greg Shah wrote:
> > Constantin/Hynek: Do you know of any other critical bugs or missing feat...
Greg Shah

01/14/2020

03:57 PM Bug #4484: Accumulator confusion using same field for count and total
Roger Borrello wrote:
> The code no longer creates a field reference when there is a @[@ downpath:
>
> [...]
>
...
Roger Borrello
02:17 PM Bug #4484: Accumulator confusion using same field for count and total
The code no longer creates a field reference when there is a @[@ downpath:... Roger Borrello
02:12 PM Bug #4484 (WIP): Accumulator confusion using same field for count and total
Roger Borrello
09:15 AM Feature #3810: SECURITY-POLICY and other security features
Manually merged updates into 4335a revision 11469. Igor Skornyakov
09:13 AM Feature #3810: SECURITY-POLICY and other security features
Igor Skornyakov wrote:
> I will first merge into 4335a and continue in it. Is it OK?
Yes.
Constantin Asofiei
08:58 AM Feature #3810: SECURITY-POLICY and other security features
Constantin Asofiei wrote:
> Yes, please do. And please go through https://documentation.progress.com/output/ua/Open...
Igor Skornyakov
08:56 AM Feature #3810: SECURITY-POLICY and other security features
Igor Skornyakov wrote:
> Oops. It seems that I've overlooked this, sorry. I have to add a corresponding test and upd...
Constantin Asofiei
08:53 AM Feature #3810: SECURITY-POLICY and other security features
Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > Maybe it is better to just manually merge the changes as the...
Igor Skornyakov
08:42 AM Feature #3810: SECURITY-POLICY and other security features
Igor Skornyakov wrote:
> Maybe it is better to just manually merge the changes as they affect only two classes?
Yes...
Constantin Asofiei
08:22 AM Feature #3810: SECURITY-POLICY and other security features
Constantin Asofiei wrote:
> And if is an unknown value?
An error 4065 is generated.
Igor Skornyakov
08:20 AM Feature #3810: SECURITY-POLICY and other security features
Constantin Asofiei wrote:
> Igor, I'm OK with the changes. This can be merged with 4335a.
Constantin. 3810e wa...
Igor Skornyakov
08:17 AM Feature #3810: SECURITY-POLICY and other security features
Igor Skornyakov wrote:
> Constantin. In 4GL the @domainAccessCode@ parameter is mandatory for the @SEAL@ call.
And ...
Constantin Asofiei
08:15 AM Feature #3810: SECURITY-POLICY and other security features
Constantin Asofiei wrote:
> Igor, I'm OK with the changes. This can be merged with 4335a.
>
> On a side note, in...
Igor Skornyakov
08:04 AM Feature #3810: SECURITY-POLICY and other security features
Igor, I'm OK with the changes. This can be merged with 4335a.
On a side note, in @validateSeal@ I left this comme...
Constantin Asofiei

01/13/2020

07:17 AM Feature #3254: add support for running 4GL on multiple threads in a single session
Greg,
I think we should support the thread "JOIN" concept by using an additional option @AS-THREAD [SET handle] [ON-...
Ovidiu Maxiniuc

01/12/2020

02:05 PM Feature #3810: SECURITY-POLICY and other security features
The issue #3810-407 resolved in 3810e revision 11342.
BTW: it appears the @PRIMARY_PASSPHRASE@ attribute value is ig...
Igor Skornyakov
12:00 PM Feature #3810: SECURITY-POLICY and other security features
@SET-DB-CLIENT@ for the principal in a @LOGIN@ state validates only @DOMAIN-NAME@ and @DOMAIN-ACCESS-CODE@ (using MAC... Igor Skornyakov
11:03 AM Feature #3810: SECURITY-POLICY and other security features
With 3810e revision 11341, the @SET-DB-CLIENT@ with the imported sealed principal works fine. So the issue described ... Igor Skornyakov

01/10/2020

05:32 PM Feature #3254 (WIP): add support for running 4GL on multiple threads in a single session
To create a new thread, I was planning to add an optional @AS-THREAD [SET handle]@ extension to the @RUN@ statement. ... Greg Shah
04:10 AM Feature #3867: direct java class access from 4GL code
Greg Shah wrote:
> I believe that we are at a good "first pass" level of support here. A future improvement would b...
Constantin Asofiei
01:12 AM Feature #3867: direct java class access from 4GL code
Greg Shah wrote:
> Constantin/Hynek: Do you know of any other critical bugs or missing features before we can accept...
Hynek Cihlar

01/09/2020

05:56 PM Feature #3254: add support for running 4GL on multiple threads in a single session
Understood. To implement "temp-tables" that are shared across threads we would have to implement a multi-user databa... Greg Shah
05:17 PM Feature #3254: add support for running 4GL on multiple threads in a single session
To clarify, you can access a persistent table across threads, but not over the same connection. A temp-table actually... Eric Faulhaber
05:16 PM Feature #3254: add support for running 4GL on multiple threads in a single session
Greg Shah wrote:
> Since JDBC connections cannot be shared across more than one thread, the current temp-table appro...
Eric Faulhaber
05:09 PM Feature #3254: add support for running 4GL on multiple threads in a single session
Some months ago, Eric noted to me that sharing temp-tables will be a problem since they are private to a single JDBC ... Greg Shah
04:28 PM Feature #3867: direct java class access from 4GL code
I believe that we are at a good "first pass" level of support here. A future improvement would be to support inherit... Greg Shah
04:24 PM Feature #3867: direct java class access from 4GL code
I just committed revision 11467 to branch 4335a (which is derived from 3809e revision 11466). This revision provides... Greg Shah

01/06/2020

02:06 PM Feature #3810: SECURITY-POLICY and other security features
Well, I understand what was wrong in my setup. I had @large_customer_application.jar@ in my project classpath. Now th... Igor Skornyakov
02:00 PM Feature #3810: SECURITY-POLICY and other security features
Igor Skornyakov wrote:
> Eric Faulhaber wrote:
> > Does @com/goldencode/testcases/dmo/_meta/meta_table_ddl.sql@ exi...
Igor Skornyakov
01:56 PM Feature #3810: SECURITY-POLICY and other security features
Eric Faulhaber wrote:
> Does @com/goldencode/testcases/dmo/_meta/meta_table_ddl.sql@ exist in your application jar f...
Igor Skornyakov
01:40 PM Feature #3810: SECURITY-POLICY and other security features
Does @com/goldencode/testcases/dmo/_meta/meta_table_ddl.sql@ exist in your application jar file? Eric Faulhaber
01:21 PM Feature #3810: SECURITY-POLICY and other security features
Eric Faulhaber wrote:
> Igor Skornyakov wrote:
> > Please note that I still have no solution for problem #3810-413....
Igor Skornyakov
12:46 PM Feature #3810: SECURITY-POLICY and other security features
Igor Skornyakov wrote:
> Please note that I still have no solution for problem #3810-413. Any help will be highly ap...
Eric Faulhaber
05:37 AM Bug #4160: Arrays assigment issue
Roger Borrello wrote:
> That was not enough detail to get me going. I believe Greg thought it would be an exercise i...
Constantin Asofiei

01/03/2020

01:49 PM Feature #3810: SECURITY-POLICY and other security features
The extended @uast/security/export-cp.p@ test produces the compatible results in 4GL and FWD branch 3810e rev. 11341.... Igor Skornyakov
01:52 AM Feature #2135: implement COPY-LOB language statement
Eric Faulhaber wrote:
> * What is the structure/size/layout of the BOM for file input/output?
There is no special...
Marian Edu

01/02/2020

01:07 PM Bug #4476 (Test): Shared frame does not get @ widget method generated
Greg Shah
12:12 PM Bug #4476 (WIP): Shared frame does not get @ widget method generated
Roger Borrello
12:11 PM Bug #4476: Shared frame does not get @ widget method generated
Greg Shah wrote:
> > but doesn't myat have to be defined properly, too?
>
> In the working case, the variable is ...
Roger Borrello
10:23 AM Bug #4476: Shared frame does not get @ widget method generated
> but doesn't myat have to be defined properly, too?
In the working case, the variable is not defined as an inline...
Greg Shah
10:15 AM Bug #4476: Shared frame does not get @ widget method generated
Greg Shah wrote:
> That is probably not related. The issue will be the tree structure under the @KW_FORM@. The @FO...
Roger Borrello
10:07 AM Bug #4476: Shared frame does not get @ widget method generated
That is probably not related. The issue will be the tree structure under the @KW_FORM@. The @FORM_ITEM@ related to ... Greg Shah
10:02 AM Bug #4476: Shared frame does not get @ widget method generated
Comparing the AST generated for the broken case (@shared_frame_at_label.p@) against the correct case (@shared_frame_a... Roger Borrello
 

Also available in: Atom