Project

General

Profile

Activity

From 06/24/2020 to 07/23/2020

07/17/2020

10:13 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
I'm looking at the table, dataset and buffer matching right now. In @SymbolResolver.translateType()@ we have this co... Greg Shah

07/16/2020

06:37 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
Greg Shah wrote:
> OK, an important point is @if caller hasn't specified a mode for an argument, use wildcard@.
>
...
Constantin Asofiei
06:21 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
OK, an important point is @if caller hasn't specified a mode for an argument, use wildcard@.
Still, I don't unders...
Greg Shah
05:34 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
Greg Shah wrote:
> As far as I know the parameter modes are not actually part of the "fuzziness". In fact, we proba...
Constantin Asofiei
05:29 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
No, I mean this code:... Greg Shah
05:24 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
Constantin wrote:
> you mean the narrowing/widening match, based on the parameters mode?
Greg Shah
05:23 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
We have a step that comes at the end for matching parameter modes.
Constantin: Why does it need to come at the en...
Greg Shah
05:22 PM Feature #4350 (WIP): method overload when they differ by a temp-table, dataset, buffer or object ...
> Do you have a simple example for this? Conversion rules should choose the @putBytes_1@ if the argument is @Memptr@.... Greg Shah
02:35 PM Feature #3817: create resource bundles from string literals and implement optional support for se...
This is very interesting. I wasn't familiar with gettext. Thank you for posting this!
I like that the results ar...
Greg Shah
10:10 AM Bug #4754 (Test): DYNAMIC-FUNCTION parsing fails when first parameter is not an expression
I'm fine with the change. Greg Shah
09:56 AM Bug #4754: DYNAMIC-FUNCTION parsing fails when first parameter is not an expression
@3821c-11399@ ready for review. Roger Borrello
09:42 AM Bug #4754: DYNAMIC-FUNCTION parsing fails when first parameter is not an expression
> Can I check it in?
Yes.
Greg Shah
09:25 AM Bug #4754: DYNAMIC-FUNCTION parsing fails when first parameter is not an expression
Greg Shah wrote:
> > It's not the same as a function call parameter.
>
> In what way?
Well, my ignorance was s...
Roger Borrello

07/15/2020

04:03 PM Feature #3817: create resource bundles from string literals and implement optional support for se...
I have good experience with GNU gettext (for Java). The great advantage is the ability to use the original texts in t... Hynek Cihlar
03:11 PM Feature #3753 (Closed): I18N additions
The support from this task is already in trunk. The remaining items will be tracked in #4761. Greg Shah
02:53 PM Feature #3753: I18N additions
> Ah, as a side note we've found a strange issue with conversion - the backslash escape in strings present in source ... Greg Shah
03:07 PM Feature #2135 (Closed): implement COPY-LOB language statement
These changes are all in trunk. The remaining work will be tracked in #4768. Greg Shah
03:06 PM Feature #4761: I18N phase 3
#4763 replace any hard coded dependencies on charset processing
#4762 localize system error messages
#4768 finish @...
Greg Shah
12:08 PM Feature #4761 (New): I18N phase 3
Greg Shah
03:01 PM Feature #4768: finish copy-lob support
The following need to be completed:
* TODOs in the code, primarily those where errors need to be handled with a mo...
Greg Shah
02:58 PM Feature #4768 (Closed): finish copy-lob support
Greg Shah
02:56 PM Bug #4767: memptr set-size() issue
From Marian:
> memptr, set-size - on Windows when passing a negative number the value apparently gets set as xor b...
Greg Shah
02:55 PM Bug #4767 (New): memptr set-size() issue
Greg Shah
02:51 PM Feature #4763: replace any hard coded dependencies on charset processing
Is this what you've reported in #3753-121 as "'iso8859-1' seems to be considered as the 4GL default"?
> Greg, alre...
Greg Shah
01:40 PM Feature #4763: replace any hard coded dependencies on charset processing
Greg Shah wrote:
> We need to check the FWD runtime for hard coded references to specific charsets. For example the...
Marian Edu
01:27 PM Feature #4763: replace any hard coded dependencies on charset processing
We need to check the FWD runtime for hard coded references to specific charsets. For example there is code like this... Greg Shah
01:25 PM Feature #4763 (New): replace any hard coded dependencies on charset processing
Greg Shah
02:49 PM Bug #4766: fix CHR and ASC
As noted during #4384 work, Marian's team found that CHR and ASC were not double byte enabled, they use the wrong def... Greg Shah
02:48 PM Bug #4766 (WIP): fix CHR and ASC
Greg Shah
02:45 PM Feature #4765: MAP/NO-MAP support
In #3753 we added conversion support for the @MAP@ and @NO-MAP@ stream options. As can be seen in #3753-57, we need ... Greg Shah
02:40 PM Feature #4765 (New): MAP/NO-MAP support
Greg Shah
02:21 PM Feature #4764: make modifications to FWD so that all I18N testcases work properly
In #3753, we implemented phase 2 of our I18N support. This was done before I18N testcases were available. This task... Greg Shah
02:14 PM Feature #4764 (New): make modifications to FWD so that all I18N testcases work properly
Greg Shah
01:35 PM Feature #4762: localize system error messages
Greg Shah wrote:
> We know that 4GL system error messages are localized. They have different message source files t...
Marian Edu
01:24 PM Feature #4762: localize system error messages
We know that 4GL system error messages are localized. They have different message source files that are somehow sele... Greg Shah
12:48 PM Feature #4762 (New): localize system error messages
Greg Shah
12:46 PM Feature #4378: properly handle clob/lonchar assignment, especially the implicit codepage conversion
> FWD's implementation of BUFFER-COPY uses the @RecordBuffer@ invocation handler for its individual fields, so if we ... Greg Shah

07/14/2020

02:19 PM Bug #4754: DYNAMIC-FUNCTION parsing fails when first parameter is not an expression
> It's not the same as a function call parameter.
In what way?
We know that the parameter must be an @expr@. T...
Greg Shah
11:57 AM Bug #4754: DYNAMIC-FUNCTION parsing fails when first parameter is not an expression
Greg Shah wrote:
> The first parameter can be an arbitrarily complex sub-expression like @something + func(handle:bl...
Roger Borrello

07/13/2020

10:21 AM Bug #4754: DYNAMIC-FUNCTION parsing fails when first parameter is not an expression
The first parameter can be an arbitrarily complex sub-expression like @something + func(handle:blah:blah:method(), ob... Greg Shah
10:12 AM Bug #4754: DYNAMIC-FUNCTION parsing fails when first parameter is not an expression
Why is the 1st parameter of @KW_DYN_FUNC@ handled the same as the other parameters, when it is the _function-name_, n... Roger Borrello
09:12 AM Bug #4754: DYNAMIC-FUNCTION parsing fails when first parameter is not an expression
If you are sure that this is procedure handle syntax instead of widget qualifier syntax, then we may need a different... Greg Shah
08:46 AM Bug #4754: DYNAMIC-FUNCTION parsing fails when first parameter is not an expression
@hFunc:NAME@ is a character, which in the DYNAMIC-FUNCTION's syntax for the first argument (@function-name[ IN proc-h... Constantin Asofiei
08:33 AM Bug #4754: DYNAMIC-FUNCTION parsing fails when first parameter is not an expression
The 4GL in the ADM2 @panel.p@ is:... Roger Borrello
03:16 AM Bug #4754: DYNAMIC-FUNCTION parsing fails when first parameter is not an expression
What's the generated Java code for this call? The @dynamic_function_func@ rule checks for @func_call_parm[false] (in_... Constantin Asofiei
12:07 AM Bug #4754: DYNAMIC-FUNCTION parsing fails when first parameter is not an expression
Greg Shah wrote:
> Because the 2nd case is not supposed to match an @in_procedure_clause@. The 2nd usage is an attr...
Roger Borrello

07/12/2020

06:10 PM Bug #4754: DYNAMIC-FUNCTION parsing fails when first parameter is not an expression
Because the 2nd case is not supposed to match an @in_procedure_clause@. The 2nd usage is an attribute that is being ... Greg Shah
06:07 PM Bug #4754: DYNAMIC-FUNCTION parsing fails when first parameter is not an expression
From Roger:
Why would @widget_qualifier@ be parsing, instead of @dynamic_function_func@...
Greg Shah
06:06 PM Bug #4754: DYNAMIC-FUNCTION parsing fails when first parameter is not an expression
Roger Borrello wrote:
> It is like the @IN@ is never parsed.
No, the @IN@ is seen but the following token is unre...
Greg Shah
05:37 PM Bug #4754: DYNAMIC-FUNCTION parsing fails when first parameter is not an expression
Added testcase @uast/handle/handle_attr_dyn_func.p@ Roger Borrello
05:31 PM Bug #4754: DYNAMIC-FUNCTION parsing fails when first parameter is not an expression
The second @DYNAMIC-FUNCTION@ call fails to parse:... Roger Borrello
05:24 PM Bug #4754 (Closed): DYNAMIC-FUNCTION parsing fails when first parameter is not an expression
Roger Borrello

07/08/2020

03:57 AM Bug #4749 (Test): Conversion error for object indeterminate extent output parameter
Marian Edu

07/07/2020

09:26 AM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
> It can be a @.x@, @.k@, @.tt@
And 4GL doesn't care about the extension, @RUN@ will work - only @.r@ is assumed if...
Constantin Asofiei
09:25 AM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
Roger Borrello wrote:
> ... but if there is a ".w" and ".p", we may have to enforce a precedence determined by testc...
Constantin Asofiei
09:02 AM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
Constantin Asofiei wrote:
> Greg, you are correct. We need more testcases to find every case.
>
> For now, can i...
Roger Borrello
06:18 AM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
Greg, you are correct. We need more testcases to find every case.
For now, can it be enough to check if the last ...
Constantin Asofiei
05:57 AM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
Relative paths @./@ and @../../something/else/../blah/@ are possible. It is also legal to include @.@ in random part... Greg Shah
08:27 PM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
Checked in updates to @3821c-11389@ that don't have the @pname.indexOf('.') < 0)@ check. I am open to changing, just ... Roger Borrello

07/06/2020

10:52 AM Bug #4734: Invalid string to date conversion for non-"mm/dd/yyyy" format
> Which FWD branch/revision?
I've tested it against trunk rev 11347.
Stanislav Lomany
10:04 AM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
Is it possible to have @.@ in your path (or filename) that might fail that test? Roger Borrello
09:51 AM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
Change the test to this: @if (extProg == null && pname.indexOf('.') < 0)@. Constantin Asofiei
09:49 AM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
Constantin Asofiei wrote:
> Instead, you need to do this:
> # if the exact match of @pname@ is found, use that.
> ...
Roger Borrello
09:16 AM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
Roger Borrello wrote:
> In the debugger I noticed that the procedure name came into the @convertName@ method first, ...
Constantin Asofiei
09:06 AM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
In the debugger I noticed that the procedure name came into the @convertName@ method first, without a path in front o... Roger Borrello

07/04/2020

01:00 PM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
I forgot to use this task for this...
I asked about the existing code making an assumption that it is rcode. Howev...
Roger Borrello

07/03/2020

05:54 PM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
He was talking about @SourceNameMapper.convertName@ at line 1395.
The usage needs to be added to @lookupDirectName...
Roger Borrello
05:52 PM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
Constantin asked:
Roger, rename @run-noext-victim.p@ to @run-noext-victim.k.p@ and do a @RUN run-noext-victim.k@. ...
Roger Borrello
05:49 PM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
There is an issue about finding an external procedure that is not passed to @RUN@ with an extension. I added this tes... Roger Borrello
05:45 PM Bug #4741 (Closed): RUN statement with a path to a procedure that does not have any extension fai...
Roger Borrello
12:56 PM Bug #4734: Invalid string to date conversion for non-"mm/dd/yyyy" format
Which FWD branch/revision? Eric Faulhaber
12:20 PM Bug #4734: Invalid string to date conversion for non-"mm/dd/yyyy" format
Testcase:... Stanislav Lomany
12:12 PM Bug #4734 (Closed): Invalid string to date conversion for non-"mm/dd/yyyy" format
Stanislav Lomany

06/30/2020

11:11 AM Feature #4384: Builtin OO Implementation
Marian, I think this is your change, right?... Constantin Asofiei

06/25/2020

04:00 AM Feature #4384: Builtin OO Implementation
We have some issues with OO named events, one of the tests does not pass conversion: @oo/openedge/net/http/filter/aut... Marian Edu
 

Also available in: Atom