Project

General

Profile

Activity

From 07/15/2020 to 08/13/2020

08/12/2020

02:40 PM Feature #3810: SECURITY-POLICY and other security features
Greg Shah wrote:
> Is #3810-406 an accurate and complete list of the remaining work in this task?
>
> In #3810-40...
Igor Skornyakov
02:22 PM Feature #3810: SECURITY-POLICY and other security features
Is #3810-406 an accurate and complete list of the remaining work in this task?
In #3810-406, you list these:
> ...
Greg Shah
07:50 AM Bug #4852: ErrorManager throws 'invalid' ErrorConditionException
Yes, the parameter order is wrong and needs to be fixed (by switching them).
Marian, regarding your original case ...
Constantin Asofiei
07:37 AM Bug #4852: ErrorManager throws 'invalid' ErrorConditionException
@public ErrorConditionException(int progressErrorCode, String message)@ is meant to raise an @ERROR@ that has a speci... Greg Shah
06:23 AM Bug #4852: ErrorManager throws 'invalid' ErrorConditionException
From Marian:
> We have a situation where ErrorManager.recordThrowError does not set the Progress error code on the...
Greg Shah
04:44 AM Bug #4852 (New): ErrorManager throws 'invalid' ErrorConditionException
Marian Edu
07:13 AM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> So I'm trying to remove these where I find them.
OK, will try to do the same. Thanks.
Marian Edu
06:29 AM Feature #4384: Builtin OO Implementation
> that one is already set as dependency in gradle so we've just used what was already there. What we are using from t... Greg Shah
02:25 AM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> * Removed recently added usage of @org.apache.commons.*@. We try not to add dependencies on ne...
Marian Edu

08/10/2020

03:06 PM Feature #4384: Builtin OO Implementation
I've merged all pending changes from 4384d (revisions 11607 through 11625 inclusive) into 3821c revision 11449. Plea... Greg Shah

08/04/2020

02:11 PM Bug #4749 (Test): Conversion error for object indeterminate extent output parameter
Greg Shah
12:08 PM Bug #4749: Conversion error for object indeterminate extent output parameter
Fixed in 3821c rev 11436. Constantin Asofiei
02:11 PM Bug #4824 (Test): Conversion error for property with indeterminate extent
I'm good with the changes. Greg Shah
01:54 PM Bug #4824: Conversion error for property with indeterminate extent
3821c/11437 fixes the case of abstract extent properties (forgot to check them). Constantin Asofiei
12:08 PM Bug #4824: Conversion error for property with indeterminate extent
Fixed in 3821c rev 11436. Please review. Constantin Asofiei

08/03/2020

05:27 PM Bug #4824 (WIP): Conversion error for property with indeterminate extent
Marian is right, we need 'bulk' getter and setter for extent properties. I have most of the changes, there's a trick... Constantin Asofiei
05:26 PM Bug #4749 (WIP): Conversion error for object indeterminate extent output parameter
I have a fix for this, but is part of the #4824 work. Will commit with that. Constantin Asofiei
12:20 PM Bug #4669 (Test): Conversion error for output stream-handle - protected property.
Greg Shah
10:35 AM Bug #4669 (WIP): Conversion error for output stream-handle - protected property.
Fixed in 3821c rev 11432. Constantin Asofiei
12:06 PM Feature #4384: Builtin OO Implementation
Eugenie Lyzenko wrote:
> Should I interrupt and restart customer application @3821c@ conversion with @11433@ update?...
Constantin Asofiei
12:04 PM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian Edu wrote:
> > We have some issues with OO named events, one of the tests does n...
Eugenie Lyzenko
11:56 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> We have some issues with OO named events, one of the tests does not pass conversion: @oo/openedg...
Constantin Asofiei

07/30/2020

01:32 PM Bug #4741 (WIP): RUN statement with a path to a procedure that does not have any extension fails ...
Roger Borrello
01:31 PM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
Changes checked into @3821c-11426@. Roger Borrello
11:31 AM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
Constantin Asofiei wrote:
> Roger, a change which affects the lookup in @p2jMap@ is that @ExternalProgram.pname@ is ...
Roger Borrello
06:30 AM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
Roger, a change which affects the lookup in @p2jMap@ is that @ExternalProgram.pname@ is no longer the key in the @p2j... Constantin Asofiei
06:24 AM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
Roger Borrello wrote:
> I am now keeping @pathAliases@ and @p2jMap@ in separate lists, but not @jp2Map@ and @classMa...
Constantin Asofiei
09:31 AM Bug #4827: OO Conversion issue with method resolve (erasure)
I think this is part of my work on #4350. Greg Shah
08:46 AM Bug #4827: OO Conversion issue with method resolve (erasure)
From Marian:
> We have quite a number of errors in conversion of our 'discovery' stubs that have to do with how th...
Greg Shah
02:24 AM Bug #4827 (Closed): OO Conversion issue with method resolve (erasure)
Marian Edu
09:03 AM Feature #4828 (WIP): rework ErrorManager to use the TransactionHelper design on the server and a ...
Greg Shah
09:03 AM Feature #4828: rework ErrorManager to use the TransactionHelper design on the server and a sync'd...
This task is for performance improvement.
Server-side usage of the EM can be expensive. For example, the @isPendi...
Greg Shah
08:58 AM Feature #4828 (Test): rework ErrorManager to use the TransactionHelper design on the server and a...
Greg Shah
08:48 AM Bug #4824: Conversion error for property with indeterminate extent
From Marian:
> If we have a property defined as an indeterminate extent the generated code doesn't (fully) work. I...
Greg Shah

07/29/2020

06:37 PM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
Traced this down to @SourceNameMapper.getInternalEntry@ where we have null passed in as the @pname@. I cannot @toLowe... Roger Borrello
05:55 PM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
In trying to figure out why OO initialization is involved, it looks like the changes I have made are causing @ObjectO... Roger Borrello
11:45 AM Feature #4384: Builtin OO Implementation
This patch was merged into the skeletons project as revision 98. I've pushed it to @proj.goldencode.com@ as well. Greg Shah
08:50 AM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> Is the patch made relative to revision 97?
Attached the fixed patch, this is done against revi...
Marian Edu
07:59 AM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> Is the patch made relative to revision 97?
Yes, I did an update before but let me check someth...
Marian Edu
07:53 AM Feature #4384: Builtin OO Implementation
Is the patch made relative to revision 97? Greg Shah
07:33 AM Feature #4384: Builtin OO Implementation
> If there are any client that use those data structures the only option will be to look at their code base and see w... Greg Shah
07:30 AM Feature #4384: Builtin OO Implementation
Attached the skeleton patch for OE12.2, some new classes added to @Core@ and @Net@ packages and some updates to exist... Marian Edu
06:06 AM Bug #4669: Conversion error for output stream-handle - protected property.
Assigning that to Greg to dispatch it to the right recipient :)
We've found an issue when converting a 4GL class a...
Marian Edu
06:06 AM Bug #4749: Conversion error for object indeterminate extent output parameter
Assigning that to Greg to dispatch it to the right recipient :)
When we have a method that returns an object array...
Marian Edu
05:51 AM Bug #4824 (Closed): Conversion error for property with indeterminate extent
Marian Edu

07/28/2020

05:04 PM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
I am not sure why, but these changes to create the multiple maps for case-sensitive and case-insensitve in SourceName... Roger Borrello
03:28 PM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
It was more like wishful thinking. There are so many issues getting through startup with this version, I must be miss... Roger Borrello
02:56 PM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
Roger Borrello wrote:
> Is this another hash-map that has implications of not matching up with the case-sensitivity ...
Greg Shah
02:18 PM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
Is this another hash-map that has implications of not matching up with the case-sensitivity associated with the proje... Roger Borrello
10:43 AM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
> I think the FWD runtime needs to know which programs had a r-code and which did not... as another attribute to nam... Greg Shah
10:33 AM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
Greg Shah wrote:
> This means that all @.p@, @.w@ and even @.whatever@ files will be present ONLY as a @.r@ in the r...
Constantin Asofiei
10:01 AM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
Not related to Greg's question, but my implementation...
This (obviously) doesn't compile, because there isn't a @...
Roger Borrello
09:49 AM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
> FWD must not match the extension for a non-compiled 4GL program. This is because the extension can be anything, 4GL... Greg Shah
09:40 AM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
Constantin Asofiei wrote:
> Roger, just the key needs to be different. @ExternalProgram.pname@ needs to keep the o...
Roger Borrello
09:19 AM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
Roger, just the key needs to be different. @ExternalProgram.pname@ needs to keep the original name (it was wrong to... Constantin Asofiei
09:15 AM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
Greg Shah wrote:
> > Moved these to the WorkArea. Can they still be static?
>
> No. The idea of the WorkArea is ...
Roger Borrello
08:58 AM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
> Moved these to the WorkArea. Can they still be static?
No. The idea of the WorkArea is that it is context-local...
Greg Shah
08:42 AM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
Moved these to the @WorkArea@. Can they still be @static@?... Roger Borrello
04:08 AM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
Roger, again, FWD *must not* match the extension for a non-compiled 4GL program. This is because the extension can b... Constantin Asofiei
10:27 PM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
4GL on Windows was fine with the below, no matter what I named the @run-wrongcase-victim.r@.... Roger Borrello

07/27/2020

03:50 PM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
Roger, do a Windows OS test with a compiled file named @some-program.r@ and try @RUN some-program.r@ and @RUN some-pr... Constantin Asofiei
03:40 PM Bug #4741: RUN statement with a path to a procedure that does not have any extension fails to be ...
I'm looking again at this task due to what is going on with #4208. Specifically this code in @convertName@:... Roger Borrello

07/25/2020

05:14 PM Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
And also double-check if raw, com-handle, object, rowid, recid are supported types, for both SOAP and REST. We found... Constantin Asofiei
05:13 PM Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
Marian, looks like INPUT-OUTPUT was missing, too. Please add a couple of tests for these, too - I just want to make ... Constantin Asofiei

07/17/2020

10:13 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
I'm looking at the table, dataset and buffer matching right now. In @SymbolResolver.translateType()@ we have this co... Greg Shah

07/16/2020

06:37 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
Greg Shah wrote:
> OK, an important point is @if caller hasn't specified a mode for an argument, use wildcard@.
>
...
Constantin Asofiei
06:21 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
OK, an important point is @if caller hasn't specified a mode for an argument, use wildcard@.
Still, I don't unders...
Greg Shah
05:34 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
Greg Shah wrote:
> As far as I know the parameter modes are not actually part of the "fuzziness". In fact, we proba...
Constantin Asofiei
05:29 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
No, I mean this code:... Greg Shah
05:24 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
Constantin wrote:
> you mean the narrowing/widening match, based on the parameters mode?
Greg Shah
05:23 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
We have a step that comes at the end for matching parameter modes.
Constantin: Why does it need to come at the en...
Greg Shah
05:22 PM Feature #4350 (WIP): method overload when they differ by a temp-table, dataset, buffer or object ...
> Do you have a simple example for this? Conversion rules should choose the @putBytes_1@ if the argument is @Memptr@.... Greg Shah
02:35 PM Feature #3817: create resource bundles from string literals and implement optional support for se...
This is very interesting. I wasn't familiar with gettext. Thank you for posting this!
I like that the results ar...
Greg Shah
10:10 AM Bug #4754 (Test): DYNAMIC-FUNCTION parsing fails when first parameter is not an expression
I'm fine with the change. Greg Shah
09:56 AM Bug #4754: DYNAMIC-FUNCTION parsing fails when first parameter is not an expression
@3821c-11399@ ready for review. Roger Borrello
09:42 AM Bug #4754: DYNAMIC-FUNCTION parsing fails when first parameter is not an expression
> Can I check it in?
Yes.
Greg Shah
09:25 AM Bug #4754: DYNAMIC-FUNCTION parsing fails when first parameter is not an expression
Greg Shah wrote:
> > It's not the same as a function call parameter.
>
> In what way?
Well, my ignorance was s...
Roger Borrello

07/15/2020

04:03 PM Feature #3817: create resource bundles from string literals and implement optional support for se...
I have good experience with GNU gettext (for Java). The great advantage is the ability to use the original texts in t... Hynek Cihlar
03:11 PM Feature #3753 (Closed): I18N additions
The support from this task is already in trunk. The remaining items will be tracked in #4761. Greg Shah
02:53 PM Feature #3753: I18N additions
> Ah, as a side note we've found a strange issue with conversion - the backslash escape in strings present in source ... Greg Shah
03:07 PM Feature #2135 (Closed): implement COPY-LOB language statement
These changes are all in trunk. The remaining work will be tracked in #4768. Greg Shah
03:06 PM Feature #4761: I18N phase 3
#4763 replace any hard coded dependencies on charset processing
#4762 localize system error messages
#4768 finish @...
Greg Shah
12:08 PM Feature #4761 (New): I18N phase 3
Greg Shah
03:01 PM Feature #4768: finish copy-lob support
The following need to be completed:
* TODOs in the code, primarily those where errors need to be handled with a mo...
Greg Shah
02:58 PM Feature #4768 (Closed): finish copy-lob support
Greg Shah
02:56 PM Bug #4767: memptr set-size() issue
From Marian:
> memptr, set-size - on Windows when passing a negative number the value apparently gets set as xor b...
Greg Shah
02:55 PM Bug #4767 (New): memptr set-size() issue
Greg Shah
02:51 PM Feature #4763: replace any hard coded dependencies on charset processing
Is this what you've reported in #3753-121 as "'iso8859-1' seems to be considered as the 4GL default"?
> Greg, alre...
Greg Shah
01:40 PM Feature #4763: replace any hard coded dependencies on charset processing
Greg Shah wrote:
> We need to check the FWD runtime for hard coded references to specific charsets. For example the...
Marian Edu
01:27 PM Feature #4763: replace any hard coded dependencies on charset processing
We need to check the FWD runtime for hard coded references to specific charsets. For example there is code like this... Greg Shah
01:25 PM Feature #4763 (New): replace any hard coded dependencies on charset processing
Greg Shah
02:49 PM Bug #4766: fix CHR and ASC
As noted during #4384 work, Marian's team found that CHR and ASC were not double byte enabled, they use the wrong def... Greg Shah
02:48 PM Bug #4766 (WIP): fix CHR and ASC
Greg Shah
02:45 PM Feature #4765: MAP/NO-MAP support
In #3753 we added conversion support for the @MAP@ and @NO-MAP@ stream options. As can be seen in #3753-57, we need ... Greg Shah
02:40 PM Feature #4765 (New): MAP/NO-MAP support
Greg Shah
02:21 PM Feature #4764: make modifications to FWD so that all I18N testcases work properly
In #3753, we implemented phase 2 of our I18N support. This was done before I18N testcases were available. This task... Greg Shah
02:14 PM Feature #4764 (New): make modifications to FWD so that all I18N testcases work properly
Greg Shah
01:35 PM Feature #4762: localize system error messages
Greg Shah wrote:
> We know that 4GL system error messages are localized. They have different message source files t...
Marian Edu
01:24 PM Feature #4762: localize system error messages
We know that 4GL system error messages are localized. They have different message source files that are somehow sele... Greg Shah
12:48 PM Feature #4762 (New): localize system error messages
Greg Shah
12:46 PM Feature #4378: properly handle clob/lonchar assignment, especially the implicit codepage conversion
> FWD's implementation of BUFFER-COPY uses the @RecordBuffer@ invocation handler for its individual fields, so if we ... Greg Shah
 

Also available in: Atom